+
${needsProjectPicker && html`
@@ -202,7 +209,7 @@ export function SpawnModal({ isOpen, onClose, onSpawn, currentProject }) {
-
`;
}
diff --git a/dashboard/utils/api.js b/dashboard/utils/api.js
index 50ad8a2..9995469 100644
--- a/dashboard/utils/api.js
+++ b/dashboard/utils/api.js
@@ -29,11 +29,11 @@ export async function fetchWithTimeout(url, options = {}, timeoutMs = API_TIMEOU
export async function fetchSkills(agent) {
const url = `${API_SKILLS}?agent=${encodeURIComponent(agent)}`;
try {
- const response = await fetch(url);
+ const response = await fetchWithTimeout(url);
if (!response.ok) return null;
- return response.json();
+ return await response.json();
} catch {
- // Network error or other failure - graceful degradation
+ // Network error, timeout, or JSON parse failure - graceful degradation
return null;
}
}
diff --git a/slice2-verify-1-initial.png b/slice2-verify-1-initial.png
new file mode 100644
index 0000000..fa8a40d
Binary files /dev/null and b/slice2-verify-1-initial.png differ
diff --git a/slice2-verify-2-modal-all-projects.png b/slice2-verify-2-modal-all-projects.png
new file mode 100644
index 0000000..0f8716d
Binary files /dev/null and b/slice2-verify-2-modal-all-projects.png differ
diff --git a/slice2-verify-3-zellij-warning.png b/slice2-verify-3-zellij-warning.png
new file mode 100644
index 0000000..abd0680
Binary files /dev/null and b/slice2-verify-3-zellij-warning.png differ
diff --git a/spawn-modal-test.png b/spawn-modal-test.png
new file mode 100644
index 0000000..25e162a
Binary files /dev/null and b/spawn-modal-test.png differ
diff --git a/tests/__pycache__/test_control.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_control.cpython-313-pytest-9.0.2.pyc
index 4f468e5..1ae6d85 100644
Binary files a/tests/__pycache__/test_control.cpython-313-pytest-9.0.2.pyc and b/tests/__pycache__/test_control.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_conversation.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_conversation.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..035f47e
Binary files /dev/null and b/tests/__pycache__/test_conversation.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_discovery.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_discovery.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..8298aec
Binary files /dev/null and b/tests/__pycache__/test_discovery.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_hook.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_hook.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..09100b9
Binary files /dev/null and b/tests/__pycache__/test_hook.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_http.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_http.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..b329bcf
Binary files /dev/null and b/tests/__pycache__/test_http.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_parsing.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_parsing.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..33d7812
Binary files /dev/null and b/tests/__pycache__/test_parsing.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_skills.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_skills.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..9618be0
Binary files /dev/null and b/tests/__pycache__/test_skills.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_spawn.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_spawn.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..dbc1a9c
Binary files /dev/null and b/tests/__pycache__/test_spawn.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_state.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_state.cpython-313-pytest-9.0.2.pyc
index b9351d7..31e1a1d 100644
Binary files a/tests/__pycache__/test_state.cpython-313-pytest-9.0.2.pyc and b/tests/__pycache__/test_state.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/__pycache__/test_zellij_metadata.cpython-313-pytest-9.0.2.pyc b/tests/__pycache__/test_zellij_metadata.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..c13f7c2
Binary files /dev/null and b/tests/__pycache__/test_zellij_metadata.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/e2e/__pycache__/__init__.cpython-313.pyc b/tests/e2e/__pycache__/__init__.cpython-313.pyc
new file mode 100644
index 0000000..4f6d510
Binary files /dev/null and b/tests/e2e/__pycache__/__init__.cpython-313.pyc differ
diff --git a/tests/e2e/__pycache__/test_skills_endpoint.cpython-313-pytest-9.0.2.pyc b/tests/e2e/__pycache__/test_skills_endpoint.cpython-313-pytest-9.0.2.pyc
new file mode 100644
index 0000000..45424d9
Binary files /dev/null and b/tests/e2e/__pycache__/test_skills_endpoint.cpython-313-pytest-9.0.2.pyc differ
diff --git a/tests/test_control.py b/tests/test_control.py
index d7707ff..8fa14a3 100644
--- a/tests/test_control.py
+++ b/tests/test_control.py
@@ -325,8 +325,8 @@ class TestDismissSession(unittest.TestCase):
with tempfile.TemporaryDirectory() as tmpdir:
sessions_dir = Path(tmpdir)
sessions_dir.mkdir(exist_ok=True)
- # Create a file that should NOT be deleted
- secret_file = Path(tmpdir).parent / "secret.json"
+ # Create a file that should NOT be deleted (unused - documents test intent)
+ _secret_file = Path(tmpdir).parent / "secret.json"
handler = DummyControlHandler()
with patch.object(control, "SESSIONS_DIR", sessions_dir):
diff --git a/tests/test_conversation.py b/tests/test_conversation.py
index dde2016..7b83ae7 100644
--- a/tests/test_conversation.py
+++ b/tests/test_conversation.py
@@ -7,8 +7,7 @@ import json
import tempfile
import unittest
from pathlib import Path
-from unittest.mock import patch, MagicMock
-import io
+from unittest.mock import patch
from amc_server.mixins.conversation import ConversationMixin
from amc_server.mixins.parsing import SessionParsingMixin
@@ -72,8 +71,8 @@ class TestServeEvents(unittest.TestCase):
def test_path_traversal_sanitized(self):
with tempfile.TemporaryDirectory() as tmpdir:
events_dir = Path(tmpdir)
- # Create a file that path traversal might try to access
- secret_file = Path(tmpdir).parent / "secret.jsonl"
+ # Create a file that path traversal might try to access (unused - documents intent)
+ _secret_file = Path(tmpdir).parent / "secret.jsonl"
with patch("amc_server.mixins.conversation.EVENTS_DIR", events_dir):
# Try path traversal
diff --git a/tests/test_hook.py b/tests/test_hook.py
index d55f3fc..2236980 100644
--- a/tests/test_hook.py
+++ b/tests/test_hook.py
@@ -6,7 +6,6 @@ Edge cases are prioritized over happy paths.
import json
import os
-import sys
import tempfile
import types
import unittest
@@ -193,7 +192,7 @@ class TestAtomicWrite(unittest.TestCase):
path.write_text('{"original": "data"}')
# Mock os.replace to fail after the temp file is written
- original_replace = os.replace
+ _original_replace = os.replace # noqa: F841 - documents test setup
def failing_replace(src, dst):
raise PermissionError("Simulated failure")
diff --git a/tests/test_http.py b/tests/test_http.py
index 0e80bb3..a4c8af7 100644
--- a/tests/test_http.py
+++ b/tests/test_http.py
@@ -128,8 +128,8 @@ class TestServeDashboardFile(unittest.TestCase):
handler._json_error = capture_error
with tempfile.TemporaryDirectory() as tmpdir:
- # Create a file outside the dashboard dir that shouldn't be accessible
- secret = Path(tmpdir).parent / "secret.txt"
+ # Create a file outside the dashboard dir that shouldn't be accessible (unused - documents intent)
+ _secret = Path(tmpdir).parent / "secret.txt"
with patch("amc_server.mixins.http.DASHBOARD_DIR", Path(tmpdir)):
handler._serve_dashboard_file("../secret.txt")
diff --git a/tests/test_parsing.py b/tests/test_parsing.py
index 77b605f..006e3b5 100644
--- a/tests/test_parsing.py
+++ b/tests/test_parsing.py
@@ -7,7 +7,7 @@ import json
import tempfile
import unittest
from pathlib import Path
-from unittest.mock import patch, MagicMock
+from unittest.mock import patch
from amc_server.mixins.parsing import SessionParsingMixin
diff --git a/tests/test_spawn.py b/tests/test_spawn.py
index 5e5f752..5337c19 100644
--- a/tests/test_spawn.py
+++ b/tests/test_spawn.py
@@ -7,7 +7,7 @@ from pathlib import Path
from unittest.mock import MagicMock, patch
import amc_server.mixins.spawn as spawn_mod
-from amc_server.mixins.spawn import SpawnMixin, load_projects_cache, _projects_cache, _sanitize_pane_name
+from amc_server.mixins.spawn import SpawnMixin, load_projects_cache, _sanitize_pane_name
class DummySpawnHandler(SpawnMixin):
@@ -317,7 +317,7 @@ class TestRateLimiting(unittest.TestCase):
def test_rapid_spawn_same_project_rejected(self):
"""Spawning the same project within cooldown returns 429."""
- from amc_server.context import _spawn_timestamps, SPAWN_COOLDOWN_SEC
+ from amc_server.context import _spawn_timestamps
_spawn_timestamps.clear()
# Pretend we just spawned this project
_spawn_timestamps['rapid-project'] = time.monotonic()
diff --git a/tests/test_state.py b/tests/test_state.py
index dbc5e2f..b348dbc 100644
--- a/tests/test_state.py
+++ b/tests/test_state.py
@@ -4,7 +4,7 @@ import tempfile
import time
import unittest
from pathlib import Path
-from unittest.mock import patch, MagicMock
+from unittest.mock import patch
import amc_server.mixins.state as state_mod
from amc_server.mixins.state import StateMixin
diff --git a/tests/test_zellij_metadata.py b/tests/test_zellij_metadata.py
index 61cd8b4..7dbe971 100644
--- a/tests/test_zellij_metadata.py
+++ b/tests/test_zellij_metadata.py
@@ -13,7 +13,7 @@ import tempfile
import types
import unittest
from pathlib import Path
-from unittest.mock import MagicMock, patch, call
+from unittest.mock import MagicMock, patch
# ---------------------------------------------------------------------------
# Import hook module (no .py extension)
@@ -24,8 +24,8 @@ amc_hook.__file__ = str(hook_path)
code = compile(hook_path.read_text(), hook_path, "exec")
exec(code, amc_hook.__dict__) # noqa: S102 - loading local module
-# Import spawn mixin
-import amc_server.mixins.spawn as spawn_mod
+# Import spawn mixin (after hook loading - intentional)
+import amc_server.mixins.spawn as spawn_mod # noqa: E402
# ===========================================================================