refactor(cli): remove deprecated stage_spinner, migrate remaining callers to v2

Phase 7 cleanup: migrate timeline.rs and main.rs search spinner
from stage_spinner() to stage_spinner_v2() with proper icon labels,
then remove the now-unused stage_spinner() function and its tests.

No external callers remain for the old numbered-stage API.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
teernisse
2026-02-14 10:10:22 -05:00
parent 8572f6cc04
commit 361757568f
4 changed files with 47 additions and 71 deletions

View File

@@ -144,11 +144,8 @@ async fn main() {
}
}
// I1: Respect NO_COLOR convention (https://no-color.org/)
let force_ascii = robot_mode
|| cli.color == "never"
|| std::env::var("NO_COLOR").is_ok_and(|v| !v.is_empty());
let glyphs = GlyphMode::detect(cli.icons.as_deref(), force_ascii);
// Icon mode is independent of color flags; robot mode still defaults to ASCII.
let glyphs = GlyphMode::detect(cli.icons.as_deref(), robot_mode);
if std::env::var("NO_COLOR").is_ok_and(|v| !v.is_empty()) {
LoreRenderer::init(ColorMode::Never, glyphs);
@@ -1919,9 +1916,9 @@ async fn handle_search(
limit: args.limit,
};
let spinner = lore::cli::progress::stage_spinner(
1,
1,
let spinner = lore::cli::progress::stage_spinner_v2(
lore::cli::render::Icons::search(),
"Search",
&format!("Searching ({})...", args.mode),
robot_mode,
);