theirongolddev/gitlore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(who): make --limit optional (unlimited default) and fix clippy sort lints

Browse Source 
Change the `who` command's --limit flag from default=20 to optional,
so omitting it returns all results. This matches the behavior users
expect when they want a complete expert/workload/active/overlap listing
without an arbitrary cap.

Also applies clippy-recommended sort improvements:
- who/reviews: sort_by(|a,b| b.count.cmp(&a.count)) -> sort_by_key with Reverse
- drift: same pattern for frequency sorting

Adds Theme::color_icon() helper to DRY the stage-icon coloring pattern
used in sync output (was inline closure, now shared method).
This commit is contained in:
teernisse
2026-02-18 16:27:48 -05:00
parent 30ed02c694
commit ea6e45e43f
6 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/cli/commands/who_tests.rs
View File

@@ -286,7 +286,7 @@ fn test_is_file_path_discrimination() {
reviews: false,
since: None,
project: None,
limit: 20,
limit: None,
detail: false,
no_detail: false,
fields: None,
@@ -310,7 +310,7 @@ fn test_is_file_path_discrimination() {
reviews: false,
since: None,
project: None,
limit: 20,
limit: None,
detail: false,
no_detail: false,
fields: None,
@@ -334,7 +334,7 @@ fn test_is_file_path_discrimination() {
reviews: false,
since: None,
project: None,
limit: 20,
limit: None,
detail: false,
no_detail: false,
fields: None,
@@ -358,7 +358,7 @@ fn test_is_file_path_discrimination() {
reviews: true,
since: None,
project: None,
limit: 20,
limit: None,
detail: false,
no_detail: false,
fields: None,
@@ -382,7 +382,7 @@ fn test_is_file_path_discrimination() {
reviews: false,
since: None,
project: None,
limit: 20,
limit: None,
detail: false,
no_detail: false,
fields: None,
@@ -406,7 +406,7 @@ fn test_is_file_path_discrimination() {
reviews: false,
since: None,
project: None,
limit: 20,
limit: None,
detail: false,
no_detail: false,
fields: None,
@@ -431,7 +431,7 @@ fn test_detail_rejected_outside_expert_mode() {
reviews: false,
since: None,
project: None,
limit: 20,
limit: None,
detail: true,
no_detail: false,
fields: None,
@@ -460,7 +460,7 @@ fn test_detail_allowed_in_expert_mode() {
reviews: false,
since: None,
project: None,
limit: 20,
limit: None,
detail: true,
no_detail: false,
fields: None,