fix: clippy lints — sort_by_key in drift, pub visibility for TUI, assert formatting

- drift.rs: Replace `sorted.sort_by(|a, b| b.1.cmp(&a.1))` with idiomatic
  `sort_by_key(|entry| std::cmp::Reverse(entry.1))` (clippy::use_sort_by_key).

- list.rs: Change `query_issues` and `query_mrs` from `fn` to `pub fn` so the
  TUI crate can call them directly instead of duplicating the query logic.

- vector.rs: Reformat multi-line assert! macro to satisfy rustfmt check
  (body moved onto separate lines with trailing message string).
This commit is contained in:
teernisse
2026-02-18 22:56:16 -05:00
parent c1b1300675
commit f8d6180f06
3 changed files with 7 additions and 4 deletions

View File

@@ -382,7 +382,7 @@ fn extract_drift_topics(description: &str, notes: &[NoteRow], drift_idx: usize)
} }
let mut sorted: Vec<(String, usize)> = freq.into_iter().collect(); let mut sorted: Vec<(String, usize)> = freq.into_iter().collect();
sorted.sort_by(|a, b| b.1.cmp(&a.1)); sorted.sort_by_key(|entry| std::cmp::Reverse(entry.1));
sorted sorted
.into_iter() .into_iter()

View File

@@ -253,7 +253,7 @@ fn query_available_statuses(conn: &Connection) -> Result<Vec<String>> {
Ok(statuses) Ok(statuses)
} }
fn query_issues(conn: &Connection, filters: &ListFilters) -> Result<ListResult> { pub fn query_issues(conn: &Connection, filters: &ListFilters) -> Result<ListResult> {
let mut where_clauses = Vec::new(); let mut where_clauses = Vec::new();
let mut params: Vec<Box<dyn rusqlite::ToSql>> = Vec::new(); let mut params: Vec<Box<dyn rusqlite::ToSql>> = Vec::new();
@@ -450,7 +450,7 @@ pub fn run_list_mrs(config: &Config, filters: MrListFilters) -> Result<MrListRes
Ok(result) Ok(result)
} }
fn query_mrs(conn: &Connection, filters: &MrListFilters) -> Result<MrListResult> { pub fn query_mrs(conn: &Connection, filters: &MrListFilters) -> Result<MrListResult> {
let mut where_clauses = Vec::new(); let mut where_clauses = Vec::new();
let mut params: Vec<Box<dyn rusqlite::ToSql>> = Vec::new(); let mut params: Vec<Box<dyn rusqlite::ToSql>> = Vec::new();

View File

@@ -153,7 +153,10 @@ mod tests {
// The original bug: limit=1500 (RECALL_CAP) with multiplier >= 8 // The original bug: limit=1500 (RECALL_CAP) with multiplier >= 8
// produced k=10_000 which exceeded sqlite-vec's 4096 cap. // produced k=10_000 which exceeded sqlite-vec's 4096 cap.
let k = compute_knn_k(1500, 1); let k = compute_knn_k(1500, 1);
assert!(k <= SQLITE_VEC_KNN_MAX, "k={k} exceeded 4096 at RECALL_CAP with 1 chunk"); assert!(
k <= SQLITE_VEC_KNN_MAX,
"k={k} exceeded 4096 at RECALL_CAP with 1 chunk"
);
} }
#[test] #[test]