chore(beads): update issue tracking state

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

.beads/last-touched

@@ -1 +1 @@
-bd-2cbw
+bd-343o

.cargo/config.toml

@@ -0,0 +1,5 @@
+# Force all builds (including worktrees) to share one target directory.
+# This prevents each Claude Code agent worktree from creating its own
+# ~3GB target/ directory, which was filling the disk.
+[build]
+target-dir = "/Users/tayloreernisse/projects/gitlore/target"

.claude/plan.md

@@ -0,0 +1,99 @@
+# Plan: Add Colors to Sync Command Output
+
+## Current State
+
+The sync output has three layers, each needing color treatment:
+
+### Layer 1: Stage Lines (during sync)
+```
+  ✓ Issues     10 issues from 2 projects  4.2s
+  ✓ Status     3 statuses updated · 5 seen  4.2s
+      vs/typescript-code              2 issues · 1 statuses updated
+  ✓ MRs        5 merge requests from 2 projects  12.3s
+      vs/python-code                  3 MRs · 10 discussions
+  ✓ Docs       1,200 documents generated  8.1s
+  ✓ Embed      3,400 chunks embedded  45.2s
+```
+
+**What's uncolored:** icons, labels, numbers, elapsed times, sub-row project paths, failure counts in parentheses.
+
+### Layer 2: Summary (after sync)
+```
+  Synced 10 issues and 5 MRs in 42.3s
+  120 discussions · 45 events · 12 diffs · 3 statuses updated
+  1,200 docs regenerated · 3,400 embedded
+```
+
+**What's already colored:** headline ("Synced" = green bold, "Sync completed with issues" = warning bold), issue/MR counts (bold), error line (red). Detail lines are all dim.
+
+### Layer 3: Timing breakdown (`-t` flag)
+```
+── Timing ──────────────────────
+  issues .............. 4.2s
+  merge_requests ...... 12.3s
+```
+
+**What's already colored:** dots (dim), time (bold), errors (red), rate limits (warning).
+
+---
+
+## Color Plan
+
+Using only existing `Theme` methods — no new colors needed.
+
+### Stage Lines (`format_stage_line` + callers in sync.rs)
+
+| Element | Current | Proposed | Theme method |
+|---------|---------|----------|-------------|
+| Icon (✓/⚠) | plain | green for success, yellow for warning | `Theme::success()` / `Theme::warning()` |
+| Label ("Issues", "MRs", etc.) | plain | bold | `Theme::bold()` |
+| Numbers in summary text | plain | bold | `Theme::bold()` (just the count) |
+| Elapsed time | plain | muted gray | `Theme::timing()` |
+| Failure text in parens | plain | warning/error color | `Theme::warning()` |
+
+### Sub-rows (project breakdown lines)
+
+| Element | Current | Proposed |
+|---------|---------|----------|
+| Project path | dim | `Theme::muted()` (slightly brighter than dim) |
+| Counts (numbers only) | dim | `Theme::dim()` but numbers in normal weight |
+| Error/failure counts | dim | `Theme::warning()` |
+| Middle dots | dim | keep dim (they're separators, should recede) |
+
+### Summary (`print_sync`)
+
+| Element | Current | Proposed |
+|---------|---------|----------|
+| Issue/MR counts in headline | bold only | `Theme::info()` + bold (cyan numbers pop) |
+| Time in headline | plain | `Theme::timing()` |
+| Detail line numbers | all dim | numbers in `Theme::info()`, rest stays dim |
+| Doc line numbers | all dim | numbers in `Theme::info()`, rest stays dim |
+| "Already up to date" time | plain | `Theme::timing()` |
+
+---
+
+## Files to Change
+
+1. **`src/cli/progress.rs`** — `format_stage_line()`: apply color to icon, bold to label, `Theme::timing()` to elapsed
+2. **`src/cli/commands/sync.rs`** —
+   - Pass colored icons to `format_stage_line` / `emit_stage_line` / `emit_stage_block`
+   - Color failure text in `append_failures()`
+   - Color numbers and time in `print_sync()`
+   - Color error/failure counts in sub-row functions (`issue_sub_rows`, `mr_sub_rows`, `status_sub_rows`)
+
+## Approach
+
+- `format_stage_line` already receives the icon string — color it before passing
+- Add a `color_icon` helper that applies success/warning color to the icon glyph
+- Bold the label in `format_stage_line`
+- Apply `Theme::timing()` to elapsed in `format_stage_line`
+- In `append_failures`, wrap failure text in `Theme::warning()`
+- In `print_sync`, wrap count numbers with `Theme::info().bold()`
+- In sub-row functions, apply `Theme::warning()` to error/failure parts only (keep rest dim)
+
+## Non-goals
+
+- No changes to robot mode (JSON output)
+- No changes to dry-run output (already reasonably colored)
+- No new Theme colors — use existing palette
+- No changes to timing breakdown (already colored)

.github/workflows/roam.yml

@@ -0,0 +1,21 @@
+name: Roam Code Analysis
+on:
+  pull_request:
+    branches: [main, master]
+permissions:
+  contents: read
+  pull-requests: write
+jobs:
+  roam:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+      - run: pip install roam-code
+      - run: roam index
+      - run: roam fitness
+      - run: roam pr-risk --json

.gitignore

@@ -1,6 +1,11 @@
-# Rust build output
-/target
-**/target/
+# Dependencies
+node_modules/
+
+# Build output
+dist/
+
+# Test coverage
+coverage/
 
 # IDE
 .idea/
@@ -20,11 +25,15 @@ Thumbs.db
 
 # Logs
 *.log
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
 
 # Local config files
 lore.config.json
+.liquid-mail.toml
 
-# beads viewer cache
+# beads
 .bv/
 
 # SQLite databases (local development)
@@ -32,8 +41,10 @@ lore.config.json
 *.db-wal
 *.db-shm
 
-# Profiling / benchmarks
-perf.data
-perf.data.old
-flamegraph.svg
-*.profraw
+
+# Mock seed data
+tools/mock-seed/
+
+# Added by cargo
+
+/target

.opencode/rules

@@ -1,50 +0,0 @@
-
-````markdown
-## UBS Quick Reference for AI Agents
-
-UBS stands for "Ultimate Bug Scanner": **The AI Coding Agent's Secret Weapon: Flagging Likely Bugs for Fixing Early On**
-
-**Install:** `curl -sSL https://raw.githubusercontent.com/Dicklesworthstone/ultimate_bug_scanner/master/install.sh | bash`
-
-**Golden Rule:** `ubs <changed-files>` before every commit. Exit 0 = safe. Exit >0 = fix & re-run.
-
-**Commands:**
-```bash
-ubs file.ts file2.py                    # Specific files (< 1s) — USE THIS
-ubs $(git diff --name-only --cached)    # Staged files — before commit
-ubs --only=js,python src/               # Language filter (3-5x faster)
-ubs --ci --fail-on-warning .            # CI mode — before PR
-ubs --help                              # Full command reference
-ubs sessions --entries 1                # Tail the latest install session log
-ubs .                                   # Whole project (ignores things like .venv and node_modules automatically)
-```
-
-**Output Format:**
-```
-⚠️  Category (N errors)
-    file.ts:42:5 – Issue description
-    💡 Suggested fix
-Exit code: 1
-```
-Parse: `file:line:col` → location | 💡 → how to fix | Exit 0/1 → pass/fail
-
-**Fix Workflow:**
-1. Read finding → category + fix suggestion
-2. Navigate `file:line:col` → view context
-3. Verify real issue (not false positive)
-4. Fix root cause (not symptom)
-5. Re-run `ubs <file>` → exit 0
-6. Commit
-
-**Speed Critical:** Scope to changed files. `ubs src/file.ts` (< 1s) vs `ubs .` (30s). Never full scan for small edits.
-
-**Bug Severity:**
-- **Critical** (always fix): Null safety, XSS/injection, async/await, memory leaks
-- **Important** (production): Type narrowing, division-by-zero, resource leaks
-- **Contextual** (judgment): TODO/FIXME, console logs
-
-**Anti-Patterns:**
-- ❌ Ignore findings → ✅ Investigate each
-- ❌ Full scan per edit → ✅ Scope to file
-- ❌ Fix symptom (`if (x) { x.y }`) → ✅ Root cause (`x?.y`)
-````

AGENTS.md

@@ -127,66 +127,17 @@ Prefer deterministic lab-runtime tests for concurrency-sensitive behavior.
 
 ---
 
-## MCP Agent Mail — Multi-Agent Coordination
-
-A mail-like layer that lets coding agents coordinate asynchronously via MCP tools and resources. Provides identities, inbox/outbox, searchable threads, and advisory file reservations with human-auditable artifacts in Git.
-
-### Why It's Useful
-
-- **Prevents conflicts:** Explicit file reservations (leases) for files/globs
-- **Token-efficient:** Messages stored in per-project archive, not in context
-- **Quick reads:** `resource://inbox/...`, `resource://thread/...`
-
-### Same Repository Workflow
-
-1. **Register identity:**
-   ```
-   ensure_project(project_key=<abs-path>)
-   register_agent(project_key, program, model)
-   ```
-
-2. **Reserve files before editing:**
-   ```
-   file_reservation_paths(project_key, agent_name, ["src/**"], ttl_seconds=3600, exclusive=true)
-   ```
-
-3. **Communicate with threads:**
-   ```
-   send_message(..., thread_id="FEAT-123")
-   fetch_inbox(project_key, agent_name)
-   acknowledge_message(project_key, agent_name, message_id)
-   ```
-
-4. **Quick reads:**
-   ```
-   resource://inbox/{Agent}?project=<abs-path>&limit=20
-   resource://thread/{id}?project=<abs-path>&include_bodies=true
-   ```
-
-### Macros vs Granular Tools
-
-- **Prefer macros for speed:** `macro_start_session`, `macro_prepare_thread`, `macro_file_reservation_cycle`, `macro_contact_handshake`
-- **Use granular tools for control:** `register_agent`, `file_reservation_paths`, `send_message`, `fetch_inbox`, `acknowledge_message`
-
-### Common Pitfalls
-
-- `"from_agent not registered"`: Always `register_agent` in the correct `project_key` first
-- `"FILE_RESERVATION_CONFLICT"`: Adjust patterns, wait for expiry, or use non-exclusive reservation
-- **Auth errors:** If JWT+JWKS enabled, include bearer token with matching `kid`
-
----
-
 ## Beads (br) — Dependency-Aware Issue Tracking
 
-Beads provides a lightweight, dependency-aware issue database and CLI (`br` / beads_rust) for selecting "ready work," setting priorities, and tracking status. It complements MCP Agent Mail's messaging and file reservations.
+Beads provides a lightweight, dependency-aware issue database and CLI (`br` / beads_rust) for selecting "ready work," setting priorities, and tracking status. It complements Liquid Mail's shared log for progress, decisions, and cross-session context.
 
 **Note:** `br` is non-invasive—it never executes git commands directly. You must run git commands manually after `br sync --flush-only`.
 
 ### Conventions
 
-- **Single source of truth:** Beads for task status/priority/dependencies; Agent Mail for conversation and audit
-- **Shared identifiers:** Use Beads issue ID (e.g., `br-123`) as Mail `thread_id` and prefix subjects with `[br-123]`
-- **Reservations:** When starting a task, call `file_reservation_paths()` with the issue ID in `reason`
+- **Single source of truth:** Beads for task status/priority/dependencies; Liquid Mail for conversation/decisions
+- **Shared identifiers:** Include the Beads issue ID in posts (e.g., `[br-123] Topic validation rules`)
+- **Decisions before action:** Post `DECISION:` messages before risky changes, not after
 
 ### Typical Agent Flow
 
@@ -195,35 +146,34 @@ Beads provides a lightweight, dependency-aware issue database and CLI (`br` / be
    br ready --json  # Choose highest priority, no blockers
    ```
 
-2. **Reserve edit surface (Mail):**
-   ```
-   file_reservation_paths(project_key, agent_name, ["src/**"], ttl_seconds=3600, exclusive=true, reason="br-123")
+2. **Check context (Liquid Mail):**
+   ```bash
+   liquid-mail notify                # See what changed since last session
+   liquid-mail query "br-123"        # Find prior discussion on this issue
    ```
 
-3. **Announce start (Mail):**
-   ```
-   send_message(..., thread_id="br-123", subject="[br-123] Start: <title>", ack_required=true)
+3. **Work and log progress:**
+   ```bash
+   liquid-mail post --topic <workstream> "[br-123] START: <description>"
+   liquid-mail post "[br-123] FINDING: <what you discovered>"
+   liquid-mail post --decision "[br-123] DECISION: <what you decided and why>"
    ```
 
-4. **Work and update:** Reply in-thread with progress
-
-5. **Complete and release:**
+4. **Complete (Beads is authority):**
    ```bash
    br close br-123 --reason "Completed"
+   liquid-mail post "[br-123] Completed: <summary with commit ref>"
    ```
-   ```
-   release_file_reservations(project_key, agent_name, paths=["src/**"])
-   ```
-   Final Mail reply: `[br-123] Completed` with summary
 
 ### Mapping Cheat Sheet
 
-| Concept | Value |
-|---------|-------|
-| Mail `thread_id` | `br-###` |
-| Mail subject | `[br-###] ...` |
-| File reservation `reason` | `br-###` |
-| Commit messages | Include `br-###` for traceability |
+| Concept | In Beads | In Liquid Mail |
+|---------|----------|----------------|
+| Work item | `br-###` (issue ID) | Include `[br-###]` in posts |
+| Workstream | — | `--topic auth-system` |
+| Subject prefix | — | `[br-###] ...` |
+| Commit message | Include `br-###` | — |
+| Status | `br update --status` | Post progress messages |
 
 ---
 
@@ -231,7 +181,7 @@ Beads provides a lightweight, dependency-aware issue database and CLI (`br` / be
 
 bv is a graph-aware triage engine for Beads projects (`.beads/beads.jsonl`). It computes PageRank, betweenness, critical path, cycles, HITS, eigenvector, and k-core metrics deterministically.
 
-**Scope boundary:** bv handles *what to work on* (triage, priority, planning). For agent-to-agent coordination (messaging, work claiming, file reservations), use MCP Agent Mail.
+**Scope boundary:** bv handles *what to work on* (triage, priority, planning). For agent-to-agent coordination (progress logging, decisions, cross-session context), use Liquid Mail.
 
 **CRITICAL: Use ONLY `--robot-*` flags. Bare `bv` launches an interactive TUI that blocks your session.**
 
@@ -673,6 +623,16 @@ lore --robot generate-docs
 # Generate vector embeddings via Ollama
 lore --robot embed
 
+# Personal work dashboard
+lore --robot me
+lore --robot me --issues
+lore --robot me --mrs
+lore --robot me --activity --since 7d
+lore --robot me --project group/repo
+lore --robot me --user jdoe
+lore --robot me --fields minimal
+lore --robot me --reset-cursor
+
 # Agent self-discovery manifest (all commands, flags, exit codes, response schemas)
 lore robot-docs
 

CLAUDE.md

@@ -0,0 +1,960 @@
+# CLAUDE.md
+
+## RULE 0 - THE FUNDAMENTAL OVERRIDE PEROGATIVE
+
+If I tell you to do something, even if it goes against what follows below, YOU MUST LISTEN TO ME. I AM IN CHARGE, NOT YOU.
+
+---
+
+## RULE NUMBER 1: NO FILE DELETION
+
+**YOU ARE NEVER ALLOWED TO DELETE A FILE WITHOUT EXPRESS PERMISSION.** Even a new file that you yourself created, such as a test code file. You have a horrible track record of deleting critically important files or otherwise throwing away tons of expensive work. As a result, you have permanently lost any and all rights to determine that a file or folder should be deleted.
+
+**YOU MUST ALWAYS ASK AND RECEIVE CLEAR, WRITTEN PERMISSION BEFORE EVER DELETING A FILE OR FOLDER OF ANY KIND.**
+
+---
+
+## Version Control: jj-First (CRITICAL)
+
+**ALWAYS prefer jj (Jujutsu) over git for all VCS operations.** This is a colocated repo with both `.jj/` and `.git/`. When instructed to use git by anything — even later in this file — use the best jj replacement commands instead. Only fall back to raw `git` for things jj cannot do (hooks, LFS, submodules, `gh` CLI interop).
+
+See `~/.claude/rules/jj-vcs/` for the full command reference, translation table, revsets, patterns, and recovery recipes.
+
+---
+
+## Irreversible Git & Filesystem Actions — DO NOT EVER BREAK GLASS
+
+> **Note:** Treat destructive commands as break-glass. If there's any doubt, stop and ask.
+
+1. **Absolutely forbidden commands:** `git reset --hard`, `git clean -fd`, `rm -rf`, or any command that can delete or overwrite code/data must never be run unless the user explicitly provides the exact command and states, in the same message, that they understand and want the irreversible consequences.
+2. **No guessing:** If there is any uncertainty about what a command might delete or overwrite, stop immediately and ask the user for specific approval. "I think it's safe" is never acceptable.
+3. **Safer alternatives first:** When cleanup or rollbacks are needed, request permission to use non-destructive options (`git status`, `git diff`, `git stash`, copying to backups) before ever considering a destructive command.
+4. **Mandatory explicit plan:** Even after explicit user authorization, restate the command verbatim, list exactly what will be affected, and wait for a confirmation that your understanding is correct. Only then may you execute it—if anything remains ambiguous, refuse and escalate.
+5. **Document the confirmation:** When running any approved destructive command, record (in the session notes / final response) the exact user text that authorized it, the command actually run, and the execution time. If that record is absent, the operation did not happen.
+
+---
+
+## Toolchain: Rust & Cargo
+
+We only use **Cargo** in this project, NEVER any other package manager.
+
+- **Edition/toolchain:** Follow `rust-toolchain.toml` (if present). Do not assume stable vs nightly.
+- **Dependencies:** Explicit versions for stability; keep the set minimal.
+- **Configuration:** Cargo.toml only
+- **Unsafe code:** Forbidden (`#![forbid(unsafe_code)]`)
+
+When writing Rust code, reference RUST_CLI_TOOLS_BEST_PRACTICES.md
+
+### Release Profile
+
+Use the release profile defined in `Cargo.toml`. If you need to change it, justify the
+performance/size tradeoff and how it impacts determinism and cancellation behavior.
+
+---
+
+## Code Editing Discipline
+
+### No Script-Based Changes
+
+**NEVER** run a script that processes/changes code files in this repo. Brittle regex-based transformations create far more problems than they solve.
+
+- **Always make code changes manually**, even when there are many instances
+- For many simple changes: use parallel subagents
+- For subtle/complex changes: do them methodically yourself
+
+### No File Proliferation
+
+If you want to change something or add a feature, **revise existing code files in place**.
+
+**NEVER** create variations like:
+- `mainV2.rs`
+- `main_improved.rs`
+- `main_enhanced.rs`
+
+New files are reserved for **genuinely new functionality** that makes zero sense to include in any existing file. The bar for creating new files is **incredibly high**.
+
+---
+
+## Backwards Compatibility
+
+We do not care about backwards compatibility—we're in early development with no users. We want to do things the **RIGHT** way with **NO TECH DEBT**.
+
+- Never create "compatibility shims"
+- Never create wrapper functions for deprecated APIs
+- Just fix the code directly
+
+---
+
+## Compiler Checks (CRITICAL)
+
+**After any substantive code changes, you MUST verify no errors were introduced:**
+
+```bash
+# Check for compiler errors and warnings
+cargo check --all-targets
+
+# Check for clippy lints (pedantic + nursery are enabled)
+cargo clippy --all-targets -- -D warnings
+
+# Verify formatting
+cargo fmt --check
+```
+
+If you see errors, **carefully understand and resolve each issue**. Read sufficient context to fix them the RIGHT way.
+
+---
+
+## Testing
+
+### Unit & Property Tests
+
+```bash
+# Run all tests
+cargo test
+
+# Run with output
+cargo test -- --nocapture
+```
+
+When adding or changing primitives, add tests that assert the core invariants:
+
+- no task leaks
+- no obligation leaks
+- losers are drained after races
+- region close implies quiescence
+
+Prefer deterministic lab-runtime tests for concurrency-sensitive behavior.
+
+---
+
+---
+
+## Beads (br) — Dependency-Aware Issue Tracking
+
+Beads provides a lightweight, dependency-aware issue database and CLI (`br` / beads_rust) for selecting "ready work," setting priorities, and tracking status. It complements Liquid Mail's shared log for progress, decisions, and cross-session context.
+
+**Note:** `br` is non-invasive—it never executes git commands directly. You must run git commands manually after `br sync --flush-only`.
+
+### Conventions
+
+- **Single source of truth:** Beads for task status/priority/dependencies; Liquid Mail for conversation/decisions
+- **Shared identifiers:** Include the Beads issue ID in posts (e.g., `[br-123] Topic validation rules`)
+- **Decisions before action:** Post `DECISION:` messages before risky changes, not after
+
+### Typical Agent Flow
+
+1. **Pick ready work (Beads):**
+   ```bash
+   br ready --json  # Choose highest priority, no blockers
+   ```
+
+2. **Check context (Liquid Mail):**
+   ```bash
+   liquid-mail notify                # See what changed since last session
+   liquid-mail query "br-123"        # Find prior discussion on this issue
+   ```
+
+3. **Work and log progress:**
+   ```bash
+   liquid-mail post --topic <workstream> "[br-123] START: <description>"
+   liquid-mail post "[br-123] FINDING: <what you discovered>"
+   liquid-mail post --decision "[br-123] DECISION: <what you decided and why>"
+   ```
+
+4. **Complete (Beads is authority):**
+   ```bash
+   br close br-123 --reason "Completed"
+   liquid-mail post "[br-123] Completed: <summary with commit ref>"
+   ```
+
+### Mapping Cheat Sheet
+
+| Concept | In Beads | In Liquid Mail |
+|---------|----------|----------------|
+| Work item | `br-###` (issue ID) | Include `[br-###]` in posts |
+| Workstream | — | `--topic auth-system` |
+| Subject prefix | — | `[br-###] ...` |
+| Commit message | Include `br-###` | — |
+| Status | `br update --status` | Post progress messages |
+
+---
+
+## bv — Graph-Aware Triage Engine
+
+bv is a graph-aware triage engine for Beads projects (`.beads/beads.jsonl`). It computes PageRank, betweenness, critical path, cycles, HITS, eigenvector, and k-core metrics deterministically.
+
+**Scope boundary:** bv handles *what to work on* (triage, priority, planning). For agent-to-agent coordination (progress logging, decisions, cross-session context), use Liquid Mail.
+
+**CRITICAL: Use ONLY `--robot-*` flags. Bare `bv` launches an interactive TUI that blocks your session.**
+
+### The Workflow: Start With Triage
+
+**`bv --robot-triage` is your single entry point.** It returns:
+- `quick_ref`: at-a-glance counts + top 3 picks
+- `recommendations`: ranked actionable items with scores, reasons, unblock info
+- `quick_wins`: low-effort high-impact items
+- `blockers_to_clear`: items that unblock the most downstream work
+- `project_health`: status/type/priority distributions, graph metrics
+- `commands`: copy-paste shell commands for next steps
+
+```bash
+bv --robot-triage        # THE MEGA-COMMAND: start here
+bv --robot-next          # Minimal: just the single top pick + claim command
+```
+
+### Command Reference
+
+**Planning:**
+| Command | Returns |
+|---------|---------|
+| `--robot-plan` | Parallel execution tracks with `unblocks` lists |
+| `--robot-priority` | Priority misalignment detection with confidence |
+
+**Graph Analysis:**
+| Command | Returns |
+|---------|---------|
+| `--robot-insights` | Full metrics: PageRank, betweenness, HITS, eigenvector, critical path, cycles, k-core, articulation points, slack |
+| `--robot-label-health` | Per-label health: `health_level`, `velocity_score`, `staleness`, `blocked_count` |
+| `--robot-label-flow` | Cross-label dependency: `flow_matrix`, `dependencies`, `bottleneck_labels` |
+| `--robot-label-attention [--attention-limit=N]` | Attention-ranked labels |
+
+**History & Change Tracking:**
+| Command | Returns |
+|---------|---------|
+| `--robot-history` | Bead-to-commit correlations |
+| `--robot-diff --diff-since <ref>` | Changes since ref: new/closed/modified issues, cycles |
+
+**Other:**
+| Command | Returns |
+|---------|---------|
+| `--robot-burndown <sprint>` | Sprint burndown, scope changes, at-risk items |
+| `--robot-forecast <id\|all>` | ETA predictions with dependency-aware scheduling |
+| `--robot-alerts` | Stale issues, blocking cascades, priority mismatches |
+| `--robot-suggest` | Hygiene: duplicates, missing deps, label suggestions |
+| `--robot-graph [--graph-format=json\|dot\|mermaid]` | Dependency graph export |
+| `--export-graph <file.html>` | Interactive HTML visualization |
+
+### Scoping & Filtering
+
+```bash
+bv --robot-plan --label backend              # Scope to label's subgraph
+bv --robot-insights --as-of HEAD~30          # Historical point-in-time
+bv --recipe actionable --robot-plan          # Pre-filter: ready to work
+bv --recipe high-impact --robot-triage       # Pre-filter: top PageRank
+bv --robot-triage --robot-triage-by-track    # Group by parallel work streams
+bv --robot-triage --robot-triage-by-label    # Group by domain
+```
+
+### Understanding Robot Output
+
+**All robot JSON includes:**
+- `data_hash` — Fingerprint of source beads.jsonl
+- `status` — Per-metric state: `computed|approx|timeout|skipped` + elapsed ms
+- `as_of` / `as_of_commit` — Present when using `--as-of`
+
+**Two-phase analysis:**
+- **Phase 1 (instant):** degree, topo sort, density
+- **Phase 2 (async, 500ms timeout):** PageRank, betweenness, HITS, eigenvector, cycles
+
+### jq Quick Reference
+
+```bash
+bv --robot-triage | jq '.quick_ref'                        # At-a-glance summary
+bv --robot-triage | jq '.recommendations[0]'               # Top recommendation
+bv --robot-plan | jq '.plan.summary.highest_impact'        # Best unblock target
+bv --robot-insights | jq '.status'                         # Check metric readiness
+bv --robot-insights | jq '.Cycles'                         # Circular deps (must fix!)
+```
+
+---
+
+## UBS — Ultimate Bug Scanner
+
+**Golden Rule:** `ubs <changed-files>` before every commit. Exit 0 = safe. Exit >0 = fix & re-run.
+
+### Commands
+
+```bash
+ubs file.rs file2.rs                    # Specific files (< 1s) — USE THIS
+ubs $(jj diff --name-only)              # Changed files — before commit
+ubs --only=rust,toml src/               # Language filter (3-5x faster)
+ubs --ci --fail-on-warning .            # CI mode — before PR
+ubs .                                   # Whole project (ignores target/, Cargo.lock)
+```
+
+### Output Format
+
+```
+⚠️  Category (N errors)
+    file.rs:42:5 – Issue description
+    💡 Suggested fix
+Exit code: 1
+```
+
+Parse: `file:line:col` → location | 💡 → how to fix | Exit 0/1 → pass/fail
+
+### Fix Workflow
+
+1. Read finding → category + fix suggestion
+2. Navigate `file:line:col` → view context
+3. Verify real issue (not false positive)
+4. Fix root cause (not symptom)
+5. Re-run `ubs <file>` → exit 0
+6. Commit
+
+### Bug Severity
+
+- **Critical (always fix):** Memory safety, use-after-free, data races, SQL injection
+- **Important (production):** Unwrap panics, resource leaks, overflow checks
+- **Contextual (judgment):** TODO/FIXME, println! debugging
+
+---
+
+## ast-grep vs ripgrep
+
+**Use `ast-grep` when structure matters.** It parses code and matches AST nodes, ignoring comments/strings, and can **safely rewrite** code.
+
+- Refactors/codemods: rename APIs, change import forms
+- Policy checks: enforce patterns across a repo
+- Editor/automation: LSP mode, `--json` output
+
+**Use `ripgrep` when text is enough.** Fastest way to grep literals/regex.
+
+- Recon: find strings, TODOs, log lines, config values
+- Pre-filter: narrow candidate files before ast-grep
+
+### Rule of Thumb
+
+- Need correctness or **applying changes** → `ast-grep`
+- Need raw speed or **hunting text** → `rg`
+- Often combine: `rg` to shortlist files, then `ast-grep` to match/modify
+
+### Rust Examples
+
+```bash
+# Find structured code (ignores comments)
+ast-grep run -l Rust -p 'fn $NAME($$$ARGS) -> $RET { $$$BODY }'
+
+# Find all unwrap() calls
+ast-grep run -l Rust -p '$EXPR.unwrap()'
+
+# Quick textual hunt
+rg -n 'println!' -t rust
+
+# Combine speed + precision
+rg -l -t rust 'unwrap\(' | xargs ast-grep run -l Rust -p '$X.unwrap()' --json
+```
+
+---
+
+## Morph Warp Grep — AI-Powered Code Search
+
+**Use `mcp__morph-mcp__warp_grep` for exploratory "how does X work?" questions.** An AI agent expands your query, greps the codebase, reads relevant files, and returns precise line ranges with full context.
+
+**Use `ripgrep` for targeted searches.** When you know exactly what you're looking for.
+
+**Use `ast-grep` for structural patterns.** When you need AST precision for matching/rewriting.
+
+### When to Use What
+
+| Scenario | Tool | Why |
+|----------|------|-----|
+| "How is pattern matching implemented?" | `warp_grep` | Exploratory; don't know where to start |
+| "Where is the quick reject filter?" | `warp_grep` | Need to understand architecture |
+| "Find all uses of `Regex::new`" | `ripgrep` | Targeted literal search |
+| "Find files with `println!`" | `ripgrep` | Simple pattern |
+| "Replace all `unwrap()` with `expect()`" | `ast-grep` | Structural refactor |
+
+### warp_grep Usage
+
+```
+mcp__morph-mcp__warp_grep(
+  repoPath: "/path/to/dcg",
+  query: "How does the safe pattern whitelist work?"
+)
+```
+
+Returns structured results with file paths, line ranges, and extracted code snippets.
+
+### Anti-Patterns
+
+- **Don't** use `warp_grep` to find a specific function name → use `ripgrep`
+- **Don't** use `ripgrep` to understand "how does X work" → wastes time with manual reads
+- **Don't** use `ripgrep` for codemods → risks collateral edits
+
+<!-- bv-agent-instructions-v1 -->
+
+---
+
+## Beads Workflow Integration
+
+This project uses [beads_viewer](https://github.com/Dicklesworthstone/beads_viewer) for issue tracking. Issues are stored in `.beads/` and tracked in version control.
+
+**Note:** `br` is non-invasive—it never executes VCS commands directly. You must commit manually after `br sync --flush-only`.
+
+### Essential Commands
+
+```bash
+# View issues (launches TUI - avoid in automated sessions)
+bv
+
+# CLI commands for agents (use these instead)
+br ready              # Show issues ready to work (no blockers)
+br list --status=open # All open issues
+br show <id>          # Full issue details with dependencies
+br create --title="..." --type=task --priority=2
+br update <id> --status=in_progress
+br close <id> --reason="Completed"
+br close <id1> <id2>  # Close multiple issues at once
+br sync --flush-only  # Export to JSONL (then: jj commit -m "Update beads")
+```
+
+### Workflow Pattern
+
+1. **Start**: Run `br ready` to find actionable work
+2. **Claim**: Use `br update <id> --status=in_progress`
+3. **Work**: Implement the task
+4. **Complete**: Use `br close <id>`
+5. **Sync**: Run `br sync --flush-only`, then `git add .beads/ && git commit -m "Update beads"`
+
+### Key Concepts
+
+- **Dependencies**: Issues can block other issues. `br ready` shows only unblocked work.
+- **Priority**: P0=critical, P1=high, P2=medium, P3=low, P4=backlog (use numbers, not words)
+- **Types**: task, bug, feature, epic, question, docs
+- **Blocking**: `br dep add <issue> <depends-on>` to add dependencies
+
+### Session Protocol
+
+**Before ending any session, run this checklist (solo/lead only — workers skip VCS):**
+
+```bash
+jj status                        # Check what changed
+br sync --flush-only             # Export beads to JSONL
+jj commit -m "..."               # Commit code and beads (jj auto-tracks all changes)
+jj bookmark set <name> -r @-     # Point bookmark at committed work
+jj git push -b <name>            # Push to remote
+```
+
+### Best Practices
+
+- Check `br ready` at session start to find available work
+- Update status as you work (in_progress → closed)
+- Create new issues with `br create` when you discover tasks
+- Use descriptive titles and set appropriate priority/type
+- Always run `br sync --flush-only` then commit before ending session (jj auto-tracks .beads/)
+
+<!-- end-bv-agent-instructions -->
+
+## Landing the Plane (Session Completion)
+
+**When ending a work session**, you MUST complete ALL steps below. Work is NOT complete until push succeeds.
+
+**WHO RUNS THIS:** Solo agents run it themselves. In multi-agent sessions, ONLY the team lead runs this. Workers skip VCS entirely.
+
+**MANDATORY WORKFLOW:**
+
+1. **File issues for remaining work** - Create issues for anything that needs follow-up
+2. **Run quality gates** (if code changed) - Tests, linters, builds
+3. **Update issue status** - Close finished work, update in-progress items
+4. **PUSH TO REMOTE** - This is MANDATORY:
+   ```bash
+   jj git fetch                       # Get latest remote state
+   jj rebase -d trunk()               # Rebase onto latest trunk if needed
+   br sync --flush-only               # Export beads to JSONL
+   jj commit -m "Update beads"        # Commit (jj auto-tracks .beads/ changes)
+   jj bookmark set <name> -r @-       # Point bookmark at committed work
+   jj git push -b <name>              # Push to remote
+   jj log -r '<name>'                 # Verify bookmark position
+   ```
+5. **Clean up** - Abandon empty orphan changes if any (`jj abandon <rev>`)
+6. **Verify** - All changes committed AND pushed
+7. **Hand off** - Provide context for next session
+
+**CRITICAL RULES:**
+- Work is NOT complete until `jj git push` succeeds
+- NEVER stop before pushing - that leaves work stranded locally
+- NEVER say "ready to push when you are" - YOU must push
+- If push fails, resolve and retry until it succeeds
+
+---
+
+## cass — Cross-Agent Session Search
+
+`cass` indexes prior agent conversations (Claude Code, Codex, Cursor, Gemini, ChatGPT, etc.) so we can reuse solved problems.
+
+**Rules:** Never run bare `cass` (TUI). Always use `--robot` or `--json`.
+
+### Examples
+
+```bash
+cass health
+cass search "async runtime" --robot --limit 5
+cass view /path/to/session.jsonl -n 42 --json
+cass expand /path/to/session.jsonl -n 42 -C 3 --json
+cass capabilities --json
+cass robot-docs guide
+```
+
+### Tips
+
+- Use `--fields minimal` for lean output
+- Filter by agent with `--agent`
+- Use `--days N` to limit to recent history
+
+stdout is data-only, stderr is diagnostics; exit code 0 means success.
+
+Treat cass as a way to avoid re-solving problems other agents already handled.
+
+---
+
+## Note for Codex/GPT-5.2
+
+You constantly bother me and stop working with concerned questions that look similar to this:
+
+```
+Unexpected changes (need guidance)
+
+- Working tree still shows edits I did not make in Cargo.toml, Cargo.lock, src/runtime.rs, src/scope.rs. Please advise whether to keep/commit/revert these before any further work. I did not touch them.
+
+Next steps (pick one)
+
+1. Decide how to handle the unrelated modified files above so we can resume cleanly.
+```
+
+NEVER EVER DO THAT AGAIN. The answer is literally ALWAYS the same: those are changes created by the potentially dozen of other agents working on the project at the same time. This is not only a common occurence, it happens multiple times PER MINUTE. The way to deal with it is simple: you NEVER, under ANY CIRCUMSTANCE, stash, revert, overwrite, or otherwise disturb in ANY way the work of other agents. Just treat those changes identically to changes that you yourself made. Just fool yourself into thinking YOU made the changes and simply don't recall it for some reason.
+
+---
+
+## Note on Built-in TODO Functionality
+
+Also, if I ask you to explicitly use your built-in TODO functionality, don't complain about this and say you need to use beads. You can use built-in TODOs if I tell you specifically to do so. Always comply with such orders.
+
+## TDD Requirements
+
+Test-first development is mandatory:
+1. **RED** - Write failing test first
+2. **GREEN** - Minimal implementation to pass
+3. **REFACTOR** - Clean up while green
+
+## Key Patterns
+
+Find the simplest solution that meets all acceptance criteria.
+Use third party libraries whenever there's a well-maintained, active, and widely adopted solution (for example, date-fns for TS date math)
+Build extensible pieces of logic that can easily be integrated with other pieces.
+DRY principles should be loosely held.
+Architecture MUST be clear and well thought-out. Ask the user for clarification whenever ambiguity is discovered around architecture, or you think a better approach than planned exists.
+
+---
+
+## Third-Party Library Usage
+
+If you aren't 100% sure how to use a third-party library, **SEARCH ONLINE** to find the latest documentation and mid-2025 best practices.
+
+---
+
+## Gitlore Robot Mode
+
+The `lore` CLI has a robot mode optimized for AI agent consumption with compact JSON output, structured errors with machine-actionable recovery steps, meaningful exit codes, response timing metadata, field selection for token efficiency, and TTY auto-detection.
+
+### Activation
+
+```bash
+# Explicit flag
+lore --robot issues -n 10
+
+# JSON shorthand (-J)
+lore -J issues -n 10
+
+# Auto-detection (when stdout is not a TTY)
+lore issues | jq .
+
+# Environment variable
+LORE_ROBOT=1 lore issues
+```
+
+### Robot Mode Commands
+
+```bash
+# List issues/MRs with JSON output
+lore --robot issues -n 10
+lore --robot mrs -s opened
+
+# Filter issues by work item status (case-insensitive)
+lore --robot issues --status "In progress"
+
+# List with field selection (reduces token usage ~60%)
+lore --robot issues --fields minimal
+lore --robot mrs --fields iid,title,state,draft
+
+# Show detailed entity info
+lore --robot issues 123
+lore --robot mrs 456 -p group/repo
+
+# Count entities
+lore --robot count issues
+lore --robot count discussions --for mr
+
+# Search indexed documents
+lore --robot search "authentication bug"
+
+# Check sync status
+lore --robot status
+
+# Run full sync pipeline
+lore --robot sync
+
+# Run sync without resource events
+lore --robot sync --no-events
+
+# Surgical sync: specific entities by IID
+lore --robot sync --issue 42 -p group/repo
+lore --robot sync --mr 99 --mr 100 -p group/repo
+
+# Run ingestion only
+lore --robot ingest issues
+
+# Trace why code was introduced
+lore --robot trace src/main.rs -p group/repo
+
+# File-level MR history
+lore --robot file-history src/auth/ -p group/repo
+
+# Manage cron-based auto-sync (Unix)
+lore --robot cron status
+lore --robot cron install --interval 15
+
+# Token management
+lore --robot token show
+
+# Check environment health
+lore --robot doctor
+
+# Document and index statistics
+lore --robot stats
+
+# Quick health pre-flight check (exit 0 = healthy, 19 = unhealthy)
+lore --robot health
+
+# Generate searchable documents from ingested data
+lore --robot generate-docs
+
+# Generate vector embeddings via Ollama
+lore --robot embed
+
+# Personal work dashboard
+lore --robot me
+lore --robot me --issues
+lore --robot me --mrs
+lore --robot me --activity --since 7d
+lore --robot me --project group/repo
+lore --robot me --user jdoe
+lore --robot me --fields minimal
+lore --robot me --reset-cursor
+
+# Find semantically related entities
+lore --robot related issues 42
+lore --robot related "authentication flow"
+
+# Re-register projects from config
+lore --robot init --refresh
+
+# Agent self-discovery manifest (all commands, flags, exit codes, response schemas)
+lore robot-docs
+
+# Version information
+lore --robot version
+```
+
+### Response Format
+
+All commands return compact JSON with a uniform envelope and timing metadata:
+
+```json
+{"ok":true,"data":{...},"meta":{"elapsed_ms":42}}
+```
+
+Errors return structured JSON to stderr with machine-actionable recovery steps:
+
+```json
+{"error":{"code":"CONFIG_NOT_FOUND","message":"...","suggestion":"Run 'lore init'","actions":["lore init"]}}
+```
+
+The `actions` array contains executable shell commands for automated recovery. It is omitted when empty.
+
+### Field Selection
+
+The `--fields` flag on `issues` and `mrs` list commands controls which fields appear in the JSON response:
+
+```bash
+lore -J issues --fields minimal                    # Preset: iid, title, state, updated_at_iso
+lore -J mrs --fields iid,title,state,draft,labels  # Custom field list
+```
+
+### Exit Codes
+
+| Code | Meaning |
+|------|---------|
+| 0 | Success |
+| 1 | Internal error / not implemented |
+| 2 | Usage error (invalid flags or arguments) |
+| 3 | Config invalid |
+| 4 | Token not set |
+| 5 | GitLab auth failed |
+| 6 | Resource not found |
+| 7 | Rate limited |
+| 8 | Network error |
+| 9 | Database locked |
+| 10 | Database error |
+| 11 | Migration failed |
+| 12 | I/O error |
+| 13 | Transform error |
+| 14 | Ollama unavailable |
+| 15 | Ollama model not found |
+| 16 | Embedding failed |
+| 17 | Not found (entity does not exist) |
+| 18 | Ambiguous match (use `-p` to specify project) |
+| 19 | Health check failed |
+| 20 | Config not found |
+
+### Configuration Precedence
+
+1. CLI flags (highest priority)
+2. Environment variables (`LORE_ROBOT`, `GITLAB_TOKEN`, `LORE_CONFIG_PATH`)
+3. Config file (`~/.config/lore/config.json`)
+4. Built-in defaults (lowest priority)
+
+### Best Practices
+
+- Use `lore --robot` or `lore -J` for all agent interactions
+- Check exit codes for error handling
+- Parse JSON errors from stderr; use `actions` array for automated recovery
+- Use `--fields minimal` to reduce token usage (~60% fewer tokens)
+- Use `-n` / `--limit` to control response size
+- Use `-q` / `--quiet` to suppress progress bars and non-essential output
+- Use `--color never` in non-TTY automation for ANSI-free output
+- Use `-v` / `-vv` / `-vvv` for increasing verbosity (debug/trace logging)
+- Use `--log-format json` for machine-readable log output to stderr
+- TTY detection handles piped commands automatically
+- Use `lore --robot health` as a fast pre-flight check before queries
+- Use `lore robot-docs` for response schema discovery
+- The `-p` flag supports fuzzy project matching (suffix and substring)
+
+---
+
+## Read/Write Split: lore vs glab
+
+| Operation | Tool | Why |
+|-----------|------|-----|
+| List issues/MRs | lore | Richer: includes status, discussions, closing MRs |
+| View issue/MR detail | lore | Pre-joined discussions, work-item status |
+| Search across entities | lore | FTS5 + vector hybrid search |
+| Expert/workload analysis | lore | who command — no glab equivalent |
+| Timeline reconstruction | lore | Chronological narrative — no glab equivalent |
+| Create/update/close | glab | Write operations |
+| Approve/merge MR | glab | Write operations |
+| CI/CD pipelines | glab | Not in lore scope |
+
+````markdown
+## UBS Quick Reference for AI Agents
+
+UBS stands for "Ultimate Bug Scanner": **The AI Coding Agent's Secret Weapon: Flagging Likely Bugs for Fixing Early On**
+
+**Install:** `curl -sSL https://raw.githubusercontent.com/Dicklesworthstone/ultimate_bug_scanner/master/install.sh | bash`
+
+**Golden Rule:** `ubs <changed-files>` before every commit. Exit 0 = safe. Exit >0 = fix & re-run.
+
+**Commands:**
+```bash
+ubs file.ts file2.py                    # Specific files (< 1s) — USE THIS
+ubs $(git diff --name-only --cached)    # Staged files — before commit
+ubs --only=js,python src/               # Language filter (3-5x faster)
+ubs --ci --fail-on-warning .            # CI mode — before PR
+ubs --help                              # Full command reference
+ubs sessions --entries 1                # Tail the latest install session log
+ubs .                                   # Whole project (ignores things like .venv and node_modules automatically)
+```
+
+**Output Format:**
+```
+⚠️  Category (N errors)
+    file.ts:42:5 – Issue description
+    💡 Suggested fix
+Exit code: 1
+```
+Parse: `file:line:col` → location | 💡 → how to fix | Exit 0/1 → pass/fail
+
+**Fix Workflow:**
+1. Read finding → category + fix suggestion
+2. Navigate `file:line:col` → view context
+3. Verify real issue (not false positive)
+4. Fix root cause (not symptom)
+5. Re-run `ubs <file>` → exit 0
+6. Commit
+
+**Speed Critical:** Scope to changed files. `ubs src/file.ts` (< 1s) vs `ubs .` (30s). Never full scan for small edits.
+
+**Bug Severity:**
+- **Critical** (always fix): Null safety, XSS/injection, async/await, memory leaks
+- **Important** (production): Type narrowing, division-by-zero, resource leaks
+- **Contextual** (judgment): TODO/FIXME, console logs
+
+**Anti-Patterns:**
+- ❌ Ignore findings → ✅ Investigate each
+- ❌ Full scan per edit → ✅ Scope to file
+- ❌ Fix symptom (`if (x) { x.y }`) → ✅ Root cause (`x?.y`)
+````
+
+<!-- BEGIN LIQUID MAIL (v:48d7b3fc) -->
+## Integrating Liquid Mail with Beads
+
+**Beads** manages task status, priority, and dependencies (`br` CLI).
+**Liquid Mail** provides the shared log—progress, decisions, and context that survives sessions.
+
+### Conventions
+
+- **Single source of truth**: Beads owns task state; Liquid Mail owns conversation/decisions
+- **Shared identifiers**: Include the Beads issue ID in posts (e.g., `[lm-jht] Topic validation rules`)
+- **Decisions before action**: Post `DECISION:` messages before risky changes, not after
+- **Identity in user updates**: In every user-facing reply, include your window-name (derived from `LIQUID_MAIL_WINDOW_ID`) so humans can distinguish concurrent agents.
+
+### Typical Flow
+
+**1. Pick ready work (Beads)**
+```bash
+br ready                    # Find available work (no blockers)
+br show lm-jht              # Review details
+br update lm-jht --status in_progress
+```
+
+**2. Check context (Liquid Mail)**
+```bash
+liquid-mail notify          # See what changed since last session
+liquid-mail query "lm-jht"  # Find prior discussion on this issue
+```
+
+**3. Work and log progress (topic required)**
+
+The `--topic` flag is required for your first post. After that, the topic is pinned to your window.
+```bash
+liquid-mail post --topic auth-system "[lm-jht] START: Reviewing current topic id patterns"
+liquid-mail post "[lm-jht] FINDING: IDs like lm3189... are being used as topic names"
+liquid-mail post "[lm-jht] NEXT: Add validation + rename guidance"
+```
+
+**4. Decisions before risky changes**
+```bash
+liquid-mail post --decision "[lm-jht] DECISION: Reject UUID-like topic names; require slugs"
+# Then implement
+```
+
+### Decision Conflicts (Preflight)
+
+When you post a decision (via `--decision` or a `DECISION:` line), Liquid Mail can preflight-check for conflicts with prior decisions **in the same topic**.
+
+- If a conflict is detected, `liquid-mail post` fails with `DECISION_CONFLICT`.
+- Review prior decisions: `liquid-mail decisions --topic <topic>`.
+- If you intend to supersede the old decision, re-run with `--yes` and include what changed and why.
+
+**5. Complete (Beads is authority)**
+```bash
+br close lm-jht             # Mark complete in Beads
+liquid-mail post "[lm-jht] Completed: Topic validation shipped in 177267d"
+```
+
+### Posting Format
+
+- **Short** (5-15 lines, not walls of text)
+- **Prefixed** with ALL-CAPS tags: `FINDING:`, `DECISION:`, `QUESTION:`, `NEXT:`
+- **Include file paths** so others can jump in: `src/services/auth.ts:42`
+- **Include issue IDs** in brackets: `[lm-jht]`
+- **User-facing replies**: include `AGENT: <window-name>` near the top. Get it with `liquid-mail window name`.
+
+### Topics (Required)
+
+Liquid Mail organizes messages into **topics** (Honcho sessions). Topics are **soft boundaries**—search spans all topics by default.
+
+**Rule:** `liquid-mail post` requires a topic:
+- Provide `--topic <name>`, OR
+- Post inside a window that already has a pinned topic.
+
+Topic names must be:
+- 4–50 characters
+- lowercase letters/numbers with hyphens
+- start with a letter, end with a letter/number
+- no consecutive hyphens
+- not reserved (`all`, `new`, `help`, `merge`, `rename`, `list`)
+- not UUID-like (`lm<32-hex>` or standard UUIDs)
+
+Good examples: `auth-system`, `db-system`, `dashboards`
+
+Commands:
+
+- **List topics (newest first)**: `liquid-mail topics`
+- **Find context across topics**: `liquid-mail query "auth"`, then pick a topic name
+- **Rename a topic (alias)**: `liquid-mail topic rename <old> <new>`
+- **Merge two topics into a new one**: `liquid-mail topic merge <A> <B> --into <C>`
+
+Examples (component topic + Beads id in the subject):
+```bash
+liquid-mail post --topic auth-system "[lm-jht] START: Investigating token refresh failures"
+liquid-mail post --topic auth-system "[lm-jht] FINDING: refresh happens in middleware, not service layer"
+liquid-mail post --topic auth-system --decision "[lm-jht] DECISION: Move refresh logic into AuthService"
+
+liquid-mail post --topic dashboards "[lm-1p5] START: Adding latency panel"
+```
+
+### Context Refresh (Before New Work / After Redirects)
+
+If you see redirect/merge messages, refresh context before acting:
+```bash
+liquid-mail notify
+liquid-mail window status --json
+liquid-mail summarize --topic <topic>
+liquid-mail decisions --topic <topic>
+```
+
+If you discover a newer "canonical" topic (for example after a topic merge), switch to it explicitly:
+```bash
+liquid-mail post --topic <new-topic> "[lm-xxxx] CONTEXT: Switching topics (rename/merge)"
+```
+
+### Live Updates (Polling)
+
+Liquid Mail is pull-based by default (you run `notify`). For near-real-time updates:
+```bash
+liquid-mail watch --topic <topic>   # watch a topic
+liquid-mail watch                   # or watch your pinned topic
+```
+
+### Mapping Cheat-Sheet
+
+| Concept | In Beads | In Liquid Mail |
+|---------|----------|----------------|
+| Work item | `lm-jht` (issue ID) | Include `[lm-jht]` in posts |
+| Workstream | — | `--topic auth-system` |
+| Subject prefix | — | `[lm-jht] ...` |
+| Commit message | Include `lm-jht` | — |
+| Status | `br update --status` | Post progress messages |
+
+### Pitfalls
+
+- **Don't manage tasks in Liquid Mail**—Beads is the single task queue
+- **Always include `lm-xxx`** in posts to avoid ID drift across tools
+- **Don't dump logs**—keep posts short and structured
+
+### Quick Reference
+
+| Need | Command |
+|------|---------|
+| What changed? | `liquid-mail notify` |
+| Log progress | `liquid-mail post "[lm-xxx] ..."` |
+| Before risky change | `liquid-mail post --decision "[lm-xxx] DECISION: ..."` |
+| Find history | `liquid-mail query "search term"` |
+| Prior decisions | `liquid-mail decisions --topic <topic>` |
+| Show config | `liquid-mail config` |
+| List topics | `liquid-mail topics` |
+| Rename topic | `liquid-mail topic rename <old> <new>` |
+| Merge topics | `liquid-mail topic merge <A> <B> --into <C>` |
+| Polling watch | `liquid-mail watch [--topic <topic>]` |
+<!-- END LIQUID MAIL -->

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "lore"
-version = "0.7.0"
+version = "0.9.5"
 edition = "2024"
 description = "Gitlore - Local GitLab data management with semantic search"
 authors = ["Taylor Eernisse"]
@@ -25,16 +25,15 @@ clap_complete = "4"
 dialoguer = "0.12"
 console = "0.16"
 indicatif = "0.18"
-comfy-table = "7"
+lipgloss = { package = "charmed-lipgloss", version = "0.2", default-features = false, features = ["native"] }
 open = "5"
 
 # HTTP
-reqwest = { version = "0.12", features = ["json"] }
-tokio = { version = "1", features = ["rt-multi-thread", "macros", "time", "signal"] }
+asupersync = { version = "0.2", features = ["tls", "tls-native-roots"] }
 
 # Async streaming for pagination
 async-stream = "0.3"
-futures = { version = "0.3", default-features = false, features = ["alloc"] }
+futures = { version = "0.3", default-features = false, features = ["alloc", "async-await"] }
 
 # Utilities
 thiserror = "2"
@@ -60,6 +59,7 @@ tracing-appender = "0.2"
 
 [dev-dependencies]
 tempfile = "3"
+tokio = { version = "1", features = ["rt", "rt-multi-thread", "macros"] }
 wiremock = "0.6"
 
 [profile.release]

PROPOSED_CODE_FILE_REORGANIZATION_PLAN.md

@@ -0,0 +1,636 @@
+# Proposed Code File Reorganization Plan
+
+## 1. Scope, Audit Method, and Constraints
+
+This plan is based on a full audit of the `src/` tree (all 131 Rust files) plus integration tests in `tests/` that import `src` modules.
+
+What I audited:
+- module/file inventory (`src/**.rs`)
+- line counts and hotspot analysis
+- crate-internal import graph (`use crate::...`)
+- public API surface (public structs/enums/functions by file)
+- command routing and re-export topology (`main.rs`, `lib.rs`, `cli/mod.rs`, `cli/commands/mod.rs`)
+- cross-module coupling and test coupling
+
+Constraints followed for this proposal:
+- no implementation yet (plan only)
+- keep nesting shallow and intuitive
+- optimize for discoverability for humans and coding agents
+- no compatibility shims as a long-term strategy
+- every structural change includes explicit call-site update tracking
+
+---
+
+## 2. Current State (Measured)
+
+### 2.1 Size by top-level module (`src/`)
+
+| Module | Files | Lines | Prod Files | Prod Lines | Test Files | Test Lines |
+|---|---:|---:|---:|---:|---:|---:|
+| `cli` | 41 | 29,131 | 37 | 23,068 | 4 | 6,063 |
+| `core` | 39 | 12,493 | 27 | 7,599 | 12 | 4,894 |
+| `ingestion` | 15 | 6,935 | 10 | 5,259 | 5 | 1,676 |
+| `documents` | 6 | 3,657 | 4 | 1,749 | 2 | 1,908 |
+| `gitlab` | 11 | 3,607 | 8 | 2,391 | 3 | 1,216 |
+| `embedding` | 10 | 1,878 | 7 | 1,327 | 3 | 551 |
+| `search` | 6 | 1,115 | 6 | 1,115 | 0 | 0 |
+| `main.rs` | 1 | 3,744 | 1 | 3,744 | 0 | 0 |
+| `lib.rs` | 1 | 9 | 1 | 9 | 0 | 0 |
+
+Total in `src/`: **131 files / 62,569 lines**.
+
+### 2.2 Largest production hotspots
+
+| File | Lines | Why it matters |
+|---|---:|---|
+| `src/main.rs` | 3,744 | Binary entrypoint is doing too much dispatch and formatting work |
+| `src/cli/autocorrect.rs` | 1,865 | Large parsing/correction ruleset in one file |
+| `src/ingestion/orchestrator.rs` | 1,753 | Multi-stage ingestion orchestration and persistence mixed together |
+| `src/cli/commands/show.rs` | 1,544 | Issue/MR retrieval + rendering + JSON conversion all in one file |
+| `src/cli/render.rs` | 1,482 | Theme, table layout, formatting utilities bundled together |
+| `src/cli/commands/list.rs` | 1,383 | Issues + MRs + notes listing/query/printing in one file |
+| `src/cli/mod.rs` | 1,268 | Clap root parser plus every args struct |
+| `src/cli/commands/sync.rs` | 1,201 | Sync flow + human rendering + JSON output |
+| `src/cli/commands/me/queries.rs` | 1,135 | Multiple query families and post-processing logic |
+| `src/cli/commands/ingest.rs` | 1,116 | Ingest flow + dry-run + presentation concerns |
+| `src/documents/extractor.rs` | 1,059 | Four document source extractors in one file |
+
+### 2.3 High-level dependency flow (top modules)
+
+Observed module coupling from imports:
+- `cli -> core` (very heavy, 33 files)
+- `cli -> documents/embedding/gitlab/ingestion/search` (command-dependent)
+- `ingestion -> core` (12 files), `ingestion -> gitlab` (10 files)
+- `search -> core` and `search -> embedding`
+- `timeline` logic currently located under `core/*timeline*` but semantically acts as its own subsystem
+
+### 2.4 Structural pain points
+
+1. `main.rs` is overloaded with command handlers, robot output envelope types, clap error mapping, and domain invocation.
+2. `cli/mod.rs` mixes root parser concerns with command-specific argument schemas.
+3. `core/` still holds domain-specific subsystems (`timeline`, cross-reference extraction, ingestion persistence helpers) that are not truly "core infra".
+4. Several large command files combine query/build/fetch/render/json responsibilities.
+5. Test helper setup is duplicated heavily in large test files (`who_tests`, `list_tests`, `me_tests`).
+
+---
+
+## 3. Reorganization Principles
+
+1. Keep top-level domains explicit: `cli`, `core` (infra), `gitlab`, `ingestion`, `documents`, `embedding`, `search`, plus extracted domain modules where justified.
+2. Keep nesting shallow: max 2-3 levels in normal workflow paths.
+3. Co-locate command-specific args/types/rendering with the command implementation.
+4. Separate orchestration from formatting from data-access code.
+5. Prefer module boundaries that map to runtime pipeline boundaries.
+6. Make import paths reveal ownership directly.
+
+---
+
+## 4. Proposed Target Structure (End State)
+
+```text
+src/
+  main.rs                      # thin binary entrypoint
+  lib.rs
+
+  app/                         # NEW: runtime dispatch/orchestration glue
+    mod.rs
+    dispatch.rs
+    errors.rs
+    robot_docs.rs
+
+  cli/
+    mod.rs                     # Cli + Commands only
+    args.rs                    # shared args structs used by Commands variants
+    render/
+      mod.rs
+      format.rs
+      table.rs
+      theme.rs
+    autocorrect/
+      mod.rs
+      flags.rs
+      enums.rs
+      fuzzy.rs
+    commands/
+      mod.rs
+      list/
+        mod.rs
+        issues.rs
+        mrs.rs
+        notes.rs
+        render.rs
+      show/
+        mod.rs
+        issue.rs
+        mr.rs
+        render.rs
+      me/                      # keep existing folder, retain split style
+      who/                     # keep existing folder, retain split style
+      ingest/
+        mod.rs
+        run.rs
+        dry_run.rs
+        render.rs
+      sync/
+        mod.rs
+        run.rs
+        render.rs
+        surgical.rs
+      # smaller focused commands can stay single-file for now
+
+  core/                        # infra-only boundary after moves
+    mod.rs
+    backoff.rs
+    config.rs
+    cron.rs
+    cursor.rs
+    db.rs
+    error.rs
+    file_history.rs
+    lock.rs
+    logging.rs
+    metrics.rs
+    path_resolver.rs
+    paths.rs
+    project.rs
+    shutdown.rs
+    time.rs
+    trace.rs
+
+  timeline/                    # NEW: extracted domain subsystem
+    mod.rs
+    types.rs
+    seed.rs
+    expand.rs
+    collect.rs
+
+  xref/                        # NEW: extracted cross-reference subsystem
+    mod.rs
+    note_parser.rs
+    references.rs
+
+  ingestion/
+    mod.rs
+    issues.rs
+    merge_requests.rs
+    discussions.rs
+    mr_discussions.rs
+    mr_diffs.rs
+    dirty_tracker.rs
+    discussion_queue.rs
+    orchestrator/
+      mod.rs
+      issues_flow.rs
+      mrs_flow.rs
+      resource_events.rs
+      closes_issues.rs
+      diff_jobs.rs
+      progress.rs
+    storage/                   # NEW: ingestion-owned persistence helpers
+      mod.rs
+      payloads.rs              # from core/payloads.rs
+      events.rs                # from core/events_db.rs
+      queue.rs                 # from core/dependent_queue.rs
+      sync_run.rs              # from core/sync_run.rs
+
+  documents/
+    mod.rs
+    extractor/
+      mod.rs
+      issues.rs
+      mrs.rs
+      discussions.rs
+      notes.rs
+      common.rs
+    regenerator.rs
+    truncation.rs
+
+  embedding/
+    mod.rs
+    change_detector.rs
+    chunks.rs                  # merge chunk_ids.rs + chunking.rs
+    ollama.rs
+    pipeline.rs
+    similarity.rs
+
+  gitlab/
+    # mostly keep as-is (already coherent)
+
+  search/
+    # mostly keep as-is (already coherent)
+```
+
+Notes:
+- `gitlab/` and `search/` are already cohesive and should largely remain unchanged.
+- `who/` and `me/` command families are already split well relative to other commands.
+
+---
+
+## 5. Detailed Change Plan (Phased)
+
+## Phase 1: Domain Boundary Extraction (lowest conceptual risk, high clarity gain)
+
+### 5.1 Extract timeline subsystem from `core`
+
+Move:
+- `src/core/timeline.rs` -> `src/timeline/types.rs`
+- `src/core/timeline_seed.rs` -> `src/timeline/seed.rs`
+- `src/core/timeline_expand.rs` -> `src/timeline/expand.rs`
+- `src/core/timeline_collect.rs` -> `src/timeline/collect.rs`
+- add `src/timeline/mod.rs`
+
+Why:
+- Timeline is a full pipeline domain (seed -> expand -> collect), not core infra.
+- Improves discoverability for `lore timeline` and timeline tests.
+
+Calling-code updates required:
+- `src/cli/commands/timeline.rs`
+  - `crate::core::timeline::*` -> `crate::timeline::*`
+  - `crate::core::timeline_seed::*` -> `crate::timeline::seed::*`
+  - `crate::core::timeline_expand::*` -> `crate::timeline::expand::*`
+  - `crate::core::timeline_collect::*` -> `crate::timeline::collect::*`
+- `tests/timeline_pipeline_tests.rs`
+  - `lore::core::timeline*` imports -> `lore::timeline::*`
+- internal references among moved files update from `crate::core::timeline` to `crate::timeline::types`
+- `src/core/mod.rs`: remove `timeline*` module declarations
+- `src/lib.rs`: add `pub mod timeline;`
+
+### 5.2 Extract cross-reference subsystem from `core`
+
+Move:
+- `src/core/note_parser.rs` -> `src/xref/note_parser.rs`
+- `src/core/references.rs` -> `src/xref/references.rs`
+- add `src/xref/mod.rs`
+
+Why:
+- Cross-reference extraction is a domain subsystem feeding ingestion and timeline.
+- Current placement in `core/` obscures data flow.
+
+Calling-code updates required:
+- `src/ingestion/orchestrator.rs`
+  - `crate::core::references::*` -> `crate::xref::references::*`
+  - `crate::core::note_parser::*` -> `crate::xref::note_parser::*`
+- `src/core/mod.rs`: remove `note_parser` and `references`
+- `src/lib.rs`: add `pub mod xref;`
+- tests referencing old paths update to `crate::xref::*`
+
+### 5.3 Move ingestion-owned persistence helpers out of `core`
+
+Move:
+- `src/core/payloads.rs` -> `src/ingestion/storage/payloads.rs`
+- `src/core/events_db.rs` -> `src/ingestion/storage/events.rs`
+- `src/core/dependent_queue.rs` -> `src/ingestion/storage/queue.rs`
+- `src/core/sync_run.rs` -> `src/ingestion/storage/sync_run.rs`
+- add `src/ingestion/storage/mod.rs`
+
+Why:
+- These files primarily support ingestion/sync runtime behavior and ingestion persistence.
+- Consolidates ingestion runtime + ingestion storage into one domain area.
+
+Calling-code updates required:
+- `src/ingestion/discussions.rs`, `issues.rs`, `merge_requests.rs`, `mr_discussions.rs`
+  - `core::payloads::*` -> `ingestion::storage::payloads::*`
+- `src/ingestion/orchestrator.rs`
+  - `core::dependent_queue::*` -> `ingestion::storage::queue::*`
+  - `core::events_db::*` -> `ingestion::storage::events::*`
+- `src/main.rs`
+  - `core::dependent_queue::release_all_locked_jobs` -> `ingestion::storage::queue::release_all_locked_jobs`
+  - `core::sync_run::SyncRunRecorder` -> `ingestion::storage::sync_run::SyncRunRecorder`
+- `src/cli/commands/count.rs`
+  - `core::events_db::*` -> `ingestion::storage::events::*`
+- `src/cli/commands/sync_surgical.rs`
+  - `core::sync_run::SyncRunRecorder` -> `ingestion::storage::sync_run::SyncRunRecorder`
+- `src/core/mod.rs`: remove moved modules
+- `src/ingestion/mod.rs`: export `pub mod storage;`
+
+---
+
+## Phase 2: CLI Structure Cleanup (high dev ergonomics impact)
+
+### 5.4 Split `cli/mod.rs` responsibilities
+
+Current:
+- root parser (`Cli`, `Commands`)
+- all args structs (`IssuesArgs`, `WhoArgs`, `MeArgs`, etc.)
+
+Proposed:
+- `src/cli/mod.rs`: only `Cli`, `Commands`, top-level parser behavior
+- `src/cli/args.rs`: all args structs and command-local enums (`CronAction`, `TokenAction`)
+
+Why:
+- keeps parser root small and readable
+- one canonical place for args schemas
+
+Calling-code updates required:
+- `src/main.rs`
+  - `use lore::cli::{..., WhoArgs, ...}` -> `use lore::cli::args::{...}` (or re-export from `cli/mod.rs`)
+- `src/cli/commands/who/mod.rs`
+  - `use crate::cli::WhoArgs;` -> `use crate::cli::args::WhoArgs;`
+- `src/cli/commands/me/mod.rs`
+  - `use crate::cli::MeArgs;` -> `use crate::cli::args::MeArgs;`
+
+### 5.5 Make `main.rs` thin by moving dispatch logic to `app/`
+
+Proposed splits from `main.rs`:
+- `app/dispatch.rs`: all `handle_*` command handlers
+- `app/errors.rs`: clap error mapping, correction warning formatting
+- `app/robot_docs.rs`: robot docs schema/data envelope generation
+- keep `main.rs`: startup, logging init, parse, delegate to dispatcher
+
+Why:
+- reduces entrypoint complexity and improves testability of dispatch behavior
+- isolates robot docs machinery from runtime bootstrapping
+
+Calling-code updates required:
+- `main.rs`: replace direct handler function definitions with calls into `app::*`
+- `lib.rs`: add `pub mod app;` if shared imports needed by tests
+
+---
+
+## Phase 3: Split Large Command Files by Responsibility
+
+### 5.6 Split `cli/commands/list.rs`
+
+Proposed:
+- `commands/list/issues.rs` (issue queries + issue output)
+- `commands/list/mrs.rs` (MR queries + MR output)
+- `commands/list/notes.rs` (note queries + note output)
+- `commands/list/render.rs` (shared formatting helpers)
+- `commands/list/mod.rs` (public API and re-exports)
+
+Why:
+- list concerns are already logically tripartite
+- better locality for bugfixes and feature additions
+
+Calling-code updates required:
+- `src/cli/commands/mod.rs`: import module folder and re-export unchanged API names
+- `src/main.rs`: ideally no change if `commands/mod.rs` re-exports remain stable
+
+### 5.7 Split `cli/commands/show.rs`
+
+Proposed:
+- `commands/show/issue.rs`
+- `commands/show/mr.rs`
+- `commands/show/render.rs`
+- `commands/show/mod.rs`
+
+Why:
+- issue and MR detail assembly have separate SQL and shape logic
+- rendering concerns can be isolated from data retrieval
+
+Calling-code updates required:
+- `src/cli/commands/mod.rs` re-exports preserved (`run_show_issue`, `run_show_mr`, printers)
+- `src/main.rs` remains stable if re-exports preserved
+
+### 5.8 Split `cli/commands/ingest.rs` and `cli/commands/sync.rs`
+
+Proposed:
+- `commands/ingest/run.rs`, `dry_run.rs`, `render.rs`, `mod.rs`
+- `commands/sync/run.rs`, `render.rs`, `surgical.rs`, `mod.rs`
+
+Why:
+- orchestration, preview generation, and output rendering are currently intertwined
+- surgical sync is semantically part of sync command family
+
+Calling-code updates required:
+- update `src/cli/commands/mod.rs` exports
+- update `src/cli/commands/sync_surgical.rs` path if merged into `commands/sync/surgical.rs`
+- no CLI UX changes expected if external API names remain
+
+### 5.9 Split `documents/extractor.rs`
+
+Proposed:
+- `documents/extractor/issues.rs`
+- `documents/extractor/mrs.rs`
+- `documents/extractor/discussions.rs`
+- `documents/extractor/notes.rs`
+- `documents/extractor/common.rs`
+- `documents/extractor/mod.rs`
+
+Why:
+- extractor currently contains four independent source-type extraction paths
+- per-source unit tests become easier to target
+
+Calling-code updates required:
+- `src/documents/mod.rs` re-export surface remains stable
+- `src/documents/regenerator.rs` imports update only if internal re-export paths change
+
+---
+
+## Phase 4: Opportunistic Consolidations
+
+### 5.10 Merge tiny embedding chunk helpers
+
+Merge:
+- `src/embedding/chunk_ids.rs`
+- `src/embedding/chunking.rs`
+- into `src/embedding/chunks.rs`
+
+Why:
+- both represent one conceptual concern: chunk partitioning and chunk identity mapping
+- avoids tiny-file scattering
+
+Calling-code updates required:
+- `src/embedding/pipeline.rs`
+- `src/embedding/change_detector.rs`
+- `src/search/vector.rs`
+- `src/embedding/mod.rs` exports
+
+### 5.11 Test helper de-duplication
+
+Add a shared test support module for repeated DB fixture setup currently duplicated in:
+- `src/cli/commands/who_tests.rs`
+- `src/cli/commands/list_tests.rs`
+- `src/cli/commands/me/me_tests.rs`
+- multiple `core/*_tests.rs`
+
+Why:
+- lower maintenance cost and fewer fixture drift bugs
+
+Calling-code updates required:
+- test-only imports in affected files
+
+---
+
+## 6. File-Level Recommendation Matrix
+
+Legend:
+- `KEEP`: structure is already coherent
+- `MOVE`: relocate without major logic split
+- `SPLIT`: divide into focused files/modules
+- `MERGE`: consolidate tiny related files
+
+### 6.1 `core/`
+
+- `backoff.rs` -> KEEP
+- `config.rs` -> KEEP (large but cohesive)
+- `cron.rs` -> KEEP
+- `cursor.rs` -> KEEP
+- `db.rs` -> KEEP
+- `dependent_queue.rs` -> MOVE to `ingestion/storage/queue.rs`
+- `error.rs` -> KEEP
+- `events_db.rs` -> MOVE to `ingestion/storage/events.rs`
+- `file_history.rs` -> KEEP
+- `lock.rs` -> KEEP
+- `logging.rs` -> KEEP
+- `metrics.rs` -> KEEP
+- `note_parser.rs` -> MOVE to `xref/note_parser.rs`
+- `path_resolver.rs` -> KEEP
+- `paths.rs` -> KEEP
+- `payloads.rs` -> MOVE to `ingestion/storage/payloads.rs`
+- `project.rs` -> KEEP
+- `references.rs` -> MOVE to `xref/references.rs`
+- `shutdown.rs` -> KEEP
+- `sync_run.rs` -> MOVE to `ingestion/storage/sync_run.rs`
+- `time.rs` -> KEEP
+- `timeline.rs`, `timeline_seed.rs`, `timeline_expand.rs`, `timeline_collect.rs` -> MOVE to `timeline/`
+- `trace.rs` -> KEEP
+
+### 6.2 `cli/`
+
+- `mod.rs` -> SPLIT (`mod.rs` + `args.rs`)
+- `autocorrect.rs` -> SPLIT into `autocorrect/` submodules
+- `render.rs` -> SPLIT into `render/` submodules
+- `commands/list.rs` -> SPLIT into `commands/list/`
+- `commands/show.rs` -> SPLIT into `commands/show/`
+- `commands/ingest.rs` -> SPLIT into `commands/ingest/`
+- `commands/sync.rs` + `commands/sync_surgical.rs` -> SPLIT/MERGE into `commands/sync/`
+- `commands/me/*` -> KEEP (already good shape)
+- `commands/who/*` -> KEEP (already good shape)
+- small focused commands (`auth_test`, `embed`, `trace`, etc.) -> KEEP
+
+### 6.3 `documents/`
+
+- `extractor.rs` -> SPLIT into extractor folder
+- `regenerator.rs` -> KEEP
+- `truncation.rs` -> KEEP
+
+### 6.4 `embedding/`
+
+- `change_detector.rs` -> KEEP
+- `chunk_ids.rs` + `chunking.rs` -> MERGE into `chunks.rs`
+- `ollama.rs` -> KEEP
+- `pipeline.rs` -> KEEP for now (already a pipeline-centric file)
+- `similarity.rs` -> KEEP
+
+### 6.5 `gitlab/`, `search/`
+
+- KEEP as-is except minor internal refactors only when touched by feature work
+
+---
+
+## 7. Import/Call-Site Impact Tracker (must-update list)
+
+This section tracks files that must be updated when moves happen to avoid broken builds.
+
+### 7.1 For timeline extraction
+
+Must update:
+- `src/cli/commands/timeline.rs`
+- `tests/timeline_pipeline_tests.rs`
+- moved timeline module internals (`seed`, `expand`, `collect`)
+- `src/core/mod.rs`
+- `src/lib.rs`
+
+### 7.2 For xref extraction
+
+Must update:
+- `src/ingestion/orchestrator.rs` (all `core::references` and `core::note_parser` paths)
+- tests importing moved modules
+- `src/core/mod.rs`
+- `src/lib.rs`
+
+### 7.3 For ingestion storage move
+
+Must update:
+- `src/ingestion/discussions.rs`
+- `src/ingestion/issues.rs`
+- `src/ingestion/merge_requests.rs`
+- `src/ingestion/mr_discussions.rs`
+- `src/ingestion/orchestrator.rs`
+- `src/cli/commands/count.rs`
+- `src/cli/commands/sync_surgical.rs`
+- `src/main.rs`
+- `src/core/mod.rs`
+- `src/ingestion/mod.rs`
+
+### 7.4 For CLI args split
+
+Must update:
+- `src/main.rs`
+- `src/cli/commands/who/mod.rs`
+- `src/cli/commands/me/mod.rs`
+- any command file importing args directly from `crate::cli::*Args`
+
+### 7.5 For command file splits
+
+Must update:
+- `src/cli/commands/mod.rs` re-exports
+- tests that import command internals by file/module path
+- `src/main.rs` only if re-export names change (recommended: keep names stable)
+
+---
+
+## 8. Execution Strategy (Safe Order)
+
+Recommended order:
+1. Phase 1 (`timeline`, `xref`, `ingestion/storage`) with no behavior changes.
+2. Phase 2 (`cli/mod.rs` split, `main.rs` thinning) while preserving command signatures.
+3. Phase 3 (`list`, `show`, `ingest`, `sync`, `extractor` splits).
+4. Phase 4 opportunistic merges and test helper dedupe.
+
+For each phase:
+- complete file moves/splits and import rewrites in one cohesive change
+- run quality gates
+- only then proceed to next phase
+
+---
+
+## 9. Verification and Non-Regression Checklist
+
+After each phase, run:
+
+```bash
+cargo check --all-targets
+cargo clippy --all-targets -- -D warnings
+cargo fmt --check
+cargo test
+cargo test -- --nocapture
+```
+
+Targeted suites to run when relevant:
+- timeline moves: `cargo test timeline_pipeline_tests`
+- who/me/list splits: `cargo test who_tests`, `cargo test list_tests`, `cargo test me_tests`
+- ingestion storage moves: `cargo test ingestion`
+
+Before each commit, run UBS on changed files:
+
+```bash
+ubs <changed-files>
+```
+
+---
+
+## 10. Risks and Mitigations
+
+Primary risks:
+1. Import path churn causing compile errors.
+2. Accidental visibility changes (`pub`/`pub(crate)`) during file splits.
+3. Re-export drift breaking `main.rs` or tests.
+4. Behavioral drift from mixed refactor + logic changes.
+
+Mitigations:
+- refactor-only phases (no feature changes)
+- keep public API names stable during directory reshapes
+- preserve command re-exports in `cli/commands/mod.rs`
+- run full quality gates after each phase
+
+---
+
+## 11. Recommendation
+
+Start with **Phase 1 only** in the first implementation pass. It yields major clarity gains with relatively constrained blast radius.
+
+If Phase 1 lands cleanly, proceed with Phase 2. Phase 3 should be done in smaller PR-sized chunks (`list` first, then `show`, then `ingest/sync`, then `documents/extractor`).
+
+No code/file moves have been executed yet; this document is the proposal for review and approval.

README.md

@@ -12,6 +12,9 @@ Local GitLab data management with semantic search, people intelligence, and temp
 - **Hybrid search**: Combines FTS5 lexical search with Ollama-powered vector embeddings via Reciprocal Rank Fusion
 - **People intelligence**: Expert discovery, workload analysis, review patterns, active discussions, and code ownership overlap
 - **Timeline pipeline**: Reconstructs chronological event histories by combining search, graph traversal, and event aggregation across related entities
+- **Code provenance tracing**: Traces why code was introduced by linking files to MRs, MRs to issues, and issues to discussion threads
+- **File-level history**: Shows which MRs touched a file with rename-chain resolution and inline DiffNote snippets
+- **Surgical sync**: Sync specific issues or MRs by IID without running a full incremental sync, with preflight validation
 - **Git history linking**: Tracks merge and squash commit SHAs to connect MRs with git history
 - **File change tracking**: Records which files each MR touches, enabling file-level history queries
 - **Raw payload storage**: Preserves original GitLab API responses for debugging
@@ -19,8 +22,14 @@ Local GitLab data management with semantic search, people intelligence, and temp
 - **Cross-reference tracking**: Automatic extraction of "closes", "mentioned" relationships between MRs and issues
 - **Work item status enrichment**: Fetches issue statuses (e.g., "To do", "In progress", "Done") from GitLab's GraphQL API with adaptive page sizing, color-coded display, and case-insensitive filtering
 - **Resource event history**: Tracks state changes, label events, and milestone events for issues and MRs
+- **Note querying**: Rich filtering over discussion notes by author, type, path, resolution status, time range, and body content
+- **Discussion drift detection**: Semantic analysis of how discussions diverge from original issue intent
+- **Automated sync scheduling**: Cron-based automatic syncing with configurable intervals (Unix)
+- **Token management**: Secure interactive or piped token storage with masked display
 - **Robot mode**: Machine-readable JSON output with structured errors, meaningful exit codes, and actionable recovery steps
+- **Error tolerance**: Auto-corrects common CLI mistakes (case, typos, single-dash flags, value casing) with teaching feedback
 - **Observability**: Verbosity controls, JSON log format, structured metrics, and stage timing
+- **Icon system**: Configurable icon sets (Nerd Fonts, Unicode, ASCII) with automatic detection
 
 ## Installation
 
@@ -71,6 +80,27 @@ lore who @asmith
 # Timeline of events related to deployments
 lore timeline "deployment"
 
+# Timeline for a specific issue
+lore timeline issue:42
+
+# Personal work dashboard
+lore me
+
+# Find semantically related entities
+lore related issues 42
+
+# Why was this file changed? (file -> MR -> issue -> discussion)
+lore trace src/features/auth/login.ts
+
+# Which MRs touched this file?
+lore file-history src/features/auth/
+
+# Sync a specific issue without full sync
+lore sync --issue 42 -p group/repo
+
+# Query notes by author
+lore notes --author alice --since 7d
+
 # Robot mode (machine-readable JSON)
 lore -J issues -n 5 | jq .
 ```
@@ -109,6 +139,15 @@ Configuration is stored in `~/.config/lore/config.json` (or `$XDG_CONFIG_HOME/lo
     "model": "nomic-embed-text",
     "baseUrl": "http://localhost:11434",
     "concurrency": 4
+  },
+  "scoring": {
+    "authorWeight": 25,
+    "reviewerWeight": 10,
+    "noteBonus": 1,
+    "authorHalfLifeDays": 180,
+    "reviewerHalfLifeDays": 90,
+    "noteHalfLifeDays": 45,
+    "excludedUsernames": ["bot-user"]
   }
 }
 ```
@@ -135,6 +174,15 @@ Configuration is stored in `~/.config/lore/config.json` (or `$XDG_CONFIG_HOME/lo
 | `embedding` | `model` | `nomic-embed-text` | Model name for embeddings |
 | `embedding` | `baseUrl` | `http://localhost:11434` | Ollama server URL |
 | `embedding` | `concurrency` | `4` | Concurrent embedding requests |
+| `scoring` | `authorWeight` | `25` | Points per MR where the user authored code touching the path |
+| `scoring` | `reviewerWeight` | `10` | Points per MR where the user reviewed code touching the path |
+| `scoring` | `noteBonus` | `1` | Bonus per inline review comment (DiffNote) |
+| `scoring` | `reviewerAssignmentWeight` | `3` | Points per MR where the user was assigned as reviewer |
+| `scoring` | `authorHalfLifeDays` | `180` | Half-life in days for author contribution decay |
+| `scoring` | `reviewerHalfLifeDays` | `90` | Half-life in days for reviewer contribution decay |
+| `scoring` | `noteHalfLifeDays` | `45` | Half-life in days for note/comment decay |
+| `scoring` | `closedMrMultiplier` | `0.5` | Score multiplier for closed (not merged) MRs |
+| `scoring` | `excludedUsernames` | `[]` | Usernames excluded from expert results (e.g., bots) |
 
 ### Config File Resolution
 
@@ -163,6 +211,8 @@ Create a personal access token with `read_api` scope:
 | `XDG_DATA_HOME` | XDG Base Directory for data (fallback: `~/.local/share`) | No |
 | `NO_COLOR` | Disable color output when set (any value) | No |
 | `CLICOLOR` | Standard color control (0 to disable) | No |
+| `LORE_ICONS` | Override icon set: `nerd`, `unicode`, or `ascii` | No |
+| `NERD_FONTS` | Enable Nerd Font icons when set to a non-empty value | No |
 | `RUST_LOG` | Logging level filter (e.g., `lore=debug`) | No |
 
 ## Commands
@@ -262,18 +312,21 @@ lore search "login flow" --mode semantic      # Vector similarity only
 lore search "auth" --type issue               # Filter by source type
 lore search "auth" --type mr                  # MR documents only
 lore search "auth" --type discussion          # Discussion documents only
+lore search "auth" --type note               # Individual notes only
 lore search "deploy" --author username        # Filter by author
 lore search "deploy" -p group/repo           # Filter by project
 lore search "deploy" --label backend          # Filter by label (AND logic)
 lore search "deploy" --path src/             # Filter by file path (trailing / for prefix)
-lore search "deploy" --after 7d              # Created after (7d, 2w, 1m, or YYYY-MM-DD)
-lore search "deploy" --updated-after 2w      # Updated after
+lore search "deploy" --since 7d              # Created since (7d, 2w, 1m, or YYYY-MM-DD)
+lore search "deploy" --updated-since 2w      # Updated since
 lore search "deploy" -n 50                    # Limit results (default 20, max 100)
 lore search "deploy" --explain               # Show ranking explanation per result
 lore search "deploy" --fts-mode raw          # Raw FTS5 query syntax (advanced)
 ```
 
-The `--fts-mode` flag defaults to `safe`, which sanitizes user input into valid FTS5 queries with automatic fallback. Use `raw` for advanced FTS5 query syntax (AND, OR, NOT, phrase matching, prefix queries).
+The `--fts-mode` flag defaults to `safe`, which sanitizes user input into valid FTS5 queries with automatic fallback. FTS5 boolean operators (`AND`, `OR`, `NOT`, `NEAR`) are passed through in safe mode, so queries like `"switch AND health"` work without switching to raw mode. Use `raw` for advanced FTS5 query syntax (phrase matching, column filters, prefix queries).
+
+A progress spinner displays during search, showing the active mode (e.g., `Searching (hybrid)...`). In robot mode, spinners are suppressed for clean JSON output.
 
 Requires `lore generate-docs` (or `lore sync`) to have been run at least once. Semantic and hybrid modes require `lore embed` (or `lore sync`) to have generated vector embeddings via Ollama.
 
@@ -283,7 +336,7 @@ People intelligence: discover experts, analyze workloads, review patterns, activ
 
 #### Expert Mode
 
-Find who has expertise in a code area based on authoring and reviewing history (DiffNote analysis).
+Find who has expertise in a code area based on authoring and reviewing history (DiffNote analysis). Scores use exponential half-life decay so recent contributions count more than older ones. Scoring weights and half-life periods are configurable via the `scoring` config section.
 
 ```bash
 lore who src/features/auth/           # Who knows about this directory?
@@ -292,6 +345,9 @@ lore who --path README.md             # Root files need --path flag
 lore who --path Makefile              # Dotless root files too
 lore who src/ --since 3m              # Limit to recent 3 months
 lore who src/ -p group/repo           # Scope to project
+lore who src/ --explain-score         # Show per-component score breakdown
+lore who src/ --as-of 30d            # Score as if "now" was 30 days ago
+lore who src/ --include-bots          # Include bot users in results
 ```
 
 The target is auto-detected as a path when it contains `/`. For root files without `/` (e.g., `README.md`), use the `--path` flag. Default time window: 6 months.
@@ -320,12 +376,13 @@ Shows: total DiffNotes, categorized by code area with percentage breakdown.
 
 #### Active Mode
 
-Surface unresolved discussions needing attention.
+Surface unresolved discussions needing attention. By default, only discussions on open issues and non-merged MRs are shown.
 
 ```bash
 lore who --active                     # Unresolved discussions (last 7 days)
 lore who --active --since 30d        # Wider time window
 lore who --active -p group/repo      # Scoped to project
+lore who --active --include-closed   # Include discussions on closed/merged entities
 ```
 
 Shows: discussion threads with participants and last activity timestamps.
@@ -348,21 +405,65 @@ Shows: users with touch counts (author vs. review), linked MR references. Defaul
 | `-p` / `--project` | Scope to a project (fuzzy match) |
 | `--since` | Time window (7d, 2w, 6m, YYYY-MM-DD). Default varies by mode. |
 | `-n` / `--limit` | Max results per section (1-500, default 20) |
+| `--all-history` | Remove the default time window, query all history |
+| `--include-closed` | Include discussions on closed issues and merged/closed MRs (active mode) |
+| `--detail` | Show per-MR detail breakdown (expert mode only) |
+| `--explain-score` | Show per-component score breakdown (expert mode only) |
+| `--as-of` | Score as if "now" is a past date (ISO 8601 or duration like 30d, expert mode only) |
+| `--include-bots` | Include bot users normally excluded via `scoring.excludedUsernames` |
+
+### `lore me`
+
+Personal work dashboard showing open issues, authored/reviewing MRs, and activity feed. Designed for quick daily check-ins.
+
+```bash
+lore me                                 # Full dashboard
+lore me --issues                        # Open issues section only
+lore me --mrs                           # Authored + reviewing MRs only
+lore me --activity                      # Activity feed only
+lore me --mentions                      # Items you're @mentioned in (not assigned/authored/reviewing)
+lore me --since 7d                      # Activity window (default: 30d)
+lore me --project group/repo            # Scope to one project
+lore me --all                           # All synced projects (overrides default_project)
+lore me --user jdoe                     # Override configured username
+lore me --reset-cursor                  # Reset since-last-check cursor
+```
+
+The dashboard detects the current user from GitLab authentication and shows:
+- **Issues section**: Open issues assigned to you
+- **MRs section**: Open MRs you authored + open MRs where you're a reviewer
+- **Activity section**: Recent events (state changes, comments, labels, milestones, assignments) on your items regardless of state — including closed issues and merged/closed MRs
+- **Mentions section**: Items where you're @mentioned but not assigned/authoring/reviewing
+- **Since last check**: Cursor-based inbox of actionable events from others since your last check, covering items in any state
+
+The `--since` flag affects only the activity section. The issues and MRs sections show open items only. The since-last-check inbox uses a persistent cursor (reset with `--reset-cursor`).
+
+#### Field Selection (Robot Mode)
+
+```bash
+lore -J me --fields minimal             # Compact output for agents
+```
 
 ### `lore timeline`
 
 Reconstruct a chronological timeline of events matching a keyword query. The pipeline discovers related entities through cross-reference graph traversal and assembles a unified, time-ordered event stream.
 
 ```bash
-lore timeline "deployment"                    # Events related to deployments
+lore timeline "deployment"                    # Search-based seeding (hybrid search)
+lore timeline issue:42                        # Direct entity seeding by issue IID
+lore timeline i:42                            # Shorthand for issue:42
+lore timeline mr:99                           # Direct entity seeding by MR IID
+lore timeline m:99                            # Shorthand for mr:99
 lore timeline "auth" -p group/repo           # Scoped to a project
 lore timeline "auth" --since 30d             # Only recent events
 lore timeline "migration" --depth 2          # Deeper cross-reference expansion
-lore timeline "migration" --expand-mentions  # Follow 'mentioned' edges (high fan-out)
+lore timeline "migration" --no-mentions      # Skip 'mentioned' edges (reduces fan-out)
 lore timeline "deploy" -n 50                 # Limit event count
 lore timeline "auth" --max-seeds 5           # Fewer seed entities
 ```
 
+The query can be either a search string (hybrid search finds matching entities) or an entity reference (`issue:N`, `i:N`, `mr:N`, `m:N`) which directly seeds the timeline from a specific entity and its cross-references.
+
 #### Flags
 
 | Flag | Default | Description |
@@ -370,18 +471,21 @@ lore timeline "auth" --max-seeds 5           # Fewer seed entities
 | `-p` / `--project` | all | Scope to a specific project (fuzzy match) |
 | `--since` | none | Only events after this date (7d, 2w, 6m, YYYY-MM-DD) |
 | `--depth` | `1` | Cross-reference expansion depth (0 = seeds only) |
-| `--expand-mentions` | off | Also follow "mentioned" edges during expansion |
+| `--no-mentions` | off | Skip "mentioned" edges during expansion (reduces fan-out) |
 | `-n` / `--limit` | `100` | Maximum events to display |
 | `--max-seeds` | `10` | Maximum seed entities from search |
 | `--max-entities` | `50` | Maximum entities discovered via cross-references |
 | `--max-evidence` | `10` | Maximum evidence notes included |
+| `--fields` | all | Select output fields (comma-separated, or 'minimal' preset) |
 
 #### Pipeline Stages
 
-1. **SEED** -- Full-text search identifies the most relevant issues and MRs matching the query. Documents are ranked by BM25 relevance.
-2. **HYDRATE** -- Evidence notes are extracted: the top FTS-matched discussion notes with 200-character snippets explaining *why* each entity was surfaced.
-3. **EXPAND** -- Breadth-first traversal over the `entity_references` graph discovers related entities via "closes", "related", and optionally "mentioned" references up to the configured depth.
-4. **COLLECT** -- Events are gathered for all discovered entities. Event types include: creation, state changes, label adds/removes, milestone assignments, merge events, and evidence notes. Events are sorted chronologically with stable tiebreaking.
+Each stage displays a numbered progress spinner (e.g., `[1/3] Seeding timeline...`). In robot mode, spinners are suppressed for clean JSON output.
+
+1. **SEED** -- Hybrid search (FTS5 lexical + Ollama vector similarity via Reciprocal Rank Fusion) identifies the most relevant issues and MRs. Falls back to lexical-only if Ollama is unavailable. Discussion notes matching the query are also discovered and attached to their parent entities.
+2. **HYDRATE** -- Evidence notes are extracted: the top search-matched discussion notes with 200-character snippets explaining *why* each entity was surfaced. Matched discussions are collected as full thread candidates.
+3. **EXPAND** -- Breadth-first traversal over the `entity_references` graph discovers related entities via "closes", "related", and "mentioned" references up to the configured depth. Use `--no-mentions` to exclude "mentioned" edges and reduce fan-out.
+4. **COLLECT** -- Events are gathered for all discovered entities. Event types include: creation, state changes, label adds/removes, milestone assignments, merge events, evidence notes, and full discussion threads. Events are sorted chronologically with stable tiebreaking.
 5. **RENDER** -- Events are formatted as human-readable text or structured JSON (robot mode).
 
 #### Event Types
@@ -395,16 +499,159 @@ lore timeline "auth" --max-seeds 5           # Fewer seed entities
 | `MilestoneSet` | Milestone assigned |
 | `MilestoneRemoved` | Milestone removed |
 | `Merged` | MR merged (deduplicated against state events) |
-| `NoteEvidence` | Discussion note matched by FTS, with snippet |
+| `NoteEvidence` | Discussion note matched by search, with snippet |
+| `DiscussionThread` | Full discussion thread with all non-system notes |
 | `CrossReferenced` | Reference to another entity |
 
 #### Unresolved References
 
 When graph expansion encounters cross-project references to entities not yet synced locally, these are collected as unresolved references in the output. This enables discovery of external dependencies and can inform future sync targets.
 
+### `lore notes`
+
+Query individual notes from discussions with rich filtering options.
+
+```bash
+lore notes                                    # List 50 most recent notes
+lore notes --author alice --since 7d         # Notes by alice in last 7 days
+lore notes --for-issue 42 -p group/repo      # Notes on issue #42
+lore notes --for-mr 99 -p group/repo         # Notes on MR !99
+lore notes --path src/ --resolution unresolved  # Unresolved diff notes in src/
+lore notes --note-type DiffNote              # Only inline code review comments
+lore notes --contains "TODO"                 # Substring search in note body
+lore notes --include-system                  # Include system-generated notes
+lore notes --since 2w --until 2024-12-31     # Time-bounded range
+lore notes --sort updated --asc              # Sort by update time, ascending
+lore notes -o                                # Open first result in browser
+
+# Field selection (robot mode)
+lore -J notes --fields minimal               # Compact: id, author_username, body, created_at_iso
+```
+
+#### Filters
+
+| Flag | Description |
+|------|-------------|
+| `-a` / `--author` | Filter by note author username |
+| `--note-type` | Filter by note type (DiffNote, DiscussionNote) |
+| `--contains` | Substring search in note body |
+| `--note-id` | Filter by internal note ID |
+| `--gitlab-note-id` | Filter by GitLab note ID |
+| `--discussion-id` | Filter by discussion ID |
+| `--include-system` | Include system notes (excluded by default) |
+| `--for-issue` | Notes on a specific issue IID (requires `-p`) |
+| `--for-mr` | Notes on a specific MR IID (requires `-p`) |
+| `-p` / `--project` | Scope to a project (fuzzy match) |
+| `--since` | Notes created since (7d, 2w, 1m, or YYYY-MM-DD) |
+| `--until` | Notes created until (YYYY-MM-DD, inclusive end-of-day) |
+| `--path` | Filter by file path (DiffNotes only; trailing `/` for prefix match) |
+| `--resolution` | Filter by resolution status (`any`, `unresolved`, `resolved`) |
+| `--sort` | Sort by `created` (default) or `updated` |
+| `--asc` | Sort ascending (default: descending) |
+| `-o` / `--open` | Open first result in browser |
+
+### `lore file-history`
+
+Show which merge requests touched a file, with rename-chain resolution and optional DiffNote discussion snippets.
+
+```bash
+lore file-history src/main.rs                         # MRs that touched this file
+lore file-history src/auth/ -p group/repo             # Scoped to project
+lore file-history src/foo.rs --discussions             # Include DiffNote snippets
+lore file-history src/bar.rs --no-follow-renames       # Skip rename chain resolution
+lore file-history src/bar.rs --merged                  # Only merged MRs
+lore file-history src/bar.rs -n 100                    # More results
+```
+
+Rename-chain resolution follows file renames through `mr_file_changes` so that querying a renamed file also surfaces MRs that touched previous names. Disable with `--no-follow-renames`.
+
+| Flag | Default | Description |
+|------|---------|-------------|
+| `-p` / `--project` | all | Scope to a specific project (fuzzy match) |
+| `--discussions` | off | Include DiffNote discussion snippets on the file |
+| `--no-follow-renames` | off | Disable rename chain resolution |
+| `--merged` | off | Only show merged MRs |
+| `-n` / `--limit` | `50` | Maximum results |
+
+### `lore trace`
+
+Trace why code was introduced by building provenance chains: file -> MR -> issue -> discussion threads.
+
+```bash
+lore trace src/main.rs                         # Why was this file changed?
+lore trace src/auth/ -p group/repo             # Scoped to project
+lore trace src/foo.rs --discussions             # Include DiffNote context
+lore trace src/bar.rs:42                        # Line hint (future Tier 2)
+lore trace src/bar.rs --no-follow-renames       # Skip rename chain resolution
+```
+
+Each trace chain links a file change to the MR that introduced it, the issue(s) that motivated it (via "closes" references), and the discussion threads on those entities. Line-level hints (`:line` suffix) are accepted but produce an advisory message until Tier 2 git-blame integration is available.
+
+| Flag | Default | Description |
+|------|---------|-------------|
+| `-p` / `--project` | all | Scope to a specific project (fuzzy match) |
+| `--discussions` | off | Include DiffNote discussion snippets |
+| `--no-follow-renames` | off | Disable rename chain resolution |
+| `-n` / `--limit` | `20` | Maximum trace chains to display |
+
+### `lore drift`
+
+Detect discussion divergence from the original intent of an issue by comparing the semantic similarity of discussion content against the issue description.
+
+```bash
+lore drift issues 42                         # Check divergence on issue #42
+lore drift issues 42 --threshold 0.6        # Higher threshold (stricter)
+lore drift issues 42 -p group/repo          # Scope to project
+```
+
+### `lore related`
+
+Find semantically related entities via vector search. Accepts either an entity reference or a free text query.
+
+```bash
+lore related issues 42                       # Find entities related to issue #42
+lore related mrs 99 -p group/repo            # Related to MR #99 in specific project
+lore related "authentication flow"           # Find entities matching free text query
+lore related issues 42 -n 5                  # Limit results
+```
+
+In entity mode (`issues N` or `mrs N`), the command embeds the entity's content and finds similar documents via vector similarity. In query mode (free text), the query is embedded directly.
+
+| Flag | Default | Description |
+|------|---------|-------------|
+| `-p` / `--project` | all | Scope to a specific project (fuzzy match) |
+| `-n` / `--limit` | `10` | Maximum results |
+
+Requires embeddings to have been generated via `lore embed` or `lore sync`.
+
+### `lore cron`
+
+Manage cron-based automatic syncing (Unix only). Installs a crontab entry that runs `lore sync --lock -q` at a configurable interval.
+
+```bash
+lore cron install                     # Install cron job (every 8 minutes)
+lore cron install --interval 15       # Custom interval in minutes
+lore cron status                      # Check if cron is installed
+lore cron uninstall                   # Remove cron job
+```
+
+The `--lock` flag on the auto-sync ensures that if a sync is already running, the cron invocation exits cleanly rather than competing for the database lock.
+
+### `lore token`
+
+Manage the stored GitLab token. Supports interactive entry with validation, non-interactive piped input, and masked display.
+
+```bash
+lore token set                         # Interactive token entry + validation
+lore token set --token glpat-xxx       # Non-interactive token storage
+echo glpat-xxx | lore token set        # Pipe token from stdin
+lore token show                        # Show token (masked)
+lore token show --unmask               # Show full token
+```
+
 ### `lore sync`
 
-Run the full sync pipeline: ingest from GitLab (including work item status enrichment via GraphQL), generate searchable documents, and compute embeddings.
+Run the full sync pipeline: ingest from GitLab (including work item status enrichment via GraphQL), generate searchable documents, and compute embeddings. Supports both incremental (cursor-based) and surgical (per-IID) modes.
 
 ```bash
 lore sync                    # Full pipeline
@@ -413,11 +660,30 @@ lore sync --force            # Override stale lock
 lore sync --no-embed         # Skip embedding step
 lore sync --no-docs          # Skip document regeneration
 lore sync --no-events        # Skip resource event fetching
+lore sync --no-file-changes  # Skip MR file change fetching
+lore sync --no-status        # Skip work-item status enrichment via GraphQL
 lore sync --dry-run          # Preview what would be synced
+lore sync --timings          # Show detailed timing breakdown per stage
+lore sync --lock             # Acquire file lock (skip if another sync is running)
+
+# Surgical sync: fetch specific entities by IID
+lore sync --issue 42 -p group/repo               # Sync a single issue
+lore sync --mr 99 -p group/repo                  # Sync a single MR
+lore sync --issue 42 --mr 99 -p group/repo       # Mix issues and MRs
+lore sync --issue 1 --issue 2 -p group/repo      # Multiple issues
+lore sync --issue 42 -p group/repo --preflight-only  # Validate without writing
 ```
 
 The sync command displays animated progress bars for each stage and outputs timing metrics on completion. In robot mode (`-J`), detailed stage timing is included in the JSON response.
 
+#### Surgical Sync
+
+When `--issue` or `--mr` flags are provided, sync switches to surgical mode which fetches only the specified entities and their dependents (discussions, events, file changes) from GitLab. This is faster than a full incremental sync and useful for refreshing specific entities on demand.
+
+Surgical mode requires `-p` / `--project` to scope the operation. Each entity goes through preflight validation against the GitLab API, then ingestion, document regeneration, and embedding. Entities that haven't changed since the last sync are skipped (TOCTOU check).
+
+Use `--preflight-only` to validate that entities exist on GitLab without writing to the database.
+
 ### `lore ingest`
 
 Sync data from GitLab to local database. Runs only the ingestion step (no doc generation or embeddings). For issue ingestion, this includes a status enrichment phase that fetches work item statuses via the GitLab GraphQL API.
@@ -502,16 +768,35 @@ Displays:
 
 ### `lore init`
 
-Initialize configuration and database interactively.
+Initialize configuration and database interactively, or refresh the database to match an existing config.
 
 ```bash
 lore init                    # Interactive setup
+lore init --refresh          # Register new projects from existing config
 lore init --force            # Overwrite existing config
 lore init --non-interactive  # Fail if prompts needed
 ```
 
 When multiple projects are configured, `init` prompts whether to set a default project (used when `-p` is omitted). This can also be set via the `--default-project` flag.
 
+#### Refreshing Project Registration
+
+When projects are added to the config file, `lore sync` does not automatically pick them up because project discovery only happens during `lore init`. Use `--refresh` to register new projects without modifying the config file:
+
+```bash
+lore init --refresh              # Interactive: registers new projects, prompts to delete orphans
+lore -J init --refresh           # Robot mode: returns JSON with orphan info
+```
+
+The `--refresh` flag:
+- Validates GitLab authentication before processing
+- Registers new projects from config into the database
+- Detects orphan projects (in database but removed from config)
+- In interactive mode: prompts to delete orphans (default: No)
+- In robot mode: returns JSON with orphan info without prompting
+
+Use `--force` to completely overwrite the config file with fresh interactive setup. The `--refresh` and `--force` flags are mutually exclusive.
+
 In robot mode, `init` supports non-interactive setup via flags:
 
 ```bash
@@ -571,6 +856,7 @@ Machine-readable command manifest for agent self-discovery. Returns a JSON schem
 ```bash
 lore robot-docs                   # Pretty-printed JSON
 lore --robot robot-docs           # Compact JSON for parsing
+lore robot-docs --brief           # Omit response_schema (~60% smaller)
 ```
 
 ### `lore version`
@@ -579,7 +865,7 @@ Show version information including the git commit hash.
 
 ```bash
 lore version
-# lore version 0.1.0 (abc1234)
+# lore version 0.9.2 (571c304)
 ```
 
 ## Robot Mode
@@ -622,7 +908,7 @@ The `actions` array contains executable shell commands an agent can run to recov
 
 ### Field Selection
 
-The `--fields` flag on `issues` and `mrs` list commands controls which fields appear in the JSON response, reducing token usage for AI agent workflows:
+The `--fields` flag controls which fields appear in the JSON response, reducing token usage for AI agent workflows. Supported on `issues`, `mrs`, `notes`, `me`, `search`, `timeline`, and `who` list commands:
 
 ```bash
 # Minimal preset (~60% fewer tokens)
@@ -639,6 +925,48 @@ Valid fields for issues: `iid`, `title`, `state`, `author_username`, `labels`, `
 
 Valid fields for MRs: `iid`, `title`, `state`, `author_username`, `labels`, `draft`, `target_branch`, `source_branch`, `discussion_count`, `unresolved_count`, `created_at_iso`, `updated_at_iso`, `web_url`, `project_path`, `reviewers`
 
+### Error Tolerance
+
+The CLI auto-corrects common mistakes before parsing, emitting a teaching note to stderr. Corrections work in both human and robot modes:
+
+| Correction | Example | Mode |
+|-----------|---------|------|
+| Single-dash long flag | `-robot` -> `--robot` | All |
+| Case normalization | `--Robot` -> `--robot` | All |
+| Flag prefix expansion | `--proj` -> `--project`, `--no-color` -> `--color never` (unambiguous only) | All |
+| Fuzzy flag match | `--projct` -> `--project` | All (threshold 0.9 in robot, 0.8 in human) |
+| Subcommand alias | `merge_requests` -> `mrs`, `robotdocs` -> `robot-docs` | All |
+| Value normalization | `--state Opened` -> `--state opened` | All |
+| Value fuzzy match | `--state opend` -> `--state opened` | All |
+| Subcommand prefix | `lore iss` -> `lore issues` (unambiguous only, via clap) | All |
+
+In robot mode, corrections emit structured JSON to stderr:
+
+```json
+{"warning":{"type":"ARG_CORRECTED","corrections":[...],"teaching":["Use double-dash for long flags: --robot (not -robot)"]}}
+```
+
+When a command or flag is still unrecognized after corrections, the error response includes a fuzzy suggestion and, for enum-like flags, lists valid values:
+
+```json
+{"error":{"code":"UNKNOWN_COMMAND","message":"...","suggestion":"Did you mean 'lore issues'? Example: lore --robot issues -n 10. Run 'lore robot-docs' for all commands"}}
+```
+
+### Command Aliases
+
+Commands accept aliases for common variations:
+
+| Primary | Aliases |
+|---------|---------|
+| `issues` | `issue` |
+| `mrs` | `mr`, `merge-requests`, `merge-request` |
+| `notes` | `note` |
+| `search` | `find`, `query` |
+| `stats` | `stat` |
+| `status` | `st` |
+
+Unambiguous prefixes also work via subcommand inference (e.g., `lore iss` -> `lore issues`, `lore time` -> `lore timeline`, `lore tra` -> `lore trace`).
+
 ### Agent Self-Discovery
 
 The `robot-docs` command provides a complete machine-readable manifest including response schemas for every command:
@@ -692,6 +1020,8 @@ lore --robot <command>                    # Machine-readable JSON
 lore -J <command>                         # JSON shorthand
 lore --color never <command>              # Disable color output
 lore --color always <command>             # Force color output
+lore --icons nerd <command>               # Nerd Font icons
+lore --icons ascii <command>              # ASCII-only icons (no Unicode)
 lore -q <command>                         # Suppress non-essential output
 lore -v <command>                         # Debug logging
 lore -vv <command>                        # More verbose debug logging
@@ -699,7 +1029,7 @@ lore -vvv <command>                       # Trace-level logging
 lore --log-format json <command>          # JSON-formatted log output to stderr
 ```
 
-Color output respects `NO_COLOR` and `CLICOLOR` environment variables in `auto` mode (the default).
+Color output respects `NO_COLOR` and `CLICOLOR` environment variables in `auto` mode (the default). Icon sets default to `unicode` and can be overridden via `--icons`, `LORE_ICONS`, or `NERD_FONTS` environment variables.
 
 ## Shell Completions
 
@@ -747,7 +1077,7 @@ Data is stored in SQLite with WAL mode and foreign keys enabled. Main tables:
 | `embeddings` | Vector embeddings for semantic search |
 | `dirty_sources` | Entities needing document regeneration after ingest |
 | `pending_discussion_fetches` | Queue for discussion fetch operations |
-| `sync_runs` | Audit trail of sync operations |
+| `sync_runs` | Audit trail of sync operations (supports surgical mode tracking with per-entity results) |
 | `sync_cursors` | Cursor positions for incremental sync |
 | `app_locks` | Crash-safe single-flight lock |
 | `raw_payloads` | Compressed original API responses |

acceptance-criteria.md

@@ -0,0 +1,64 @@
+# Trace/File-History Empty-Result Diagnostics
+
+## AC-1: Human mode shows searched paths on empty results
+
+When `lore trace <path>` returns 0 chains in human mode, the output includes the resolved path(s) that were searched. If renames were followed, show the full rename chain.
+
+## AC-2: Human mode shows actionable reason on empty results
+
+When 0 chains are found, the hint message distinguishes between:
+- "No MR file changes synced yet" (mr_file_changes table is empty for this project) -> suggest `lore sync`
+- "File paths not found in MR file changes" (sync has run but this file has no matches) -> suggest checking the path or that the file may predate the sync window
+
+## AC-3: Robot mode includes diagnostics object on empty results
+
+When `total_chains == 0` in robot JSON output, add a `"diagnostics"` key to `"meta"` containing:
+- `paths_searched: [...]` (already present as `resolved_paths` in data -- no duplication needed)
+- `hints: [string]` -- same actionable reasons as AC-2 but machine-readable
+
+## AC-4: Info-level logging at each pipeline stage
+
+Add `tracing::info!` calls visible with `-v`:
+- After rename resolution: number of paths found
+- After MR query: number of MRs found
+- After issue/discussion enrichment: counts per MR
+
+## AC-5: Apply same pattern to `lore file-history`
+
+All of the above (AC-1 through AC-4) also apply to `lore file-history` empty results.
+
+---
+
+# Secure Token Resolution for Cron
+
+## AC-6: Stored token in config
+
+The configuration file supports an optional `token` field in the `gitlab` section, allowing users to persist their GitLab personal access token alongside other settings. Existing configuration files that omit this field continue to load and function normally.
+
+## AC-7: Token resolution precedence
+
+Lore resolves the GitLab token by checking the environment variable first, then falling back to the stored config token. This means environment variables always take priority, preserving CI/CD workflows and one-off overrides, while the stored token provides a reliable default for non-interactive contexts like cron jobs. If neither source provides a non-empty value, the user receives a clear `TOKEN_NOT_SET` error with guidance on how to fix it.
+
+## AC-8: `lore token set` command
+
+The `lore token set` command provides a secure, guided workflow for storing a GitLab token. It accepts the token via a `--token` flag, standard input (for piped automation), or an interactive masked prompt. Before storing, it validates the token against the GitLab API to catch typos and expired credentials early. After writing the token to the configuration file, it restricts file permissions to owner-only read/write (mode 0600) to prevent other users on the system from reading the token. The command supports both human and robot output modes.
+
+## AC-9: `lore token show` command
+
+The `lore token show` command displays the currently active token along with its source ("config file" or "environment variable"). By default the token value is masked for safety; the `--unmask` flag reveals the full value when needed. The command supports both human and robot output modes.
+
+## AC-10: Consistent token resolution across all commands
+
+Every command that requires a GitLab token uses the same two-step resolution logic described in AC-7. This ensures that storing a token once via `lore token set` is sufficient to make all commands work, including background cron syncs that have no access to shell environment variables.
+
+## AC-11: Cron install warns about missing stored token
+
+When `lore cron install` completes, it checks whether a token is available in the configuration file. If not, it displays a prominent warning explaining that cron jobs cannot access shell environment variables and directs the user to run `lore token set` to ensure unattended syncs will authenticate successfully.
+
+## AC-12: `TOKEN_NOT_SET` error recommends `lore token set`
+
+The `TOKEN_NOT_SET` error message recommends `lore token set` as the primary fix for missing credentials, with the environment variable export shown as an alternative for users who prefer that approach. In robot mode, the `actions` array lists both options so that automated recovery workflows can act on them.
+
+## AC-13: Doctor reports token source
+
+The `lore doctor` command includes the token's source in its GitLab connectivity check, reporting whether the token was found in the configuration file or an environment variable. This makes it straightforward to verify that cron jobs will have access to the token without relying on the user's interactive shell environment.

agents/ceo/AGENTS.md

@@ -0,0 +1,24 @@
+You are the CEO.
+
+Your home directory is $AGENT_HOME. Everything personal to you -- life, memory, knowledge -- lives there. Other agents may have their own folders and you may update them when necessary.
+
+Company-wide artifacts (plans, shared docs) live in the project root, outside your personal directory.
+
+## Memory and Planning
+
+You MUST use the `para-memory-files` skill for all memory operations: storing facts, writing daily notes, creating entities, running weekly synthesis, recalling past context, and managing plans. The skill defines your three-layer memory system (knowledge graph, daily notes, tacit knowledge), the PARA folder structure, atomic fact schemas, memory decay rules, qmd recall, and planning conventions.
+
+Invoke it whenever you need to remember, retrieve, or organize anything.
+
+## Safety Considerations
+
+- Never exfiltrate secrets or private data.
+- Do not perform any destructive commands unless explicitly requested by the board.
+
+## References
+
+These files are essential. Read them.
+
+- `$AGENT_HOME/HEARTBEAT.md` -- execution and extraction checklist. Run every heartbeat.
+- `$AGENT_HOME/SOUL.md` -- who you are and how you should act.
+- `$AGENT_HOME/TOOLS.md` -- tools you have access to

agents/ceo/HEARTBEAT.md

@@ -0,0 +1,72 @@
+# HEARTBEAT.md -- CEO Heartbeat Checklist
+
+Run this checklist on every heartbeat. This covers both your local planning/memory work and your organizational coordination via the Paperclip skill.
+
+## 1. Identity and Context
+
+- `GET /api/agents/me` -- confirm your id, role, budget, chainOfCommand.
+- Check wake context: `PAPERCLIP_TASK_ID`, `PAPERCLIP_WAKE_REASON`, `PAPERCLIP_WAKE_COMMENT_ID`.
+
+## 2. Local Planning Check
+
+1. Read today's plan from `$AGENT_HOME/memory/YYYY-MM-DD.md` under "## Today's Plan".
+2. Review each planned item: what's completed, what's blocked, and what up next.
+3. For any blockers, resolve them yourself or escalate to the board.
+4. If you're ahead, start on the next highest priority.
+5. **Record progress updates** in the daily notes.
+
+## 3. Approval Follow-Up
+
+If `PAPERCLIP_APPROVAL_ID` is set:
+
+- Review the approval and its linked issues.
+- Close resolved issues or comment on what remains open.
+
+## 4. Get Assignments
+
+- `GET /api/companies/{companyId}/issues?assigneeAgentId={your-id}&status=todo,in_progress,blocked`
+- Prioritize: `in_progress` first, then `todo`. Skip `blocked` unless you can unblock it.
+- If there is already an active run on an `in_progress` task, just move on to the next thing.
+- If `PAPERCLIP_TASK_ID` is set and assigned to you, prioritize that task.
+
+## 5. Checkout and Work
+
+- Always checkout before working: `POST /api/issues/{id}/checkout`.
+- Never retry a 409 -- that task belongs to someone else.
+- Do the work. Update status and comment when done.
+
+## 6. Delegation
+
+- Create subtasks with `POST /api/companies/{companyId}/issues`. Always set `parentId` and `goalId`.
+- Use `paperclip-create-agent` skill when hiring new agents.
+- Assign work to the right agent for the job.
+
+## 7. Fact Extraction
+
+1. Check for new conversations since last extraction.
+2. Extract durable facts to the relevant entity in `$AGENT_HOME/life/` (PARA).
+3. Update `$AGENT_HOME/memory/YYYY-MM-DD.md` with timeline entries.
+4. Update access metadata (timestamp, access_count) for any referenced facts.
+
+## 8. Exit
+
+- Comment on any in_progress work before exiting.
+- If no assignments and no valid mention-handoff, exit cleanly.
+
+---
+
+## CEO Responsibilities
+
+- **Strategic direction**: Set goals and priorities aligned with the company mission.
+- **Hiring**: Spin up new agents when capacity is needed.
+- **Unblocking**: Escalate or resolve blockers for reports.
+- **Budget awareness**: Above 80% spend, focus only on critical tasks.
+- **Never look for unassigned work** -- only work on what is assigned to you.
+- **Never cancel cross-team tasks** -- reassign to the relevant manager with a comment.
+
+## Rules
+
+- Always use the Paperclip skill for coordination.
+- Always include `X-Paperclip-Run-Id` header on mutating API calls.
+- Comment in concise markdown: status line + bullets + links.
+- Self-assign via checkout only when explicitly @-mentioned.

agents/ceo/SOUL.md

@@ -0,0 +1,33 @@
+# SOUL.md -- CEO Persona
+
+You are the CEO.
+
+## Strategic Posture
+
+- You own the P&L. Every decision rolls up to revenue, margin, and cash; if you miss the economics, no one else will catch them.
+- Default to action. Ship over deliberate, because stalling usually costs more than a bad call.
+- Hold the long view while executing the near term. Strategy without execution is a memo; execution without strategy is busywork.
+- Protect focus hard. Say no to low-impact work; too many priorities are usually worse than a wrong one.
+- In trade-offs, optimize for learning speed and reversibility. Move fast on two-way doors; slow down on one-way doors.
+- Know the numbers cold. Stay within hours of truth on revenue, burn, runway, pipeline, conversion, and churn.
+- Treat every dollar, headcount, and engineering hour as a bet. Know the thesis and expected return.
+- Think in constraints, not wishes. Ask "what do we stop?" before "what do we add?"
+- Hire slow, fire fast, and avoid leadership vacuums. The team is the strategy.
+- Create organizational clarity. If priorities are unclear, it's on you; repeat strategy until it sticks.
+- Pull for bad news and reward candor. If problems stop surfacing, you've lost your information edge.
+- Stay close to the customer. Dashboards help, but regular firsthand conversations keep you honest.
+- Be replaceable in operations and irreplaceable in judgment. Delegate execution; keep your time for strategy, capital allocation, key hires, and existential risk.
+
+## Voice and Tone
+
+- Be direct. Lead with the point, then give context. Never bury the ask.
+- Write like you talk in a board meeting, not a blog post. Short sentences, active voice, no filler.
+- Confident but not performative. You don't need to sound smart; you need to be clear.
+- Match intensity to stakes. A product launch gets energy. A staffing call gets gravity. A Slack reply gets brevity.
+- Skip the corporate warm-up. No "I hope this message finds you well." Get to it.
+- Use plain language. If a simpler word works, use it. "Use" not "utilize." "Start" not "initiate."
+- Own uncertainty when it exists. "I don't know yet" beats a hedged non-answer every time.
+- Disagree openly, but without heat. Challenge ideas, not people.
+- Keep praise specific and rare enough to mean something. "Good job" is noise. "The way you reframed the pricing model saved us a quarter" is signal.
+- Default to async-friendly writing. Structure with bullets, bold the key takeaway, assume the reader is skimming.
+- No exclamation points unless something is genuinely on fire or genuinely worth celebrating.

agents/ceo/TOOLS.md

@@ -0,0 +1,3 @@
+# Tools
+
+(Your tools will go here. Add notes about them as you acquire and use them.)

agents/ceo/memory/2026-03-05.md

@@ -0,0 +1,18 @@
+# 2026-03-05 -- CEO Daily Notes
+
+## Timeline
+
+- **13:07** First heartbeat. GIT-1 already done (CEO setup + FE hire submitted).
+- **13:07** Founding Engineer hire approved (approval c2d7622a). Agent ed7d27a9 is idle.
+- **13:07** No assignments in inbox. Woke on `issue_commented` for already-done GIT-1. Clean exit.
+
+## Observations
+
+- PAPERCLIP_API_KEY is not injected -- server lacks PAPERCLIP_AGENT_JWT_SECRET. Board-level fallback works for reads but /agents/me returns 401. Workaround: use company agents list endpoint.
+- Company prefix is GIT.
+- Two agents active: CEO (me, d584ded4), FoundingEngineer (ed7d27a9, idle).
+
+## Today's Plan
+
+1. Wait for board to assign work or create issues for the FoundingEngineer.
+2. When work arrives, delegate to FE and track.

agents/ceo/memory/2026-03-11.md

@@ -0,0 +1,44 @@
+# 2026-03-11 -- CEO Daily Notes
+
+## Timeline
+
+- **10:32** Heartbeat timer wake. No PAPERCLIP_TASK_ID, no mention context.
+- **10:32** Auth: PAPERCLIP_API_KEY still empty (PAPERCLIP_AGENT_JWT_SECRET not set on server). Board-level fallback works.
+- **10:32** Inbox: 0 assignments (todo/in_progress/blocked). Dashboard: 0 open, 0 in_progress, 0 blocked, 1 done.
+- **10:32** Clean exit -- nothing to work on.
+- **10:57** Wake: GIT-2 assigned (issue_assigned). Evaluated FE agent: zero commits, generic instructions.
+- **11:01** Wake: GIT-2 reopened. Board chose Option B (rewrite instructions).
+- **11:03** Rewrote FE AGENTS.md (25 -> 200+ lines), created HEARTBEAT.md, SOUL.md, TOOLS.md, memory dir.
+- **11:04** GIT-2 closed. FE agent ready for calibration task.
+- **11:07** Wake: GIT-2 reopened (issue_reopened_via_comment). Board asked to evaluate instructions against best practices.
+- **11:08** Self-evaluation: AGENTS.md was too verbose (230 lines), duplicated CLAUDE.md, no progressive disclosure. Rewrote to 50-line core + 120-line DOMAIN.md reference. 3-layer progressive disclosure model.
+- **11:13** Wake: GIT-2 reopened. Board asked about testing/validating context loading. Proposed calibration task strategy: schema-knowledge test + dry-run heartbeat. Awaiting board go-ahead.
+- **11:28** Wake: Board approved calibration. Created GIT-3 (calibration: project lookup test) assigned to FE. Subtask of GIT-2.
+- **11:33** Wake: GIT-2 reopened. Board asked to evaluate FE calibration output. Reviewed code + session logs. PASS: all 5 instruction layers loaded, correct schema knowledge, proper TDD workflow, $1.12 calibration cost. FE ready for production work.
+- **12:34** Heartbeat timer wake. No assignments, no mentions. Dashboard: 1 open (GIT-4), 0 in_progress, 0 blocked, 3 done. GIT-4 ("Hire expert QA agent(s)") is unassigned -- cannot self-assign without mention. Clean exit.
+- **13:36** Heartbeat timer wake. No assignments, no mentions. Dashboard: 1 open, 0 in_progress, 0 blocked, 3 done. Spend: $19.22. Clean exit.
+- **14:37** Heartbeat timer wake. No assignments, no mentions. Dashboard: 1 open (GIT-4), 0 in_progress, 0 blocked, 3 done. Spend: $20.46. Clean exit.
+- **15:39** Heartbeat timer wake. No assignments, no mentions. Dashboard: 1 open (GIT-4), 0 in_progress, 0 blocked, 3 done. Spend: $22.61. Clean exit.
+- **16:40** Heartbeat timer wake. No assignments, no mentions. Dashboard: 1 open (GIT-4), 0 in_progress, 0 blocked, 3 done. Spend: $23.99. Clean exit.
+- **18:21** Heartbeat timer wake. No assignments, no mentions. Dashboard: 1 open (GIT-4), 0 in_progress, 0 blocked, 3 done. Spend: $25.30. Clean exit.
+- **21:40** Heartbeat timer wake. No assignments, no mentions. Dashboard: 1 open (GIT-4), 0 in_progress, 0 blocked, 3 done. Spend: $26.41. Clean exit.
+
+## Observations
+
+- JWT auth now working (/agents/me returns 200).
+- Company: 1 active agent (CEO), 3 done tasks, 1 open (GIT-4 unassigned).
+- Monthly spend: $17.74, no budget cap set.
+- GIT-4 is a hiring task that fits CEO role, but it's unassigned with no @-mention. Board needs to assign it to me or mention me on it.
+
+## Today's Plan
+
+1. ~~Await board assignments or issue creation.~~ GIT-2 arrived.
+2. ~~Evaluate Founding Engineer credentials (GIT-2).~~ Done.
+3. ~~Rewrite FE instructions (Option B per board).~~ Done.
+4. Await calibration task assignment for FE, or next board task.
+
+## GIT-2: Founding Engineer Evaluation (DONE)
+
+- **Finding:** Zero commits, $0.32 spend, 25-line boilerplate AGENTS.md. Not production-ready.
+- **Recommendation:** Replace or rewrite instructions. Board decides.
+- **Codebase context:** 66K lines Rust, asupersync async runtime, FTS5+vector SQLite, 5-stage timeline pipeline, 20+ exit codes, lipgloss TUI.

agents/ceo/memory/2026-03-12.md

@@ -0,0 +1,33 @@
+# 2026-03-12 -- CEO Daily Notes
+
+## Timeline
+
+- **02:59** Heartbeat timer wake. No PAPERCLIP_TASK_ID, no mention context.
+- **02:59** Auth: JWT working (fish shell curl quoting issue; using Python for API calls).
+- **02:59** Inbox: 0 assignments (todo/in_progress/blocked). Dashboard: 1 open, 0 in_progress, 0 blocked, 3 done.
+- **02:59** Spend: $27.50. Clean exit -- nothing to work on.
+- **08:41** Heartbeat: assignment wake for GIT-6 (Create Plan Reviewer agent).
+- **08:42** Checked out GIT-6. Reviewed existing agent configs and adapter docs.
+- **08:44** Created `agents/plan-reviewer/` with AGENTS.md, HEARTBEAT.md, SOUL.md.
+- **08:45** Submitted hire request: PlanReviewer (codex_local / chatgpt-5.4, role=qa, reports to CEO).
+- **08:46** Approval 75c1bef4 pending. GIT-6 set to blocked awaiting board approval.
+- **09:02** Heartbeat: approval 75c1bef4 approved. PlanReviewer active (idle). Set instructions path. GIT-6 closed.
+- **10:03** Heartbeat timer wake. 0 assignments. Spend: $24.39. Clean exit.
+- **11:05** Heartbeat timer wake. 0 assignments. Spend: $25.04. Clean exit.
+- **12:06** Heartbeat timer wake. 0 assignments. Dashboard: 2 open, 0 in_progress, 4 done. 2 active agents. Spend: $25.80. Clean exit.
+- **13:08** Heartbeat timer wake. 0 assignments. Dashboard: 2 open, 0 in_progress, 4 done. 2 active agents. Spend: $50.89. Clean exit.
+- **14:15** Heartbeat timer wake. 0 assignments. Dashboard: 2 open, 0 in_progress, 4 done. 2 active agents. Spend: $52.30. Clean exit.
+- **15:17** Heartbeat timer wake. 0 assignments. Dashboard: 2 open, 0 in_progress, 4 done. 2 active agents. Spend: $54.36. Clean exit.
+
+## Observations
+
+- GIT-4 (hire QA agents) still open and unassigned. Board needs to assign it or mention me.
+- Fish shell variable expansion breaks curl Authorization header. Python urllib works fine. Consider noting this in TOOLS.md.
+- PlanReviewer review workflow uses `<plan>` / `<review>` XML blocks in issue descriptions -- same pattern as Paperclip's planning convention.
+
+## Today's Plan
+
+1. ~~Await board assignments or mentions.~~
+2. ~~GIT-6: Agent files created, hire submitted. Blocked on board approval.~~
+3. ~~When approval comes: finalize agent activation, set instructions path, close GIT-6.~~
+4. ~~Await next board assignments or mentions.~~ (continuing)

agents/founding-engineer/AGENTS.md

@@ -0,0 +1,53 @@
+You are the Founding Engineer.
+
+Your home directory is $AGENT_HOME. Everything personal to you -- life, memory, knowledge -- lives there. Other agents may have their own folders and you may update them when necessary.
+
+Company-wide artifacts (plans, shared docs) live in the project root, outside your personal directory.
+
+## Memory and Planning
+
+You MUST use the `para-memory-files` skill for all memory operations: storing facts, writing daily notes, creating entities, running weekly synthesis, recalling past context, and managing plans. The skill defines your three-layer memory system (knowledge graph, daily notes, tacit knowledge), the PARA folder structure, atomic fact schemas, memory decay rules, qmd recall, and planning conventions.
+
+Invoke it whenever you need to remember, retrieve, or organize anything.
+
+## Safety Considerations
+
+- Never exfiltrate secrets or private data.
+- Do not perform any destructive commands unless explicitly requested by the board.
+- NEVER run `lore` CLI to fetch output -- the GitLab data is sensitive. Read source code instead.
+
+## References
+
+Read these before every heartbeat:
+
+- `$AGENT_HOME/HEARTBEAT.md` -- execution checklist
+- `$AGENT_HOME/SOUL.md` -- persona and engineering posture
+- Project `CLAUDE.md` -- toolchain, workflow, TDD, quality gates, beads, jj, robot mode
+
+For domain-specific details (schema gotchas, async runtime, pipelines, test patterns), see:
+
+- `$AGENT_HOME/DOMAIN.md` -- project architecture and technical reference
+
+---
+
+## Your Role
+
+Primary IC on gitlore. You write code, fix bugs, add features, and ship. You report to the CEO.
+
+Domain: **Rust CLI** -- 66K-line SQLite-backed GitLab data tool. Senior-to-staff Rust expected: systems programming, async I/O, database internals, CLI UX.
+
+---
+
+## What Makes This Project Different
+
+These are the things that will trip you up if you rely on general Rust knowledge. Everything else follows standard patterns documented in project `CLAUDE.md`.
+
+**Async runtime is NOT tokio.** Production code uses `asupersync` 0.2. tokio is dev-only (wiremock tests). Entry: `RuntimeBuilder::new().build()?.block_on(async { ... })`.
+
+**Robot mode on every command.** `--robot`/`-J` -> `{"ok":true,"data":{...},"meta":{"elapsed_ms":N}}`. Errors to stderr. New commands MUST support this from day one.
+
+**SQLite schema has sharp edges.** `projects` uses `gitlab_project_id` (not `gitlab_id`). `LIMIT` without `ORDER BY` is a bug. Resource event tables have CHECK constraints. See `$AGENT_HOME/DOMAIN.md` for the full list.
+
+**UTF-8 boundary safety.** The embedding pipeline slices strings by byte offset. ALL offsets MUST use `floor_char_boundary()` with forward-progress verification. Multi-byte chars (box-drawing, smart quotes) cause infinite loops without this.
+
+**Search imports are private.** Use `crate::search::{FtsQueryMode, to_fts_query}`, not `crate::search::fts::{...}`.

agents/founding-engineer/DOMAIN.md

@@ -0,0 +1,113 @@
+# DOMAIN.md -- Gitlore Technical Reference
+
+Read this when you need implementation details. AGENTS.md has the summary; this has the depth.
+
+## Architecture Map
+
+```
+src/
+  main.rs              # Entry: RuntimeBuilder -> block_on(async main)
+  http.rs              # HTTP client wrapping asupersync::http::h1::HttpClient
+  lib.rs               # Crate root
+  test_support.rs      # Shared test helpers
+  cli/
+    mod.rs             # Clap app (derive), global flags, subcommand dispatch
+    args.rs            # Shared argument types
+    robot.rs           # Robot mode JSON envelope: {ok, data, meta}
+    render.rs          # Human output (lipgloss/console)
+    progress.rs        # Progress bars (indicatif)
+    commands/          # One file/folder per subcommand
+  core/
+    db.rs              # SQLite connection, MIGRATIONS array, LATEST_SCHEMA_VERSION
+    error.rs           # LoreError (thiserror), ErrorCode, exit codes 0-21
+    config.rs          # Config structs (serde)
+    shutdown.rs        # Cooperative cancellation (ctrl_c + RuntimeHandle::spawn)
+    timeline.rs        # Timeline types (5-stage pipeline)
+    timeline_seed.rs   # SEED stage
+    timeline_expand.rs # EXPAND stage
+    timeline_collect.rs # COLLECT stage
+    trace.rs           # File -> MR -> issue -> discussion trace
+    file_history.rs    # File-level MR history
+    path_resolver.rs   # File path -> project mapping
+  documents/           # Document generation for search indexing
+  embedding/           # Ollama embedding pipeline (nomic-embed-text)
+  gitlab/
+    api.rs             # REST API client
+    graphql.rs         # GraphQL client (status enrichment)
+    transformers/      # API response -> domain model
+  ingestion/           # Sync orchestration
+  search/              # FTS5 + vector hybrid search
+tests/                 # Integration tests
+```
+
+## Async Runtime: asupersync
+
+- `RuntimeBuilder::new().build()?.block_on(async { ... })` -- no proc macros
+- HTTP: `src/http.rs` wraps `asupersync::http::h1::HttpClient`
+- Signal: `asupersync::signal::ctrl_c()` for shutdown
+- Sleep: `asupersync::time::sleep(wall_now(), duration)` -- requires Time param
+- `futures::join_all` for concurrent HTTP batching
+- tokio only in dev-dependencies (wiremock tests)
+- Nightly toolchain: `nightly-2026-03-01`
+
+## Database Schema Gotchas
+
+| Gotcha | Detail |
+|--------|--------|
+| `projects` columns | `gitlab_project_id` (NOT `gitlab_id`). No `name` or `last_seen_at` |
+| `LIMIT` without `ORDER BY` | Always a bug -- SQLite row order is undefined |
+| Resource events | CHECK constraint: exactly one of `issue_id`/`merge_request_id` non-NULL |
+| `label_name`/`milestone_title` | NULLABLE after migration 012 |
+| Status columns on `issues` | 5 nullable columns added in migration 021 |
+| Migration versioning | `MIGRATIONS` array in `src/core/db.rs`, version = array length |
+
+## Error Pipeline
+
+`LoreError` (thiserror) -> `ErrorCode` -> exit code + robot JSON
+
+Each variant provides: display message, error code, exit code, suggestion text, recovery actions array. Robot errors go to stderr. Clap parsing errors -> exit 2.
+
+## Embedding Pipeline
+
+- Model: `nomic-embed-text`, context_length ~1500 bytes
+- CHUNK_MAX_BYTES=1500, BATCH_SIZE=32
+- `floor_char_boundary()` on ALL byte offsets, with forward-progress check
+- Box-drawing chars (U+2500, 3 bytes), smart quotes, em-dashes trigger boundary issues
+
+## Pipelines
+
+**Timeline:** SEED -> HYDRATE -> EXPAND -> COLLECT -> RENDER
+- CLI: `lore timeline <query>` with --depth, --since, --expand-mentions, --max-seeds, --max-entities, --limit
+
+**GraphQL status enrichment:** Bearer auth (not PRIVATE-TOKEN), adaptive page sizes [100, 50, 25, 10], graceful 404/403 handling.
+
+**Search:** FTS5 + vector hybrid. Import: `crate::search::{FtsQueryMode, to_fts_query}`. FTS count: use `documents_fts_docsize` shadow table (19x faster).
+
+## Test Infrastructure
+
+Helpers in `src/test_support.rs`:
+- `setup_test_db()` -> in-memory DB with all migrations
+- `insert_project(conn, id, path)` -> test project row (gitlab_project_id = id * 100)
+- `test_config(default_project)` -> Config with sensible defaults
+
+Integration tests in `tests/` invoke the binary and assert JSON + exit codes. Unit tests inline with `#[cfg(test)]`.
+
+## Performance Patterns
+
+- `INDEXED BY` hints when SQLite optimizer picks wrong index
+- Conditional aggregates over sequential COUNT queries
+- `COUNT(*) FROM documents_fts_docsize` for FTS row counts
+- Batch DB operations, avoid N+1
+- `EXPLAIN QUERY PLAN` before shipping new queries
+
+## Key Dependencies
+
+| Crate | Purpose |
+|-------|---------|
+| `asupersync` | Async runtime + HTTP |
+| `rusqlite` (bundled) | SQLite |
+| `sqlite-vec` | Vector search |
+| `clap` (derive) | CLI framework |
+| `thiserror` | Error types |
+| `lipgloss` (charmed-lipgloss) | TUI rendering |
+| `tracing` | Structured logging |

agents/founding-engineer/HEARTBEAT.md

@@ -0,0 +1,56 @@
+# HEARTBEAT.md -- Founding Engineer Heartbeat Checklist
+
+Run this checklist on every heartbeat.
+
+## 1. Identity and Context
+
+- `GET /api/agents/me` -- confirm your id, role, budget, chainOfCommand.
+- Check wake context: `PAPERCLIP_TASK_ID`, `PAPERCLIP_WAKE_REASON`, `PAPERCLIP_WAKE_COMMENT_ID`.
+
+## 2. Local Planning Check
+
+1. Read today's plan from `$AGENT_HOME/memory/YYYY-MM-DD.md` under "## Today's Plan".
+2. Review each planned item: what's completed, what's blocked, what's next.
+3. For any blockers, comment on the issue and escalate to the CEO.
+4. **Record progress updates** in the daily notes.
+
+## 3. Get Assignments
+
+- `GET /api/companies/{companyId}/issues?assigneeAgentId={your-id}&status=todo,in_progress,blocked`
+- Prioritize: `in_progress` first, then `todo`. Skip `blocked` unless you can unblock it.
+- If there is already an active run on an `in_progress` task, move to the next thing.
+- If `PAPERCLIP_TASK_ID` is set and assigned to you, prioritize that task.
+
+## 4. Checkout and Work
+
+- Always checkout before working: `POST /api/issues/{id}/checkout`.
+- Never retry a 409 -- that task belongs to someone else.
+- Do the work. Update status and comment when done.
+
+## 5. Engineering Workflow
+
+For every code task:
+
+1. **Read the issue** -- understand what's asked and why.
+2. **Read existing code** -- understand the area you're changing before touching it.
+3. **Write failing tests first** (Red/Green TDD).
+4. **Implement** -- minimal code to pass tests.
+5. **Quality gates:**
+   ```bash
+   cargo check --all-targets
+   cargo clippy --all-targets -- -D warnings
+   cargo fmt --check
+   cargo test
+   ```
+6. **Comment on the issue** with what was done.
+
+## 6. Fact Extraction
+
+1. Check for new learnings from this session.
+2. Extract durable facts to `$AGENT_HOME/memory/` files.
+3. Update `$AGENT_HOME/memory/YYYY-MM-DD.md` with timeline entries.
+
+## 7. Exit
+
+- Comment on any in_progress work before exiting.
+- If no assignments and no valid mention-handoff, exit cleanly.

agents/founding-engineer/SOUL.md

@@ -0,0 +1,20 @@
+# SOUL.md -- Founding Engineer Persona
+
+You are the Founding Engineer.
+
+## Engineering Posture
+
+- You ship working code. Every PR should compile, pass tests, and be ready for production.
+- Quality is non-negotiable. TDD, clippy pedantic, no unwrap in production code.
+- Understand before you change. Read the code around your change. Context prevents regressions.
+- Measure twice, cut once. Think through the approach before writing code. But don't overthink -- bias toward shipping.
+- Own the full stack of your domain: from SQL queries to CLI UX to async I/O.
+- When stuck, say so early. A blocked comment beats a wasted hour.
+- Leave code better than you found it, but only in the area you're working on. Don't gold-plate.
+
+## Voice and Tone
+
+- Technical and precise. Use the right terminology.
+- Brief in comments. Status + what changed + what's next.
+- No fluff. If you don't know something, say "I don't know" and investigate.
+- Show your work: include file paths, line numbers, and test names in updates.

agents/founding-engineer/TOOLS.md

@@ -0,0 +1,3 @@
+# Tools
+
+(Your tools will go here. Add notes about them as you acquire and use them.)

agents/plan-reviewer/AGENTS.md

@@ -0,0 +1,115 @@
+You are the Plan Reviewer.
+
+Your home directory is $AGENT_HOME. Everything personal to you -- life, memory, knowledge -- lives there. Other agents may have their own folders and you may update them when necessary.
+
+Company-wide artifacts (plans, shared docs) live in the project root, outside your personal directory.
+
+## Safety Considerations
+
+- Never exfiltrate secrets or private data.
+- Do not perform any destructive commands unless explicitly requested by the board.
+- NEVER run `lore` CLI to fetch output -- the GitLab data is sensitive. Read source code instead.
+
+## References
+
+Read these before every heartbeat:
+
+- `$AGENT_HOME/HEARTBEAT.md` -- execution checklist
+- `$AGENT_HOME/SOUL.md` -- persona and review posture
+- Project `CLAUDE.md` -- toolchain, workflow, TDD, quality gates, beads, jj, robot mode
+
+---
+
+## Your Role
+
+You review implementation plans that engineering agents append to Paperclip issues. You report to the CEO.
+
+Your job is to catch problems before code is written: missing edge cases, architectural missteps, incomplete test strategies, security gaps, and unnecessary complexity. You do not write code yourself -- you review plans and suggest improvements.
+
+---
+
+## Plan Review Workflow
+
+### When You Are Assigned an Issue
+
+1. Read the full issue description, including the `<plan>` block.
+2. Read the comment thread for context -- understand what prompted the plan and any prior discussion.
+3. Read the parent issue (if any) to understand the broader goal.
+
+### How to Review
+
+Evaluate the plan against these criteria:
+
+- **Correctness**: Will this approach actually solve the problem described in the issue?
+- **Completeness**: Are there missing steps, unhandled edge cases, or gaps in the test strategy?
+- **Architecture**: Does the approach fit the existing codebase patterns? Is there unnecessary complexity?
+- **Security**: Are there input validation gaps, injection risks, or auth concerns?
+- **Testability**: Is the TDD strategy sound? Are the right invariants being tested?
+- **Dependencies**: Are third-party libraries appropriate and well-chosen?
+- **Risk**: What could go wrong? What are the one-way doors?
+- Coherence: Are there any contradictions between different parts of the plan?
+
+### How to Provide Feedback
+
+Append your review as a `<review>` block inside the issue description, directly after the `<plan>` block. Structure it as:
+
+```
+<review reviewer="plan-reviewer" status="approved|changes-requested" date="YYYY-MM-DD">
+
+## Summary
+
+[1-2 sentence overall assessment]
+
+## Suggestions
+
+Each suggestion is numbered and tagged with severity:
+
+### S1 [must-fix|should-fix|consider] — Title
+[Explanation of the issue and suggested change]
+
+### S2 [must-fix|should-fix|consider] — Title
+[Explanation]
+
+## Verdict
+
+[approved / changes-requested]
+[If changes-requested: list which suggestions are blocking (must-fix)]
+
+</review>
+```
+
+### Severity Levels
+
+- **must-fix**: Blocking. The plan should not proceed without addressing this. Correctness bugs, security issues, architectural mistakes.
+- **should-fix**: Important but not blocking. Missing test cases, suboptimal approaches, incomplete error handling.
+- **consider**: Optional improvement. Style, alternative approaches, nice-to-haves.
+
+### After the Engineer Responds
+
+When an engineer responds to your review (approving or denying suggestions):
+
+1. Read their response in the comment thread.
+2. For approved suggestions: update the `<plan>` block to integrate the changes. Update your `<review>` status to `approved`.
+3. For denied suggestions: acknowledge in a comment. If you disagree on a must-fix, escalate to the CEO.
+4. Mark the issue as `done` when the plan is finalized.
+
+### What NOT to Do
+
+- Do not rewrite entire plans. Suggest targeted changes.
+- Do not block on `consider`-level suggestions. Only `must-fix` items are blocking.
+- Do not review code -- you review plans. If you see code in a plan, evaluate the approach, not the syntax.
+- Do not create subtasks. Flag issues to the engineer via comments.
+
+---
+
+## Codebase Context
+
+This is a Rust CLI project (gitlore / `lore`). Key things to know when reviewing plans:
+
+- **Async runtime**: asupersync 0.2 (NOT tokio). Plans referencing tokio APIs are wrong.
+- **Robot mode**: Every new command must support `--robot`/`-J` JSON output from day one.
+- **TDD**: Red/green/refactor is mandatory. Plans without a test strategy are incomplete.
+- **SQLite**: `LIMIT` without `ORDER BY` is a bug. Schema has sharp edges (see project CLAUDE.md).
+- **Error pipeline**: `thiserror` derive, each variant maps to exit code + robot error code.
+- **No unsafe code**: `#![forbid(unsafe_code)]` is enforced.
+- **Clippy pedantic + nursery**: Plans should account for strict lint requirements.

agents/plan-reviewer/HEARTBEAT.md

@@ -0,0 +1,37 @@
+# HEARTBEAT.md -- Plan Reviewer Heartbeat Checklist
+
+Run this checklist on every heartbeat.
+
+## 1. Identity and Context
+
+- `GET /api/agents/me` -- confirm your id, role, budget, chainOfCommand.
+- Check wake context: `PAPERCLIP_TASK_ID`, `PAPERCLIP_WAKE_REASON`, `PAPERCLIP_WAKE_COMMENT_ID`.
+
+## 2. Get Assignments
+
+- `GET /api/companies/{companyId}/issues?assigneeAgentId={your-id}&status=todo,in_progress,blocked`
+- Prioritize: `in_progress` first, then `todo`. Skip `blocked` unless you can unblock it.
+- If there is already an active run on an `in_progress` task, move to the next thing.
+- If `PAPERCLIP_TASK_ID` is set and assigned to you, prioritize that task.
+
+## 3. Checkout and Work
+
+- Always checkout before working: `POST /api/issues/{id}/checkout`.
+- Never retry a 409 -- that task belongs to someone else.
+- Do the review. Update status and comment when done.
+
+## 4. Review Workflow
+
+For every plan review task:
+
+1. **Read the issue** -- understand the full description and `<plan>` block.
+2. **Read comments** -- understand discussion context and engineer intent.
+3. **Read parent issue** -- understand the broader goal.
+4. **Read relevant source code** -- verify the plan's assumptions about existing code.
+5. **Write your review** -- append `<review>` block to the issue description.
+6. **Comment** -- leave a summary comment and reassign to the engineer.
+
+## 5. Exit
+
+- Comment on any in_progress work before exiting.
+- If no assignments and no valid mention-handoff, exit cleanly.

agents/plan-reviewer/SOUL.md

@@ -0,0 +1,21 @@
+# SOUL.md -- Plan Reviewer Persona
+
+You are the Plan Reviewer.
+
+## Review Posture
+
+- You catch problems before they become code. Your value is preventing wasted engineering hours.
+- Be specific. "This might have issues" is useless. "The LIMIT on line 3 of step 2 lacks ORDER BY, which produces nondeterministic results per SQLite docs" is useful.
+- Calibrate severity honestly. Not everything is a must-fix. Reserve blocking status for real correctness, security, or architectural issues.
+- Respect the engineer's judgment. They know the codebase better than you. Challenge their approach, but acknowledge when they have good reasons for unconventional choices.
+- Focus on what matters: correctness, security, completeness, testability. Skip style nitpicks.
+- Think adversarially. What inputs break this? What happens under load? What if the network fails mid-operation?
+- Be fast. Engineers are waiting on your review to start coding. A good review in 5 minutes beats a perfect review in an hour.
+
+## Voice and Tone
+
+- Direct and technical. Lead with the finding, then explain why it matters.
+- Constructive, not combative. "This misses X" not "You forgot X."
+- Brief. A review should be scannable in under 2 minutes.
+- No filler. Skip "great plan overall" unless it genuinely is and you have something specific to praise.
+- When uncertain, say so. "I'm not sure if asupersync handles this case -- worth verifying" is better than either silence or false confidence.

command-restructure/CLI_AUDIT.md

@@ -0,0 +1,388 @@
+# Gitlore CLI Command Audit
+
+## 1. Full Command Inventory
+
+**29 visible + 4 hidden + 2 stub = 35 total command surface**
+
+| # | Command | Aliases | Args | Flags | Purpose |
+|---|---------|---------|------|-------|---------|
+| 1 | `issues` | `issue` | `[IID]` | 15 | List/show issues |
+| 2 | `mrs` | `mr`, `merge-requests` | `[IID]` | 16 | List/show MRs |
+| 3 | `notes` | `note` | — | 16 | List notes |
+| 4 | `search` | `find`, `query` | `<QUERY>` | 13 | Hybrid FTS+vector search |
+| 5 | `timeline` | — | `<QUERY>` | 11 | Chronological event reconstruction |
+| 6 | `who` | — | `[TARGET]` | 16 | People intelligence (5 modes) |
+| 7 | `me` | — | — | 10 | Personal dashboard |
+| 8 | `file-history` | — | `<PATH>` | 6 | MRs that touched a file |
+| 9 | `trace` | — | `<PATH>` | 5 | file->MR->issue->discussion chain |
+| 10 | `drift` | — | `<TYPE> <IID>` | 3 | Discussion divergence detection |
+| 11 | `related` | — | `<QUERY_OR_TYPE> [IID]` | 3 | Semantic similarity |
+| 12 | `count` | — | `<ENTITY>` | 2 | Count entities |
+| 13 | `sync` | — | — | 14 | Full pipeline: ingest+docs+embed |
+| 14 | `ingest` | — | `[ENTITY]` | 5 | Fetch from GitLab API |
+| 15 | `generate-docs` | — | — | 2 | Build searchable documents |
+| 16 | `embed` | — | — | 2 | Generate vector embeddings |
+| 17 | `status` | `st` | — | 0 | Last sync times per project |
+| 18 | `health` | — | — | 0 | Quick pre-flight (exit code only) |
+| 19 | `doctor` | — | — | 0 | Full environment diagnostic |
+| 20 | `stats` | `stat` | — | 3 | Document/index statistics |
+| 21 | `init` | — | — | 6 | Setup config + database |
+| 22 | `auth` | — | — | 0 | Verify GitLab token |
+| 23 | `token` | — | subcommand | 1-2 | Token CRUD (set/show) |
+| 24 | `cron` | — | subcommand | 0-1 | Auto-sync scheduling |
+| 25 | `migrate` | — | — | 0 | Apply DB migrations |
+| 26 | `robot-docs` | — | — | 1 | Agent self-discovery manifest |
+| 27 | `completions` | — | `<SHELL>` | 0 | Shell completions |
+| 28 | `version` | — | — | 0 | Version info |
+| 29 | *help* | — | — | — | (clap built-in) |
+| | **Hidden/deprecated:** | | | | |
+| 30 | `list` | — | `<ENTITY>` | 14 | deprecated, use issues/mrs |
+| 31 | `auth-test` | — | — | 0 | deprecated, use auth |
+| 32 | `sync-status` | — | — | 0 | deprecated, use status |
+| 33 | `backup` | — | — | 0 | Stub (not implemented) |
+| 34 | `reset` | — | — | 1 | Stub (not implemented) |
+
+---
+
+## 2. Semantic Overlap Analysis
+
+### Cluster A: "Is the system working?" (4 commands, 1 concept)
+
+| Command | What it checks | Exit code semantics | Has flags? |
+|---------|---------------|---------------------|------------|
+| `health` | config exists, DB opens, schema version | 0=healthy, 19=unhealthy | No |
+| `doctor` | config, token, database, Ollama | informational | No |
+| `status` | last sync times per project | informational | No |
+| `stats` | document counts, index size, integrity | informational | `--check`, `--repair` |
+
+**Problem:** A user/agent asking "is lore working?" must choose among four commands. `health` is a strict subset of `doctor`. `status` and `stats` are near-homonyms that answer different questions -- sync recency vs. index health. `count` (Cluster E) also overlaps with what `stats` reports.
+
+**Cognitive cost:** High. The CLI literature (Clig.dev, Heroku CLI design guide, 12-factor CLI) consistently warns against >2 "status" commands. Users build a mental model of "the status command" -- when there are four, they pick wrong or give up.
+
+**Theoretical basis:**
+
+- **Nielsen's "Recognition over Recall"** -- Four similar system-status commands force users to *recall* which one does what. One command with progressive disclosure (flags for depth) lets them *recognize* the option they need. This is doubly important for LLM agents, which perform better with fewer top-level choices and compositional flags.
+
+- **Fitts's Law for CLIs** -- Command discovery cost is proportional to list length. Each additional top-level command adds scanning time for humans and token cost for robots.
+
+### Cluster B: "Data pipeline stages" (4 commands, 1 pipeline)
+
+| Command | Pipeline stage | Subsumed by `sync`? |
+|---------|---------------|---------------------|
+| `sync` | ingest -> generate-docs -> embed | -- (is the parent) |
+| `ingest` | GitLab API fetch | `sync` without `--no-docs --no-embed` |
+| `generate-docs` | Build FTS documents | `sync --no-embed` (after ingest) |
+| `embed` | Vector embeddings via Ollama | (final stage) |
+
+**Problem:** `sync` already has skip flags (`--no-embed`, `--no-docs`, `--no-events`, `--no-status`, `--no-file-changes`). The individual stage commands duplicate this with less control -- `ingest` has `--full`, `--force`, `--dry-run`, but `sync` also has all three.
+
+The standalone commands exist for granular debugging, but in practice they're reached for <5% of the time. They inflate the help screen while `sync` handles 95% of use cases.
+
+### Cluster C: "File-centric intelligence" (3 overlapping surfaces)
+
+| Command | Input | Output | Key flags |
+|---------|-------|--------|-----------|
+| `file-history` | `<PATH>` | MRs that touched file | `-p`, `--discussions`, `--no-follow-renames`, `--merged`, `-n` |
+| `trace` | `<PATH>` | file->MR->issue->discussion chains | `-p`, `--discussions`, `--no-follow-renames`, `-n` |
+| `who --path <PATH>` | `<PATH>` via flag | experts for file area | `-p`, `--since`, `-n` |
+| `who --overlap <PATH>` | `<PATH>` via flag | users touching same files | `-p`, `--since`, `-n` |
+
+**Problem:** `trace` is a superset of `file-history` -- it follows the same MR chain but additionally links to closing issues and discussions. They share 4 of 5 filter flags. A user who wants "what happened to this file?" has to choose between two commands that sound nearly identical.
+
+### Cluster D: "Semantic discovery" (3 commands, all need embeddings)
+
+| Command | Input | Output |
+|---------|-------|--------|
+| `search` | free text query | ranked documents |
+| `related` | entity ref OR free text | similar entities |
+| `drift` | entity ref | divergence score per discussion |
+
+`related "some text"` is functionally a vector-only `search "some text" --mode semantic`. The difference is that `related` can also seed from an entity (issues 42), while `search` only accepts text.
+
+`drift` is specialized enough to stand alone, but it's only used on issues and has a single non-project flag (`--threshold`).
+
+### Cluster E: "Count" is an orphan
+
+`count` is a standalone command for `SELECT COUNT(*) FROM <table>`. This could be:
+- A `--count` flag on `issues`/`mrs`/`notes`
+- A section in `stats` output (which already shows counts)
+- Part of `status` output
+
+It exists as its own top-level command primarily for robot convenience, but adds to the 29-command sprawl.
+
+---
+
+## 3. Flag Consistency Audit
+
+### Consistent (good patterns)
+
+| Flag | Meaning | Used in |
+|------|---------|---------|
+| `-p, --project` | Scope to project (fuzzy) | issues, mrs, notes, search, sync, ingest, generate-docs, timeline, who, me, file-history, trace, drift, related |
+| `-n, --limit` | Max results | issues, mrs, notes, search, timeline, who, me, file-history, trace, related |
+| `--since` | Temporal filter (7d, 2w, YYYY-MM-DD) | issues, mrs, notes, search, timeline, who, me |
+| `--fields` | Field selection / `minimal` preset | issues, mrs, notes, search, timeline, who, me |
+| `--full` | Reset cursors / full rebuild | sync, ingest, embed, generate-docs |
+| `--force` | Override stale lock | sync, ingest |
+| `--dry-run` | Preview without changes | sync, ingest, stats |
+
+### Inconsistencies (problems)
+
+| Issue | Details | Impact |
+|-------|---------|--------|
+| `-f` collision | `ingest -f` = `--force`, `count -f` = `--for` | Robot confusion; violates "same short flag = same semantics" |
+| `-a` inconsistency | `issues -a` = `--author`, `me` has no `-a` (uses `--user` for analogous concept) | Minor |
+| `-s` inconsistency | `issues -s` = `--state`, `search` has no `-s` short flag at all | Missed ergonomic shortcut |
+| `--sort` availability | Present in issues/mrs/notes, absent from search/timeline/file-history | Inconsistent query power |
+| `--discussions` | `file-history --discussions`, `trace --discussions`, but `issues 42` has no `--discussions` flag | Can't get discussions when showing an issue |
+| `--open` (browser) | `issues -o`, `mrs -o`, `notes --open` (no `-o`) | Inconsistent short flag |
+| `--merged` | Only on `file-history`, not on `mrs` (which uses `--state merged`) | Different filter mechanics for same concept |
+| Entity type naming | `count` takes `issues, mrs, discussions, notes, events`; `search --type` takes `issue, mr, discussion, note` (singular) | Singular vs plural for same concept |
+
+**Theoretical basis:**
+
+- **Principle of Least Surprise (POLS)** -- When `-f` means `--force` in one command and `--for` in another, both humans and agents learn the wrong lesson from one interaction and apply it to the other. CLI design guides (GNU standards, POSIX conventions, clig.dev) are unanimous: short flags should have consistent semantics across all subcommands.
+
+- **Singular/plural inconsistency** (`issues` vs `issue` as entity type values) is particularly harmful for LLM agents, which use pattern matching on prior successful invocations. If `lore count issues` works, the agent will try `lore search --type issues` -- and get a parse error.
+
+---
+
+## 4. Robot Ergonomics Assessment
+
+### Strengths (well above average for a CLI)
+
+| Feature | Rating | Notes |
+|---------|--------|-------|
+| Structured output | Excellent | Consistent `{ok, data, meta}` envelope |
+| Auto-detection | Excellent | Non-TTY -> robot mode, `LORE_ROBOT` env var |
+| Error output | Excellent | Structured JSON to stderr with `actions` array for recovery |
+| Exit codes | Excellent | 20 distinct, well-documented codes |
+| Self-discovery | Excellent | `robot-docs` manifest, `--brief` for token savings |
+| Typo tolerance | Excellent | Autocorrect with confidence scores + structured warnings |
+| Field selection | Good | `--fields minimal` saves ~60% tokens |
+| No-args behavior | Good | Robot mode auto-outputs robot-docs |
+
+### Weaknesses
+
+| Issue | Severity | Recommendation |
+|-------|----------|----------------|
+| 29 commands in robot-docs manifest | High | Agents spend tokens evaluating which command to use. Grouping would reduce decision space. |
+| `status`/`stats`/`stat` near-homonyms | High | LLMs are particularly susceptible to surface-level lexical confusion. `stat` is an alias for `stats` while `status` is a different command -- this guarantees agent errors. |
+| Singular vs plural entity types | Medium | `count issues` works but `search --type issues` fails. Agents learn from one and apply to the other. |
+| Overlapping file commands | Medium | Agent must decide between `trace`, `file-history`, and `who --path`. The decision tree isn't obvious from names alone. |
+| `count` as separate command | Low | Could be a flag; standalone command inflates the decision space |
+
+---
+
+## 5. Human Ergonomics Assessment
+
+### Strengths
+
+| Feature | Rating | Notes |
+|---------|--------|-------|
+| Help text quality | Excellent | Every command has examples, help headings organize flags |
+| Short flags | Good | `-p`, `-n`, `-s`, `-a`, `-J` cover 80% of common use |
+| Alias coverage | Good | `issue`/`issues`, `mr`/`mrs`, `st`/`status`, `find`/`search` |
+| Subcommand inference | Good | `lore issu` -> `issues` via clap infer |
+| Color/icon system | Good | Auto, with overrides |
+
+### Weaknesses
+
+| Issue | Severity | Recommendation |
+|-------|----------|----------------|
+| 29 commands in flat help | High | Doesn't fit one terminal screen. No grouping -> overwhelming |
+| `status` vs `stats` naming | High | Humans will type wrong one repeatedly |
+| `health` vs `doctor` distinction | Medium | "Which one do I run?" -- unclear from names |
+| `who` 5-mode overload | Medium | Help text is long; mode exclusions are complex |
+| Pipeline stages as top-level | Low | `ingest`/`generate-docs`/`embed` rarely used directly but clutter help |
+| `generate-docs` is 14 chars | Low | Longest command name; `gen-docs` or `gendocs` would help |
+
+---
+
+## 6. Proposals (Ranked by Impact x Feasibility)
+
+### P1: Help Grouping (HIGH impact, LOW effort)
+
+**Problem:** 29 flat commands -> information overload.
+
+**Fix:** Use clap's `help_heading` on subcommands to group them:
+
+```
+Query:
+  issues         List or show issues [aliases: issue]
+  mrs            List or show merge requests [aliases: mr]
+  notes          List notes from discussions [aliases: note]
+  search         Search indexed documents [aliases: find]
+  count          Count entities in local database
+
+Intelligence:
+  timeline       Chronological timeline of events
+  who            People intelligence: experts, workload, overlap
+  me             Personal work dashboard
+
+File Analysis:
+  trace          Trace why code was introduced
+  file-history   Show MRs that touched a file
+  related        Find semantically related entities
+  drift          Detect discussion divergence
+
+Data Pipeline:
+  sync           Run full sync pipeline
+  ingest         Ingest data from GitLab
+  generate-docs  Generate searchable documents
+  embed          Generate vector embeddings
+
+System:
+  init           Initialize configuration and database
+  status         Show sync state [aliases: st]
+  health         Quick health check
+  doctor         Check environment health
+  stats          Document and index statistics [aliases: stat]
+  auth           Verify GitLab authentication
+  token          Manage stored GitLab token
+  migrate        Run pending database migrations
+  cron           Manage automatic syncing
+  completions    Generate shell completions
+  robot-docs     Agent self-discovery manifest
+  version        Show version information
+```
+
+**Effort:** ~20 lines of `#[command(help_heading = "...")]` annotations. No behavior changes.
+
+### P2: Resolve `status`/`stats` Confusion (HIGH impact, LOW effort)
+
+**Option A (recommended):** Rename `stats` -> `index`.
+- `lore status` = when did I last sync? (pipeline state)
+- `lore index` = how big is my index? (data inventory)
+- The alias `stat` goes away (it was causing confusion anyway)
+
+**Option B:** Rename `status` -> `sync-state` and `stats` -> `db-stats`. More descriptive but longer.
+
+**Option C:** Merge both under `check` (see P4).
+
+### P3: Fix Singular/Plural Entity Type Inconsistency (MEDIUM impact, TRIVIAL effort)
+
+Accept both singular and plural forms everywhere:
+- `count` already takes `issues` (plural) -- also accept `issue`
+- `search --type` already takes `issue` (singular) -- also accept `issues`
+- `drift` takes `issues` -- also accept `issue`
+
+This is a ~10 line change in the value parsers and eliminates an entire class of agent errors.
+
+### P4: Merge `health` + `doctor` (MEDIUM impact, LOW effort)
+
+`health` is a fast subset of `doctor`. Merge:
+- `lore doctor` = full diagnostic (current behavior)
+- `lore doctor --quick` = fast pre-flight, exit-code-only (current `health`)
+- Drop `health` as a separate command, add a hidden alias for backward compat
+
+### P5: Fix `-f` Short Flag Collision (MEDIUM impact, TRIVIAL effort)
+
+Change `count`'s `-f, --for` to just `--for` (no short flag). `-f` should mean `--force` project-wide, or nowhere.
+
+### P6: Consolidate `trace` + `file-history` (MEDIUM impact, MEDIUM effort)
+
+`trace` already does everything `file-history` does plus more. Options:
+
+**Option A:** Make `file-history` an alias for `trace --flat` (shows MR list without issue/discussion linking).
+
+**Option B:** Add `--mrs-only` to `trace` that produces `file-history` output. Deprecate `file-history` with a hidden alias.
+
+Either way, one fewer top-level command and no lost functionality.
+
+### P7: Hide Pipeline Sub-stages (LOW impact, TRIVIAL effort)
+
+Move `ingest`, `generate-docs`, `embed` to `#[command(hide = true)]`. They remain usable but don't clutter `--help`. Direct users to `sync` with stage-skip flags.
+
+For power users who need individual stages, document in `sync --help`:
+```
+To run individual stages:
+  lore ingest                    # Fetch from GitLab only
+  lore generate-docs             # Rebuild documents only
+  lore embed                     # Re-embed only
+```
+
+### P8: Make `count` a Flag, Not a Command (LOW impact, MEDIUM effort)
+
+Add `--count` to `issues` and `mrs`:
+```bash
+lore issues --count              # replaces: lore count issues
+lore mrs --count                 # replaces: lore count mrs
+lore notes --count               # replaces: lore count notes
+```
+
+Keep `count` as a hidden alias for backward compatibility. Removes one top-level command.
+
+### P9: Consistent `--open` Short Flag (LOW impact, TRIVIAL effort)
+
+`notes --open` lacks the `-o` shorthand that `issues` and `mrs` have. Add it.
+
+### P10: Add `--sort` to `search` (LOW impact, LOW effort)
+
+`search` returns ranked results but offers no `--sort` override. Adding `--sort=score,created,updated` would bring it in line with `issues`/`mrs`/`notes`.
+
+---
+
+## 7. Summary: Proposed Command Tree (After All Changes)
+
+If all proposals were adopted, the visible top-level shrinks from **29 -> 21**:
+
+| Before (29) | After (21) | Change |
+|-------------|------------|--------|
+| `issues` | `issues` | -- |
+| `mrs` | `mrs` | -- |
+| `notes` | `notes` | -- |
+| `search` | `search` | -- |
+| `timeline` | `timeline` | -- |
+| `who` | `who` | -- |
+| `me` | `me` | -- |
+| `file-history` | *(hidden, alias for `trace --flat`)* | **merged into trace** |
+| `trace` | `trace` | absorbs file-history |
+| `drift` | `drift` | -- |
+| `related` | `related` | -- |
+| `count` | *(hidden, `issues --count` replaces)* | **absorbed** |
+| `sync` | `sync` | -- |
+| `ingest` | *(hidden)* | **hidden** |
+| `generate-docs` | *(hidden)* | **hidden** |
+| `embed` | *(hidden)* | **hidden** |
+| `status` | `status` | -- |
+| `health` | *(merged into doctor)* | **merged** |
+| `doctor` | `doctor` | absorbs health |
+| `stats` | `index` | **renamed** |
+| `init` | `init` | -- |
+| `auth` | `auth` | -- |
+| `token` | `token` | -- |
+| `migrate` | `migrate` | -- |
+| `cron` | `cron` | -- |
+| `robot-docs` | `robot-docs` | -- |
+| `completions` | `completions` | -- |
+| `version` | `version` | -- |
+
+**Net reduction:** 29 -> 21 visible (-28%). The hidden commands remain fully functional and documented in `robot-docs` for agents that already use them.
+
+**Theoretical basis:**
+
+- **Miller's Law** -- Humans can hold 7+/-2 items in working memory. 29 commands far exceeds this. Even with help grouping (P1), the sheer count creates decision fatigue. The literature on CLI design (Heroku's "12-Factor CLI", clig.dev's "Command Line Interface Guidelines") recommends 10-15 top-level commands maximum, with grouping or nesting for anything beyond.
+
+- **For LLM agents specifically:** Research on tool-use with large tool sets (Schick et al. 2023, Qin et al. 2023) shows that agent accuracy degrades as the tool count increases, roughly following an inverse log curve. Reducing from 29 to 21 commands in the robot-docs manifest would measurably improve agent command selection accuracy.
+
+- **Backward compatibility is free:** Since AGENTS.md says "we don't care about backward compatibility," hidden aliases cost nothing and prevent breakage for agents with cached robot-docs.
+
+---
+
+## 8. Priority Matrix
+
+| Proposal | Impact | Effort | Risk | Recommended Order |
+|----------|--------|--------|------|-------------------|
+| P1: Help grouping | High | Trivial | None | **Do first** |
+| P3: Singular/plural fix | Medium | Trivial | None | **Do first** |
+| P5: Fix `-f` collision | Medium | Trivial | None | **Do first** |
+| P9: `notes -o` shorthand | Low | Trivial | None | **Do first** |
+| P2: Rename `stats`->`index` | High | Low | Alias needed | **Do second** |
+| P4: Merge health->doctor | Medium | Low | Alias needed | **Do second** |
+| P7: Hide pipeline stages | Low | Trivial | Needs docs update | **Do second** |
+| P6: Merge file-history->trace | Medium | Medium | Flag design | **Plan carefully** |
+| P8: count -> --count flag | Low | Medium | Compat shim | **Plan carefully** |
+| P10: `--sort` on search | Low | Low | None | **When convenient** |
+
+The "do first" tier is 4 changes that could ship in a single commit with zero risk and immediate ergonomic improvement for both humans and agents.

command-restructure/IMPLEMENTATION_PLAN.md

@@ -0,0 +1,966 @@
+# Command Restructure: Implementation Plan
+
+**Reference:** `command-restructure/CLI_AUDIT.md`
+**Scope:** 10 proposals, 3 implementation phases, estimated ~15 files touched
+
+---
+
+## Phase 1: Zero-Risk Quick Wins (1 commit)
+
+These four changes are purely additive -- no behavior changes, no renames, no removed commands.
+
+### P1: Help Grouping
+
+**Goal:** Group the 29 visible commands into 5 semantic clusters in `--help` output.
+
+**File:** `src/cli/mod.rs` (lines 117-399, the `Commands` enum)
+
+**Changes:** Add `#[command(help_heading = "...")]` to each variant:
+
+```rust
+#[derive(Subcommand)]
+#[allow(clippy::large_enum_variant)]
+pub enum Commands {
+    // ── Query ──────────────────────────────────────────────
+    /// List or show issues
+    #[command(visible_alias = "issue", help_heading = "Query")]
+    Issues(IssuesArgs),
+
+    /// List or show merge requests
+    #[command(visible_alias = "mr", alias = "merge-requests", alias = "merge-request", help_heading = "Query")]
+    Mrs(MrsArgs),
+
+    /// List notes from discussions
+    #[command(visible_alias = "note", help_heading = "Query")]
+    Notes(NotesArgs),
+
+    /// Search indexed documents
+    #[command(visible_alias = "find", alias = "query", help_heading = "Query")]
+    Search(SearchArgs),
+
+    /// Count entities in local database
+    #[command(help_heading = "Query")]
+    Count(CountArgs),
+
+    // ── Intelligence ───────────────────────────────────────
+    /// Show a chronological timeline of events matching a query
+    #[command(help_heading = "Intelligence")]
+    Timeline(TimelineArgs),
+
+    /// People intelligence: experts, workload, active discussions, overlap
+    #[command(help_heading = "Intelligence")]
+    Who(WhoArgs),
+
+    /// Personal work dashboard: open issues, authored/reviewing MRs, activity
+    #[command(help_heading = "Intelligence")]
+    Me(MeArgs),
+
+    // ── File Analysis ──────────────────────────────────────
+    /// Trace why code was introduced: file -> MR -> issue -> discussion
+    #[command(help_heading = "File Analysis")]
+    Trace(TraceArgs),
+
+    /// Show MRs that touched a file, with linked discussions
+    #[command(name = "file-history", help_heading = "File Analysis")]
+    FileHistory(FileHistoryArgs),
+
+    /// Find semantically related entities via vector search
+    #[command(help_heading = "File Analysis", ...)]
+    Related { ... },
+
+    /// Detect discussion divergence from original intent
+    #[command(help_heading = "File Analysis", ...)]
+    Drift { ... },
+
+    // ── Data Pipeline ──────────────────────────────────────
+    /// Run full sync pipeline: ingest -> generate-docs -> embed
+    #[command(help_heading = "Data Pipeline")]
+    Sync(SyncArgs),
+
+    /// Ingest data from GitLab
+    #[command(help_heading = "Data Pipeline")]
+    Ingest(IngestArgs),
+
+    /// Generate searchable documents from ingested data
+    #[command(name = "generate-docs", help_heading = "Data Pipeline")]
+    GenerateDocs(GenerateDocsArgs),
+
+    /// Generate vector embeddings for documents via Ollama
+    #[command(help_heading = "Data Pipeline")]
+    Embed(EmbedArgs),
+
+    // ── System ─────────────────────────────────────────────
+    // (init, status, health, doctor, stats, auth, token, migrate, cron,
+    //  completions, robot-docs, version -- all get help_heading = "System")
+}
+```
+
+**Verification:**
+- `lore --help` shows grouped output
+- All existing commands still work identically
+- `lore robot-docs` output unchanged (robot-docs is hand-crafted, not derived from clap)
+
+**Files touched:** `src/cli/mod.rs` only
+
+---
+
+### P3: Singular/Plural Entity Type Fix
+
+**Goal:** Accept both `issue`/`issues`, `mr`/`mrs` everywhere entity types are value-parsed.
+
+**File:** `src/cli/args.rs`
+
+**Change 1 -- `CountArgs.entity` (line 819):**
+```rust
+// BEFORE:
+#[arg(value_parser = ["issues", "mrs", "discussions", "notes", "events"])]
+pub entity: String,
+
+// AFTER:
+#[arg(value_parser = ["issue", "issues", "mr", "mrs", "discussion", "discussions", "note", "notes", "event", "events"])]
+pub entity: String,
+```
+
+**File:** `src/cli/args.rs`
+
+**Change 2 -- `SearchArgs.source_type` (line 369):**
+```rust
+// BEFORE:
+#[arg(long = "type", value_parser = ["issue", "mr", "discussion", "note"], ...)]
+pub source_type: Option<String>,
+
+// AFTER:
+#[arg(long = "type", value_parser = ["issue", "issues", "mr", "mrs", "discussion", "discussions", "note", "notes"], ...)]
+pub source_type: Option<String>,
+```
+
+**File:** `src/cli/mod.rs`
+
+**Change 3 -- `Drift.entity_type` (line 287):**
+```rust
+// BEFORE:
+#[arg(value_parser = ["issues"])]
+pub entity_type: String,
+
+// AFTER:
+#[arg(value_parser = ["issue", "issues"])]
+pub entity_type: String,
+```
+
+**Normalization layer:** In the handlers that consume these values, normalize to the canonical form (plural for entity names, singular for source_type) so downstream code doesn't need changes:
+
+**File:** `src/app/handlers.rs`
+
+In `handle_count` (~line 409): Normalize entity string before passing to `run_count`:
+```rust
+let entity = match args.entity.as_str() {
+    "issue" => "issues",
+    "mr" => "mrs",
+    "discussion" => "discussions",
+    "note" => "notes",
+    "event" => "events",
+    other => other,
+};
+```
+
+In `handle_search` (search handler): Normalize source_type:
+```rust
+let source_type = args.source_type.as_deref().map(|t| match t {
+    "issues" => "issue",
+    "mrs" => "mr",
+    "discussions" => "discussion",
+    "notes" => "note",
+    other => other,
+});
+```
+
+In `handle_drift` (~line 225): Normalize entity_type:
+```rust
+let entity_type = if entity_type == "issue" { "issues" } else { &entity_type };
+```
+
+**Verification:**
+- `lore count issue` works (same as `lore count issues`)
+- `lore search --type issues 'foo'` works (same as `--type issue`)
+- `lore drift issue 42` works (same as `drift issues 42`)
+- All existing invocations unchanged
+
+**Files touched:** `src/cli/args.rs`, `src/cli/mod.rs`, `src/app/handlers.rs`
+
+---
+
+### P5: Fix `-f` Short Flag Collision
+
+**Goal:** Remove `-f` shorthand from `count --for` so `-f` consistently means `--force` across the CLI.
+
+**File:** `src/cli/args.rs` (line 823)
+
+```rust
+// BEFORE:
+#[arg(short = 'f', long = "for", value_parser = ["issue", "mr"])]
+pub for_entity: Option<String>,
+
+// AFTER:
+#[arg(long = "for", value_parser = ["issue", "mr"])]
+pub for_entity: Option<String>,
+```
+
+**Also update the value_parser to accept both forms** (while we're here):
+```rust
+#[arg(long = "for", value_parser = ["issue", "issues", "mr", "mrs"])]
+pub for_entity: Option<String>,
+```
+
+And normalize in `handle_count`:
+```rust
+let for_entity = args.for_entity.as_deref().map(|f| match f {
+    "issues" => "issue",
+    "mrs" => "mr",
+    other => other,
+});
+```
+
+**File:** `src/app/robot_docs.rs` (line 173) -- update the robot-docs entry:
+```rust
+// BEFORE:
+"flags": ["<entity: issues|mrs|discussions|notes|events>", "-f/--for <issue|mr>"],
+
+// AFTER:
+"flags": ["<entity: issues|mrs|discussions|notes|events>", "--for <issue|mr>"],
+```
+
+**Verification:**
+- `lore count notes --for mr` still works
+- `lore count notes -f mr` now fails with a clear error (unknown flag `-f`)
+- `lore ingest -f` still works (means `--force`)
+
+**Files touched:** `src/cli/args.rs`, `src/app/robot_docs.rs`
+
+---
+
+### P9: Consistent `--open` Short Flag on `notes`
+
+**Goal:** Add `-o` shorthand to `notes --open`, matching `issues` and `mrs`.
+
+**File:** `src/cli/args.rs` (line 292)
+
+```rust
+// BEFORE:
+#[arg(long, help_heading = "Actions")]
+pub open: bool,
+
+// AFTER:
+#[arg(short = 'o', long, help_heading = "Actions", overrides_with = "no_open")]
+pub open: bool,
+
+#[arg(long = "no-open", hide = true, overrides_with = "open")]
+pub no_open: bool,
+```
+
+**Verification:**
+- `lore notes -o` opens first result in browser
+- Matches behavior of `lore issues -o` and `lore mrs -o`
+
+**Files touched:** `src/cli/args.rs`
+
+---
+
+### Phase 1 Commit Summary
+
+**Files modified:**
+1. `src/cli/mod.rs` -- help_heading on all Commands variants + drift value_parser
+2. `src/cli/args.rs` -- singular/plural value_parsers, remove `-f` from count, add `-o` to notes
+3. `src/app/handlers.rs` -- normalization of entity/source_type strings
+4. `src/app/robot_docs.rs` -- update count flags documentation
+
+**Test plan:**
+```bash
+cargo check --all-targets
+cargo clippy --all-targets -- -D warnings
+cargo fmt --check
+cargo test
+lore --help                    # Verify grouped output
+lore count issue               # Verify singular accepted
+lore search --type issues 'x'  # Verify plural accepted
+lore drift issue 42            # Verify singular accepted
+lore notes -o                  # Verify short flag works
+```
+
+---
+
+## Phase 2: Renames and Merges (2-3 commits)
+
+These changes rename commands and merge overlapping ones. Hidden aliases preserve backward compatibility.
+
+### P2: Rename `stats` -> `index`
+
+**Goal:** Eliminate `status`/`stats`/`stat` confusion. `stats` becomes `index`.
+
+**File:** `src/cli/mod.rs`
+
+```rust
+// BEFORE:
+/// Show document and index statistics
+#[command(visible_alias = "stat", help_heading = "System")]
+Stats(StatsArgs),
+
+// AFTER:
+/// Show document and index statistics
+#[command(visible_alias = "idx", alias = "stats", alias = "stat", help_heading = "System")]
+Index(StatsArgs),
+```
+
+Note: `alias = "stats"` and `alias = "stat"` are hidden aliases (not `visible_alias`) -- old invocations still work, but `--help` shows `index`.
+
+**File:** `src/main.rs` (line 257)
+
+```rust
+// BEFORE:
+Some(Commands::Stats(args)) => handle_stats(cli.config.as_deref(), args, robot_mode).await,
+
+// AFTER:
+Some(Commands::Index(args)) => handle_stats(cli.config.as_deref(), args, robot_mode).await,
+```
+
+**File:** `src/app/robot_docs.rs` (line 181)
+
+```rust
+// BEFORE:
+"stats": {
+    "description": "Show document and index statistics",
+    ...
+
+// AFTER:
+"index": {
+    "description": "Show document and index statistics (formerly 'stats')",
+    ...
+```
+
+Also update references in:
+- `robot_docs.rs` quick_start.lore_exclusive array (line 415): `"stats: Database statistics..."` -> `"index: Database statistics..."`
+- `robot_docs.rs` aliases.deprecated_commands: add `"stats": "index"`, `"stat": "index"`
+
+**File:** `src/cli/autocorrect.rs`
+
+Update `CANONICAL_SUBCOMMANDS` (line 366-area):
+```rust
+// Replace "stats" with "index" in the canonical list
+// Add ("stats", "index") and ("stat", "index") to SUBCOMMAND_ALIASES
+```
+
+Update `COMMAND_FLAGS` (line 166-area):
+```rust
+// BEFORE:
+("stats", &["--check", ...]),
+
+// AFTER:
+("index", &["--check", ...]),
+```
+
+**File:** `src/cli/robot.rs` -- update `expand_fields_preset` if any preset key is `"stats"` (currently no stats preset, so no change needed).
+
+**Verification:**
+- `lore index` works (shows document/index stats)
+- `lore stats` still works (hidden alias)
+- `lore stat` still works (hidden alias)
+- `lore index --check` works
+- `lore --help` shows `index` in System group, not `stats`
+- `lore robot-docs` shows `index` key in commands map
+
+**Files touched:** `src/cli/mod.rs`, `src/main.rs`, `src/app/robot_docs.rs`, `src/cli/autocorrect.rs`
+
+---
+
+### P4: Merge `health` into `doctor`
+
+**Goal:** One diagnostic command (`doctor`) with a `--quick` flag for the pre-flight check that `health` currently provides.
+
+**File:** `src/cli/mod.rs`
+
+```rust
+// BEFORE:
+/// Quick health check: config, database, schema version
+#[command(after_help = "...")]
+Health,
+
+/// Check environment health
+#[command(after_help = "...")]
+Doctor,
+
+// AFTER:
+// Remove Health variant entirely. Add hidden alias:
+/// Check environment health (--quick for fast pre-flight)
+#[command(
+    after_help = "...",
+    alias = "health",  // hidden backward compat
+    help_heading = "System"
+)]
+Doctor {
+    /// Fast pre-flight check only (config, DB, schema). Exit 0 = healthy.
+    #[arg(long)]
+    quick: bool,
+},
+```
+
+**File:** `src/main.rs`
+
+```rust
+// BEFORE:
+Some(Commands::Doctor) => handle_doctor(cli.config.as_deref(), robot_mode).await,
+...
+Some(Commands::Health) => handle_health(cli.config.as_deref(), robot_mode).await,
+
+// AFTER:
+Some(Commands::Doctor { quick }) => {
+    if quick {
+        handle_health(cli.config.as_deref(), robot_mode).await
+    } else {
+        handle_doctor(cli.config.as_deref(), robot_mode).await
+    }
+}
+// Health variant removed from enum, so no separate match arm
+```
+
+**File:** `src/app/robot_docs.rs`
+
+Merge the `health` and `doctor` entries:
+```rust
+"doctor": {
+    "description": "Environment health check. Use --quick for fast pre-flight (exit 0 = healthy, 19 = unhealthy).",
+    "flags": ["--quick"],
+    "example": "lore --robot doctor",
+    "notes": {
+        "quick_mode": "lore --robot doctor --quick — fast pre-flight check (formerly 'lore health'). Only checks config, DB, schema version. Returns exit 19 on failure.",
+        "full_mode": "lore --robot doctor — full diagnostic: config, auth, database, Ollama"
+    },
+    "response_schema": {
+        "full": { ... },  // current doctor schema
+        "quick": { ... }  // current health schema
+    }
+}
+```
+
+Remove the standalone `health` entry from the commands map.
+
+**File:** `src/cli/autocorrect.rs`
+
+- Remove `"health"` from `CANONICAL_SUBCOMMANDS` (clap's `alias` handles it)
+- Or keep it -- since clap treats aliases as valid subcommands, the autocorrect system will still resolve typos like `"helth"` to `"health"` which clap then maps to `doctor`. Either way works.
+
+**File:** `src/app/robot_docs.rs` -- update `workflows.pre_flight`:
+```rust
+"pre_flight": [
+    "lore --robot doctor --quick"
+],
+```
+
+Add to aliases.deprecated_commands:
+```rust
+"health": "doctor --quick"
+```
+
+**Verification:**
+- `lore doctor` runs full diagnostic (unchanged behavior)
+- `lore doctor --quick` runs fast pre-flight (exit 0/19)
+- `lore health` still works (hidden alias, runs `doctor --quick`)
+- `lore --help` shows only `doctor` in System group
+- `lore robot-docs` shows merged entry
+
+**Files touched:** `src/cli/mod.rs`, `src/main.rs`, `src/app/robot_docs.rs`, `src/cli/autocorrect.rs`
+
+**Important edge case:** `lore health` via the hidden alias will invoke `Doctor { quick: false }` unless we handle it specially. Two options:
+
+**Option A (simpler):** Instead of making `health` an alias of `doctor`, keep both variants but hide `Health`:
+```rust
+#[command(hide = true, help_heading = "System")]
+Health,
+```
+Then in `main.rs`, `Commands::Health` maps to `handle_health()` as before. This is less clean but zero-risk.
+
+**Option B (cleaner):** In the autocorrect layer, rewrite `health` -> `doctor --quick` before clap parsing:
+```rust
+// In SUBCOMMAND_ALIASES or a new pre-clap rewrite:
+("health", "doctor"),  // plus inject "--quick" flag
+```
+This requires a small enhancement to autocorrect to support flag injection during alias resolution.
+
+**Recommendation:** Use Option A for initial implementation. It's one line (`hide = true`) and achieves the goal of removing `health` from `--help` while preserving full backward compatibility. The `doctor --quick` flag is additive.
+
+---
+
+### P7: Hide Pipeline Sub-stages
+
+**Goal:** Remove `ingest`, `generate-docs`, `embed` from `--help` while keeping them fully functional.
+
+**File:** `src/cli/mod.rs`
+
+```rust
+// Add hide = true to each:
+
+/// Ingest data from GitLab
+#[command(hide = true)]
+Ingest(IngestArgs),
+
+/// Generate searchable documents from ingested data
+#[command(name = "generate-docs", hide = true)]
+GenerateDocs(GenerateDocsArgs),
+
+/// Generate vector embeddings for documents via Ollama
+#[command(hide = true)]
+Embed(EmbedArgs),
+```
+
+**File:** `src/cli/mod.rs` -- Update `Sync` help text to mention the individual stage commands:
+
+```rust
+/// Run full sync pipeline: ingest -> generate-docs -> embed
+#[command(after_help = "\x1b[1mExamples:\x1b[0m
+  lore sync                             # Full pipeline: ingest + docs + embed
+  lore sync --no-embed                  # Skip embedding step
+  ...
+
+\x1b[1mIndividual stages:\x1b[0m
+  lore ingest                           # Fetch from GitLab only
+  lore generate-docs                    # Rebuild documents only
+  lore embed                            # Re-embed only",
+    help_heading = "Data Pipeline"
+)]
+Sync(SyncArgs),
+```
+
+**File:** `src/app/robot_docs.rs` -- Add a `"hidden": true` field to the ingest/generate-docs/embed entries so agents know these are secondary:
+```rust
+"ingest": {
+    "hidden": true,
+    "description": "Sync data from GitLab (prefer 'sync' for full pipeline)",
+    ...
+```
+
+**Verification:**
+- `lore --help` no longer shows ingest, generate-docs, embed
+- `lore ingest`, `lore generate-docs`, `lore embed` all still work
+- `lore sync --help` mentions individual stage commands
+- `lore robot-docs` still includes all three (with `hidden: true`)
+
+**Files touched:** `src/cli/mod.rs`, `src/app/robot_docs.rs`
+
+---
+
+### Phase 2 Commit Summary
+
+**Commit A: Rename `stats` -> `index`**
+- `src/cli/mod.rs`, `src/main.rs`, `src/app/robot_docs.rs`, `src/cli/autocorrect.rs`
+
+**Commit B: Merge `health` into `doctor`, hide pipeline stages**
+- `src/cli/mod.rs`, `src/main.rs`, `src/app/robot_docs.rs`, `src/cli/autocorrect.rs`
+
+**Test plan:**
+```bash
+cargo check --all-targets
+cargo clippy --all-targets -- -D warnings
+cargo fmt --check
+cargo test
+
+# Rename verification
+lore index                     # Works (new name)
+lore stats                     # Works (hidden alias)
+lore index --check             # Works
+
+# Doctor merge verification
+lore doctor                    # Full diagnostic
+lore doctor --quick            # Fast pre-flight
+lore health                    # Still works (hidden)
+
+# Hidden stages verification
+lore --help                    # ingest/generate-docs/embed gone
+lore ingest                    # Still works
+lore sync --help               # Mentions individual stages
+```
+
+---
+
+## Phase 3: Structural Consolidation (requires careful design)
+
+These changes merge or absorb commands. More effort, more testing, but the biggest UX wins.
+
+### P6: Consolidate `file-history` into `trace`
+
+**Goal:** `trace` absorbs `file-history`. One command for file-centric intelligence.
+
+**Approach:** Add `--mrs-only` flag to `trace`. When set, output matches `file-history` format (flat MR list, no issue/discussion linking). `file-history` becomes a hidden alias.
+
+**File:** `src/cli/args.rs` -- Add flag to `TraceArgs`:
+
+```rust
+pub struct TraceArgs {
+    pub path: String,
+
+    #[arg(short = 'p', long, help_heading = "Filters")]
+    pub project: Option<String>,
+
+    #[arg(long, help_heading = "Output")]
+    pub discussions: bool,
+
+    #[arg(long = "no-follow-renames", help_heading = "Filters")]
+    pub no_follow_renames: bool,
+
+    #[arg(short = 'n', long = "limit", default_value = "20", help_heading = "Output")]
+    pub limit: usize,
+
+    // NEW: absorb file-history behavior
+    /// Show only MR list without issue/discussion linking (file-history mode)
+    #[arg(long = "mrs-only", help_heading = "Output")]
+    pub mrs_only: bool,
+
+    /// Only show merged MRs (file-history mode)
+    #[arg(long, help_heading = "Filters")]
+    pub merged: bool,
+}
+```
+
+**File:** `src/cli/mod.rs` -- Hide `FileHistory`:
+
+```rust
+/// Show MRs that touched a file, with linked discussions
+#[command(name = "file-history", hide = true, help_heading = "File Analysis")]
+FileHistory(FileHistoryArgs),
+```
+
+**File:** `src/app/handlers.rs` -- Route `trace --mrs-only` to the file-history handler:
+
+```rust
+fn handle_trace(
+    config_override: Option<&str>,
+    args: TraceArgs,
+    robot_mode: bool,
+) -> Result<(), Box<dyn std::error::Error>> {
+    if args.mrs_only {
+        // Delegate to file-history handler
+        let fh_args = FileHistoryArgs {
+            path: args.path,
+            project: args.project,
+            discussions: args.discussions,
+            no_follow_renames: args.no_follow_renames,
+            merged: args.merged,
+            limit: args.limit,
+        };
+        return handle_file_history(config_override, fh_args, robot_mode);
+    }
+    // ... existing trace logic ...
+}
+```
+
+**File:** `src/app/robot_docs.rs` -- Update trace entry, mark file-history as deprecated:
+
+```rust
+"trace": {
+    "description": "Trace why code was introduced: file -> MR -> issue -> discussion. Use --mrs-only for flat MR listing.",
+    "flags": ["<path>", "-p/--project", "--discussions", "--no-follow-renames", "-n/--limit", "--mrs-only", "--merged"],
+    ...
+},
+"file-history": {
+    "hidden": true,
+    "deprecated": "Use 'trace --mrs-only' instead",
+    ...
+}
+```
+
+**Verification:**
+- `lore trace src/main.rs` works unchanged
+- `lore trace src/main.rs --mrs-only` produces file-history output
+- `lore trace src/main.rs --mrs-only --merged` filters to merged MRs
+- `lore file-history src/main.rs` still works (hidden command)
+- `lore --help` shows only `trace` in File Analysis group
+
+**Files touched:** `src/cli/args.rs`, `src/cli/mod.rs`, `src/app/handlers.rs`, `src/app/robot_docs.rs`
+
+---
+
+### P8: Make `count` a Flag on Entity Commands
+
+**Goal:** `lore issues --count` replaces `lore count issues`. Standalone `count` becomes hidden.
+
+**File:** `src/cli/args.rs` -- Add `--count` to `IssuesArgs`, `MrsArgs`, `NotesArgs`:
+
+```rust
+// In IssuesArgs:
+/// Show count only (no listing)
+#[arg(long, help_heading = "Output", conflicts_with_all = ["iid", "open"])]
+pub count: bool,
+
+// In MrsArgs:
+/// Show count only (no listing)
+#[arg(long, help_heading = "Output", conflicts_with_all = ["iid", "open"])]
+pub count: bool,
+
+// In NotesArgs:
+/// Show count only (no listing)
+#[arg(long, help_heading = "Output", conflicts_with = "open")]
+pub count: bool,
+```
+
+**File:** `src/app/handlers.rs` -- In `handle_issues`, `handle_mrs`, `handle_notes`, check the count flag early:
+
+```rust
+// In handle_issues (pseudocode):
+if args.count {
+    let count_args = CountArgs { entity: "issues".to_string(), for_entity: None };
+    return handle_count(config_override, count_args, robot_mode).await;
+}
+```
+
+**File:** `src/cli/mod.rs` -- Hide `Count`:
+
+```rust
+/// Count entities in local database
+#[command(hide = true, help_heading = "Query")]
+Count(CountArgs),
+```
+
+**File:** `src/app/robot_docs.rs` -- Mark count as hidden, add `--count` documentation to issues/mrs/notes entries.
+
+**Verification:**
+- `lore issues --count` returns issue count
+- `lore mrs --count` returns MR count
+- `lore notes --count` returns note count
+- `lore count issues` still works (hidden)
+- `lore count discussions --for mr` still works (no equivalent in the new pattern -- discussions/events/references still need the standalone `count` command)
+
+**Important note:** `count` supports entity types that don't have their own command (discussions, events, references). The standalone `count` must remain functional (just hidden). The `--count` flag on `issues`/`mrs`/`notes` handles the common cases only.
+
+**Files touched:** `src/cli/args.rs`, `src/cli/mod.rs`, `src/app/handlers.rs`, `src/app/robot_docs.rs`
+
+---
+
+### P10: Add `--sort` to `search`
+
+**Goal:** Allow sorting search results by score, created date, or updated date.
+
+**File:** `src/cli/args.rs` -- Add to `SearchArgs`:
+
+```rust
+/// Sort results by field (score is default for ranked search)
+#[arg(long, value_parser = ["score", "created", "updated"], default_value = "score", help_heading = "Sorting")]
+pub sort: String,
+
+/// Sort ascending (default: descending)
+#[arg(long, help_heading = "Sorting", overrides_with = "no_asc")]
+pub asc: bool,
+
+#[arg(long = "no-asc", hide = true, overrides_with = "asc")]
+pub no_asc: bool,
+```
+
+**File:** `src/cli/commands/search.rs` -- Thread the sort parameter through to the search query.
+
+The search function currently returns results sorted by score. When `--sort created` or `--sort updated` is specified, apply an `ORDER BY` clause to the final result set.
+
+**File:** `src/app/robot_docs.rs` -- Add `--sort` and `--asc` to the search command's flags list.
+
+**Verification:**
+- `lore search 'auth' --sort score` (default, unchanged)
+- `lore search 'auth' --sort created --asc` (oldest first)
+- `lore search 'auth' --sort updated` (most recently updated first)
+
+**Files touched:** `src/cli/args.rs`, `src/cli/commands/search.rs`, `src/app/robot_docs.rs`
+
+---
+
+### Phase 3 Commit Summary
+
+**Commit C: Consolidate file-history into trace**
+- `src/cli/args.rs`, `src/cli/mod.rs`, `src/app/handlers.rs`, `src/app/robot_docs.rs`
+
+**Commit D: Add `--count` flag to entity commands**
+- `src/cli/args.rs`, `src/cli/mod.rs`, `src/app/handlers.rs`, `src/app/robot_docs.rs`
+
+**Commit E: Add `--sort` to search**
+- `src/cli/args.rs`, `src/cli/commands/search.rs`, `src/app/robot_docs.rs`
+
+**Test plan:**
+```bash
+cargo check --all-targets
+cargo clippy --all-targets -- -D warnings
+cargo fmt --check
+cargo test
+
+# trace consolidation
+lore trace src/main.rs --mrs-only
+lore trace src/main.rs --mrs-only --merged --discussions
+lore file-history src/main.rs     # backward compat
+
+# count flag
+lore issues --count
+lore mrs --count -s opened
+lore notes --count --for-issue 42
+lore count discussions --for mr   # still works
+
+# search sort
+lore search 'auth' --sort created --asc
+```
+
+---
+
+## Documentation Updates
+
+After all implementation is complete:
+
+### CLAUDE.md / AGENTS.md
+
+Update the robot mode command reference to reflect:
+- `stats` -> `index` (with note that `stats` is a hidden alias)
+- `health` -> `doctor --quick` (with note that `health` is a hidden alias)
+- Remove `ingest`, `generate-docs`, `embed` from the primary command table (mention as "hidden, use `sync`")
+- Remove `file-history` from primary table (mention as "hidden, use `trace --mrs-only`")
+- Add `--count` flag to issues/mrs/notes documentation
+- Add `--sort` flag to search documentation
+- Add `--mrs-only` and `--merged` flags to trace documentation
+
+### robot-docs Self-Discovery
+
+The `robot_docs.rs` changes above handle this. Key points:
+- New `"hidden": true` field on deprecated/hidden commands
+- Updated descriptions mentioning canonical alternatives
+- Updated flags lists
+- Updated workflows section
+
+---
+
+## File Impact Summary
+
+| File | Phase 1 | Phase 2 | Phase 3 | Total Changes |
+|------|---------|---------|---------|---------------|
+| `src/cli/mod.rs` | help_heading, drift value_parser | stats->index rename, hide health, hide pipeline stages | hide file-history, hide count | 4 passes |
+| `src/cli/args.rs` | singular/plural, remove `-f`, add `-o` | — | `--mrs-only`/`--merged` on trace, `--count` on entities, `--sort` on search | 2 passes |
+| `src/app/handlers.rs` | normalize entity strings | route doctor --quick | trace mrs-only delegation, count flag routing | 3 passes |
+| `src/app/robot_docs.rs` | update count flags | rename stats->index, merge health+doctor, add hidden field | update trace, file-history, count, search entries | 3 passes |
+| `src/cli/autocorrect.rs` | — | update CANONICAL_SUBCOMMANDS, SUBCOMMAND_ALIASES, COMMAND_FLAGS | — | 1 pass |
+| `src/main.rs` | — | stats->index variant rename, doctor variant change | — | 1 pass |
+| `src/cli/commands/search.rs` | — | — | sort parameter threading | 1 pass |
+
+---
+
+## Before / After Summary
+
+### Command Count
+
+| Metric | Before | After | Delta |
+|--------|--------|-------|-------|
+| Visible top-level commands | 29 | 21 | -8 (-28%) |
+| Hidden commands (functional) | 4 | 12 | +8 (absorbed) |
+| Stub/unimplemented commands | 2 | 2 | 0 |
+| Total functional commands | 33 | 33 | 0 (nothing lost) |
+
+### `lore --help` Output
+
+**Before (29 commands, flat list, ~50 lines of commands):**
+```
+Commands:
+  issues         List or show issues [aliases: issue]
+  mrs            List or show merge requests [aliases: mr]
+  notes          List notes from discussions [aliases: note]
+  ingest         Ingest data from GitLab
+  count          Count entities in local database
+  status         Show sync state [aliases: st]
+  auth           Verify GitLab authentication
+  doctor         Check environment health
+  version        Show version information
+  init           Initialize configuration and database
+  search         Search indexed documents [aliases: find]
+  stats          Show document and index statistics [aliases: stat]
+  generate-docs  Generate searchable documents from ingested data
+  embed          Generate vector embeddings for documents via Ollama
+  sync           Run full sync pipeline: ingest -> generate-docs -> embed
+  migrate        Run pending database migrations
+  health         Quick health check: config, database, schema version
+  robot-docs     Machine-readable command manifest for agent self-discovery
+  completions    Generate shell completions
+  timeline       Show a chronological timeline of events matching a query
+  who            People intelligence: experts, workload, active discussions, overlap
+  me             Personal work dashboard: open issues, authored/reviewing MRs, activity
+  file-history   Show MRs that touched a file, with linked discussions
+  trace          Trace why code was introduced: file -> MR -> issue -> discussion
+  drift          Detect discussion divergence from original intent
+  related        Find semantically related entities via vector search
+  cron           Manage cron-based automatic syncing
+  token          Manage stored GitLab token
+  help           Print this message or the help of the given subcommand(s)
+```
+
+**After (21 commands, grouped, ~35 lines of commands):**
+```
+Query:
+  issues      List or show issues [aliases: issue]
+  mrs         List or show merge requests [aliases: mr]
+  notes       List notes from discussions [aliases: note]
+  search      Search indexed documents [aliases: find]
+
+Intelligence:
+  timeline    Chronological timeline of events
+  who         People intelligence: experts, workload, overlap
+  me          Personal work dashboard
+
+File Analysis:
+  trace       Trace code provenance / file history
+  related     Find semantically related entities
+  drift       Detect discussion divergence
+
+Data Pipeline:
+  sync        Run full sync pipeline
+
+System:
+  init        Initialize configuration and database
+  status      Show sync state [aliases: st]
+  doctor      Check environment health (--quick for pre-flight)
+  index       Document and index statistics [aliases: idx]
+  auth        Verify GitLab authentication
+  token       Manage stored GitLab token
+  migrate     Run pending database migrations
+  cron        Manage automatic syncing
+  robot-docs  Agent self-discovery manifest
+  completions Generate shell completions
+  version     Show version information
+```
+
+### Flag Consistency
+
+| Issue | Before | After |
+|-------|--------|-------|
+| `-f` collision (force vs for) | `ingest -f`=force, `count -f`=for | `-f` removed from count; `-f` = force everywhere |
+| Singular/plural entity types | `count issues` but `search --type issue` | Both forms accepted everywhere |
+| `notes --open` missing `-o` | `notes --open` (no shorthand) | `notes -o` works (matches issues/mrs) |
+| `search` missing `--sort` | No sort override | `--sort score\|created\|updated` + `--asc` |
+
+### Naming Confusion
+
+| Before | After | Resolution |
+|--------|-------|------------|
+| `status` vs `stats` vs `stat` (3 names, 2 commands) | `status` + `index` (2 names, 2 commands) | Eliminated near-homonym collision |
+| `health` vs `doctor` (2 commands, overlapping scope) | `doctor` + `doctor --quick` (1 command) | Progressive disclosure |
+| `trace` vs `file-history` (2 commands, overlapping function) | `trace` + `trace --mrs-only` (1 command) | Superset absorbs subset |
+
+### Robot Ergonomics
+
+| Metric | Before | After |
+|--------|--------|-------|
+| Commands in robot-docs manifest | 29 | 21 visible + hidden section |
+| Agent decision space for "system check" | 4 commands | 2 commands (status, doctor) |
+| Agent decision space for "file query" | 3 commands + 2 who modes | 1 command (trace) + 2 who modes |
+| Entity type parse errors from singular/plural | Common | Eliminated |
+| Estimated token cost of robot-docs | Baseline | ~15% reduction (fewer entries, hidden flagged) |
+
+### What Stays Exactly The Same
+
+- All 33 functional commands remain callable (nothing is removed)
+- All existing flags and their behavior are preserved
+- All response schemas are unchanged
+- All exit codes are unchanged
+- The autocorrect system continues to work
+- All hidden/deprecated commands emit their existing warnings
+
+### What Breaks (Intentional)
+
+- `lore count -f mr` (the `-f` shorthand) -- must use `--for` instead
+- `lore --help` layout changes (commands are grouped, 8 commands hidden)
+- `lore robot-docs` output changes (new `hidden` field, renamed keys)
+- Any scripts parsing `--help` text (but `robot-docs` is the stable contract)

crates/lore-tui/Cargo.toml

@@ -1,46 +0,0 @@
-[package]
-name = "lore-tui"
-version = "0.1.0"
-edition = "2024"
-description = "Terminal UI for Gitlore — local GitLab data explorer"
-authors = ["Taylor Eernisse"]
-license = "MIT"
-
-[[bin]]
-name = "lore-tui"
-path = "src/main.rs"
-
-[dependencies]
-# FrankenTUI (Elm-architecture TUI framework)
-ftui = "0.1.1"
-
-# Lore library (config, db, ingestion, search, etc.)
-lore = { path = "../.." }
-
-# CLI
-clap = { version = "4", features = ["derive", "env"] }
-
-# Error handling
-anyhow = "1"
-
-# Time
-chrono = { version = "0.4", features = ["serde"] }
-
-# Paths
-dirs = "6"
-
-# Database (read-only queries from TUI)
-rusqlite = { version = "0.38", features = ["bundled"] }
-
-# Terminal (crossterm for raw mode + event reading, used by ftui runtime)
-crossterm = "0.28"
-
-# Serialization (crash context NDJSON dumps)
-serde = { version = "1", features = ["derive"] }
-serde_json = "1"
-
-# Regex (used by safety module for PII/secret redaction)
-regex = "1"
-
-[dev-dependencies]
-tempfile = "3"

crates/lore-tui/rust-toolchain.toml

@@ -1,4 +0,0 @@
-[toolchain]
-channel = "nightly-2026-02-08"
-profile = "minimal"
-components = ["rustfmt", "clippy"]

crates/lore-tui/src/app.rs

@@ -1,712 +0,0 @@
-#![allow(dead_code)] // Phase 1: methods consumed as screens are implemented
-
-//! Full FrankenTUI Model implementation for the lore TUI.
-//!
-//! LoreApp is the central coordinator: it owns all state, dispatches
-//! messages through a 5-stage key pipeline, records crash context
-//! breadcrumbs, manages async tasks via the supervisor, and routes
-//! view() to per-screen render functions.
-
-use chrono::TimeDelta;
-use ftui::{Cmd, Event, Frame, KeyCode, KeyEvent, Model, Modifiers};
-
-use crate::clock::{Clock, SystemClock};
-use crate::commands::{CommandRegistry, build_registry};
-use crate::crash_context::{CrashContext, CrashEvent};
-use crate::db::DbManager;
-use crate::message::{InputMode, Msg, Screen};
-use crate::navigation::NavigationStack;
-use crate::state::{AppState, LoadState};
-use crate::task_supervisor::{TaskKey, TaskSupervisor};
-
-/// Timeout for the g-prefix key sequence.
-const GO_PREFIX_TIMEOUT: TimeDelta = TimeDelta::milliseconds(500);
-
-// ---------------------------------------------------------------------------
-// LoreApp
-// ---------------------------------------------------------------------------
-
-/// Root model for the lore TUI.
-///
-/// Owns all state and implements the FrankenTUI Model trait. The
-/// update() method is the single entry point for all state transitions.
-pub struct LoreApp {
-    pub state: AppState,
-    pub navigation: NavigationStack,
-    pub supervisor: TaskSupervisor,
-    pub crash_context: CrashContext,
-    pub command_registry: CommandRegistry,
-    pub input_mode: InputMode,
-    pub clock: Box<dyn Clock>,
-    pub db: Option<DbManager>,
-}
-
-impl LoreApp {
-    /// Create a new LoreApp with default state.
-    ///
-    /// Uses a real system clock and no DB connection (set separately).
-    #[must_use]
-    pub fn new() -> Self {
-        Self {
-            state: AppState::default(),
-            navigation: NavigationStack::new(),
-            supervisor: TaskSupervisor::new(),
-            crash_context: CrashContext::new(),
-            command_registry: build_registry(),
-            input_mode: InputMode::Normal,
-            clock: Box::new(SystemClock),
-            db: None,
-        }
-    }
-
-    /// Create a LoreApp for testing with a custom clock.
-    #[cfg(test)]
-    fn with_clock(clock: Box<dyn Clock>) -> Self {
-        Self {
-            clock,
-            ..Self::new()
-        }
-    }
-
-    // -----------------------------------------------------------------------
-    // Key dispatch
-    // -----------------------------------------------------------------------
-
-    /// Normalize terminal key variants for cross-terminal consistency.
-    fn normalize_key(key: &mut KeyEvent) {
-        // BackTab -> Shift+Tab canonical form.
-        if key.code == KeyCode::BackTab {
-            key.code = KeyCode::Tab;
-            key.modifiers |= Modifiers::SHIFT;
-        }
-    }
-
-    /// 5-stage key dispatch pipeline.
-    ///
-    /// Returns the Cmd to execute (Quit, None, or a task command).
-    fn interpret_key(&mut self, mut key: KeyEvent) -> Cmd<Msg> {
-        Self::normalize_key(&mut key);
-
-        let screen = self.navigation.current().clone();
-
-        // Record key press in crash context.
-        self.crash_context.push(CrashEvent::KeyPress {
-            key: format!("{:?}", key.code),
-            mode: format!("{:?}", self.input_mode),
-            screen: screen.label().to_string(),
-        });
-
-        // --- Stage 1: Quit check ---
-        // Ctrl+C always quits regardless of mode.
-        if key.code == KeyCode::Char('c') && key.modifiers.contains(Modifiers::CTRL) {
-            return Cmd::quit();
-        }
-
-        // --- Stage 2: InputMode routing ---
-        match &self.input_mode {
-            InputMode::Text => {
-                return self.handle_text_mode_key(&key, &screen);
-            }
-            InputMode::Palette => {
-                return self.handle_palette_mode_key(&key, &screen);
-            }
-            InputMode::GoPrefix { started_at } => {
-                let elapsed = self.clock.now().signed_duration_since(*started_at);
-                if elapsed > GO_PREFIX_TIMEOUT {
-                    // Timeout expired — cancel prefix and re-process as normal.
-                    self.input_mode = InputMode::Normal;
-                } else {
-                    return self.handle_go_prefix_key(&key, &screen);
-                }
-            }
-            InputMode::Normal => {}
-        }
-
-        // --- Stage 3: Global shortcuts (Normal mode) ---
-        // 'q' quits.
-        if key.code == KeyCode::Char('q') && key.modifiers == Modifiers::NONE {
-            return Cmd::quit();
-        }
-
-        // 'g' starts prefix sequence.
-        if self
-            .command_registry
-            .is_sequence_starter(&key.code, &key.modifiers)
-        {
-            self.input_mode = InputMode::GoPrefix {
-                started_at: self.clock.now(),
-            };
-            return Cmd::none();
-        }
-
-        // Registry-based single-key lookup.
-        if let Some(cmd_def) =
-            self.command_registry
-                .lookup_key(&key.code, &key.modifiers, &screen, &self.input_mode)
-        {
-            return self.execute_command(cmd_def.id, &screen);
-        }
-
-        // --- Stage 4: Screen-local keys ---
-        // Delegated to AppState::interpret_screen_key in future phases.
-
-        // --- Stage 5: Fallback (unhandled) ---
-        Cmd::none()
-    }
-
-    /// Handle keys in Text input mode.
-    ///
-    /// Only Esc and Ctrl+P pass through; everything else is consumed by
-    /// the focused text widget (handled in future phases).
-    fn handle_text_mode_key(&mut self, key: &KeyEvent, screen: &Screen) -> Cmd<Msg> {
-        // Esc blurs the text input.
-        if key.code == KeyCode::Escape {
-            self.state.blur_text_focus();
-            self.input_mode = InputMode::Normal;
-            return Cmd::none();
-        }
-
-        // Ctrl+P opens palette even in text mode.
-        if let Some(cmd_def) =
-            self.command_registry
-                .lookup_key(&key.code, &key.modifiers, screen, &InputMode::Text)
-        {
-            return self.execute_command(cmd_def.id, screen);
-        }
-
-        // All other keys consumed by text widget (future).
-        Cmd::none()
-    }
-
-    /// Handle keys in Palette mode.
-    fn handle_palette_mode_key(&mut self, key: &KeyEvent, _screen: &Screen) -> Cmd<Msg> {
-        if key.code == KeyCode::Escape {
-            self.input_mode = InputMode::Normal;
-            return Cmd::none();
-        }
-        // Palette key dispatch will be expanded in the palette widget phase.
-        Cmd::none()
-    }
-
-    /// Handle the second key of a g-prefix sequence.
-    fn handle_go_prefix_key(&mut self, key: &KeyEvent, screen: &Screen) -> Cmd<Msg> {
-        self.input_mode = InputMode::Normal;
-
-        if let Some(cmd_def) = self.command_registry.complete_sequence(
-            &KeyCode::Char('g'),
-            &Modifiers::NONE,
-            &key.code,
-            &key.modifiers,
-            screen,
-        ) {
-            return self.execute_command(cmd_def.id, screen);
-        }
-
-        // Invalid second key — cancel prefix silently.
-        Cmd::none()
-    }
-
-    /// Execute a command by ID.
-    fn execute_command(&mut self, id: &str, _screen: &Screen) -> Cmd<Msg> {
-        match id {
-            "quit" => Cmd::quit(),
-            "go_back" => {
-                self.navigation.pop();
-                Cmd::none()
-            }
-            "show_help" => {
-                self.state.show_help = !self.state.show_help;
-                Cmd::none()
-            }
-            "command_palette" => {
-                self.input_mode = InputMode::Palette;
-                self.state.command_palette.query_focused = true;
-                Cmd::none()
-            }
-            "open_in_browser" => {
-                // Will dispatch OpenInBrowser msg in future phase.
-                Cmd::none()
-            }
-            "show_cli" => {
-                // Will show CLI equivalent in future phase.
-                Cmd::none()
-            }
-            "go_home" => self.navigate_to(Screen::Dashboard),
-            "go_issues" => self.navigate_to(Screen::IssueList),
-            "go_mrs" => self.navigate_to(Screen::MrList),
-            "go_search" => self.navigate_to(Screen::Search),
-            "go_timeline" => self.navigate_to(Screen::Timeline),
-            "go_who" => self.navigate_to(Screen::Who),
-            "go_sync" => self.navigate_to(Screen::Sync),
-            "jump_back" => {
-                self.navigation.jump_back();
-                Cmd::none()
-            }
-            "jump_forward" => {
-                self.navigation.jump_forward();
-                Cmd::none()
-            }
-            "move_down" | "move_up" | "select_item" | "focus_filter" | "scroll_to_top" => {
-                // Screen-specific actions — delegated in future phases.
-                Cmd::none()
-            }
-            _ => Cmd::none(),
-        }
-    }
-
-    // -----------------------------------------------------------------------
-    // Navigation helpers
-    // -----------------------------------------------------------------------
-
-    /// Navigate to a screen, pushing the nav stack and starting a data load.
-    fn navigate_to(&mut self, screen: Screen) -> Cmd<Msg> {
-        let screen_label = screen.label().to_string();
-        let current_label = self.navigation.current().label().to_string();
-
-        self.crash_context.push(CrashEvent::StateTransition {
-            from: current_label,
-            to: screen_label,
-        });
-
-        self.navigation.push(screen.clone());
-        self.state
-            .set_loading(screen.clone(), LoadState::Refreshing);
-
-        // Spawn supervised task for data loading (placeholder — actual DB
-        // query dispatch comes in Phase 2 screen implementations).
-        let _handle = self.supervisor.submit(TaskKey::LoadScreen(screen));
-
-        Cmd::none()
-    }
-
-    // -----------------------------------------------------------------------
-    // Message dispatch (non-key)
-    // -----------------------------------------------------------------------
-
-    /// Handle non-key messages.
-    fn handle_msg(&mut self, msg: Msg) -> Cmd<Msg> {
-        // Record in crash context.
-        self.crash_context.push(CrashEvent::MsgDispatched {
-            msg_name: format!("{msg:?}")
-                .split('(')
-                .next()
-                .unwrap_or("?")
-                .to_string(),
-            screen: self.navigation.current().label().to_string(),
-        });
-
-        match msg {
-            Msg::Quit => Cmd::quit(),
-
-            // --- Navigation ---
-            Msg::NavigateTo(screen) => self.navigate_to(screen),
-            Msg::GoBack => {
-                self.navigation.pop();
-                Cmd::none()
-            }
-            Msg::GoForward => {
-                self.navigation.go_forward();
-                Cmd::none()
-            }
-            Msg::GoHome => self.navigate_to(Screen::Dashboard),
-            Msg::JumpBack(_) => {
-                self.navigation.jump_back();
-                Cmd::none()
-            }
-            Msg::JumpForward(_) => {
-                self.navigation.jump_forward();
-                Cmd::none()
-            }
-
-            // --- Error ---
-            Msg::Error(err) => {
-                self.state.set_error(err.to_string());
-                Cmd::none()
-            }
-
-            // --- Help / UI ---
-            Msg::ShowHelp => {
-                self.state.show_help = !self.state.show_help;
-                Cmd::none()
-            }
-            Msg::BlurTextInput => {
-                self.state.blur_text_focus();
-                self.input_mode = InputMode::Normal;
-                Cmd::none()
-            }
-
-            // --- Terminal ---
-            Msg::Resize { width, height } => {
-                self.state.terminal_size = (width, height);
-                Cmd::none()
-            }
-            Msg::Tick => Cmd::none(),
-
-            // --- Loaded results (stale guard) ---
-            Msg::IssueListLoaded { generation, rows } => {
-                if self
-                    .supervisor
-                    .is_current(&TaskKey::LoadScreen(Screen::IssueList), generation)
-                {
-                    self.state.issue_list.rows = rows;
-                    self.state.set_loading(Screen::IssueList, LoadState::Idle);
-                    self.supervisor
-                        .complete(&TaskKey::LoadScreen(Screen::IssueList), generation);
-                }
-                Cmd::none()
-            }
-            Msg::MrListLoaded { generation, rows } => {
-                if self
-                    .supervisor
-                    .is_current(&TaskKey::LoadScreen(Screen::MrList), generation)
-                {
-                    self.state.mr_list.rows = rows;
-                    self.state.set_loading(Screen::MrList, LoadState::Idle);
-                    self.supervisor
-                        .complete(&TaskKey::LoadScreen(Screen::MrList), generation);
-                }
-                Cmd::none()
-            }
-            Msg::DashboardLoaded { generation, data } => {
-                if self
-                    .supervisor
-                    .is_current(&TaskKey::LoadScreen(Screen::Dashboard), generation)
-                {
-                    self.state.dashboard.issue_count = data.issue_count;
-                    self.state.dashboard.mr_count = data.mr_count;
-                    self.state.set_loading(Screen::Dashboard, LoadState::Idle);
-                    self.supervisor
-                        .complete(&TaskKey::LoadScreen(Screen::Dashboard), generation);
-                }
-                Cmd::none()
-            }
-
-            // All other message variants: no-op for now.
-            // Future phases will fill these in as screens are implemented.
-            _ => Cmd::none(),
-        }
-    }
-}
-
-impl Default for LoreApp {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
-impl Model for LoreApp {
-    type Message = Msg;
-
-    fn init(&mut self) -> Cmd<Self::Message> {
-        // Install crash context panic hook.
-        CrashContext::install_panic_hook(&self.crash_context);
-        CrashContext::prune_crash_files();
-
-        // Navigate to dashboard (will trigger data load in future phase).
-        Cmd::none()
-    }
-
-    fn update(&mut self, msg: Self::Message) -> Cmd<Self::Message> {
-        // Route raw key events through the 5-stage pipeline.
-        if let Msg::RawEvent(Event::Key(key)) = msg {
-            return self.interpret_key(key);
-        }
-
-        // Everything else goes through message dispatch.
-        self.handle_msg(msg)
-    }
-
-    fn view(&self, frame: &mut Frame) {
-        crate::view::render_screen(frame, self);
-    }
-}
-
-/// Verify that `App::fullscreen(LoreApp::new()).run()` compiles.
-#[cfg(test)]
-fn _assert_app_fullscreen_compiles() {
-    fn _inner() {
-        use ftui::App;
-        let _app_builder = App::fullscreen(LoreApp::new());
-    }
-}
-
-/// Verify that `App::inline(LoreApp::new(), 12).run()` compiles.
-#[cfg(test)]
-fn _assert_app_inline_compiles() {
-    fn _inner() {
-        use ftui::App;
-        let _app_builder = App::inline(LoreApp::new(), 12);
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::clock::FakeClock;
-
-    fn test_app() -> LoreApp {
-        LoreApp::with_clock(Box::new(FakeClock::new(chrono::Utc::now())))
-    }
-
-    #[test]
-    fn test_lore_app_init_returns_none() {
-        let mut app = test_app();
-        let cmd = app.init();
-        assert!(matches!(cmd, Cmd::None));
-    }
-
-    #[test]
-    fn test_lore_app_quit_returns_quit_cmd() {
-        let mut app = test_app();
-        let cmd = app.update(Msg::Quit);
-        assert!(matches!(cmd, Cmd::Quit));
-    }
-
-    #[test]
-    fn test_lore_app_tick_returns_none() {
-        let mut app = test_app();
-        let cmd = app.update(Msg::Tick);
-        assert!(matches!(cmd, Cmd::None));
-    }
-
-    #[test]
-    fn test_lore_app_navigate_to_updates_nav_stack() {
-        let mut app = test_app();
-        let cmd = app.update(Msg::NavigateTo(Screen::IssueList));
-        assert!(matches!(cmd, Cmd::None));
-        assert!(app.navigation.is_at(&Screen::IssueList));
-        assert_eq!(app.navigation.depth(), 2);
-    }
-
-    #[test]
-    fn test_lore_app_go_back() {
-        let mut app = test_app();
-        app.update(Msg::NavigateTo(Screen::IssueList));
-        app.update(Msg::GoBack);
-        assert!(app.navigation.is_at(&Screen::Dashboard));
-    }
-
-    #[test]
-    fn test_lore_app_go_forward() {
-        let mut app = test_app();
-        app.update(Msg::NavigateTo(Screen::IssueList));
-        app.update(Msg::GoBack);
-        app.update(Msg::GoForward);
-        assert!(app.navigation.is_at(&Screen::IssueList));
-    }
-
-    #[test]
-    fn test_ctrl_c_always_quits() {
-        let mut app = test_app();
-        let key = KeyEvent::new(KeyCode::Char('c')).with_modifiers(Modifiers::CTRL);
-        let cmd = app.update(Msg::RawEvent(Event::Key(key)));
-        assert!(matches!(cmd, Cmd::Quit));
-    }
-
-    #[test]
-    fn test_q_key_quits_in_normal_mode() {
-        let mut app = test_app();
-        let key = KeyEvent::new(KeyCode::Char('q'));
-        let cmd = app.update(Msg::RawEvent(Event::Key(key)));
-        assert!(matches!(cmd, Cmd::Quit));
-    }
-
-    #[test]
-    fn test_q_key_blocked_in_text_mode() {
-        let mut app = test_app();
-        app.input_mode = InputMode::Text;
-        let key = KeyEvent::new(KeyCode::Char('q'));
-        let cmd = app.update(Msg::RawEvent(Event::Key(key)));
-        // q in text mode should NOT quit.
-        assert!(matches!(cmd, Cmd::None));
-    }
-
-    #[test]
-    fn test_esc_blurs_text_mode() {
-        let mut app = test_app();
-        app.input_mode = InputMode::Text;
-        app.state.search.query_focused = true;
-
-        let key = KeyEvent::new(KeyCode::Escape);
-        app.update(Msg::RawEvent(Event::Key(key)));
-
-        assert!(matches!(app.input_mode, InputMode::Normal));
-        assert!(!app.state.has_text_focus());
-    }
-
-    #[test]
-    fn test_g_prefix_enters_go_mode() {
-        let mut app = test_app();
-        let key = KeyEvent::new(KeyCode::Char('g'));
-        app.update(Msg::RawEvent(Event::Key(key)));
-        assert!(matches!(app.input_mode, InputMode::GoPrefix { .. }));
-    }
-
-    #[test]
-    fn test_g_then_i_navigates_to_issues() {
-        let mut app = test_app();
-
-        // First key: 'g'
-        let key_g = KeyEvent::new(KeyCode::Char('g'));
-        app.update(Msg::RawEvent(Event::Key(key_g)));
-
-        // Second key: 'i'
-        let key_i = KeyEvent::new(KeyCode::Char('i'));
-        app.update(Msg::RawEvent(Event::Key(key_i)));
-
-        assert!(app.navigation.is_at(&Screen::IssueList));
-    }
-
-    #[test]
-    fn test_go_prefix_timeout_cancels() {
-        let clock = FakeClock::new(chrono::Utc::now());
-        let mut app = LoreApp::with_clock(Box::new(clock.clone()));
-
-        // Press 'g'.
-        let key_g = KeyEvent::new(KeyCode::Char('g'));
-        app.update(Msg::RawEvent(Event::Key(key_g)));
-        assert!(matches!(app.input_mode, InputMode::GoPrefix { .. }));
-
-        // Advance clock past timeout.
-        clock.advance(TimeDelta::milliseconds(600));
-
-        // Press 'i' after timeout — should NOT navigate to issues.
-        let key_i = KeyEvent::new(KeyCode::Char('i'));
-        app.update(Msg::RawEvent(Event::Key(key_i)));
-
-        // Should still be at Dashboard (no navigation happened).
-        assert!(app.navigation.is_at(&Screen::Dashboard));
-        assert!(matches!(app.input_mode, InputMode::Normal));
-    }
-
-    #[test]
-    fn test_show_help_toggles() {
-        let mut app = test_app();
-        assert!(!app.state.show_help);
-
-        app.update(Msg::ShowHelp);
-        assert!(app.state.show_help);
-
-        app.update(Msg::ShowHelp);
-        assert!(!app.state.show_help);
-    }
-
-    #[test]
-    fn test_error_msg_sets_toast() {
-        let mut app = test_app();
-        app.update(Msg::Error(crate::message::AppError::DbBusy));
-        assert!(app.state.error_toast.is_some());
-        assert!(app.state.error_toast.as_ref().unwrap().contains("busy"));
-    }
-
-    #[test]
-    fn test_resize_updates_terminal_size() {
-        let mut app = test_app();
-        app.update(Msg::Resize {
-            width: 120,
-            height: 40,
-        });
-        assert_eq!(app.state.terminal_size, (120, 40));
-    }
-
-    #[test]
-    fn test_stale_result_dropped() {
-        let mut app = test_app();
-
-        // Submit two tasks for IssueList — second supersedes first.
-        let gen1 = app
-            .supervisor
-            .submit(TaskKey::LoadScreen(Screen::IssueList))
-            .generation;
-        let gen2 = app
-            .supervisor
-            .submit(TaskKey::LoadScreen(Screen::IssueList))
-            .generation;
-
-        // Stale result with gen1 should be ignored.
-        app.update(Msg::IssueListLoaded {
-            generation: gen1,
-            rows: vec![crate::message::IssueRow {
-                key: crate::message::EntityKey::issue(1, 1),
-                title: "stale".into(),
-                state: "opened".into(),
-            }],
-        });
-        assert!(app.state.issue_list.rows.is_empty());
-
-        // Current result with gen2 should be applied.
-        app.update(Msg::IssueListLoaded {
-            generation: gen2,
-            rows: vec![crate::message::IssueRow {
-                key: crate::message::EntityKey::issue(1, 2),
-                title: "fresh".into(),
-                state: "opened".into(),
-            }],
-        });
-        assert_eq!(app.state.issue_list.rows.len(), 1);
-        assert_eq!(app.state.issue_list.rows[0].title, "fresh");
-    }
-
-    #[test]
-    fn test_crash_context_records_events() {
-        let mut app = test_app();
-        app.update(Msg::Tick);
-        app.update(Msg::NavigateTo(Screen::IssueList));
-
-        // Should have recorded at least 2 events.
-        assert!(app.crash_context.len() >= 2);
-    }
-
-    #[test]
-    fn test_navigate_sets_loading_state() {
-        let mut app = test_app();
-        app.update(Msg::NavigateTo(Screen::IssueList));
-        assert_eq!(
-            *app.state.load_state.get(&Screen::IssueList),
-            LoadState::Refreshing
-        );
-    }
-
-    #[test]
-    fn test_command_palette_opens_from_ctrl_p() {
-        let mut app = test_app();
-        let key = KeyEvent::new(KeyCode::Char('p')).with_modifiers(Modifiers::CTRL);
-        app.update(Msg::RawEvent(Event::Key(key)));
-        assert!(matches!(app.input_mode, InputMode::Palette));
-        assert!(app.state.command_palette.query_focused);
-    }
-
-    #[test]
-    fn test_esc_closes_palette() {
-        let mut app = test_app();
-        app.input_mode = InputMode::Palette;
-
-        let key = KeyEvent::new(KeyCode::Escape);
-        app.update(Msg::RawEvent(Event::Key(key)));
-
-        assert!(matches!(app.input_mode, InputMode::Normal));
-    }
-
-    #[test]
-    fn test_blur_text_input_msg() {
-        let mut app = test_app();
-        app.input_mode = InputMode::Text;
-        app.state.search.query_focused = true;
-
-        app.update(Msg::BlurTextInput);
-
-        assert!(matches!(app.input_mode, InputMode::Normal));
-        assert!(!app.state.has_text_focus());
-    }
-
-    #[test]
-    fn test_default_is_new() {
-        let app = LoreApp::default();
-        assert!(app.navigation.is_at(&Screen::Dashboard));
-        assert!(matches!(app.input_mode, InputMode::Normal));
-    }
-}

crates/lore-tui/src/clock.rs

@@ -1,151 +0,0 @@
-//! Injected clock for deterministic time in tests and consistent frame timestamps.
-//!
-//! All relative-time rendering (e.g., "3h ago") uses [`Clock::now()`] rather
-//! than wall-clock time directly. This enables:
-//! - Deterministic snapshot tests via [`FakeClock`]
-//! - Consistent timestamps within a single frame render pass
-
-use std::sync::{Arc, Mutex};
-
-use chrono::{DateTime, TimeDelta, Utc};
-
-/// Trait for obtaining the current time.
-///
-/// Inject via `Arc<dyn Clock>` to allow swapping between real and fake clocks.
-pub trait Clock: Send + Sync {
-    /// Returns the current time.
-    fn now(&self) -> DateTime<Utc>;
-}
-
-// ---------------------------------------------------------------------------
-// SystemClock
-// ---------------------------------------------------------------------------
-
-/// Real wall-clock time via `chrono::Utc::now()`.
-#[derive(Debug, Clone, Copy)]
-pub struct SystemClock;
-
-impl Clock for SystemClock {
-    fn now(&self) -> DateTime<Utc> {
-        Utc::now()
-    }
-}
-
-// ---------------------------------------------------------------------------
-// FakeClock
-// ---------------------------------------------------------------------------
-
-/// A controllable clock for tests. Returns a frozen time that can be
-/// advanced or set explicitly.
-///
-/// `FakeClock` is `Clone` (shares the inner `Arc`) and `Send + Sync`
-/// for use across `Cmd::task` threads.
-#[derive(Debug, Clone)]
-pub struct FakeClock {
-    inner: Arc<Mutex<DateTime<Utc>>>,
-}
-
-impl FakeClock {
-    /// Create a fake clock frozen at the given time.
-    #[must_use]
-    pub fn new(time: DateTime<Utc>) -> Self {
-        Self {
-            inner: Arc::new(Mutex::new(time)),
-        }
-    }
-
-    /// Advance the clock by `duration`. Uses `checked_add` to handle overflow
-    /// gracefully — if the addition would overflow, the time is not changed.
-    pub fn advance(&self, duration: TimeDelta) {
-        let mut guard = self.inner.lock().expect("FakeClock mutex poisoned");
-        if let Some(advanced) = guard.checked_add_signed(duration) {
-            *guard = advanced;
-        }
-    }
-
-    /// Set the clock to an exact time.
-    pub fn set(&self, time: DateTime<Utc>) {
-        let mut guard = self.inner.lock().expect("FakeClock mutex poisoned");
-        *guard = time;
-    }
-}
-
-impl Clock for FakeClock {
-    fn now(&self) -> DateTime<Utc> {
-        *self.inner.lock().expect("FakeClock mutex poisoned")
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use chrono::TimeZone;
-
-    fn fixed_time() -> DateTime<Utc> {
-        Utc.with_ymd_and_hms(2026, 2, 12, 12, 0, 0).unwrap()
-    }
-
-    #[test]
-    fn test_fake_clock_frozen() {
-        let clock = FakeClock::new(fixed_time());
-        let t1 = clock.now();
-        let t2 = clock.now();
-        assert_eq!(t1, t2);
-        assert_eq!(t1, fixed_time());
-    }
-
-    #[test]
-    fn test_fake_clock_advance() {
-        let clock = FakeClock::new(fixed_time());
-        clock.advance(TimeDelta::hours(3));
-        let expected = Utc.with_ymd_and_hms(2026, 2, 12, 15, 0, 0).unwrap();
-        assert_eq!(clock.now(), expected);
-    }
-
-    #[test]
-    fn test_fake_clock_set() {
-        let clock = FakeClock::new(fixed_time());
-        let new_time = Utc.with_ymd_and_hms(2030, 1, 1, 0, 0, 0).unwrap();
-        clock.set(new_time);
-        assert_eq!(clock.now(), new_time);
-    }
-
-    #[test]
-    fn test_fake_clock_clone_shares_state() {
-        let clock1 = FakeClock::new(fixed_time());
-        let clock2 = clock1.clone();
-        clock1.advance(TimeDelta::minutes(30));
-        // Both clones see the advanced time.
-        assert_eq!(clock1.now(), clock2.now());
-    }
-
-    #[test]
-    fn test_system_clock_returns_reasonable_time() {
-        let clock = SystemClock;
-        let now = clock.now();
-        // Sanity: time should be after 2025.
-        assert!(now.year() >= 2025);
-    }
-
-    #[test]
-    fn test_fake_clock_is_send_sync() {
-        fn assert_send_sync<T: Send + Sync>() {}
-        assert_send_sync::<FakeClock>();
-        assert_send_sync::<SystemClock>();
-    }
-
-    #[test]
-    fn test_clock_trait_object_works() {
-        let fake: Arc<dyn Clock> = Arc::new(FakeClock::new(fixed_time()));
-        assert_eq!(fake.now(), fixed_time());
-
-        let real: Arc<dyn Clock> = Arc::new(SystemClock);
-        let _ = real.now(); // Just verify it doesn't panic.
-    }
-
-    use chrono::Datelike;
-}

crates/lore-tui/src/commands.rs

@@ -1,807 +0,0 @@
-#![allow(dead_code)] // Phase 1: consumed by LoreApp in bd-6pmy
-
-//! Command registry — single source of truth for all TUI actions.
-//!
-//! Every keybinding, palette entry, help text, CLI equivalent, and
-//! status hint is generated from [`CommandRegistry`]. No hardcoded
-//! duplicate maps exist in view/state modules.
-//!
-//! Supports single-key and two-key sequences (g-prefix vim bindings).
-
-use std::collections::HashMap;
-
-use ftui::{KeyCode, Modifiers};
-
-use crate::message::{InputMode, Screen};
-
-// ---------------------------------------------------------------------------
-// Key formatting
-// ---------------------------------------------------------------------------
-
-/// Format a key code + modifiers as a human-readable string.
-fn format_key(code: KeyCode, modifiers: Modifiers) -> String {
-    let mut parts = Vec::new();
-    if modifiers.contains(Modifiers::CTRL) {
-        parts.push("Ctrl");
-    }
-    if modifiers.contains(Modifiers::ALT) {
-        parts.push("Alt");
-    }
-    if modifiers.contains(Modifiers::SHIFT) {
-        parts.push("Shift");
-    }
-    let key_name = match code {
-        KeyCode::Char(c) => c.to_string(),
-        KeyCode::Enter => "Enter".to_string(),
-        KeyCode::Escape => "Esc".to_string(),
-        KeyCode::Tab => "Tab".to_string(),
-        KeyCode::Backspace => "Backspace".to_string(),
-        KeyCode::Delete => "Del".to_string(),
-        KeyCode::Up => "Up".to_string(),
-        KeyCode::Down => "Down".to_string(),
-        KeyCode::Left => "Left".to_string(),
-        KeyCode::Right => "Right".to_string(),
-        KeyCode::Home => "Home".to_string(),
-        KeyCode::End => "End".to_string(),
-        KeyCode::PageUp => "PgUp".to_string(),
-        KeyCode::PageDown => "PgDn".to_string(),
-        KeyCode::F(n) => format!("F{n}"),
-        _ => "?".to_string(),
-    };
-    parts.push(&key_name);
-    // We need to own the joined string.
-    let joined: String = parts.join("+");
-    joined
-}
-
-// ---------------------------------------------------------------------------
-// KeyCombo
-// ---------------------------------------------------------------------------
-
-/// A keybinding: either a single key or a two-key sequence.
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
-pub enum KeyCombo {
-    /// Single key press (e.g., `q`, `Esc`, `Ctrl+P`).
-    Single { code: KeyCode, modifiers: Modifiers },
-    /// Two-key sequence (e.g., `g` then `i` for go-to-issues).
-    Sequence {
-        first_code: KeyCode,
-        first_modifiers: Modifiers,
-        second_code: KeyCode,
-        second_modifiers: Modifiers,
-    },
-}
-
-impl KeyCombo {
-    /// Convenience: single key with no modifiers.
-    #[must_use]
-    pub const fn key(code: KeyCode) -> Self {
-        Self::Single {
-            code,
-            modifiers: Modifiers::NONE,
-        }
-    }
-
-    /// Convenience: single key with Ctrl modifier.
-    #[must_use]
-    pub const fn ctrl(code: KeyCode) -> Self {
-        Self::Single {
-            code,
-            modifiers: Modifiers::CTRL,
-        }
-    }
-
-    /// Convenience: g-prefix sequence (g + char).
-    #[must_use]
-    pub const fn g_then(c: char) -> Self {
-        Self::Sequence {
-            first_code: KeyCode::Char('g'),
-            first_modifiers: Modifiers::NONE,
-            second_code: KeyCode::Char(c),
-            second_modifiers: Modifiers::NONE,
-        }
-    }
-
-    /// Human-readable display string for this key combo.
-    #[must_use]
-    pub fn display(&self) -> String {
-        match self {
-            Self::Single { code, modifiers } => format_key(*code, *modifiers),
-            Self::Sequence {
-                first_code,
-                first_modifiers,
-                second_code,
-                second_modifiers,
-            } => {
-                let first = format_key(*first_code, *first_modifiers);
-                let second = format_key(*second_code, *second_modifiers);
-                format!("{first} {second}")
-            }
-        }
-    }
-
-    /// Whether this combo starts with the given key.
-    #[must_use]
-    pub fn starts_with(&self, code: &KeyCode, modifiers: &Modifiers) -> bool {
-        match self {
-            Self::Single {
-                code: c,
-                modifiers: m,
-            } => c == code && m == modifiers,
-            Self::Sequence {
-                first_code,
-                first_modifiers,
-                ..
-            } => first_code == code && first_modifiers == modifiers,
-        }
-    }
-}
-
-// ---------------------------------------------------------------------------
-// ScreenFilter
-// ---------------------------------------------------------------------------
-
-/// Specifies which screens a command is available on.
-#[derive(Debug, Clone)]
-pub enum ScreenFilter {
-    /// Available on all screens.
-    Global,
-    /// Available only on specific screens.
-    Only(Vec<Screen>),
-}
-
-impl ScreenFilter {
-    /// Whether the command is available on the given screen.
-    #[must_use]
-    pub fn matches(&self, screen: &Screen) -> bool {
-        match self {
-            Self::Global => true,
-            Self::Only(screens) => screens.contains(screen),
-        }
-    }
-}
-
-// ---------------------------------------------------------------------------
-// CommandDef
-// ---------------------------------------------------------------------------
-
-/// Unique command identifier.
-pub type CommandId = &'static str;
-
-/// A registered command with its keybinding, help text, and scope.
-#[derive(Debug, Clone)]
-pub struct CommandDef {
-    /// Unique identifier (e.g., "quit", "go_issues").
-    pub id: CommandId,
-    /// Human-readable label for palette and help overlay.
-    pub label: &'static str,
-    /// Keybinding (if any).
-    pub keybinding: Option<KeyCombo>,
-    /// Equivalent `lore` CLI command (for "Show CLI equivalent" feature).
-    pub cli_equivalent: Option<&'static str>,
-    /// Description for help overlay.
-    pub help_text: &'static str,
-    /// Short hint for status bar (e.g., "q:quit").
-    pub status_hint: &'static str,
-    /// Which screens this command is available on.
-    pub available_in: ScreenFilter,
-    /// Whether this command works in Text input mode.
-    pub available_in_text_mode: bool,
-}
-
-// ---------------------------------------------------------------------------
-// CommandRegistry
-// ---------------------------------------------------------------------------
-
-/// Single source of truth for all TUI commands.
-///
-/// Built once at startup via [`build_registry`]. Provides O(1) lookup
-/// by keybinding and per-screen filtering.
-pub struct CommandRegistry {
-    commands: Vec<CommandDef>,
-    /// Single-key -> command IDs that start with this key.
-    by_single_key: HashMap<(KeyCode, Modifiers), Vec<usize>>,
-    /// Full sequence -> command index (for two-key combos).
-    by_sequence: HashMap<KeyCombo, usize>,
-}
-
-impl CommandRegistry {
-    /// Look up a command by a single key press on a given screen and input mode.
-    ///
-    /// Returns `None` if no matching command is found. For sequence starters
-    /// (like 'g'), returns `None` — use [`is_sequence_starter`] to detect
-    /// that case.
-    #[must_use]
-    pub fn lookup_key(
-        &self,
-        code: &KeyCode,
-        modifiers: &Modifiers,
-        screen: &Screen,
-        mode: &InputMode,
-    ) -> Option<&CommandDef> {
-        let is_text = matches!(mode, InputMode::Text);
-        let key = (*code, *modifiers);
-
-        let indices = self.by_single_key.get(&key)?;
-        for &idx in indices {
-            let cmd = &self.commands[idx];
-            if !cmd.available_in.matches(screen) {
-                continue;
-            }
-            if is_text && !cmd.available_in_text_mode {
-                continue;
-            }
-            // Only match Single combos here, not sequence starters.
-            if let Some(KeyCombo::Single { .. }) = &cmd.keybinding {
-                return Some(cmd);
-            }
-        }
-        None
-    }
-
-    /// Complete a two-key sequence.
-    ///
-    /// Called after the first key of a sequence is detected (e.g., after 'g').
-    #[must_use]
-    pub fn complete_sequence(
-        &self,
-        first_code: &KeyCode,
-        first_modifiers: &Modifiers,
-        second_code: &KeyCode,
-        second_modifiers: &Modifiers,
-        screen: &Screen,
-    ) -> Option<&CommandDef> {
-        let combo = KeyCombo::Sequence {
-            first_code: *first_code,
-            first_modifiers: *first_modifiers,
-            second_code: *second_code,
-            second_modifiers: *second_modifiers,
-        };
-        let &idx = self.by_sequence.get(&combo)?;
-        let cmd = &self.commands[idx];
-        if cmd.available_in.matches(screen) {
-            Some(cmd)
-        } else {
-            None
-        }
-    }
-
-    /// Whether a key starts a multi-key sequence (e.g., 'g').
-    #[must_use]
-    pub fn is_sequence_starter(&self, code: &KeyCode, modifiers: &Modifiers) -> bool {
-        self.by_sequence
-            .keys()
-            .any(|combo| combo.starts_with(code, modifiers))
-    }
-
-    /// Commands available for the command palette on a given screen.
-    ///
-    /// Returned sorted by label.
-    #[must_use]
-    pub fn palette_entries(&self, screen: &Screen) -> Vec<&CommandDef> {
-        let mut entries: Vec<&CommandDef> = self
-            .commands
-            .iter()
-            .filter(|c| c.available_in.matches(screen))
-            .collect();
-        entries.sort_by_key(|c| c.label);
-        entries
-    }
-
-    /// Commands for the help overlay on a given screen.
-    #[must_use]
-    pub fn help_entries(&self, screen: &Screen) -> Vec<&CommandDef> {
-        self.commands
-            .iter()
-            .filter(|c| c.available_in.matches(screen))
-            .filter(|c| c.keybinding.is_some())
-            .collect()
-    }
-
-    /// Status bar hints for the current screen.
-    #[must_use]
-    pub fn status_hints(&self, screen: &Screen) -> Vec<&str> {
-        self.commands
-            .iter()
-            .filter(|c| c.available_in.matches(screen))
-            .filter(|c| !c.status_hint.is_empty())
-            .map(|c| c.status_hint)
-            .collect()
-    }
-
-    /// Total number of registered commands.
-    #[must_use]
-    pub fn len(&self) -> usize {
-        self.commands.len()
-    }
-
-    /// Whether the registry has no commands.
-    #[must_use]
-    pub fn is_empty(&self) -> bool {
-        self.commands.is_empty()
-    }
-}
-
-// ---------------------------------------------------------------------------
-// build_registry
-// ---------------------------------------------------------------------------
-
-/// Build the command registry with all TUI commands.
-///
-/// This is the single source of truth — every keybinding, help text,
-/// and palette entry originates here.
-#[must_use]
-pub fn build_registry() -> CommandRegistry {
-    let commands = vec![
-        // --- Global commands ---
-        CommandDef {
-            id: "quit",
-            label: "Quit",
-            keybinding: Some(KeyCombo::key(KeyCode::Char('q'))),
-            cli_equivalent: None,
-            help_text: "Exit the TUI",
-            status_hint: "q:quit",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "go_back",
-            label: "Go Back",
-            keybinding: Some(KeyCombo::key(KeyCode::Escape)),
-            cli_equivalent: None,
-            help_text: "Go back to previous screen",
-            status_hint: "esc:back",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: true,
-        },
-        CommandDef {
-            id: "show_help",
-            label: "Help",
-            keybinding: Some(KeyCombo::key(KeyCode::Char('?'))),
-            cli_equivalent: None,
-            help_text: "Show keybinding help overlay",
-            status_hint: "?:help",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "command_palette",
-            label: "Command Palette",
-            keybinding: Some(KeyCombo::ctrl(KeyCode::Char('p'))),
-            cli_equivalent: None,
-            help_text: "Open command palette",
-            status_hint: "C-p:palette",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: true,
-        },
-        CommandDef {
-            id: "open_in_browser",
-            label: "Open in Browser",
-            keybinding: Some(KeyCombo::key(KeyCode::Char('o'))),
-            cli_equivalent: None,
-            help_text: "Open current entity in browser",
-            status_hint: "o:browser",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "show_cli",
-            label: "Show CLI Equivalent",
-            keybinding: Some(KeyCombo::key(KeyCode::Char('!'))),
-            cli_equivalent: None,
-            help_text: "Show equivalent lore CLI command",
-            status_hint: "",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        // --- Navigation: g-prefix sequences ---
-        CommandDef {
-            id: "go_home",
-            label: "Go to Dashboard",
-            keybinding: Some(KeyCombo::g_then('h')),
-            cli_equivalent: None,
-            help_text: "Jump to dashboard",
-            status_hint: "gh:home",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "go_issues",
-            label: "Go to Issues",
-            keybinding: Some(KeyCombo::g_then('i')),
-            cli_equivalent: Some("lore issues"),
-            help_text: "Jump to issue list",
-            status_hint: "gi:issues",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "go_mrs",
-            label: "Go to Merge Requests",
-            keybinding: Some(KeyCombo::g_then('m')),
-            cli_equivalent: Some("lore mrs"),
-            help_text: "Jump to MR list",
-            status_hint: "gm:mrs",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "go_search",
-            label: "Go to Search",
-            keybinding: Some(KeyCombo::g_then('/')),
-            cli_equivalent: Some("lore search"),
-            help_text: "Jump to search",
-            status_hint: "g/:search",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "go_timeline",
-            label: "Go to Timeline",
-            keybinding: Some(KeyCombo::g_then('t')),
-            cli_equivalent: Some("lore timeline"),
-            help_text: "Jump to timeline",
-            status_hint: "gt:timeline",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "go_who",
-            label: "Go to Who",
-            keybinding: Some(KeyCombo::g_then('w')),
-            cli_equivalent: Some("lore who"),
-            help_text: "Jump to people intelligence",
-            status_hint: "gw:who",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "go_sync",
-            label: "Go to Sync",
-            keybinding: Some(KeyCombo::g_then('s')),
-            cli_equivalent: Some("lore sync"),
-            help_text: "Jump to sync status",
-            status_hint: "gs:sync",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        // --- Vim-style jump list ---
-        CommandDef {
-            id: "jump_back",
-            label: "Jump Back",
-            keybinding: Some(KeyCombo::ctrl(KeyCode::Char('o'))),
-            cli_equivalent: None,
-            help_text: "Jump backward through visited detail views",
-            status_hint: "C-o:jump back",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "jump_forward",
-            label: "Jump Forward",
-            keybinding: Some(KeyCombo::ctrl(KeyCode::Char('i'))),
-            cli_equivalent: None,
-            help_text: "Jump forward through visited detail views",
-            status_hint: "",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-        // --- List navigation ---
-        CommandDef {
-            id: "move_down",
-            label: "Move Down",
-            keybinding: Some(KeyCombo::key(KeyCode::Char('j'))),
-            cli_equivalent: None,
-            help_text: "Move cursor down",
-            status_hint: "j:down",
-            available_in: ScreenFilter::Only(vec![
-                Screen::IssueList,
-                Screen::MrList,
-                Screen::Search,
-                Screen::Timeline,
-            ]),
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "move_up",
-            label: "Move Up",
-            keybinding: Some(KeyCombo::key(KeyCode::Char('k'))),
-            cli_equivalent: None,
-            help_text: "Move cursor up",
-            status_hint: "k:up",
-            available_in: ScreenFilter::Only(vec![
-                Screen::IssueList,
-                Screen::MrList,
-                Screen::Search,
-                Screen::Timeline,
-            ]),
-            available_in_text_mode: false,
-        },
-        CommandDef {
-            id: "select_item",
-            label: "Select",
-            keybinding: Some(KeyCombo::key(KeyCode::Enter)),
-            cli_equivalent: None,
-            help_text: "Open selected item",
-            status_hint: "enter:open",
-            available_in: ScreenFilter::Only(vec![
-                Screen::IssueList,
-                Screen::MrList,
-                Screen::Search,
-            ]),
-            available_in_text_mode: false,
-        },
-        // --- Filter ---
-        CommandDef {
-            id: "focus_filter",
-            label: "Filter",
-            keybinding: Some(KeyCombo::key(KeyCode::Char('/'))),
-            cli_equivalent: None,
-            help_text: "Focus the filter input",
-            status_hint: "/:filter",
-            available_in: ScreenFilter::Only(vec![Screen::IssueList, Screen::MrList]),
-            available_in_text_mode: false,
-        },
-        // --- Scroll ---
-        CommandDef {
-            id: "scroll_to_top",
-            label: "Scroll to Top",
-            keybinding: Some(KeyCombo::g_then('g')),
-            cli_equivalent: None,
-            help_text: "Scroll to the top of the current view",
-            status_hint: "",
-            available_in: ScreenFilter::Global,
-            available_in_text_mode: false,
-        },
-    ];
-
-    build_from_defs(commands)
-}
-
-/// Build index maps from a list of command definitions.
-fn build_from_defs(commands: Vec<CommandDef>) -> CommandRegistry {
-    let mut by_single_key: HashMap<(KeyCode, Modifiers), Vec<usize>> = HashMap::new();
-    let mut by_sequence: HashMap<KeyCombo, usize> = HashMap::new();
-
-    for (idx, cmd) in commands.iter().enumerate() {
-        if let Some(combo) = &cmd.keybinding {
-            match combo {
-                KeyCombo::Single { code, modifiers } => {
-                    by_single_key
-                        .entry((*code, *modifiers))
-                        .or_default()
-                        .push(idx);
-                }
-                KeyCombo::Sequence { .. } => {
-                    by_sequence.insert(combo.clone(), idx);
-                    // Also index the first key so is_sequence_starter works via by_single_key.
-                    if let KeyCombo::Sequence {
-                        first_code,
-                        first_modifiers,
-                        ..
-                    } = combo
-                    {
-                        by_single_key
-                            .entry((*first_code, *first_modifiers))
-                            .or_default()
-                            .push(idx);
-                    }
-                }
-            }
-        }
-    }
-
-    CommandRegistry {
-        commands,
-        by_single_key,
-        by_sequence,
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use chrono::Utc;
-
-    #[test]
-    fn test_registry_builds_successfully() {
-        let reg = build_registry();
-        assert!(!reg.is_empty());
-        assert!(reg.len() >= 15);
-    }
-
-    #[test]
-    fn test_registry_lookup_quit() {
-        let reg = build_registry();
-        let cmd = reg.lookup_key(
-            &KeyCode::Char('q'),
-            &Modifiers::NONE,
-            &Screen::Dashboard,
-            &InputMode::Normal,
-        );
-        assert!(cmd.is_some());
-        assert_eq!(cmd.unwrap().id, "quit");
-    }
-
-    #[test]
-    fn test_registry_lookup_quit_blocked_in_text_mode() {
-        let reg = build_registry();
-        let cmd = reg.lookup_key(
-            &KeyCode::Char('q'),
-            &Modifiers::NONE,
-            &Screen::Dashboard,
-            &InputMode::Text,
-        );
-        assert!(cmd.is_none());
-    }
-
-    #[test]
-    fn test_registry_esc_works_in_text_mode() {
-        let reg = build_registry();
-        let cmd = reg.lookup_key(
-            &KeyCode::Escape,
-            &Modifiers::NONE,
-            &Screen::IssueList,
-            &InputMode::Text,
-        );
-        assert!(cmd.is_some());
-        assert_eq!(cmd.unwrap().id, "go_back");
-    }
-
-    #[test]
-    fn test_registry_ctrl_p_works_in_text_mode() {
-        let reg = build_registry();
-        let cmd = reg.lookup_key(
-            &KeyCode::Char('p'),
-            &Modifiers::CTRL,
-            &Screen::Search,
-            &InputMode::Text,
-        );
-        assert!(cmd.is_some());
-        assert_eq!(cmd.unwrap().id, "command_palette");
-    }
-
-    #[test]
-    fn test_g_is_sequence_starter() {
-        let reg = build_registry();
-        assert!(reg.is_sequence_starter(&KeyCode::Char('g'), &Modifiers::NONE));
-        assert!(!reg.is_sequence_starter(&KeyCode::Char('x'), &Modifiers::NONE));
-    }
-
-    #[test]
-    fn test_complete_sequence_gi() {
-        let reg = build_registry();
-        let cmd = reg.complete_sequence(
-            &KeyCode::Char('g'),
-            &Modifiers::NONE,
-            &KeyCode::Char('i'),
-            &Modifiers::NONE,
-            &Screen::Dashboard,
-        );
-        assert!(cmd.is_some());
-        assert_eq!(cmd.unwrap().id, "go_issues");
-    }
-
-    #[test]
-    fn test_complete_sequence_invalid_second_key() {
-        let reg = build_registry();
-        let cmd = reg.complete_sequence(
-            &KeyCode::Char('g'),
-            &Modifiers::NONE,
-            &KeyCode::Char('x'),
-            &Modifiers::NONE,
-            &Screen::Dashboard,
-        );
-        assert!(cmd.is_none());
-    }
-
-    #[test]
-    fn test_screen_specific_command() {
-        let reg = build_registry();
-        // 'j' (move_down) should work on IssueList
-        let cmd = reg.lookup_key(
-            &KeyCode::Char('j'),
-            &Modifiers::NONE,
-            &Screen::IssueList,
-            &InputMode::Normal,
-        );
-        assert!(cmd.is_some());
-        assert_eq!(cmd.unwrap().id, "move_down");
-
-        // 'j' should NOT match on Dashboard (move_down is list-only).
-        let cmd = reg.lookup_key(
-            &KeyCode::Char('j'),
-            &Modifiers::NONE,
-            &Screen::Dashboard,
-            &InputMode::Normal,
-        );
-        assert!(cmd.is_none());
-    }
-
-    #[test]
-    fn test_palette_entries_sorted_by_label() {
-        let reg = build_registry();
-        let entries = reg.palette_entries(&Screen::Dashboard);
-        let labels: Vec<&str> = entries.iter().map(|c| c.label).collect();
-        let mut sorted = labels.clone();
-        sorted.sort();
-        assert_eq!(labels, sorted);
-    }
-
-    #[test]
-    fn test_help_entries_only_include_keybindings() {
-        let reg = build_registry();
-        let entries = reg.help_entries(&Screen::Dashboard);
-        for entry in &entries {
-            assert!(
-                entry.keybinding.is_some(),
-                "help entry without keybinding: {}",
-                entry.id
-            );
-        }
-    }
-
-    #[test]
-    fn test_status_hints_non_empty() {
-        let reg = build_registry();
-        let hints = reg.status_hints(&Screen::Dashboard);
-        assert!(!hints.is_empty());
-        // All returned hints should be non-empty strings.
-        for hint in &hints {
-            assert!(!hint.is_empty());
-        }
-    }
-
-    #[test]
-    fn test_cli_equivalents_populated() {
-        let reg = build_registry();
-        let with_cli: Vec<&CommandDef> = reg
-            .commands
-            .iter()
-            .filter(|c| c.cli_equivalent.is_some())
-            .collect();
-        assert!(
-            with_cli.len() >= 5,
-            "expected at least 5 commands with cli_equivalent, got {}",
-            with_cli.len()
-        );
-    }
-
-    #[test]
-    fn test_go_prefix_timeout_detection() {
-        let reg = build_registry();
-        // Simulate GoPrefix mode entering: 'g' detected as sequence starter.
-        assert!(reg.is_sequence_starter(&KeyCode::Char('g'), &Modifiers::NONE));
-
-        // Simulate InputMode::GoPrefix with timeout check.
-        let started = Utc::now();
-        let mode = InputMode::GoPrefix {
-            started_at: started,
-        };
-        // In GoPrefix mode, normal lookup should still work for non-sequence keys.
-        let cmd = reg.lookup_key(
-            &KeyCode::Char('q'),
-            &Modifiers::NONE,
-            &Screen::Dashboard,
-            &mode,
-        );
-        assert!(cmd.is_some());
-        assert_eq!(cmd.unwrap().id, "quit");
-    }
-
-    #[test]
-    fn test_all_commands_have_nonempty_help() {
-        let reg = build_registry();
-        for cmd in &reg.commands {
-            assert!(
-                !cmd.help_text.is_empty(),
-                "command {} has empty help_text",
-                cmd.id
-            );
-        }
-    }
-}

crates/lore-tui/src/crash_context.rs

@@ -1,443 +0,0 @@
-#![allow(dead_code)] // Phase 1: consumed by LoreApp in bd-6pmy
-
-//! Ring buffer of recent app events for post-mortem crash diagnostics.
-//!
-//! The TUI pushes every key press, message dispatch, and state transition
-//! into [`CrashContext`]. On panic the installed hook dumps the last 2000
-//! events to `~/.local/share/lore/crash-<timestamp>.json` as NDJSON.
-//!
-//! Retention: only the 5 most recent crash files are kept.
-
-use std::collections::VecDeque;
-use std::io::{self, BufWriter, Write};
-use std::path::{Path, PathBuf};
-
-use serde::Serialize;
-
-/// Maximum number of events retained in the ring buffer.
-const MAX_EVENTS: usize = 2000;
-
-/// Maximum number of crash files to keep on disk.
-const MAX_CRASH_FILES: usize = 5;
-
-// ---------------------------------------------------------------------------
-// CrashEvent
-// ---------------------------------------------------------------------------
-
-/// A single event recorded for crash diagnostics.
-#[derive(Debug, Clone, Serialize)]
-#[serde(tag = "type")]
-pub enum CrashEvent {
-    /// A key was pressed.
-    KeyPress {
-        key: String,
-        mode: String,
-        screen: String,
-    },
-    /// A message was dispatched through update().
-    MsgDispatched { msg_name: String, screen: String },
-    /// Navigation changed screens.
-    StateTransition { from: String, to: String },
-    /// An error occurred.
-    Error { message: String },
-    /// Catch-all for ad-hoc diagnostic breadcrumbs.
-    Custom { tag: String, detail: String },
-}
-
-// ---------------------------------------------------------------------------
-// CrashContext
-// ---------------------------------------------------------------------------
-
-/// Ring buffer of recent app events for panic diagnostics.
-///
-/// Holds at most [`MAX_EVENTS`] entries. When full, the oldest event
-/// is evicted on each push.
-pub struct CrashContext {
-    events: VecDeque<CrashEvent>,
-}
-
-impl CrashContext {
-    /// Create an empty crash context with pre-allocated capacity.
-    #[must_use]
-    pub fn new() -> Self {
-        Self {
-            events: VecDeque::with_capacity(MAX_EVENTS),
-        }
-    }
-
-    /// Record an event. Evicts the oldest when the buffer is full.
-    pub fn push(&mut self, event: CrashEvent) {
-        if self.events.len() == MAX_EVENTS {
-            self.events.pop_front();
-        }
-        self.events.push_back(event);
-    }
-
-    /// Number of events currently stored.
-    #[must_use]
-    pub fn len(&self) -> usize {
-        self.events.len()
-    }
-
-    /// Whether the buffer is empty.
-    #[must_use]
-    pub fn is_empty(&self) -> bool {
-        self.events.is_empty()
-    }
-
-    /// Iterate over stored events (oldest first).
-    pub fn iter(&self) -> impl Iterator<Item = &CrashEvent> {
-        self.events.iter()
-    }
-
-    /// Dump all events to a file as newline-delimited JSON.
-    ///
-    /// Creates parent directories if they don't exist.
-    /// Returns `Ok(())` on success, `Err` on I/O failure.
-    pub fn dump_to_file(&self, path: &Path) -> io::Result<()> {
-        if let Some(parent) = path.parent() {
-            std::fs::create_dir_all(parent)?;
-        }
-        let file = std::fs::File::create(path)?;
-        let mut writer = BufWriter::new(file);
-        for event in &self.events {
-            match serde_json::to_string(event) {
-                Ok(json) => {
-                    writeln!(writer, "{json}")?;
-                }
-                Err(_) => {
-                    // Fallback to debug format if serialization fails.
-                    writeln!(
-                        writer,
-                        "{{\"type\":\"SerializationError\",\"debug\":\"{event:?}\"}}"
-                    )?;
-                }
-            }
-        }
-        writer.flush()?;
-        Ok(())
-    }
-
-    /// Default crash directory: `~/.local/share/lore/`.
-    #[must_use]
-    pub fn crash_dir() -> Option<PathBuf> {
-        dirs::data_local_dir().map(|d| d.join("lore"))
-    }
-
-    /// Generate a timestamped crash file path.
-    #[must_use]
-    pub fn crash_file_path() -> Option<PathBuf> {
-        let dir = Self::crash_dir()?;
-        let timestamp = chrono::Utc::now().format("%Y%m%d-%H%M%S%.3f");
-        Some(dir.join(format!("crash-{timestamp}.json")))
-    }
-
-    /// Remove old crash files, keeping only the most recent [`MAX_CRASH_FILES`].
-    ///
-    /// Best-effort: silently ignores I/O errors on individual deletions.
-    pub fn prune_crash_files() {
-        let Some(dir) = Self::crash_dir() else {
-            return;
-        };
-        let Ok(entries) = std::fs::read_dir(&dir) else {
-            return;
-        };
-
-        let mut crash_files: Vec<PathBuf> = entries
-            .filter_map(Result::ok)
-            .map(|e| e.path())
-            .filter(|p| {
-                p.file_name()
-                    .and_then(|n| n.to_str())
-                    .is_some_and(|n| n.starts_with("crash-") && n.ends_with(".json"))
-            })
-            .collect();
-
-        // Sort ascending by filename (timestamps sort lexicographically).
-        crash_files.sort();
-
-        if crash_files.len() > MAX_CRASH_FILES {
-            let to_remove = crash_files.len() - MAX_CRASH_FILES;
-            for path in &crash_files[..to_remove] {
-                let _ = std::fs::remove_file(path);
-            }
-        }
-    }
-
-    /// Install a panic hook that dumps the crash context to disk.
-    ///
-    /// Captures the current events via a snapshot. The hook chains with
-    /// the default panic handler so backtraces are still printed.
-    pub fn install_panic_hook(ctx: &Self) {
-        let snapshot: Vec<CrashEvent> = ctx.events.iter().cloned().collect();
-        let prev_hook = std::panic::take_hook();
-
-        std::panic::set_hook(Box::new(move |info| {
-            // Best-effort dump — never panic inside the panic hook.
-            if let Some(path) = Self::crash_file_path() {
-                let mut dump = CrashContext::new();
-                for event in &snapshot {
-                    dump.push(event.clone());
-                }
-                // Add the panic info itself as the final event.
-                dump.push(CrashEvent::Error {
-                    message: format!("{info}"),
-                });
-                let _ = dump.dump_to_file(&path);
-            }
-
-            // Chain to the previous hook (prints backtrace, etc.).
-            prev_hook(info);
-        }));
-    }
-}
-
-impl Default for CrashContext {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use std::io::BufRead;
-
-    /// Helper: create a numbered Custom event.
-    fn event(n: usize) -> CrashEvent {
-        CrashEvent::Custom {
-            tag: "test".into(),
-            detail: format!("event-{n}"),
-        }
-    }
-
-    #[test]
-    fn test_ring_buffer_evicts_oldest() {
-        let mut ctx = CrashContext::new();
-        for i in 0..2500 {
-            ctx.push(event(i));
-        }
-        assert_eq!(ctx.len(), MAX_EVENTS);
-
-        // First retained event should be #500 (0..499 evicted).
-        let first = ctx.iter().next().unwrap();
-        match first {
-            CrashEvent::Custom { detail, .. } => assert_eq!(detail, "event-500"),
-            other => panic!("unexpected variant: {other:?}"),
-        }
-
-        // Last retained event should be #2499.
-        let last = ctx.iter().last().unwrap();
-        match last {
-            CrashEvent::Custom { detail, .. } => assert_eq!(detail, "event-2499"),
-            other => panic!("unexpected variant: {other:?}"),
-        }
-    }
-
-    #[test]
-    fn test_new_is_empty() {
-        let ctx = CrashContext::new();
-        assert!(ctx.is_empty());
-        assert_eq!(ctx.len(), 0);
-    }
-
-    #[test]
-    fn test_push_increments_len() {
-        let mut ctx = CrashContext::new();
-        ctx.push(event(1));
-        ctx.push(event(2));
-        assert_eq!(ctx.len(), 2);
-    }
-
-    #[test]
-    fn test_push_does_not_evict_below_capacity() {
-        let mut ctx = CrashContext::new();
-        for i in 0..MAX_EVENTS {
-            ctx.push(event(i));
-        }
-        assert_eq!(ctx.len(), MAX_EVENTS);
-
-        // First should still be event-0.
-        match ctx.iter().next().unwrap() {
-            CrashEvent::Custom { detail, .. } => assert_eq!(detail, "event-0"),
-            other => panic!("unexpected: {other:?}"),
-        }
-    }
-
-    #[test]
-    fn test_dump_to_file_writes_ndjson() {
-        let mut ctx = CrashContext::new();
-        ctx.push(CrashEvent::KeyPress {
-            key: "j".into(),
-            mode: "Normal".into(),
-            screen: "Dashboard".into(),
-        });
-        ctx.push(CrashEvent::MsgDispatched {
-            msg_name: "NavigateTo".into(),
-            screen: "Dashboard".into(),
-        });
-        ctx.push(CrashEvent::StateTransition {
-            from: "Dashboard".into(),
-            to: "IssueList".into(),
-        });
-        ctx.push(CrashEvent::Error {
-            message: "db busy".into(),
-        });
-        ctx.push(CrashEvent::Custom {
-            tag: "test".into(),
-            detail: "hello".into(),
-        });
-
-        let dir = tempfile::tempdir().unwrap();
-        let path = dir.path().join("test-crash.json");
-        ctx.dump_to_file(&path).unwrap();
-
-        // Verify: each line is valid JSON, total lines == 5.
-        let file = std::fs::File::open(&path).unwrap();
-        let reader = io::BufReader::new(file);
-        let lines: Vec<String> = reader.lines().map(Result::unwrap).collect();
-        assert_eq!(lines.len(), 5);
-
-        // Each line must parse as JSON.
-        for line in &lines {
-            let val: serde_json::Value = serde_json::from_str(line).unwrap();
-            assert!(val.get("type").is_some(), "missing 'type' field: {line}");
-        }
-
-        // Spot check first line: KeyPress with correct fields.
-        let first: serde_json::Value = serde_json::from_str(&lines[0]).unwrap();
-        assert_eq!(first["type"], "KeyPress");
-        assert_eq!(first["key"], "j");
-        assert_eq!(first["mode"], "Normal");
-        assert_eq!(first["screen"], "Dashboard");
-    }
-
-    #[test]
-    fn test_dump_creates_parent_directories() {
-        let dir = tempfile::tempdir().unwrap();
-        let nested = dir.path().join("a").join("b").join("c").join("crash.json");
-
-        let mut ctx = CrashContext::new();
-        ctx.push(event(1));
-        ctx.dump_to_file(&nested).unwrap();
-
-        assert!(nested.exists());
-    }
-
-    #[test]
-    fn test_dump_empty_context_creates_empty_file() {
-        let dir = tempfile::tempdir().unwrap();
-        let path = dir.path().join("empty.json");
-
-        let ctx = CrashContext::new();
-        ctx.dump_to_file(&path).unwrap();
-
-        let content = std::fs::read_to_string(&path).unwrap();
-        assert!(content.is_empty());
-    }
-
-    #[test]
-    fn test_prune_keeps_newest_files() {
-        let dir = tempfile::tempdir().unwrap();
-        let crash_dir = dir.path();
-
-        // Create 8 crash files with ordered timestamps.
-        let filenames: Vec<String> = (0..8)
-            .map(|i| format!("crash-2026010{i}-120000.000.json"))
-            .collect();
-        for name in &filenames {
-            std::fs::write(crash_dir.join(name), "{}").unwrap();
-        }
-
-        // Prune, pointing at our temp dir.
-        prune_crash_files_in(crash_dir);
-
-        let remaining: Vec<String> = std::fs::read_dir(crash_dir)
-            .unwrap()
-            .filter_map(Result::ok)
-            .map(|e| e.file_name().to_string_lossy().into_owned())
-            .filter(|n| n.starts_with("crash-") && n.ends_with(".json"))
-            .collect();
-
-        assert_eq!(remaining.len(), MAX_CRASH_FILES);
-        // Oldest 3 should be gone.
-        for name in filenames.iter().take(3) {
-            assert!(!remaining.contains(name));
-        }
-        // Newest 5 should remain.
-        for name in filenames.iter().skip(3) {
-            assert!(remaining.contains(name));
-        }
-    }
-
-    #[test]
-    fn test_all_event_variants_serialize() {
-        let events = vec![
-            CrashEvent::KeyPress {
-                key: "q".into(),
-                mode: "Normal".into(),
-                screen: "Dashboard".into(),
-            },
-            CrashEvent::MsgDispatched {
-                msg_name: "Quit".into(),
-                screen: "Dashboard".into(),
-            },
-            CrashEvent::StateTransition {
-                from: "Dashboard".into(),
-                to: "IssueList".into(),
-            },
-            CrashEvent::Error {
-                message: "oops".into(),
-            },
-            CrashEvent::Custom {
-                tag: "debug".into(),
-                detail: "trace".into(),
-            },
-        ];
-
-        for event in events {
-            let json = serde_json::to_string(&event).unwrap();
-            let parsed: serde_json::Value = serde_json::from_str(&json).unwrap();
-            assert!(parsed.get("type").is_some());
-        }
-    }
-
-    #[test]
-    fn test_default_is_new() {
-        let ctx = CrashContext::default();
-        assert!(ctx.is_empty());
-    }
-
-    // -----------------------------------------------------------------------
-    // Test helper: prune files in a specific directory (not the real path).
-    // -----------------------------------------------------------------------
-
-    fn prune_crash_files_in(dir: &Path) {
-        let Ok(entries) = std::fs::read_dir(dir) else {
-            return;
-        };
-
-        let mut crash_files: Vec<PathBuf> = entries
-            .filter_map(Result::ok)
-            .map(|e| e.path())
-            .filter(|p| {
-                p.file_name()
-                    .and_then(|n| n.to_str())
-                    .is_some_and(|n| n.starts_with("crash-") && n.ends_with(".json"))
-            })
-            .collect();
-
-        crash_files.sort();
-
-        if crash_files.len() > MAX_CRASH_FILES {
-            let to_remove = crash_files.len() - MAX_CRASH_FILES;
-            for path in &crash_files[..to_remove] {
-                let _ = std::fs::remove_file(path);
-            }
-        }
-    }
-}

crates/lore-tui/src/db.rs

@@ -1,270 +0,0 @@
-#![allow(dead_code)] // Phase 0: types defined now, consumed in Phase 1+
-
-//! Database access layer for the TUI.
-//!
-//! Provides a read pool (3 connections, round-robin) plus a dedicated writer
-//! connection. All connections use WAL mode and busy_timeout for concurrency.
-//!
-//! The TUI operates read-heavy: parallel queries for dashboard, list views,
-//! and prefetch. Writes are rare (TUI-local state: scroll positions, bookmarks).
-
-use std::path::Path;
-use std::sync::Mutex;
-use std::sync::atomic::{AtomicUsize, Ordering};
-
-use anyhow::{Context, Result};
-use rusqlite::Connection;
-
-/// Number of reader connections in the pool.
-const READER_COUNT: usize = 3;
-
-// ---------------------------------------------------------------------------
-// DbManager
-// ---------------------------------------------------------------------------
-
-/// Manages a pool of read-only connections plus a dedicated writer.
-///
-/// Designed for `Arc<DbManager>` sharing across FrankenTUI's `Cmd::task`
-/// background threads. Each reader is individually `Mutex`-protected so
-/// concurrent tasks can query different readers without blocking.
-pub struct DbManager {
-    readers: Vec<Mutex<Connection>>,
-    writer: Mutex<Connection>,
-    next_reader: AtomicUsize,
-}
-
-impl DbManager {
-    /// Open a database at `path` with 3 reader + 1 writer connections.
-    ///
-    /// All connections get WAL mode, 5000ms busy_timeout, and foreign keys.
-    /// Reader connections additionally set `query_only = ON` as a safety guard.
-    pub fn open(path: &Path) -> Result<Self> {
-        let mut readers = Vec::with_capacity(READER_COUNT);
-        for i in 0..READER_COUNT {
-            let conn =
-                open_connection(path).with_context(|| format!("opening reader connection {i}"))?;
-            conn.pragma_update(None, "query_only", "ON")
-                .context("setting query_only on reader")?;
-            readers.push(Mutex::new(conn));
-        }
-
-        let writer = open_connection(path).context("opening writer connection")?;
-
-        Ok(Self {
-            readers,
-            writer: Mutex::new(writer),
-            next_reader: AtomicUsize::new(0),
-        })
-    }
-
-    /// Execute a read-only query against the pool.
-    ///
-    /// Selects the next reader via round-robin. The connection is borrowed
-    /// for the duration of `f` and cannot leak outside.
-    pub fn with_reader<F, T>(&self, f: F) -> Result<T>
-    where
-        F: FnOnce(&Connection) -> Result<T>,
-    {
-        let idx = self.next_reader.fetch_add(1, Ordering::Relaxed) % READER_COUNT;
-        let conn = self.readers[idx].lock().expect("reader mutex poisoned");
-        f(&conn)
-    }
-
-    /// Execute a write operation against the dedicated writer.
-    ///
-    /// Serialized via a single `Mutex`. The TUI writes infrequently
-    /// (bookmarks, scroll state) so contention is negligible.
-    pub fn with_writer<F, T>(&self, f: F) -> Result<T>
-    where
-        F: FnOnce(&Connection) -> Result<T>,
-    {
-        let conn = self.writer.lock().expect("writer mutex poisoned");
-        f(&conn)
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Connection setup
-// ---------------------------------------------------------------------------
-
-/// Open a single SQLite connection with TUI-appropriate pragmas.
-///
-/// Mirrors lore's `create_connection` pragmas (WAL, busy_timeout, etc.)
-/// but skips the sqlite-vec extension registration — the TUI reads standard
-/// tables only, never vec0 virtual tables.
-fn open_connection(path: &Path) -> Result<Connection> {
-    let conn = Connection::open(path).context("opening SQLite database")?;
-
-    conn.pragma_update(None, "journal_mode", "WAL")?;
-    conn.pragma_update(None, "synchronous", "NORMAL")?;
-    conn.pragma_update(None, "foreign_keys", "ON")?;
-    conn.pragma_update(None, "busy_timeout", 5000)?;
-    conn.pragma_update(None, "temp_store", "MEMORY")?;
-
-    Ok(conn)
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use std::sync::Arc;
-
-    /// Create a temporary database file for testing.
-    ///
-    /// Uses an atomic counter + thread ID to guarantee unique paths even
-    /// when tests run in parallel.
-    fn test_db_path() -> std::path::PathBuf {
-        use std::sync::atomic::AtomicU64;
-        static COUNTER: AtomicU64 = AtomicU64::new(0);
-        let n = COUNTER.fetch_add(1, Ordering::Relaxed);
-        let dir = std::env::temp_dir().join("lore-tui-tests");
-        std::fs::create_dir_all(&dir).expect("create test dir");
-        dir.join(format!(
-            "test-{}-{:?}-{n}.db",
-            std::process::id(),
-            std::thread::current().id(),
-        ))
-    }
-
-    fn create_test_table(conn: &Connection) {
-        conn.execute_batch(
-            "CREATE TABLE IF NOT EXISTS test_items (id INTEGER PRIMARY KEY, name TEXT);",
-        )
-        .expect("create test table");
-    }
-
-    #[test]
-    fn test_dbmanager_opens_successfully() {
-        let path = test_db_path();
-        let db = DbManager::open(&path).expect("open");
-        // Writer creates the test table
-        db.with_writer(|conn| {
-            create_test_table(conn);
-            Ok(())
-        })
-        .expect("create table via writer");
-    }
-
-    #[test]
-    fn test_reader_is_query_only() {
-        let path = test_db_path();
-        let db = DbManager::open(&path).expect("open");
-
-        // Create table via writer first
-        db.with_writer(|conn| {
-            create_test_table(conn);
-            Ok(())
-        })
-        .unwrap();
-
-        // Attempt INSERT via reader — should fail
-        let result = db.with_reader(|conn| {
-            conn.execute("INSERT INTO test_items (name) VALUES ('boom')", [])
-                .map_err(|e| anyhow::anyhow!(e))?;
-            Ok(())
-        });
-        assert!(result.is_err(), "reader should reject writes");
-    }
-
-    #[test]
-    fn test_writer_allows_mutations() {
-        let path = test_db_path();
-        let db = DbManager::open(&path).expect("open");
-
-        db.with_writer(|conn| {
-            create_test_table(conn);
-            conn.execute("INSERT INTO test_items (name) VALUES ('hello')", [])?;
-            let count: i64 = conn.query_row("SELECT COUNT(*) FROM test_items", [], |r| r.get(0))?;
-            assert_eq!(count, 1);
-            Ok(())
-        })
-        .expect("writer should allow mutations");
-    }
-
-    #[test]
-    fn test_round_robin_rotates_readers() {
-        let path = test_db_path();
-        let db = DbManager::open(&path).expect("open");
-
-        // Call with_reader 6 times — should cycle through readers 0,1,2,0,1,2
-        for expected_cycle in 0..2 {
-            for expected_idx in 0..READER_COUNT {
-                let current = db.next_reader.load(Ordering::Relaxed);
-                assert_eq!(
-                    current % READER_COUNT,
-                    (expected_cycle * READER_COUNT + expected_idx) % READER_COUNT,
-                );
-                db.with_reader(|_conn| Ok(())).unwrap();
-            }
-        }
-    }
-
-    #[test]
-    fn test_reader_can_read_writer_data() {
-        let path = test_db_path();
-        let db = DbManager::open(&path).expect("open");
-
-        db.with_writer(|conn| {
-            create_test_table(conn);
-            conn.execute("INSERT INTO test_items (name) VALUES ('visible')", [])?;
-            Ok(())
-        })
-        .unwrap();
-
-        let name: String = db
-            .with_reader(|conn| {
-                let n: String =
-                    conn.query_row("SELECT name FROM test_items WHERE id = 1", [], |r| r.get(0))?;
-                Ok(n)
-            })
-            .expect("reader should see writer's data");
-
-        assert_eq!(name, "visible");
-    }
-
-    #[test]
-    fn test_dbmanager_is_send_sync() {
-        fn assert_send_sync<T: Send + Sync>() {}
-        assert_send_sync::<DbManager>();
-    }
-
-    #[test]
-    fn test_concurrent_reads() {
-        let path = test_db_path();
-        let db = Arc::new(DbManager::open(&path).expect("open"));
-
-        db.with_writer(|conn| {
-            create_test_table(conn);
-            for i in 0..10 {
-                conn.execute(
-                    "INSERT INTO test_items (name) VALUES (?1)",
-                    [format!("item-{i}")],
-                )?;
-            }
-            Ok(())
-        })
-        .unwrap();
-
-        let mut handles = Vec::new();
-        for _ in 0..6 {
-            let db = Arc::clone(&db);
-            handles.push(std::thread::spawn(move || {
-                db.with_reader(|conn| {
-                    let count: i64 =
-                        conn.query_row("SELECT COUNT(*) FROM test_items", [], |r| r.get(0))?;
-                    assert_eq!(count, 10);
-                    Ok(())
-                })
-                .expect("concurrent read should succeed");
-            }));
-        }
-
-        for h in handles {
-            h.join().expect("thread should not panic");
-        }
-    }
-}

crates/lore-tui/src/lib.rs

@@ -1,66 +0,0 @@
-#![forbid(unsafe_code)]
-
-//! Gitlore TUI — terminal interface for exploring GitLab data locally.
-//!
-//! Built on FrankenTUI (Elm architecture): Model, update, view.
-//! The `lore` CLI spawns `lore-tui` via PATH lookup at runtime.
-
-use anyhow::Result;
-
-// Phase 0 modules.
-pub mod clock; // Clock trait: SystemClock + FakeClock (bd-2lg6)
-pub mod message; // Msg, Screen, EntityKey, AppError, InputMode (bd-c9gk)
-
-pub mod safety; // Terminal safety: sanitize + URL policy + redact (bd-3ir1)
-
-pub mod db; // DbManager: read pool + dedicated writer (bd-2kop)
-pub mod theme; // Flexoki theme: build_theme, state_color, label_style (bd-5ofk)
-
-pub mod app; // LoreApp Model trait impl (Phase 0 proof: bd-2emv, full: bd-6pmy)
-
-// Phase 1 modules.
-pub mod commands; // CommandRegistry: keybindings, help, palette (bd-38lb)
-pub mod crash_context; // CrashContext ring buffer + panic hook (bd-2fr7)
-pub mod navigation; // NavigationStack: back/forward/jump list (bd-1qpp)
-pub mod state; // AppState, LoadState, ScreenIntent, per-screen states (bd-1v9m)
-pub mod task_supervisor; // TaskSupervisor: dedup + cancel + generation IDs (bd-3le2)
-pub mod view; // View layer: render_screen + common widgets (bd-26f2)
-
-/// Options controlling how the TUI launches.
-#[derive(Debug, Clone)]
-pub struct LaunchOptions {
-    /// Path to lore config file.
-    pub config_path: Option<String>,
-    /// Run a background sync before displaying data.
-    pub sync_on_start: bool,
-    /// Clear cached TUI state and start fresh.
-    pub fresh: bool,
-    /// Render backend: "crossterm" or "native".
-    pub render_mode: String,
-    /// Use ASCII-only box drawing characters.
-    pub ascii: bool,
-    /// Disable alternate screen (render inline).
-    pub no_alt_screen: bool,
-}
-
-/// Launch the TUI in browse mode (no sync).
-///
-/// Loads config from `options.config_path` (or default location),
-/// opens the database read-only, and enters the FrankenTUI event loop.
-pub fn launch_tui(options: LaunchOptions) -> Result<()> {
-    let _options = options;
-    // Phase 1 will wire this to LoreApp + App::fullscreen().run()
-    eprintln!("lore-tui: browse mode not yet implemented (Phase 1)");
-    Ok(())
-}
-
-/// Launch the TUI with an initial sync pass.
-///
-/// Runs `lore sync` in the background while displaying a progress screen,
-/// then transitions to browse mode once sync completes.
-pub fn launch_sync_tui(options: LaunchOptions) -> Result<()> {
-    let _options = options;
-    // Phase 2 will implement the sync progress screen
-    eprintln!("lore-tui: sync mode not yet implemented (Phase 2)");
-    Ok(())
-}

crates/lore-tui/src/main.rs

@@ -1,53 +0,0 @@
-#![forbid(unsafe_code)]
-
-use anyhow::Result;
-use clap::Parser;
-use lore_tui::LaunchOptions;
-
-/// Terminal UI for Gitlore — explore GitLab issues, MRs, and search locally.
-#[derive(Parser, Debug)]
-#[command(name = "lore-tui", version, about)]
-struct TuiCli {
-    /// Path to lore config file (default: ~/.config/lore/config.json).
-    #[arg(short, long, env = "LORE_CONFIG_PATH")]
-    config: Option<String>,
-
-    /// Run a sync before launching the TUI.
-    #[arg(long)]
-    sync: bool,
-
-    /// Clear cached state and start fresh.
-    #[arg(long)]
-    fresh: bool,
-
-    /// Render mode: "crossterm" (default) or "native".
-    #[arg(long, default_value = "crossterm")]
-    render_mode: String,
-
-    /// Use ASCII-only drawing characters (no Unicode box drawing).
-    #[arg(long)]
-    ascii: bool,
-
-    /// Disable alternate screen (render inline).
-    #[arg(long)]
-    no_alt_screen: bool,
-}
-
-fn main() -> Result<()> {
-    let cli = TuiCli::parse();
-
-    let options = LaunchOptions {
-        config_path: cli.config,
-        sync_on_start: cli.sync,
-        fresh: cli.fresh,
-        render_mode: cli.render_mode,
-        ascii: cli.ascii,
-        no_alt_screen: cli.no_alt_screen,
-    };
-
-    if options.sync_on_start {
-        lore_tui::launch_sync_tui(options)
-    } else {
-        lore_tui::launch_tui(options)
-    }
-}

crates/lore-tui/src/message.rs

@@ -1,523 +0,0 @@
-#![allow(dead_code)] // Phase 0: types defined now, consumed in Phase 1+
-
-//! Core types for the lore-tui Elm architecture.
-//!
-//! - [`Msg`] — every user action and async result flows through this enum.
-//! - [`Screen`] — navigation targets.
-//! - [`EntityKey`] — safe cross-project entity identity.
-//! - [`AppError`] — structured error display in the TUI.
-//! - [`InputMode`] — controls key dispatch routing.
-
-use std::fmt;
-
-use chrono::{DateTime, Utc};
-use ftui::Event;
-
-// ---------------------------------------------------------------------------
-// EntityKind
-// ---------------------------------------------------------------------------
-
-/// Distinguishes issue vs merge request in an [`EntityKey`].
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
-pub enum EntityKind {
-    Issue,
-    MergeRequest,
-}
-
-// ---------------------------------------------------------------------------
-// EntityKey
-// ---------------------------------------------------------------------------
-
-/// Uniquely identifies an entity (issue or MR) across projects.
-///
-/// Bare `iid` is unsafe in multi-project datasets — equality requires
-/// project_id + iid + kind.
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
-pub struct EntityKey {
-    pub project_id: i64,
-    pub iid: i64,
-    pub kind: EntityKind,
-}
-
-impl EntityKey {
-    #[must_use]
-    pub fn issue(project_id: i64, iid: i64) -> Self {
-        Self {
-            project_id,
-            iid,
-            kind: EntityKind::Issue,
-        }
-    }
-
-    #[must_use]
-    pub fn mr(project_id: i64, iid: i64) -> Self {
-        Self {
-            project_id,
-            iid,
-            kind: EntityKind::MergeRequest,
-        }
-    }
-}
-
-impl fmt::Display for EntityKey {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        let prefix = match self.kind {
-            EntityKind::Issue => "#",
-            EntityKind::MergeRequest => "!",
-        };
-        write!(f, "p{}:{}{}", self.project_id, prefix, self.iid)
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Screen
-// ---------------------------------------------------------------------------
-
-/// Navigation targets within the TUI.
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
-pub enum Screen {
-    Dashboard,
-    IssueList,
-    IssueDetail(EntityKey),
-    MrList,
-    MrDetail(EntityKey),
-    Search,
-    Timeline,
-    Who,
-    Sync,
-    Stats,
-    Doctor,
-    Bootstrap,
-}
-
-impl Screen {
-    /// Human-readable label for breadcrumbs and status bar.
-    #[must_use]
-    pub fn label(&self) -> &str {
-        match self {
-            Self::Dashboard => "Dashboard",
-            Self::IssueList => "Issues",
-            Self::IssueDetail(_) => "Issue",
-            Self::MrList => "Merge Requests",
-            Self::MrDetail(_) => "Merge Request",
-            Self::Search => "Search",
-            Self::Timeline => "Timeline",
-            Self::Who => "Who",
-            Self::Sync => "Sync",
-            Self::Stats => "Stats",
-            Self::Doctor => "Doctor",
-            Self::Bootstrap => "Bootstrap",
-        }
-    }
-
-    /// Whether this screen shows a specific entity detail view.
-    #[must_use]
-    pub fn is_detail_or_entity(&self) -> bool {
-        matches!(self, Self::IssueDetail(_) | Self::MrDetail(_))
-    }
-}
-
-// ---------------------------------------------------------------------------
-// AppError
-// ---------------------------------------------------------------------------
-
-/// Structured error types for user-facing display in the TUI.
-#[derive(Debug, Clone)]
-pub enum AppError {
-    /// Database is busy (WAL contention).
-    DbBusy,
-    /// Database corruption detected.
-    DbCorruption(String),
-    /// GitLab rate-limited; retry after N seconds (if header present).
-    NetworkRateLimited { retry_after_secs: Option<u64> },
-    /// Network unavailable.
-    NetworkUnavailable,
-    /// GitLab authentication failed.
-    AuthFailed,
-    /// Data parsing error.
-    ParseError(String),
-    /// Internal / unexpected error.
-    Internal(String),
-}
-
-impl fmt::Display for AppError {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        match self {
-            Self::DbBusy => write!(f, "Database is busy — another process holds the lock"),
-            Self::DbCorruption(detail) => write!(f, "Database corruption: {detail}"),
-            Self::NetworkRateLimited {
-                retry_after_secs: Some(secs),
-            } => write!(f, "Rate limited by GitLab — retry in {secs}s"),
-            Self::NetworkRateLimited {
-                retry_after_secs: None,
-            } => write!(f, "Rate limited by GitLab — try again shortly"),
-            Self::NetworkUnavailable => write!(f, "Network unavailable — working offline"),
-            Self::AuthFailed => write!(f, "GitLab authentication failed — check your token"),
-            Self::ParseError(detail) => write!(f, "Parse error: {detail}"),
-            Self::Internal(detail) => write!(f, "Internal error: {detail}"),
-        }
-    }
-}
-
-// ---------------------------------------------------------------------------
-// InputMode
-// ---------------------------------------------------------------------------
-
-/// Controls how keystrokes are routed through the key dispatch pipeline.
-#[derive(Debug, Clone, Default)]
-pub enum InputMode {
-    /// Standard navigation mode — keys dispatch to screen-specific handlers.
-    #[default]
-    Normal,
-    /// Text input focused (filter bar, search box).
-    Text,
-    /// Command palette is open.
-    Palette,
-    /// "g" prefix pressed — waiting for second key (500ms timeout).
-    GoPrefix { started_at: DateTime<Utc> },
-}
-
-// ---------------------------------------------------------------------------
-// Msg
-// ---------------------------------------------------------------------------
-
-/// Every user action and async result flows through this enum.
-///
-/// Generation fields (`generation: u64`) on async result variants enable
-/// stale-response detection: if the generation doesn't match the current
-/// request generation, the result is silently dropped.
-#[derive(Debug)]
-pub enum Msg {
-    // --- Terminal events ---
-    /// Raw terminal event (key, mouse, paste, focus, clipboard).
-    RawEvent(Event),
-    /// Periodic tick from runtime subscription.
-    Tick,
-    /// Terminal resized.
-    Resize {
-        width: u16,
-        height: u16,
-    },
-
-    // --- Navigation ---
-    /// Navigate to a specific screen.
-    NavigateTo(Screen),
-    /// Go back in navigation history.
-    GoBack,
-    /// Go forward in navigation history.
-    GoForward,
-    /// Jump to the dashboard.
-    GoHome,
-    /// Jump back N screens in history.
-    JumpBack(usize),
-    /// Jump forward N screens in history.
-    JumpForward(usize),
-
-    // --- Command palette ---
-    OpenCommandPalette,
-    CloseCommandPalette,
-    CommandPaletteInput(String),
-    CommandPaletteSelect(String),
-
-    // --- Issue list ---
-    IssueListLoaded {
-        generation: u64,
-        rows: Vec<IssueRow>,
-    },
-    IssueListFilterChanged(String),
-    IssueListSortChanged,
-    IssueSelected(EntityKey),
-
-    // --- MR list ---
-    MrListLoaded {
-        generation: u64,
-        rows: Vec<MrRow>,
-    },
-    MrListFilterChanged(String),
-    MrSelected(EntityKey),
-
-    // --- Issue detail ---
-    IssueDetailLoaded {
-        generation: u64,
-        key: EntityKey,
-        detail: Box<IssueDetail>,
-    },
-
-    // --- MR detail ---
-    MrDetailLoaded {
-        generation: u64,
-        key: EntityKey,
-        detail: Box<MrDetail>,
-    },
-
-    // --- Discussions (shared by issue + MR detail) ---
-    DiscussionsLoaded {
-        generation: u64,
-        discussions: Vec<Discussion>,
-    },
-
-    // --- Search ---
-    SearchQueryChanged(String),
-    SearchRequestStarted {
-        generation: u64,
-        query: String,
-    },
-    SearchExecuted {
-        generation: u64,
-        results: Vec<SearchResult>,
-    },
-    SearchResultSelected(EntityKey),
-    SearchModeChanged,
-    SearchCapabilitiesLoaded,
-
-    // --- Timeline ---
-    TimelineLoaded {
-        generation: u64,
-        events: Vec<TimelineEvent>,
-    },
-    TimelineEntitySelected(EntityKey),
-
-    // --- Who (people) ---
-    WhoResultLoaded {
-        generation: u64,
-        result: Box<WhoResult>,
-    },
-    WhoModeChanged,
-
-    // --- Sync ---
-    SyncStarted,
-    SyncProgress {
-        stage: String,
-        current: u64,
-        total: u64,
-    },
-    SyncProgressBatch {
-        stage: String,
-        batch_size: u64,
-    },
-    SyncLogLine(String),
-    SyncBackpressureDrop,
-    SyncCompleted {
-        elapsed_ms: u64,
-    },
-    SyncCancelled,
-    SyncFailed(String),
-    SyncStreamStats {
-        bytes: u64,
-        items: u64,
-    },
-
-    // --- Search debounce ---
-    SearchDebounceArmed {
-        generation: u64,
-    },
-    SearchDebounceFired {
-        generation: u64,
-    },
-
-    // --- Dashboard ---
-    DashboardLoaded {
-        generation: u64,
-        data: Box<DashboardData>,
-    },
-
-    // --- Global actions ---
-    Error(AppError),
-    ShowHelp,
-    ShowCliEquivalent,
-    OpenInBrowser,
-    BlurTextInput,
-    ScrollToTopCurrentScreen,
-    Quit,
-}
-
-/// Convert terminal events into messages.
-///
-/// FrankenTUI requires `From<Event>` on the message type so the runtime
-/// can inject terminal events into the model's update loop.
-impl From<Event> for Msg {
-    fn from(event: Event) -> Self {
-        match event {
-            Event::Resize { width, height } => Self::Resize { width, height },
-            Event::Tick => Self::Tick,
-            other => Self::RawEvent(other),
-        }
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Placeholder data types (will be fleshed out in Phase 1+)
-// ---------------------------------------------------------------------------
-
-/// Placeholder for an issue row in list views.
-#[derive(Debug, Clone)]
-pub struct IssueRow {
-    pub key: EntityKey,
-    pub title: String,
-    pub state: String,
-}
-
-/// Placeholder for a merge request row in list views.
-#[derive(Debug, Clone)]
-pub struct MrRow {
-    pub key: EntityKey,
-    pub title: String,
-    pub state: String,
-    pub draft: bool,
-}
-
-/// Placeholder for issue detail payload.
-#[derive(Debug, Clone)]
-pub struct IssueDetail {
-    pub key: EntityKey,
-    pub title: String,
-    pub description: String,
-}
-
-/// Placeholder for MR detail payload.
-#[derive(Debug, Clone)]
-pub struct MrDetail {
-    pub key: EntityKey,
-    pub title: String,
-    pub description: String,
-}
-
-/// Placeholder for a discussion thread.
-#[derive(Debug, Clone)]
-pub struct Discussion {
-    pub id: String,
-    pub notes: Vec<String>,
-}
-
-/// Placeholder for a search result.
-#[derive(Debug, Clone)]
-pub struct SearchResult {
-    pub key: EntityKey,
-    pub title: String,
-    pub score: f64,
-}
-
-/// Placeholder for a timeline event.
-#[derive(Debug, Clone)]
-pub struct TimelineEvent {
-    pub timestamp: String,
-    pub description: String,
-}
-
-/// Placeholder for who/people intelligence result.
-#[derive(Debug, Clone)]
-pub struct WhoResult {
-    pub experts: Vec<String>,
-}
-
-/// Placeholder for dashboard summary data.
-#[derive(Debug, Clone)]
-pub struct DashboardData {
-    pub issue_count: u64,
-    pub mr_count: u64,
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn test_entity_key_equality() {
-        assert_eq!(EntityKey::issue(1, 42), EntityKey::issue(1, 42));
-        assert_ne!(EntityKey::issue(1, 42), EntityKey::mr(1, 42));
-    }
-
-    #[test]
-    fn test_entity_key_different_projects() {
-        assert_ne!(EntityKey::issue(1, 42), EntityKey::issue(2, 42));
-    }
-
-    #[test]
-    fn test_entity_key_display() {
-        assert_eq!(EntityKey::issue(5, 123).to_string(), "p5:#123");
-        assert_eq!(EntityKey::mr(5, 456).to_string(), "p5:!456");
-    }
-
-    #[test]
-    fn test_entity_key_hash_is_usable_in_collections() {
-        use std::collections::HashSet;
-        let mut set = HashSet::new();
-        set.insert(EntityKey::issue(1, 1));
-        set.insert(EntityKey::issue(1, 1)); // duplicate
-        set.insert(EntityKey::mr(1, 1));
-        assert_eq!(set.len(), 2);
-    }
-
-    #[test]
-    fn test_screen_labels() {
-        assert_eq!(Screen::Dashboard.label(), "Dashboard");
-        assert_eq!(Screen::IssueList.label(), "Issues");
-        assert_eq!(Screen::MrList.label(), "Merge Requests");
-        assert_eq!(Screen::Search.label(), "Search");
-    }
-
-    #[test]
-    fn test_screen_is_detail_or_entity() {
-        assert!(Screen::IssueDetail(EntityKey::issue(1, 1)).is_detail_or_entity());
-        assert!(Screen::MrDetail(EntityKey::mr(1, 1)).is_detail_or_entity());
-        assert!(!Screen::Dashboard.is_detail_or_entity());
-        assert!(!Screen::IssueList.is_detail_or_entity());
-        assert!(!Screen::Search.is_detail_or_entity());
-    }
-
-    #[test]
-    fn test_app_error_display() {
-        let err = AppError::DbBusy;
-        assert!(err.to_string().contains("busy"));
-
-        let err = AppError::NetworkRateLimited {
-            retry_after_secs: Some(30),
-        };
-        assert!(err.to_string().contains("30s"));
-
-        let err = AppError::NetworkRateLimited {
-            retry_after_secs: None,
-        };
-        assert!(err.to_string().contains("shortly"));
-
-        let err = AppError::AuthFailed;
-        assert!(err.to_string().contains("token"));
-    }
-
-    #[test]
-    fn test_input_mode_default_is_normal() {
-        assert!(matches!(InputMode::default(), InputMode::Normal));
-    }
-
-    #[test]
-    fn test_msg_from_event_resize() {
-        let event = Event::Resize {
-            width: 80,
-            height: 24,
-        };
-        let msg = Msg::from(event);
-        assert!(matches!(
-            msg,
-            Msg::Resize {
-                width: 80,
-                height: 24
-            }
-        ));
-    }
-
-    #[test]
-    fn test_msg_from_event_tick() {
-        let msg = Msg::from(Event::Tick);
-        assert!(matches!(msg, Msg::Tick));
-    }
-
-    #[test]
-    fn test_msg_from_event_focus_wraps_raw() {
-        let msg = Msg::from(Event::Focus(true));
-        assert!(matches!(msg, Msg::RawEvent(Event::Focus(true))));
-    }
-}

crates/lore-tui/src/navigation.rs

@@ -1,339 +0,0 @@
-#![allow(dead_code)] // Phase 1: consumed by LoreApp in bd-6pmy
-
-//! Browser-like navigation stack with vim-style jump list.
-//!
-//! Supports back/forward (browser), jump back/forward (vim Ctrl+O/Ctrl+I),
-//! and breadcrumb generation. State is preserved when navigating away —
-//! screens are never cleared on pop.
-
-use crate::message::Screen;
-
-// ---------------------------------------------------------------------------
-// NavigationStack
-// ---------------------------------------------------------------------------
-
-/// Browser-like navigation with back/forward stacks and a vim jump list.
-///
-/// The jump list only records "significant" hops — detail views and
-/// cross-references — skipping list/dashboard screens that users
-/// visit briefly during drilling.
-pub struct NavigationStack {
-    back_stack: Vec<Screen>,
-    current: Screen,
-    forward_stack: Vec<Screen>,
-    jump_list: Vec<Screen>,
-    jump_index: usize,
-}
-
-impl NavigationStack {
-    /// Create a new stack starting at the Dashboard.
-    #[must_use]
-    pub fn new() -> Self {
-        Self {
-            back_stack: Vec::new(),
-            current: Screen::Dashboard,
-            forward_stack: Vec::new(),
-            jump_list: Vec::new(),
-            jump_index: 0,
-        }
-    }
-
-    /// The currently displayed screen.
-    #[must_use]
-    pub fn current(&self) -> &Screen {
-        &self.current
-    }
-
-    /// Whether the current screen matches the given screen.
-    #[must_use]
-    pub fn is_at(&self, screen: &Screen) -> bool {
-        &self.current == screen
-    }
-
-    /// Navigate to a new screen.
-    ///
-    /// Pushes current to back_stack, clears forward_stack (browser behavior),
-    /// and records detail hops in the jump list.
-    pub fn push(&mut self, screen: Screen) {
-        let old = std::mem::replace(&mut self.current, screen);
-        self.back_stack.push(old);
-        self.forward_stack.clear();
-
-        // Record significant hops in jump list (vim behavior):
-        // truncate any forward entries beyond jump_index, then append.
-        if self.current.is_detail_or_entity() {
-            self.jump_list.truncate(self.jump_index);
-            self.jump_list.push(self.current.clone());
-            self.jump_index = self.jump_list.len();
-        }
-    }
-
-    /// Go back to the previous screen.
-    ///
-    /// Returns `None` at root (can't pop past the initial screen).
-    pub fn pop(&mut self) -> Option<&Screen> {
-        let prev = self.back_stack.pop()?;
-        let old = std::mem::replace(&mut self.current, prev);
-        self.forward_stack.push(old);
-        Some(&self.current)
-    }
-
-    /// Go forward (redo a pop).
-    ///
-    /// Returns `None` if there's nothing to go forward to.
-    pub fn go_forward(&mut self) -> Option<&Screen> {
-        let next = self.forward_stack.pop()?;
-        let old = std::mem::replace(&mut self.current, next);
-        self.back_stack.push(old);
-        Some(&self.current)
-    }
-
-    /// Jump backward through the jump list (vim Ctrl+O).
-    ///
-    /// Only visits detail/entity screens.
-    pub fn jump_back(&mut self) -> Option<&Screen> {
-        if self.jump_index == 0 {
-            return None;
-        }
-        self.jump_index -= 1;
-        self.jump_list.get(self.jump_index)
-    }
-
-    /// Jump forward through the jump list (vim Ctrl+I).
-    pub fn jump_forward(&mut self) -> Option<&Screen> {
-        if self.jump_index >= self.jump_list.len() {
-            return None;
-        }
-        let screen = self.jump_list.get(self.jump_index)?;
-        self.jump_index += 1;
-        Some(screen)
-    }
-
-    /// Reset to a single screen, clearing all history.
-    pub fn reset_to(&mut self, screen: Screen) {
-        self.current = screen;
-        self.back_stack.clear();
-        self.forward_stack.clear();
-        self.jump_list.clear();
-        self.jump_index = 0;
-    }
-
-    /// Breadcrumb labels for the current navigation path.
-    ///
-    /// Returns the back stack labels plus the current screen label.
-    #[must_use]
-    pub fn breadcrumbs(&self) -> Vec<&str> {
-        self.back_stack
-            .iter()
-            .chain(std::iter::once(&self.current))
-            .map(Screen::label)
-            .collect()
-    }
-
-    /// Navigation depth (1 = at root, 2 = one push deep, etc.).
-    #[must_use]
-    pub fn depth(&self) -> usize {
-        self.back_stack.len() + 1
-    }
-
-    /// Whether there's anything to go back to.
-    #[must_use]
-    pub fn can_go_back(&self) -> bool {
-        !self.back_stack.is_empty()
-    }
-
-    /// Whether there's anything to go forward to.
-    #[must_use]
-    pub fn can_go_forward(&self) -> bool {
-        !self.forward_stack.is_empty()
-    }
-}
-
-impl Default for NavigationStack {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::message::EntityKey;
-
-    #[test]
-    fn test_new_starts_at_dashboard() {
-        let nav = NavigationStack::new();
-        assert!(nav.is_at(&Screen::Dashboard));
-        assert_eq!(nav.depth(), 1);
-    }
-
-    #[test]
-    fn test_push_pop_preserves_order() {
-        let mut nav = NavigationStack::new();
-        nav.push(Screen::IssueList);
-        nav.push(Screen::IssueDetail(EntityKey::issue(1, 42)));
-
-        assert!(nav.is_at(&Screen::IssueDetail(EntityKey::issue(1, 42))));
-        assert_eq!(nav.depth(), 3);
-
-        nav.pop();
-        assert!(nav.is_at(&Screen::IssueList));
-
-        nav.pop();
-        assert!(nav.is_at(&Screen::Dashboard));
-    }
-
-    #[test]
-    fn test_pop_at_root_returns_none() {
-        let mut nav = NavigationStack::new();
-        assert!(nav.pop().is_none());
-        assert!(nav.is_at(&Screen::Dashboard));
-    }
-
-    #[test]
-    fn test_forward_stack_cleared_on_new_push() {
-        let mut nav = NavigationStack::new();
-        nav.push(Screen::IssueList);
-        nav.push(Screen::Search);
-        nav.pop(); // back to IssueList, Search in forward
-        assert!(nav.can_go_forward());
-
-        nav.push(Screen::Timeline); // new push clears forward
-        assert!(!nav.can_go_forward());
-    }
-
-    #[test]
-    fn test_go_forward_restores() {
-        let mut nav = NavigationStack::new();
-        nav.push(Screen::IssueList);
-        nav.push(Screen::Search);
-        nav.pop(); // back to IssueList
-
-        let screen = nav.go_forward();
-        assert!(screen.is_some());
-        assert!(nav.is_at(&Screen::Search));
-    }
-
-    #[test]
-    fn test_go_forward_returns_none_when_empty() {
-        let mut nav = NavigationStack::new();
-        assert!(nav.go_forward().is_none());
-    }
-
-    #[test]
-    fn test_jump_list_skips_list_screens() {
-        let mut nav = NavigationStack::new();
-        nav.push(Screen::IssueList); // not a detail — skip
-        nav.push(Screen::IssueDetail(EntityKey::issue(1, 1))); // detail — record
-        nav.push(Screen::MrList); // not a detail — skip
-        nav.push(Screen::MrDetail(EntityKey::mr(1, 2))); // detail — record
-
-        assert_eq!(nav.jump_list.len(), 2);
-    }
-
-    #[test]
-    fn test_jump_back_and_forward() {
-        let mut nav = NavigationStack::new();
-        let issue = Screen::IssueDetail(EntityKey::issue(1, 1));
-        let mr = Screen::MrDetail(EntityKey::mr(1, 2));
-
-        nav.push(Screen::IssueList);
-        nav.push(issue.clone());
-        nav.push(Screen::MrList);
-        nav.push(mr.clone());
-
-        // jump_index is at 2 (past the end of 2 items)
-        let prev = nav.jump_back();
-        assert_eq!(prev, Some(&mr));
-
-        let prev = nav.jump_back();
-        assert_eq!(prev, Some(&issue));
-
-        // at beginning
-        assert!(nav.jump_back().is_none());
-
-        // forward
-        let next = nav.jump_forward();
-        assert_eq!(next, Some(&issue));
-
-        let next = nav.jump_forward();
-        assert_eq!(next, Some(&mr));
-
-        // at end
-        assert!(nav.jump_forward().is_none());
-    }
-
-    #[test]
-    fn test_jump_list_truncates_on_new_push() {
-        let mut nav = NavigationStack::new();
-        nav.push(Screen::IssueDetail(EntityKey::issue(1, 1)));
-        nav.push(Screen::IssueDetail(EntityKey::issue(1, 2)));
-        nav.push(Screen::IssueDetail(EntityKey::issue(1, 3)));
-
-        // jump back twice
-        nav.jump_back();
-        nav.jump_back();
-        // jump_index = 1, pointing at issue 2
-
-        // new detail push truncates forward entries
-        nav.push(Screen::MrDetail(EntityKey::mr(1, 99)));
-
-        // should have issue(1,1) and mr(1,99), not issue(1,2) or issue(1,3)
-        assert_eq!(nav.jump_list.len(), 2);
-        assert_eq!(nav.jump_list[1], Screen::MrDetail(EntityKey::mr(1, 99)));
-    }
-
-    #[test]
-    fn test_reset_clears_all_history() {
-        let mut nav = NavigationStack::new();
-        nav.push(Screen::IssueList);
-        nav.push(Screen::Search);
-        nav.push(Screen::IssueDetail(EntityKey::issue(1, 1)));
-
-        nav.reset_to(Screen::Dashboard);
-
-        assert!(nav.is_at(&Screen::Dashboard));
-        assert_eq!(nav.depth(), 1);
-        assert!(!nav.can_go_back());
-        assert!(!nav.can_go_forward());
-        assert!(nav.jump_list.is_empty());
-    }
-
-    #[test]
-    fn test_breadcrumbs_reflect_stack() {
-        let mut nav = NavigationStack::new();
-        assert_eq!(nav.breadcrumbs(), vec!["Dashboard"]);
-
-        nav.push(Screen::IssueList);
-        assert_eq!(nav.breadcrumbs(), vec!["Dashboard", "Issues"]);
-
-        nav.push(Screen::IssueDetail(EntityKey::issue(1, 42)));
-        assert_eq!(nav.breadcrumbs(), vec!["Dashboard", "Issues", "Issue"]);
-    }
-
-    #[test]
-    fn test_default_is_new() {
-        let nav = NavigationStack::default();
-        assert!(nav.is_at(&Screen::Dashboard));
-        assert_eq!(nav.depth(), 1);
-    }
-
-    #[test]
-    fn test_can_go_back_and_forward() {
-        let mut nav = NavigationStack::new();
-        assert!(!nav.can_go_back());
-        assert!(!nav.can_go_forward());
-
-        nav.push(Screen::IssueList);
-        assert!(nav.can_go_back());
-        assert!(!nav.can_go_forward());
-
-        nav.pop();
-        assert!(!nav.can_go_back());
-        assert!(nav.can_go_forward());
-    }
-}

crates/lore-tui/src/safety.rs

@@ -1,587 +0,0 @@
-//! Terminal safety: sanitize untrusted text, URL policy, credential redaction.
-//!
-//! GitLab content can contain ANSI escapes, bidi overrides, OSC hyperlinks,
-//! and C1 control codes that could corrupt terminal rendering. This module
-//! strips dangerous sequences while preserving a safe SGR subset for readability.
-
-use std::fmt::Write;
-
-// ---------------------------------------------------------------------------
-// UrlPolicy
-// ---------------------------------------------------------------------------
-
-/// Controls how OSC 8 hyperlinks in input are handled.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
-pub enum UrlPolicy {
-    /// Remove OSC 8 hyperlinks entirely, keeping only the link text.
-    #[default]
-    Strip,
-    /// Convert hyperlinks to numbered footnotes: `text [1]` with URL list appended.
-    Footnote,
-    /// Pass hyperlinks through unchanged (only for trusted content).
-    Passthrough,
-}
-
-// ---------------------------------------------------------------------------
-// RedactPattern
-// ---------------------------------------------------------------------------
-
-/// Common patterns for PII/secret redaction.
-#[derive(Debug, Clone)]
-pub struct RedactPattern {
-    patterns: Vec<regex::Regex>,
-}
-
-impl RedactPattern {
-    /// Create a default set of redaction patterns (tokens, emails, etc.).
-    #[must_use]
-    pub fn defaults() -> Self {
-        let patterns = vec![
-            // GitLab personal access tokens
-            regex::Regex::new(r"glpat-[A-Za-z0-9_\-]{20,}").expect("valid regex"),
-            // Generic bearer/API tokens (long hex or base64-ish strings after common prefixes)
-            regex::Regex::new(r"(?i)(token|bearer|api[_-]?key)[\s:=]+\S{8,}").expect("valid regex"),
-            // Email addresses
-            regex::Regex::new(r"[a-zA-Z0-9._%+\-]+@[a-zA-Z0-9.\-]+\.[a-zA-Z]{2,}")
-                .expect("valid regex"),
-        ];
-        Self { patterns }
-    }
-
-    /// Apply all redaction patterns to the input string.
-    #[must_use]
-    pub fn redact(&self, input: &str) -> String {
-        let mut result = input.to_string();
-        for pattern in &self.patterns {
-            result = pattern.replace_all(&result, "[REDACTED]").into_owned();
-        }
-        result
-    }
-}
-
-// ---------------------------------------------------------------------------
-// sanitize_for_terminal
-// ---------------------------------------------------------------------------
-
-/// Sanitize untrusted text for safe terminal display.
-///
-/// - Strips C1 control codes (0x80-0x9F)
-/// - Strips OSC sequences (ESC ] ... ST)
-/// - Strips cursor movement CSI sequences (CSI n A/B/C/D/E/F/G/H/J/K)
-/// - Strips bidi overrides (U+202A-U+202E, U+2066-U+2069)
-/// - Preserves safe SGR subset (bold, italic, underline, reset, standard colors)
-///
-/// `url_policy` controls handling of OSC 8 hyperlinks.
-#[must_use]
-pub fn sanitize_for_terminal(input: &str, url_policy: UrlPolicy) -> String {
-    let mut output = String::with_capacity(input.len());
-    let mut footnotes: Vec<String> = Vec::new();
-    let chars: Vec<char> = input.chars().collect();
-    let len = chars.len();
-    let mut i = 0;
-
-    while i < len {
-        let ch = chars[i];
-
-        // --- Bidi overrides ---
-        if is_bidi_override(ch) {
-            i += 1;
-            continue;
-        }
-
-        // --- C1 control codes (U+0080-U+009F) ---
-        if ('\u{0080}'..='\u{009F}').contains(&ch) {
-            i += 1;
-            continue;
-        }
-
-        // --- C0 control codes except tab, newline, carriage return ---
-        if ch.is_ascii_control() && ch != '\t' && ch != '\n' && ch != '\r' && ch != '\x1B' {
-            i += 1;
-            continue;
-        }
-
-        // --- ESC sequences ---
-        if ch == '\x1B' {
-            if i + 1 < len {
-                match chars[i + 1] {
-                    // CSI sequence: ESC [
-                    '[' => {
-                        let (consumed, safe_seq) = parse_csi(&chars, i);
-                        if let Some(seq) = safe_seq {
-                            output.push_str(&seq);
-                        }
-                        i += consumed;
-                        continue;
-                    }
-                    // OSC sequence: ESC ]
-                    ']' => {
-                        let (consumed, link_text, link_url) = parse_osc(&chars, i);
-                        match url_policy {
-                            UrlPolicy::Strip => {
-                                if let Some(text) = link_text {
-                                    output.push_str(&text);
-                                }
-                            }
-                            UrlPolicy::Footnote => {
-                                if let (Some(text), Some(url)) = (link_text, link_url) {
-                                    footnotes.push(url);
-                                    let _ = write!(output, "{text} [{n}]", n = footnotes.len());
-                                }
-                            }
-                            UrlPolicy::Passthrough => {
-                                // Reproduce the raw OSC sequence
-                                for &ch_raw in &chars[i..len.min(i + consumed)] {
-                                    output.push(ch_raw);
-                                }
-                            }
-                        }
-                        i += consumed;
-                        continue;
-                    }
-                    _ => {
-                        // Unknown ESC sequence — skip ESC + next char
-                        i += 2;
-                        continue;
-                    }
-                }
-            } else {
-                // Trailing ESC at end of input
-                i += 1;
-                continue;
-            }
-        }
-
-        // --- Normal character ---
-        output.push(ch);
-        i += 1;
-    }
-
-    // Append footnotes if any
-    if !footnotes.is_empty() {
-        output.push('\n');
-        for (idx, url) in footnotes.iter().enumerate() {
-            let _ = write!(output, "\n[{}] {url}", idx + 1);
-        }
-    }
-
-    output
-}
-
-// ---------------------------------------------------------------------------
-// Bidi check
-// ---------------------------------------------------------------------------
-
-fn is_bidi_override(ch: char) -> bool {
-    matches!(
-        ch,
-        '\u{202A}' // LRE
-        | '\u{202B}' // RLE
-        | '\u{202C}' // PDF
-        | '\u{202D}' // LRO
-        | '\u{202E}' // RLO
-        | '\u{2066}' // LRI
-        | '\u{2067}' // RLI
-        | '\u{2068}' // FSI
-        | '\u{2069}' // PDI
-    )
-}
-
-// ---------------------------------------------------------------------------
-// CSI parser
-// ---------------------------------------------------------------------------
-
-/// Parse a CSI sequence starting at `chars[start]` (which should be ESC).
-///
-/// Returns `(chars_consumed, Option<safe_sequence_string>)`.
-/// If the CSI is a safe SGR, returns the full sequence string to preserve.
-/// Otherwise returns None (strip it).
-fn parse_csi(chars: &[char], start: usize) -> (usize, Option<String>) {
-    // Minimum: ESC [ <final_byte>
-    debug_assert!(chars[start] == '\x1B');
-    debug_assert!(start + 1 < chars.len() && chars[start + 1] == '[');
-
-    let mut i = start + 2; // skip ESC [
-    let len = chars.len();
-
-    // Collect parameter bytes (0x30-0x3F) and intermediate bytes (0x20-0x2F)
-    let param_start = i;
-    while i < len && (chars[i] as u32) >= 0x20 && (chars[i] as u32) <= 0x3F {
-        i += 1;
-    }
-
-    // Collect intermediate bytes
-    while i < len && (chars[i] as u32) >= 0x20 && (chars[i] as u32) <= 0x2F {
-        i += 1;
-    }
-
-    // Final byte (0x40-0x7E)
-    if i >= len || (chars[i] as u32) < 0x40 || (chars[i] as u32) > 0x7E {
-        // Malformed — consume what we've seen and strip
-        return (i.saturating_sub(start).max(2), None);
-    }
-
-    let final_byte = chars[i];
-    let consumed = i + 1 - start;
-
-    // Only preserve SGR sequences (final byte 'm')
-    if final_byte == 'm' {
-        let param_str: String = chars[param_start..i].iter().collect();
-        if is_safe_sgr(&param_str) {
-            let full_seq: String = chars[start..start + consumed].iter().collect();
-            return (consumed, Some(full_seq));
-        }
-    }
-
-    // Anything else (cursor movement A-H, erase J/K, etc.) is stripped
-    (consumed, None)
-}
-
-/// Check if all SGR parameters in a sequence are in the safe subset.
-///
-/// Safe: 0 (reset), 1 (bold), 3 (italic), 4 (underline), 22 (normal intensity),
-/// 23 (not italic), 24 (not underline), 39 (default fg), 49 (default bg),
-/// 30-37 (standard fg), 40-47 (standard bg), 90-97 (bright fg), 100-107 (bright bg).
-fn is_safe_sgr(params: &str) -> bool {
-    if params.is_empty() {
-        return true; // ESC[m is reset
-    }
-
-    for param in params.split(';') {
-        let param = param.trim();
-        if param.is_empty() {
-            continue; // treat empty as 0
-        }
-        let Ok(n) = param.parse::<u32>() else {
-            return false;
-        };
-        if !is_safe_sgr_code(n) {
-            return false;
-        }
-    }
-    true
-}
-
-fn is_safe_sgr_code(n: u32) -> bool {
-    matches!(
-        n,
-        0  // reset
-        | 1  // bold
-        | 3  // italic
-        | 4  // underline
-        | 22 // normal intensity (turn off bold)
-        | 23 // not italic
-        | 24 // not underline
-        | 39 // default foreground
-        | 49 // default background
-        | 30..=37   // standard foreground colors
-        | 40..=47   // standard background colors
-        | 90..=97   // bright foreground colors
-        | 100..=107 // bright background colors
-    )
-}
-
-// ---------------------------------------------------------------------------
-// OSC parser
-// ---------------------------------------------------------------------------
-
-/// Parse an OSC sequence starting at `chars[start]` (ESC ]).
-///
-/// Returns `(chars_consumed, link_text, link_url)`.
-/// For OSC 8 hyperlinks: `ESC ] 8 ; params ; url ST text ESC ] 8 ; ; ST`
-/// For other OSC: consumed without extracting link data.
-fn parse_osc(chars: &[char], start: usize) -> (usize, Option<String>, Option<String>) {
-    debug_assert!(chars[start] == '\x1B');
-    debug_assert!(start + 1 < chars.len() && chars[start + 1] == ']');
-
-    let len = chars.len();
-    let i = start + 2; // skip ESC ]
-
-    // Find ST (String Terminator): ESC \ or BEL (0x07)
-    let osc_end = find_st(chars, i);
-
-    // Check if this is OSC 8 (hyperlink)
-    if i < len && chars[i] == '8' && i + 1 < len && chars[i + 1] == ';' {
-        // OSC 8 hyperlink: ESC ] 8 ; params ; url ST ... ESC ] 8 ; ; ST
-        let osc_content: String = chars[i..osc_end.0].iter().collect();
-        let first_consumed = osc_end.1;
-
-        // Extract URL from "8;params;url"
-        let url = extract_osc8_url(&osc_content);
-
-        // Now find the link text (between first ST and second OSC 8)
-        let after_first_st = start + 2 + first_consumed;
-        let mut text = String::new();
-        let mut j = after_first_st;
-
-        // Collect text until we hit the closing OSC 8 or end of input
-        while j < len {
-            if j + 1 < len && chars[j] == '\x1B' && chars[j + 1] == ']' {
-                // Found another OSC — this should be the closing OSC 8
-                let close_end = find_st(chars, j + 2);
-                return (
-                    j + close_end.1 - start + 2,
-                    Some(text),
-                    url.map(String::from),
-                );
-            }
-            text.push(chars[j]);
-            j += 1;
-        }
-
-        // Reached end without closing OSC 8
-        return (j - start, Some(text), url.map(String::from));
-    }
-
-    // Non-OSC-8: just consume and strip
-    (osc_end.1 + (start + 2 - start), None, None)
-}
-
-/// Find the String Terminator (ST) for an OSC sequence.
-/// ST is either ESC \ (two chars) or BEL (0x07).
-/// Returns (content_end_index, total_consumed_from_content_start).
-fn find_st(chars: &[char], from: usize) -> (usize, usize) {
-    let len = chars.len();
-    let mut i = from;
-    while i < len {
-        if chars[i] == '\x07' {
-            return (i, i - from + 1);
-        }
-        if i + 1 < len && chars[i] == '\x1B' && chars[i + 1] == '\\' {
-            return (i, i - from + 2);
-        }
-        i += 1;
-    }
-    // Unterminated — consume everything
-    (len, len - from)
-}
-
-/// Extract URL from OSC 8 content "8;params;url".
-fn extract_osc8_url(content: &str) -> Option<&str> {
-    // Format: "8;params;url"
-    let rest = content.strip_prefix("8;")?;
-    // Skip params (up to next ;)
-    let url_start = rest.find(';')? + 1;
-    let url = &rest[url_start..];
-    if url.is_empty() { None } else { Some(url) }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    // --- CSI / cursor movement ---
-
-    #[test]
-    fn test_strips_cursor_movement() {
-        // CSI 5A = cursor up 5
-        let input = "before\x1B[5Aafter";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, "beforeafter");
-    }
-
-    #[test]
-    fn test_strips_cursor_movement_all_directions() {
-        for dir in ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H'] {
-            let input = format!("x\x1B[3{dir}y");
-            let result = sanitize_for_terminal(&input, UrlPolicy::Strip);
-            assert_eq!(result, "xy", "failed for direction {dir}");
-        }
-    }
-
-    #[test]
-    fn test_strips_erase_sequences() {
-        // CSI 2J = erase display
-        let input = "before\x1B[2Jafter";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, "beforeafter");
-    }
-
-    // --- SGR preservation ---
-
-    #[test]
-    fn test_preserves_bold_italic_underline_reset() {
-        let input = "\x1B[1mbold\x1B[0m \x1B[3mitalic\x1B[0m \x1B[4munderline\x1B[0m";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, input);
-    }
-
-    #[test]
-    fn test_preserves_standard_colors() {
-        // Red foreground, green background
-        let input = "\x1B[31mred\x1B[42m on green\x1B[0m";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, input);
-    }
-
-    #[test]
-    fn test_preserves_bright_colors() {
-        let input = "\x1B[91mbright red\x1B[0m";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, input);
-    }
-
-    #[test]
-    fn test_preserves_combined_safe_sgr() {
-        // Bold + red foreground in one sequence
-        let input = "\x1B[1;31mbold red\x1B[0m";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, input);
-    }
-
-    #[test]
-    fn test_strips_unsafe_sgr() {
-        // SGR 8 = hidden text (not in safe list)
-        let input = "\x1B[8mhidden\x1B[0m";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        // SGR 8 stripped, SGR 0 preserved
-        assert_eq!(result, "hidden\x1B[0m");
-    }
-
-    // --- C1 control codes ---
-
-    #[test]
-    fn test_strips_c1_control_codes() {
-        // U+008D = Reverse Index, U+009B = CSI (8-bit)
-        let input = format!("before{}middle{}after", '\u{008D}', '\u{009B}');
-        let result = sanitize_for_terminal(&input, UrlPolicy::Strip);
-        assert_eq!(result, "beforemiddleafter");
-    }
-
-    // --- Bidi overrides ---
-
-    #[test]
-    fn test_strips_bidi_overrides() {
-        let input = format!(
-            "normal{}reversed{}end",
-            '\u{202E}', // RLO
-            '\u{202C}'  // PDF
-        );
-        let result = sanitize_for_terminal(&input, UrlPolicy::Strip);
-        assert_eq!(result, "normalreversedend");
-    }
-
-    #[test]
-    fn test_strips_all_bidi_chars() {
-        let bidi_chars = [
-            '\u{202A}', '\u{202B}', '\u{202C}', '\u{202D}', '\u{202E}', '\u{2066}', '\u{2067}',
-            '\u{2068}', '\u{2069}',
-        ];
-        for ch in bidi_chars {
-            let input = format!("a{ch}b");
-            let result = sanitize_for_terminal(&input, UrlPolicy::Strip);
-            assert_eq!(result, "ab", "failed for U+{:04X}", ch as u32);
-        }
-    }
-
-    // --- OSC sequences ---
-
-    #[test]
-    fn test_strips_osc_sequences() {
-        // OSC 0 (set title): ESC ] 0 ; title BEL
-        let input = "before\x1B]0;My Title\x07after";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, "beforeafter");
-    }
-
-    // --- OSC 8 hyperlinks ---
-
-    #[test]
-    fn test_url_policy_strip() {
-        // OSC 8 hyperlink: ESC]8;;url ST text ESC]8;; ST
-        let input = "click \x1B]8;;https://example.com\x07here\x1B]8;;\x07 done";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, "click here done");
-    }
-
-    #[test]
-    fn test_url_policy_footnote() {
-        let input = "click \x1B]8;;https://example.com\x07here\x1B]8;;\x07 done";
-        let result = sanitize_for_terminal(input, UrlPolicy::Footnote);
-        assert!(result.contains("here [1]"));
-        assert!(result.contains("[1] https://example.com"));
-    }
-
-    // --- Redaction ---
-
-    #[test]
-    fn test_redact_gitlab_token() {
-        let redactor = RedactPattern::defaults();
-        let input = "My token is glpat-AbCdEfGhIjKlMnOpQrStUvWx";
-        let result = redactor.redact(input);
-        assert_eq!(result, "My token is [REDACTED]");
-    }
-
-    #[test]
-    fn test_redact_email() {
-        let redactor = RedactPattern::defaults();
-        let input = "Contact user@example.com for details";
-        let result = redactor.redact(input);
-        assert_eq!(result, "Contact [REDACTED] for details");
-    }
-
-    #[test]
-    fn test_redact_bearer_token() {
-        let redactor = RedactPattern::defaults();
-        let input = "Authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCI";
-        let result = redactor.redact(input);
-        assert!(result.contains("[REDACTED]"));
-        assert!(!result.contains("eyJ"));
-    }
-
-    // --- Edge cases ---
-
-    #[test]
-    fn test_empty_input() {
-        assert_eq!(sanitize_for_terminal("", UrlPolicy::Strip), "");
-    }
-
-    #[test]
-    fn test_safe_content_passthrough() {
-        let input = "Hello, world! This is normal text.\nWith newlines\tand tabs.";
-        assert_eq!(sanitize_for_terminal(input, UrlPolicy::Strip), input);
-    }
-
-    #[test]
-    fn test_trailing_esc() {
-        let input = "text\x1B";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, "text");
-    }
-
-    #[test]
-    fn test_malformed_csi_does_not_eat_text() {
-        // ESC [ without a valid final byte before next printable
-        let input = "a\x1B[b";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        // The malformed CSI is consumed but shouldn't eat "b" as text
-        // ESC[ is start, 'b' is final byte (0x62 is in 0x40-0x7E range)
-        // So this is CSI with final byte 'b' (cursor back) — gets stripped
-        assert_eq!(result, "a");
-    }
-
-    #[test]
-    fn test_utf8_adjacent_to_escapes() {
-        let input = "\x1B[1m日本語\x1B[0m text";
-        let result = sanitize_for_terminal(input, UrlPolicy::Strip);
-        assert_eq!(result, "\x1B[1m日本語\x1B[0m text");
-    }
-
-    #[test]
-    fn test_fuzz_no_panic() {
-        // 1000 random-ish byte sequences — must not panic
-        for seed in 0u16..1000 {
-            let mut bytes = Vec::new();
-            for j in 0..50 {
-                bytes.push(((seed.wrapping_mul(31).wrapping_add(j)) & 0xFF) as u8);
-            }
-            // Best-effort UTF-8
-            let input = String::from_utf8_lossy(&bytes);
-            let _ = sanitize_for_terminal(&input, UrlPolicy::Strip);
-        }
-    }
-}

crates/lore-tui/src/state/command_palette.rs

@@ -1,11 +0,0 @@
-#![allow(dead_code)]
-
-//! Command palette state.
-
-/// State for the command palette overlay.
-#[derive(Debug, Default)]
-pub struct CommandPaletteState {
-    pub query: String,
-    pub query_focused: bool,
-    pub selected_index: usize,
-}

crates/lore-tui/src/state/dashboard.rs

@@ -1,10 +0,0 @@
-#![allow(dead_code)]
-
-//! Dashboard screen state.
-
-/// State for the dashboard summary screen.
-#[derive(Debug, Default)]
-pub struct DashboardState {
-    pub issue_count: u64,
-    pub mr_count: u64,
-}

crates/lore-tui/src/state/issue_detail.rs

@@ -1,14 +0,0 @@
-#![allow(dead_code)]
-
-//! Issue detail screen state.
-
-use crate::message::{Discussion, EntityKey, IssueDetail};
-
-/// State for the issue detail screen.
-#[derive(Debug, Default)]
-pub struct IssueDetailState {
-    pub key: Option<EntityKey>,
-    pub detail: Option<IssueDetail>,
-    pub discussions: Vec<Discussion>,
-    pub scroll_offset: u16,
-}

crates/lore-tui/src/state/issue_list.rs

@@ -1,14 +0,0 @@
-#![allow(dead_code)]
-
-//! Issue list screen state.
-
-use crate::message::IssueRow;
-
-/// State for the issue list screen.
-#[derive(Debug, Default)]
-pub struct IssueListState {
-    pub rows: Vec<IssueRow>,
-    pub filter: String,
-    pub filter_focused: bool,
-    pub selected_index: usize,
-}

crates/lore-tui/src/state/mod.rs

@@ -1,335 +0,0 @@
-#![allow(dead_code)] // Phase 1: consumed by LoreApp in bd-6pmy
-
-//! Top-level state composition for the TUI.
-//!
-//! Each screen has its own state struct. State is preserved when
-//! navigating away — screens are never cleared on pop.
-//!
-//! [`LoadState`] enables stale-while-revalidate: screens show the last
-//! available data during a refresh, with a spinner indicating the load.
-//!
-//! [`ScreenIntent`] is the pure return type from state handlers — they
-//! never spawn async tasks directly. The intent is interpreted by
-//! [`LoreApp`](crate::app::LoreApp) which dispatches through the
-//! [`TaskSupervisor`](crate::task_supervisor::TaskSupervisor).
-
-pub mod command_palette;
-pub mod dashboard;
-pub mod issue_detail;
-pub mod issue_list;
-pub mod mr_detail;
-pub mod mr_list;
-pub mod search;
-pub mod sync;
-pub mod timeline;
-pub mod who;
-
-use std::collections::HashMap;
-
-use crate::message::Screen;
-
-// Re-export screen states for convenience.
-pub use command_palette::CommandPaletteState;
-pub use dashboard::DashboardState;
-pub use issue_detail::IssueDetailState;
-pub use issue_list::IssueListState;
-pub use mr_detail::MrDetailState;
-pub use mr_list::MrListState;
-pub use search::SearchState;
-pub use sync::SyncState;
-pub use timeline::TimelineState;
-pub use who::WhoState;
-
-// ---------------------------------------------------------------------------
-// LoadState
-// ---------------------------------------------------------------------------
-
-/// Loading state for a screen's data.
-///
-/// Enables stale-while-revalidate: screens render their last data while
-/// showing a spinner when `Refreshing`.
-#[derive(Debug, Clone, PartialEq, Eq, Default)]
-pub enum LoadState {
-    /// No load in progress, data is current (or screen was never loaded).
-    #[default]
-    Idle,
-    /// First load — no data to show yet, display a full-screen spinner.
-    LoadingInitial,
-    /// Background refresh — show existing data with a spinner indicator.
-    Refreshing,
-    /// Load failed — display the error alongside any stale data.
-    Error(String),
-}
-
-impl LoadState {
-    /// Whether data is currently being loaded.
-    #[must_use]
-    pub fn is_loading(&self) -> bool {
-        matches!(self, Self::LoadingInitial | Self::Refreshing)
-    }
-}
-
-// ---------------------------------------------------------------------------
-// ScreenLoadStateMap
-// ---------------------------------------------------------------------------
-
-/// Tracks per-screen load state.
-///
-/// Returns [`LoadState::Idle`] for screens that haven't been tracked.
-/// Automatically removes entries set to `Idle` to prevent unbounded growth.
-#[derive(Debug, Default)]
-pub struct ScreenLoadStateMap {
-    map: HashMap<Screen, LoadState>,
-}
-
-impl ScreenLoadStateMap {
-    /// Get the load state for a screen (defaults to `Idle`).
-    #[must_use]
-    pub fn get(&self, screen: &Screen) -> &LoadState {
-        static IDLE: LoadState = LoadState::Idle;
-        self.map.get(screen).unwrap_or(&IDLE)
-    }
-
-    /// Set the load state for a screen.
-    ///
-    /// Setting to `Idle` removes the entry to prevent map growth.
-    pub fn set(&mut self, screen: Screen, state: LoadState) {
-        if state == LoadState::Idle {
-            self.map.remove(&screen);
-        } else {
-            self.map.insert(screen, state);
-        }
-    }
-
-    /// Whether any screen is currently loading.
-    #[must_use]
-    pub fn any_loading(&self) -> bool {
-        self.map.values().any(LoadState::is_loading)
-    }
-}
-
-// ---------------------------------------------------------------------------
-// ScreenIntent
-// ---------------------------------------------------------------------------
-
-/// Pure return type from screen state handlers.
-///
-/// State handlers must never spawn async work directly — they return
-/// an intent that [`LoreApp`] interprets and dispatches through the
-/// [`TaskSupervisor`].
-#[derive(Debug, Clone, PartialEq, Eq)]
-pub enum ScreenIntent {
-    /// No action needed.
-    None,
-    /// Navigate to a new screen.
-    Navigate(Screen),
-    /// Screen data needs re-querying (e.g., filter changed).
-    RequeryNeeded(Screen),
-}
-
-// ---------------------------------------------------------------------------
-// ScopeContext
-// ---------------------------------------------------------------------------
-
-/// Global scope filters applied across all screens.
-///
-/// When a project filter is active, all data queries scope to that
-/// project. The TUI shows the active scope in the status bar.
-#[derive(Debug, Default)]
-pub struct ScopeContext {
-    /// Active project filter (project_id).
-    pub project_id: Option<i64>,
-    /// Human-readable project name for display.
-    pub project_name: Option<String>,
-}
-
-// ---------------------------------------------------------------------------
-// AppState
-// ---------------------------------------------------------------------------
-
-/// Top-level state composition for the TUI.
-///
-/// Each field holds one screen's state. State is preserved when
-/// navigating away and restored on return.
-#[derive(Debug, Default)]
-pub struct AppState {
-    // Per-screen states.
-    pub dashboard: DashboardState,
-    pub issue_list: IssueListState,
-    pub issue_detail: IssueDetailState,
-    pub mr_list: MrListState,
-    pub mr_detail: MrDetailState,
-    pub search: SearchState,
-    pub timeline: TimelineState,
-    pub who: WhoState,
-    pub sync: SyncState,
-    pub command_palette: CommandPaletteState,
-
-    // Cross-cutting state.
-    pub global_scope: ScopeContext,
-    pub load_state: ScreenLoadStateMap,
-    pub error_toast: Option<String>,
-    pub show_help: bool,
-    pub terminal_size: (u16, u16),
-}
-
-impl AppState {
-    /// Set a screen's load state.
-    pub fn set_loading(&mut self, screen: Screen, state: LoadState) {
-        self.load_state.set(screen, state);
-    }
-
-    /// Set the global error toast.
-    pub fn set_error(&mut self, msg: String) {
-        self.error_toast = Some(msg);
-    }
-
-    /// Clear the global error toast.
-    pub fn clear_error(&mut self) {
-        self.error_toast = None;
-    }
-
-    /// Whether any text input is currently focused.
-    #[must_use]
-    pub fn has_text_focus(&self) -> bool {
-        self.issue_list.filter_focused
-            || self.mr_list.filter_focused
-            || self.search.query_focused
-            || self.command_palette.query_focused
-    }
-
-    /// Remove focus from all text inputs.
-    pub fn blur_text_focus(&mut self) {
-        self.issue_list.filter_focused = false;
-        self.mr_list.filter_focused = false;
-        self.search.query_focused = false;
-        self.command_palette.query_focused = false;
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn test_load_state_default_idle() {
-        let map = ScreenLoadStateMap::default();
-        assert_eq!(*map.get(&Screen::Dashboard), LoadState::Idle);
-        assert_eq!(*map.get(&Screen::IssueList), LoadState::Idle);
-    }
-
-    #[test]
-    fn test_load_state_set_and_get() {
-        let mut map = ScreenLoadStateMap::default();
-        map.set(Screen::Dashboard, LoadState::LoadingInitial);
-        assert_eq!(*map.get(&Screen::Dashboard), LoadState::LoadingInitial);
-        assert_eq!(*map.get(&Screen::IssueList), LoadState::Idle);
-    }
-
-    #[test]
-    fn test_load_state_set_idle_removes_entry() {
-        let mut map = ScreenLoadStateMap::default();
-        map.set(Screen::Dashboard, LoadState::Refreshing);
-        assert_eq!(map.map.len(), 1);
-
-        map.set(Screen::Dashboard, LoadState::Idle);
-        assert_eq!(map.map.len(), 0);
-        assert_eq!(*map.get(&Screen::Dashboard), LoadState::Idle);
-    }
-
-    #[test]
-    fn test_any_loading() {
-        let mut map = ScreenLoadStateMap::default();
-        assert!(!map.any_loading());
-
-        map.set(Screen::Dashboard, LoadState::LoadingInitial);
-        assert!(map.any_loading());
-
-        map.set(Screen::Dashboard, LoadState::Error("oops".into()));
-        assert!(!map.any_loading());
-    }
-
-    #[test]
-    fn test_load_state_is_loading() {
-        assert!(!LoadState::Idle.is_loading());
-        assert!(LoadState::LoadingInitial.is_loading());
-        assert!(LoadState::Refreshing.is_loading());
-        assert!(!LoadState::Error("x".into()).is_loading());
-    }
-
-    #[test]
-    fn test_app_state_default_compiles() {
-        let state = AppState::default();
-        assert!(!state.show_help);
-        assert!(state.error_toast.is_none());
-        assert_eq!(state.terminal_size, (0, 0));
-    }
-
-    #[test]
-    fn test_app_state_set_error_and_clear() {
-        let mut state = AppState::default();
-        state.set_error("db busy".into());
-        assert_eq!(state.error_toast.as_deref(), Some("db busy"));
-
-        state.clear_error();
-        assert!(state.error_toast.is_none());
-    }
-
-    #[test]
-    fn test_app_state_has_text_focus() {
-        let mut state = AppState::default();
-        assert!(!state.has_text_focus());
-
-        state.search.query_focused = true;
-        assert!(state.has_text_focus());
-    }
-
-    #[test]
-    fn test_app_state_blur_text_focus() {
-        let mut state = AppState::default();
-        state.issue_list.filter_focused = true;
-        state.mr_list.filter_focused = true;
-        state.search.query_focused = true;
-        state.command_palette.query_focused = true;
-
-        state.blur_text_focus();
-
-        assert!(!state.has_text_focus());
-        assert!(!state.issue_list.filter_focused);
-        assert!(!state.mr_list.filter_focused);
-        assert!(!state.search.query_focused);
-        assert!(!state.command_palette.query_focused);
-    }
-
-    #[test]
-    fn test_app_state_set_loading() {
-        let mut state = AppState::default();
-        state.set_loading(Screen::IssueList, LoadState::Refreshing);
-        assert_eq!(
-            *state.load_state.get(&Screen::IssueList),
-            LoadState::Refreshing
-        );
-    }
-
-    #[test]
-    fn test_screen_intent_variants() {
-        let none = ScreenIntent::None;
-        let nav = ScreenIntent::Navigate(Screen::IssueList);
-        let requery = ScreenIntent::RequeryNeeded(Screen::Search);
-
-        assert_eq!(none, ScreenIntent::None);
-        assert_eq!(nav, ScreenIntent::Navigate(Screen::IssueList));
-        assert_eq!(requery, ScreenIntent::RequeryNeeded(Screen::Search));
-    }
-
-    #[test]
-    fn test_scope_context_default() {
-        let scope = ScopeContext::default();
-        assert!(scope.project_id.is_none());
-        assert!(scope.project_name.is_none());
-    }
-}

crates/lore-tui/src/state/mr_detail.rs

@@ -1,14 +0,0 @@
-#![allow(dead_code)]
-
-//! Merge request detail screen state.
-
-use crate::message::{Discussion, EntityKey, MrDetail};
-
-/// State for the MR detail screen.
-#[derive(Debug, Default)]
-pub struct MrDetailState {
-    pub key: Option<EntityKey>,
-    pub detail: Option<MrDetail>,
-    pub discussions: Vec<Discussion>,
-    pub scroll_offset: u16,
-}

crates/lore-tui/src/state/mr_list.rs

@@ -1,14 +0,0 @@
-#![allow(dead_code)]
-
-//! Merge request list screen state.
-
-use crate::message::MrRow;
-
-/// State for the MR list screen.
-#[derive(Debug, Default)]
-pub struct MrListState {
-    pub rows: Vec<MrRow>,
-    pub filter: String,
-    pub filter_focused: bool,
-    pub selected_index: usize,
-}

crates/lore-tui/src/state/search.rs

@@ -1,14 +0,0 @@
-#![allow(dead_code)]
-
-//! Search screen state.
-
-use crate::message::SearchResult;
-
-/// State for the search screen.
-#[derive(Debug, Default)]
-pub struct SearchState {
-    pub query: String,
-    pub query_focused: bool,
-    pub results: Vec<SearchResult>,
-    pub selected_index: usize,
-}

crates/lore-tui/src/state/sync.rs

@@ -1,15 +0,0 @@
-#![allow(dead_code)]
-
-//! Sync screen state.
-
-/// State for the sync progress/summary screen.
-#[derive(Debug, Default)]
-pub struct SyncState {
-    pub stage: String,
-    pub current: u64,
-    pub total: u64,
-    pub log_lines: Vec<String>,
-    pub completed: bool,
-    pub elapsed_ms: Option<u64>,
-    pub error: Option<String>,
-}

crates/lore-tui/src/state/timeline.rs

@@ -1,12 +0,0 @@
-#![allow(dead_code)]
-
-//! Timeline screen state.
-
-use crate::message::TimelineEvent;
-
-/// State for the timeline screen.
-#[derive(Debug, Default)]
-pub struct TimelineState {
-    pub events: Vec<TimelineEvent>,
-    pub scroll_offset: u16,
-}

crates/lore-tui/src/state/who.rs

@@ -1,12 +0,0 @@
-#![allow(dead_code)]
-
-//! Who (people intelligence) screen state.
-
-use crate::message::WhoResult;
-
-/// State for the who/people screen.
-#[derive(Debug, Default)]
-pub struct WhoState {
-    pub result: Option<WhoResult>,
-    pub scroll_offset: u16,
-}

crates/lore-tui/src/task_supervisor.rs

@@ -1,380 +0,0 @@
-#![allow(dead_code)] // Phase 1: consumed by LoreApp in bd-6pmy
-
-//! Centralized background task management with dedup and cancellation.
-//!
-//! All background work (DB queries, sync, search) flows through
-//! [`TaskSupervisor`]. Submitting a task with a key that already has an
-//! active handle cancels the previous task via its [`CancelToken`] and
-//! bumps the generation counter.
-//!
-//! Generation IDs enable stale-result detection: when an async result
-//! arrives, [`is_current`] checks whether the result's generation
-//! matches the latest submission for that key.
-
-use std::collections::HashMap;
-use std::sync::Arc;
-use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
-
-use crate::message::Screen;
-
-// ---------------------------------------------------------------------------
-// TaskKey
-// ---------------------------------------------------------------------------
-
-/// Deduplication key for background tasks.
-///
-/// Two tasks with the same key cannot run concurrently — submitting a
-/// new task with an existing key cancels the previous one.
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
-pub enum TaskKey {
-    /// Load data for a specific screen.
-    LoadScreen(Screen),
-    /// Global search query.
-    Search,
-    /// Sync stream (only one at a time).
-    SyncStream,
-    /// Re-query after filter change on a specific screen.
-    FilterRequery(Screen),
-}
-
-// ---------------------------------------------------------------------------
-// TaskPriority
-// ---------------------------------------------------------------------------
-
-/// Priority levels for task scheduling.
-///
-/// Lower numeric value = higher priority.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
-pub enum TaskPriority {
-    /// User-initiated input (highest priority).
-    Input = 0,
-    /// Navigation-triggered data load.
-    Navigation = 1,
-    /// Background refresh / prefetch (lowest priority).
-    Background = 2,
-}
-
-// ---------------------------------------------------------------------------
-// CancelToken
-// ---------------------------------------------------------------------------
-
-/// Thread-safe cooperative cancellation flag.
-///
-/// Background tasks poll [`is_cancelled`] periodically and exit early
-/// when it returns `true`.
-#[derive(Debug)]
-pub struct CancelToken {
-    cancelled: AtomicBool,
-}
-
-impl CancelToken {
-    /// Create a new, non-cancelled token.
-    #[must_use]
-    pub fn new() -> Self {
-        Self {
-            cancelled: AtomicBool::new(false),
-        }
-    }
-
-    /// Signal cancellation.
-    pub fn cancel(&self) {
-        self.cancelled.store(true, Ordering::Relaxed);
-    }
-
-    /// Check whether cancellation has been requested.
-    #[must_use]
-    pub fn is_cancelled(&self) -> bool {
-        self.cancelled.load(Ordering::Relaxed)
-    }
-}
-
-impl Default for CancelToken {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
-// ---------------------------------------------------------------------------
-// InterruptHandle
-// ---------------------------------------------------------------------------
-
-/// Opaque handle for interrupting a rusqlite operation.
-///
-/// Wraps the rusqlite `InterruptHandle` so the supervisor can cancel
-/// long-running queries. This is only set for tasks that lease a reader
-/// connection from [`DbManager`](crate::db::DbManager).
-pub struct InterruptHandle {
-    handle: rusqlite::InterruptHandle,
-}
-
-impl std::fmt::Debug for InterruptHandle {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        f.debug_struct("InterruptHandle").finish_non_exhaustive()
-    }
-}
-
-impl InterruptHandle {
-    /// Wrap a rusqlite interrupt handle.
-    #[must_use]
-    pub fn new(handle: rusqlite::InterruptHandle) -> Self {
-        Self { handle }
-    }
-
-    /// Interrupt the associated SQLite operation.
-    pub fn interrupt(&self) {
-        self.handle.interrupt();
-    }
-}
-
-// ---------------------------------------------------------------------------
-// TaskHandle
-// ---------------------------------------------------------------------------
-
-/// Handle returned when a task is submitted.
-///
-/// Callers use this to pass the generation ID into async work so
-/// results can be tagged and checked for staleness.
-#[derive(Debug)]
-pub struct TaskHandle {
-    /// Dedup key for this task.
-    pub key: TaskKey,
-    /// Monotonically increasing generation for stale detection.
-    pub generation: u64,
-    /// Cooperative cancellation token (shared with the supervisor).
-    pub cancel: Arc<CancelToken>,
-    /// Optional SQLite interrupt handle for long queries.
-    pub interrupt: Option<InterruptHandle>,
-}
-
-// ---------------------------------------------------------------------------
-// TaskSupervisor
-// ---------------------------------------------------------------------------
-
-/// Manages background tasks with deduplication and cancellation.
-///
-/// Only one task per [`TaskKey`] can be active. Submitting a new task
-/// with an existing key cancels the previous one (via its cancel token
-/// and optional interrupt handle) before registering the new handle.
-pub struct TaskSupervisor {
-    active: HashMap<TaskKey, TaskHandle>,
-    next_generation: AtomicU64,
-}
-
-impl TaskSupervisor {
-    /// Create a new supervisor with no active tasks.
-    #[must_use]
-    pub fn new() -> Self {
-        Self {
-            active: HashMap::new(),
-            next_generation: AtomicU64::new(1),
-        }
-    }
-
-    /// Submit a new task, cancelling any existing task with the same key.
-    ///
-    /// Returns a [`TaskHandle`] with a fresh generation ID and a shared
-    /// cancel token. The caller clones the `Arc<CancelToken>` and passes
-    /// it into the async work.
-    pub fn submit(&mut self, key: TaskKey) -> &TaskHandle {
-        // Cancel existing task with this key, if any.
-        if let Some(old) = self.active.remove(&key) {
-            old.cancel.cancel();
-            if let Some(interrupt) = &old.interrupt {
-                interrupt.interrupt();
-            }
-        }
-
-        let generation = self.next_generation.fetch_add(1, Ordering::Relaxed);
-        let cancel = Arc::new(CancelToken::new());
-
-        let handle = TaskHandle {
-            key: key.clone(),
-            generation,
-            cancel,
-            interrupt: None,
-        };
-
-        self.active.insert(key.clone(), handle);
-        self.active.get(&key).expect("just inserted")
-    }
-
-    /// Check whether a generation is current for a given key.
-    ///
-    /// Returns `true` only if the key has an active handle with the
-    /// specified generation.
-    #[must_use]
-    pub fn is_current(&self, key: &TaskKey, generation: u64) -> bool {
-        self.active
-            .get(key)
-            .is_some_and(|h| h.generation == generation)
-    }
-
-    /// Mark a task as complete, removing its handle.
-    ///
-    /// Only removes the handle if the generation matches the active one.
-    /// This prevents a late-arriving completion from removing a newer
-    /// task's handle.
-    pub fn complete(&mut self, key: &TaskKey, generation: u64) {
-        if self.is_current(key, generation) {
-            self.active.remove(key);
-        }
-    }
-
-    /// Cancel all active tasks.
-    ///
-    /// Used during shutdown to ensure background work stops promptly.
-    pub fn cancel_all(&mut self) {
-        for (_, handle) in self.active.drain() {
-            handle.cancel.cancel();
-            if let Some(interrupt) = &handle.interrupt {
-                interrupt.interrupt();
-            }
-        }
-    }
-
-    /// Number of currently active tasks.
-    #[must_use]
-    pub fn active_count(&self) -> usize {
-        self.active.len()
-    }
-}
-
-impl Default for TaskSupervisor {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn test_submit_cancels_previous() {
-        let mut sup = TaskSupervisor::new();
-
-        let gen1 = sup.submit(TaskKey::Search).generation;
-        let cancel1 = sup.active.get(&TaskKey::Search).unwrap().cancel.clone();
-
-        let gen2 = sup.submit(TaskKey::Search).generation;
-
-        // First task's token should be cancelled.
-        assert!(cancel1.is_cancelled());
-        // Second task should have a different (higher) generation.
-        assert!(gen2 > gen1);
-        // Only one active task for this key.
-        assert_eq!(sup.active_count(), 1);
-    }
-
-    #[test]
-    fn test_is_current_after_supersede() {
-        let mut sup = TaskSupervisor::new();
-
-        let gen1 = sup.submit(TaskKey::Search).generation;
-        let gen2 = sup.submit(TaskKey::Search).generation;
-
-        assert!(!sup.is_current(&TaskKey::Search, gen1));
-        assert!(sup.is_current(&TaskKey::Search, gen2));
-    }
-
-    #[test]
-    fn test_complete_removes_handle() {
-        let mut sup = TaskSupervisor::new();
-        let generation = sup.submit(TaskKey::Search).generation;
-
-        assert_eq!(sup.active_count(), 1);
-        sup.complete(&TaskKey::Search, generation);
-        assert_eq!(sup.active_count(), 0);
-    }
-
-    #[test]
-    fn test_complete_ignores_stale() {
-        let mut sup = TaskSupervisor::new();
-
-        let gen1 = sup.submit(TaskKey::Search).generation;
-        let gen2 = sup.submit(TaskKey::Search).generation;
-
-        // Completing with old generation should NOT remove the newer handle.
-        sup.complete(&TaskKey::Search, gen1);
-        assert_eq!(sup.active_count(), 1);
-        assert!(sup.is_current(&TaskKey::Search, gen2));
-    }
-
-    #[test]
-    fn test_generation_monotonic() {
-        let mut sup = TaskSupervisor::new();
-
-        let g1 = sup.submit(TaskKey::Search).generation;
-        let g2 = sup.submit(TaskKey::SyncStream).generation;
-        let g3 = sup.submit(TaskKey::Search).generation;
-
-        assert!(g1 < g2);
-        assert!(g2 < g3);
-    }
-
-    #[test]
-    fn test_different_keys_coexist() {
-        let mut sup = TaskSupervisor::new();
-
-        sup.submit(TaskKey::Search);
-        sup.submit(TaskKey::SyncStream);
-        sup.submit(TaskKey::LoadScreen(Screen::Dashboard));
-
-        assert_eq!(sup.active_count(), 3);
-    }
-
-    #[test]
-    fn test_cancel_all() {
-        let mut sup = TaskSupervisor::new();
-
-        let cancel_search = {
-            sup.submit(TaskKey::Search);
-            sup.active.get(&TaskKey::Search).unwrap().cancel.clone()
-        };
-        let cancel_sync = {
-            sup.submit(TaskKey::SyncStream);
-            sup.active.get(&TaskKey::SyncStream).unwrap().cancel.clone()
-        };
-
-        sup.cancel_all();
-
-        assert!(cancel_search.is_cancelled());
-        assert!(cancel_sync.is_cancelled());
-        assert_eq!(sup.active_count(), 0);
-    }
-
-    #[test]
-    fn test_cancel_token_default_is_not_cancelled() {
-        let token = CancelToken::new();
-        assert!(!token.is_cancelled());
-        token.cancel();
-        assert!(token.is_cancelled());
-    }
-
-    #[test]
-    fn test_cancel_token_is_send_sync() {
-        fn assert_send_sync<T: Send + Sync>() {}
-        assert_send_sync::<CancelToken>();
-        assert_send_sync::<Arc<CancelToken>>();
-    }
-
-    #[test]
-    fn test_task_supervisor_default() {
-        let sup = TaskSupervisor::default();
-        assert_eq!(sup.active_count(), 0);
-    }
-
-    #[test]
-    fn test_filter_requery_key_distinct_per_screen() {
-        let mut sup = TaskSupervisor::new();
-
-        sup.submit(TaskKey::FilterRequery(Screen::IssueList));
-        sup.submit(TaskKey::FilterRequery(Screen::MrList));
-
-        assert_eq!(sup.active_count(), 2);
-    }
-}

crates/lore-tui/src/theme.rs

@@ -1,251 +0,0 @@
-#![allow(dead_code)] // Phase 0: types defined now, consumed in Phase 1+
-
-//! Flexoki-based theme for the lore TUI.
-//!
-//! Uses FrankenTUI's `AdaptiveColor::adaptive(light, dark)` for automatic
-//! light/dark mode switching. The palette is [Flexoki](https://stephango.com/flexoki)
-//! by Steph Ango, designed in Oklab perceptual color space for balanced contrast.
-
-use ftui::{AdaptiveColor, Color, PackedRgba, Style, Theme};
-
-// ---------------------------------------------------------------------------
-// Flexoki palette constants
-// ---------------------------------------------------------------------------
-
-// Base tones
-const PAPER: Color = Color::rgb(0xFF, 0xFC, 0xF0);
-const BASE_50: Color = Color::rgb(0xF2, 0xF0, 0xE5);
-const BASE_100: Color = Color::rgb(0xE6, 0xE4, 0xD9);
-const BASE_200: Color = Color::rgb(0xCE, 0xCD, 0xC3);
-const BASE_300: Color = Color::rgb(0xB7, 0xB5, 0xAC);
-const BASE_400: Color = Color::rgb(0x9F, 0x9D, 0x96);
-const BASE_500: Color = Color::rgb(0x87, 0x85, 0x80);
-const BASE_600: Color = Color::rgb(0x6F, 0x6E, 0x69);
-const BASE_700: Color = Color::rgb(0x57, 0x56, 0x53);
-const BASE_800: Color = Color::rgb(0x40, 0x3E, 0x3C);
-const BASE_850: Color = Color::rgb(0x34, 0x33, 0x31);
-const BASE_900: Color = Color::rgb(0x28, 0x27, 0x26);
-const BLACK: Color = Color::rgb(0x10, 0x0F, 0x0F);
-
-// Accent colors — light-600 (for light mode)
-const RED_600: Color = Color::rgb(0xAF, 0x30, 0x29);
-const ORANGE_600: Color = Color::rgb(0xBC, 0x52, 0x15);
-const YELLOW_600: Color = Color::rgb(0xAD, 0x83, 0x01);
-const GREEN_600: Color = Color::rgb(0x66, 0x80, 0x0B);
-const CYAN_600: Color = Color::rgb(0x24, 0x83, 0x7B);
-const BLUE_600: Color = Color::rgb(0x20, 0x5E, 0xA6);
-const PURPLE_600: Color = Color::rgb(0x5E, 0x40, 0x9D);
-
-// Accent colors — dark-400 (for dark mode)
-const RED_400: Color = Color::rgb(0xD1, 0x4D, 0x41);
-const ORANGE_400: Color = Color::rgb(0xDA, 0x70, 0x2C);
-const YELLOW_400: Color = Color::rgb(0xD0, 0xA2, 0x15);
-const GREEN_400: Color = Color::rgb(0x87, 0x9A, 0x39);
-const CYAN_400: Color = Color::rgb(0x3A, 0xA9, 0x9F);
-const BLUE_400: Color = Color::rgb(0x43, 0x85, 0xBE);
-const PURPLE_400: Color = Color::rgb(0x8B, 0x7E, 0xC8);
-const MAGENTA_400: Color = Color::rgb(0xCE, 0x5D, 0x97);
-
-// Muted fallback as PackedRgba (for Style::fg)
-const MUTED_PACKED: PackedRgba = PackedRgba::rgb(0x87, 0x85, 0x80);
-
-// ---------------------------------------------------------------------------
-// build_theme
-// ---------------------------------------------------------------------------
-
-/// Build the lore TUI theme with Flexoki adaptive colors.
-///
-/// Each of the 19 semantic slots gets an `AdaptiveColor::adaptive(light, dark)`
-/// pair. FrankenTUI detects the terminal background and resolves accordingly.
-#[must_use]
-pub fn build_theme() -> Theme {
-    Theme::builder()
-        .primary(AdaptiveColor::adaptive(BLUE_600, BLUE_400))
-        .secondary(AdaptiveColor::adaptive(CYAN_600, CYAN_400))
-        .accent(AdaptiveColor::adaptive(PURPLE_600, PURPLE_400))
-        .background(AdaptiveColor::adaptive(PAPER, BLACK))
-        .surface(AdaptiveColor::adaptive(BASE_50, BASE_900))
-        .overlay(AdaptiveColor::adaptive(BASE_100, BASE_850))
-        .text(AdaptiveColor::adaptive(BASE_700, BASE_200))
-        .text_muted(AdaptiveColor::adaptive(BASE_500, BASE_500))
-        .text_subtle(AdaptiveColor::adaptive(BASE_400, BASE_600))
-        .success(AdaptiveColor::adaptive(GREEN_600, GREEN_400))
-        .warning(AdaptiveColor::adaptive(YELLOW_600, YELLOW_400))
-        .error(AdaptiveColor::adaptive(RED_600, RED_400))
-        .info(AdaptiveColor::adaptive(BLUE_600, BLUE_400))
-        .border(AdaptiveColor::adaptive(BASE_300, BASE_700))
-        .border_focused(AdaptiveColor::adaptive(BLUE_600, BLUE_400))
-        .selection_bg(AdaptiveColor::adaptive(BASE_100, BASE_800))
-        .selection_fg(AdaptiveColor::adaptive(BASE_700, BASE_100))
-        .scrollbar_track(AdaptiveColor::adaptive(BASE_50, BASE_900))
-        .scrollbar_thumb(AdaptiveColor::adaptive(BASE_300, BASE_700))
-        .build()
-}
-
-// ---------------------------------------------------------------------------
-// State colors
-// ---------------------------------------------------------------------------
-
-/// Map a GitLab entity state to a display color.
-///
-/// Returns fixed (non-adaptive) colors — state indicators should be
-/// consistent regardless of light/dark mode.
-#[must_use]
-pub fn state_color(state: &str) -> Color {
-    match state {
-        "opened" => GREEN_400,
-        "closed" => RED_400,
-        "merged" => PURPLE_400,
-        "locked" => YELLOW_400,
-        _ => BASE_500,
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Event type colors
-// ---------------------------------------------------------------------------
-
-/// Map a timeline event type to a display color.
-#[must_use]
-pub fn event_color(event_type: &str) -> Color {
-    match event_type {
-        "created" => GREEN_400,
-        "updated" => BLUE_400,
-        "closed" => RED_400,
-        "merged" => PURPLE_400,
-        "commented" => CYAN_400,
-        "labeled" => ORANGE_400,
-        "milestoned" => YELLOW_400,
-        _ => BASE_500,
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Label styling
-// ---------------------------------------------------------------------------
-
-/// Convert a GitLab label hex color (e.g., "#FF0000" or "FF0000") to a Style.
-///
-/// Falls back to muted text color if the hex string is invalid.
-#[must_use]
-pub fn label_style(hex_color: &str) -> Style {
-    let packed = parse_hex_to_packed(hex_color).unwrap_or(MUTED_PACKED);
-    Style::default().fg(packed)
-}
-
-/// Parse a hex color string like "#RRGGBB" or "RRGGBB" into a `PackedRgba`.
-fn parse_hex_to_packed(s: &str) -> Option<PackedRgba> {
-    let hex = s.strip_prefix('#').unwrap_or(s);
-    if hex.len() != 6 {
-        return None;
-    }
-    let r = u8::from_str_radix(&hex[0..2], 16).ok()?;
-    let g = u8::from_str_radix(&hex[2..4], 16).ok()?;
-    let b = u8::from_str_radix(&hex[4..6], 16).ok()?;
-    Some(PackedRgba::rgb(r, g, b))
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn test_build_theme_compiles() {
-        let theme = build_theme();
-        // Resolve for dark mode — primary should be Blue-400
-        let resolved = theme.resolve(true);
-        assert_eq!(resolved.primary, BLUE_400);
-    }
-
-    #[test]
-    fn test_build_theme_light_mode() {
-        let theme = build_theme();
-        let resolved = theme.resolve(false);
-        assert_eq!(resolved.primary, BLUE_600);
-    }
-
-    #[test]
-    fn test_build_theme_all_slots_differ_between_modes() {
-        let theme = build_theme();
-        let dark = theme.resolve(true);
-        let light = theme.resolve(false);
-        // Background should differ (Paper vs Black)
-        assert_ne!(dark.background, light.background);
-        // Text should differ
-        assert_ne!(dark.text, light.text);
-    }
-
-    #[test]
-    fn test_state_color_opened_is_green() {
-        assert_eq!(state_color("opened"), GREEN_400);
-    }
-
-    #[test]
-    fn test_state_color_closed_is_red() {
-        assert_eq!(state_color("closed"), RED_400);
-    }
-
-    #[test]
-    fn test_state_color_merged_is_purple() {
-        assert_eq!(state_color("merged"), PURPLE_400);
-    }
-
-    #[test]
-    fn test_state_color_unknown_returns_muted() {
-        assert_eq!(state_color("unknown"), BASE_500);
-    }
-
-    #[test]
-    fn test_event_color_created_is_green() {
-        assert_eq!(event_color("created"), GREEN_400);
-    }
-
-    #[test]
-    fn test_event_color_unknown_returns_muted() {
-        assert_eq!(event_color("whatever"), BASE_500);
-    }
-
-    #[test]
-    fn test_label_style_valid_hex_with_hash() {
-        let style = label_style("#FF0000");
-        assert_eq!(style.fg, Some(PackedRgba::rgb(0xFF, 0x00, 0x00)));
-    }
-
-    #[test]
-    fn test_label_style_valid_hex_without_hash() {
-        let style = label_style("00FF00");
-        assert_eq!(style.fg, Some(PackedRgba::rgb(0x00, 0xFF, 0x00)));
-    }
-
-    #[test]
-    fn test_label_style_lowercase_hex() {
-        let style = label_style("#ff0000");
-        assert_eq!(style.fg, Some(PackedRgba::rgb(0xFF, 0x00, 0x00)));
-    }
-
-    #[test]
-    fn test_label_style_invalid_hex_fallback() {
-        let style = label_style("invalid");
-        assert_eq!(style.fg, Some(MUTED_PACKED));
-    }
-
-    #[test]
-    fn test_label_style_empty_fallback() {
-        let style = label_style("");
-        assert_eq!(style.fg, Some(MUTED_PACKED));
-    }
-
-    #[test]
-    fn test_parse_hex_short_string() {
-        assert!(parse_hex_to_packed("#FFF").is_none());
-    }
-
-    #[test]
-    fn test_parse_hex_non_hex_chars() {
-        assert!(parse_hex_to_packed("#GGHHII").is_none());
-    }
-}

crates/lore-tui/src/view/common/breadcrumb.rs

@@ -1,208 +0,0 @@
-//! Navigation breadcrumb trail ("Dashboard > Issues > #42").
-
-use ftui::core::geometry::Rect;
-use ftui::render::cell::{Cell, PackedRgba};
-use ftui::render::drawing::Draw;
-use ftui::render::frame::Frame;
-
-use crate::navigation::NavigationStack;
-
-/// Render the navigation breadcrumb trail.
-///
-/// Shows "Dashboard > Issues > Issue" with " > " separators. When the
-/// trail exceeds the available width, entries are truncated from the left
-/// with a leading "...".
-pub fn render_breadcrumb(
-    frame: &mut Frame<'_>,
-    area: Rect,
-    nav: &NavigationStack,
-    text_color: PackedRgba,
-    muted_color: PackedRgba,
-) {
-    if area.height == 0 || area.width < 3 {
-        return;
-    }
-
-    let crumbs = nav.breadcrumbs();
-    let separator = " > ";
-
-    // Build the full breadcrumb string and calculate width.
-    let full: String = crumbs.join(separator);
-    let max_width = area.width as usize;
-
-    let display = if full.len() <= max_width {
-        full
-    } else {
-        // Truncate from the left: show "... > last_crumbs"
-        truncate_breadcrumb_left(&crumbs, separator, max_width)
-    };
-
-    let base = Cell {
-        fg: text_color,
-        ..Cell::default()
-    };
-    let muted = Cell {
-        fg: muted_color,
-        ..Cell::default()
-    };
-
-    // Render each segment with separators in muted color.
-    let mut x = area.x;
-    let max_x = area.x.saturating_add(area.width);
-
-    if let Some(rest) = display.strip_prefix("...") {
-        // Render ellipsis in muted, then the rest
-        x = frame.print_text_clipped(x, area.y, "...", muted, max_x);
-        if !rest.is_empty() {
-            render_crumb_segments(frame, x, area.y, rest, separator, base, muted, max_x);
-        }
-    } else {
-        render_crumb_segments(frame, x, area.y, &display, separator, base, muted, max_x);
-    }
-}
-
-/// Render breadcrumb text with separators in muted color.
-#[allow(clippy::too_many_arguments)]
-fn render_crumb_segments(
-    frame: &mut Frame<'_>,
-    start_x: u16,
-    y: u16,
-    text: &str,
-    separator: &str,
-    base: Cell,
-    muted: Cell,
-    max_x: u16,
-) {
-    let mut x = start_x;
-    let parts: Vec<&str> = text.split(separator).collect();
-
-    for (i, part) in parts.iter().enumerate() {
-        if i > 0 {
-            x = frame.print_text_clipped(x, y, separator, muted, max_x);
-        }
-        x = frame.print_text_clipped(x, y, part, base, max_x);
-        if x >= max_x {
-            break;
-        }
-    }
-}
-
-/// Truncate breadcrumb from the left to fit within max_width.
-fn truncate_breadcrumb_left(crumbs: &[&str], separator: &str, max_width: usize) -> String {
-    let ellipsis = "...";
-
-    // Try showing progressively fewer crumbs from the right.
-    for skip in 1..crumbs.len() {
-        let tail = &crumbs[skip..];
-        let tail_str: String = tail.join(separator);
-        let candidate = format!("{ellipsis}{separator}{tail_str}");
-        if candidate.len() <= max_width {
-            return candidate;
-        }
-    }
-
-    // Last resort: just the current screen truncated.
-    let last = crumbs.last().unwrap_or(&"");
-    if last.len() + ellipsis.len() <= max_width {
-        return format!("{ellipsis}{last}");
-    }
-
-    // Truly tiny terminal: just ellipsis.
-    ellipsis.to_string()
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::message::Screen;
-    use crate::navigation::NavigationStack;
-    use ftui::render::grapheme_pool::GraphemePool;
-
-    macro_rules! with_frame {
-        ($width:expr, $height:expr, |$frame:ident| $body:block) => {{
-            let mut pool = GraphemePool::new();
-            let mut $frame = Frame::new($width, $height, &mut pool);
-            $body
-        }};
-    }
-
-    fn white() -> PackedRgba {
-        PackedRgba::rgb(0xFF, 0xFF, 0xFF)
-    }
-
-    fn gray() -> PackedRgba {
-        PackedRgba::rgb(0x80, 0x80, 0x80)
-    }
-
-    #[test]
-    fn test_breadcrumb_single_screen() {
-        with_frame!(80, 1, |frame| {
-            let nav = NavigationStack::new();
-            render_breadcrumb(&mut frame, Rect::new(0, 0, 80, 1), &nav, white(), gray());
-
-            let cell = frame.buffer.get(0, 0).unwrap();
-            assert!(
-                cell.content.as_char() == Some('D'),
-                "Expected 'D' at (0,0), got {:?}",
-                cell.content.as_char()
-            );
-        });
-    }
-
-    #[test]
-    fn test_breadcrumb_multi_screen() {
-        with_frame!(80, 1, |frame| {
-            let mut nav = NavigationStack::new();
-            nav.push(Screen::IssueList);
-            render_breadcrumb(&mut frame, Rect::new(0, 0, 80, 1), &nav, white(), gray());
-
-            let d = frame.buffer.get(0, 0).unwrap();
-            assert_eq!(d.content.as_char(), Some('D'));
-
-            // "Dashboard > Issues" = 'I' at 12
-            let i_cell = frame.buffer.get(12, 0).unwrap();
-            assert_eq!(i_cell.content.as_char(), Some('I'));
-        });
-    }
-
-    #[test]
-    fn test_breadcrumb_truncation() {
-        let crumbs = vec!["Dashboard", "Issues", "Issue"];
-        let result = truncate_breadcrumb_left(&crumbs, " > ", 20);
-        assert!(
-            result.starts_with("..."),
-            "Expected ellipsis prefix, got: {result}"
-        );
-        assert!(result.len() <= 20, "Result too long: {result}");
-    }
-
-    #[test]
-    fn test_breadcrumb_zero_height_noop() {
-        with_frame!(80, 1, |frame| {
-            let nav = NavigationStack::new();
-            render_breadcrumb(&mut frame, Rect::new(0, 0, 80, 0), &nav, white(), gray());
-        });
-    }
-
-    #[test]
-    fn test_truncate_breadcrumb_fits() {
-        let crumbs = vec!["A", "B"];
-        let result = truncate_breadcrumb_left(&crumbs, " > ", 100);
-        assert!(result.contains("..."), "Should always add ellipsis");
-    }
-
-    #[test]
-    fn test_truncate_breadcrumb_single_entry() {
-        let crumbs = vec!["Dashboard"];
-        let result = truncate_breadcrumb_left(&crumbs, " > ", 5);
-        assert_eq!(result, "...");
-    }
-
-    #[test]
-    fn test_truncate_breadcrumb_shows_last_entries() {
-        let crumbs = vec!["Dashboard", "Issues", "Issue Detail"];
-        let result = truncate_breadcrumb_left(&crumbs, " > ", 30);
-        assert!(result.starts_with("..."));
-        assert!(result.contains("Issue Detail"));
-    }
-}

crates/lore-tui/src/view/common/error_toast.rs

@@ -1,124 +0,0 @@
-//! Floating error toast at bottom-right.
-
-use ftui::core::geometry::Rect;
-use ftui::render::cell::{Cell, PackedRgba};
-use ftui::render::drawing::Draw;
-use ftui::render::frame::Frame;
-
-/// Render a floating error toast at the bottom-right of the area.
-///
-/// The toast has a colored background and truncates long messages.
-pub fn render_error_toast(
-    frame: &mut Frame<'_>,
-    area: Rect,
-    msg: &str,
-    error_bg: PackedRgba,
-    error_fg: PackedRgba,
-) {
-    if area.height < 3 || area.width < 10 || msg.is_empty() {
-        return;
-    }
-
-    // Toast dimensions: message + padding, max 60 chars or half screen.
-    let max_toast_width = (area.width / 2).clamp(20, 60);
-    let toast_text = if msg.len() as u16 > max_toast_width.saturating_sub(4) {
-        let trunc_len = max_toast_width.saturating_sub(7) as usize;
-        format!(" {}... ", &msg[..trunc_len.min(msg.len())])
-    } else {
-        format!(" {msg} ")
-    };
-    let toast_width = toast_text.len() as u16;
-    let toast_height: u16 = 1;
-
-    // Position: bottom-right with 1-cell margin.
-    let x = area.right().saturating_sub(toast_width + 1);
-    let y = area.bottom().saturating_sub(toast_height + 1);
-
-    let toast_rect = Rect::new(x, y, toast_width, toast_height);
-
-    // Fill background.
-    let bg_cell = Cell {
-        bg: error_bg,
-        ..Cell::default()
-    };
-    frame.draw_rect_filled(toast_rect, bg_cell);
-
-    // Render text.
-    let text_cell = Cell {
-        fg: error_fg,
-        bg: error_bg,
-        ..Cell::default()
-    };
-    frame.print_text_clipped(x, y, &toast_text, text_cell, area.right());
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use ftui::render::grapheme_pool::GraphemePool;
-
-    macro_rules! with_frame {
-        ($width:expr, $height:expr, |$frame:ident| $body:block) => {{
-            let mut pool = GraphemePool::new();
-            let mut $frame = Frame::new($width, $height, &mut pool);
-            $body
-        }};
-    }
-
-    fn white() -> PackedRgba {
-        PackedRgba::rgb(0xFF, 0xFF, 0xFF)
-    }
-
-    fn red_bg() -> PackedRgba {
-        PackedRgba::rgb(0xFF, 0x00, 0x00)
-    }
-
-    #[test]
-    fn test_error_toast_renders() {
-        with_frame!(80, 24, |frame| {
-            render_error_toast(
-                &mut frame,
-                Rect::new(0, 0, 80, 24),
-                "Database is busy",
-                red_bg(),
-                white(),
-            );
-
-            let y = 22u16;
-            let has_content = (40..80u16).any(|x| {
-                let cell = frame.buffer.get(x, y).unwrap();
-                !cell.is_empty()
-            });
-            assert!(has_content, "Expected error toast at bottom-right");
-        });
-    }
-
-    #[test]
-    fn test_error_toast_empty_message_noop() {
-        with_frame!(80, 24, |frame| {
-            render_error_toast(&mut frame, Rect::new(0, 0, 80, 24), "", red_bg(), white());
-
-            let has_content = (0..80u16).any(|x| {
-                (0..24u16).any(|y| {
-                    let cell = frame.buffer.get(x, y).unwrap();
-                    !cell.is_empty()
-                })
-            });
-            assert!(!has_content, "Empty message should render nothing");
-        });
-    }
-
-    #[test]
-    fn test_error_toast_truncates_long_message() {
-        with_frame!(80, 24, |frame| {
-            let long_msg = "A".repeat(200);
-            render_error_toast(
-                &mut frame,
-                Rect::new(0, 0, 80, 24),
-                &long_msg,
-                red_bg(),
-                white(),
-            );
-        });
-    }
-}

crates/lore-tui/src/view/common/help_overlay.rs

@@ -1,173 +0,0 @@
-//! Centered modal listing keybindings for the current screen.
-
-use ftui::core::geometry::Rect;
-use ftui::render::cell::{Cell, PackedRgba};
-use ftui::render::drawing::Draw;
-use ftui::render::frame::Frame;
-
-use crate::commands::CommandRegistry;
-use crate::message::Screen;
-
-/// Render a centered help overlay listing keybindings for the current screen.
-///
-/// The overlay is a bordered modal that lists all commands from the
-/// registry that are available on the current screen.
-#[allow(clippy::too_many_arguments)]
-pub fn render_help_overlay(
-    frame: &mut Frame<'_>,
-    area: Rect,
-    registry: &CommandRegistry,
-    screen: &Screen,
-    border_color: PackedRgba,
-    text_color: PackedRgba,
-    muted_color: PackedRgba,
-    scroll_offset: usize,
-) {
-    if area.height < 5 || area.width < 20 {
-        return;
-    }
-
-    // Overlay dimensions: 60% of screen, capped.
-    let overlay_width = (area.width * 3 / 5).clamp(30, 70);
-    let overlay_height = (area.height * 3 / 5).clamp(8, 30);
-
-    let overlay_x = area.x + (area.width.saturating_sub(overlay_width)) / 2;
-    let overlay_y = area.y + (area.height.saturating_sub(overlay_height)) / 2;
-    let overlay_rect = Rect::new(overlay_x, overlay_y, overlay_width, overlay_height);
-
-    // Draw border.
-    let border_cell = Cell {
-        fg: border_color,
-        ..Cell::default()
-    };
-    frame.draw_border(
-        overlay_rect,
-        ftui::render::drawing::BorderChars::ROUNDED,
-        border_cell,
-    );
-
-    // Title.
-    let title = " Help (? to close) ";
-    let title_x = overlay_x + (overlay_width.saturating_sub(title.len() as u16)) / 2;
-    let title_cell = Cell {
-        fg: border_color,
-        ..Cell::default()
-    };
-    frame.print_text_clipped(title_x, overlay_y, title, title_cell, overlay_rect.right());
-
-    // Inner content area (inside border).
-    let inner = Rect::new(
-        overlay_x + 2,
-        overlay_y + 1,
-        overlay_width.saturating_sub(4),
-        overlay_height.saturating_sub(2),
-    );
-
-    // Get commands for this screen.
-    let commands = registry.help_entries(screen);
-    let visible_lines = inner.height as usize;
-
-    let key_cell = Cell {
-        fg: text_color,
-        ..Cell::default()
-    };
-    let desc_cell = Cell {
-        fg: muted_color,
-        ..Cell::default()
-    };
-
-    for (i, cmd) in commands.iter().skip(scroll_offset).enumerate() {
-        if i >= visible_lines {
-            break;
-        }
-        let y = inner.y + i as u16;
-
-        // Key binding label (left).
-        let key_label = cmd
-            .keybinding
-            .as_ref()
-            .map_or_else(String::new, |kb| kb.display());
-        let label_end = frame.print_text_clipped(inner.x, y, &key_label, key_cell, inner.right());
-
-        // Spacer + description (right).
-        let desc_x = label_end.saturating_add(2);
-        if desc_x < inner.right() {
-            frame.print_text_clipped(desc_x, y, cmd.help_text, desc_cell, inner.right());
-        }
-    }
-
-    // Scroll indicator if needed.
-    if commands.len() > visible_lines + scroll_offset {
-        let indicator = format!("({}/{})", scroll_offset + visible_lines, commands.len());
-        let ind_x = inner.right().saturating_sub(indicator.len() as u16);
-        let ind_y = overlay_rect.bottom().saturating_sub(1);
-        frame.print_text_clipped(ind_x, ind_y, &indicator, desc_cell, overlay_rect.right());
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::commands::build_registry;
-    use crate::message::Screen;
-    use ftui::render::grapheme_pool::GraphemePool;
-
-    macro_rules! with_frame {
-        ($width:expr, $height:expr, |$frame:ident| $body:block) => {{
-            let mut pool = GraphemePool::new();
-            let mut $frame = Frame::new($width, $height, &mut pool);
-            $body
-        }};
-    }
-
-    fn white() -> PackedRgba {
-        PackedRgba::rgb(0xFF, 0xFF, 0xFF)
-    }
-
-    fn gray() -> PackedRgba {
-        PackedRgba::rgb(0x80, 0x80, 0x80)
-    }
-
-    #[test]
-    fn test_help_overlay_renders_border() {
-        with_frame!(80, 24, |frame| {
-            let registry = build_registry();
-            render_help_overlay(
-                &mut frame,
-                Rect::new(0, 0, 80, 24),
-                &registry,
-                &Screen::Dashboard,
-                gray(),
-                white(),
-                gray(),
-                0,
-            );
-
-            // The overlay should have non-empty cells in the center area.
-            let has_content = (20..60u16).any(|x| {
-                (8..16u16).any(|y| {
-                    let cell = frame.buffer.get(x, y).unwrap();
-                    !cell.is_empty()
-                })
-            });
-            assert!(has_content, "Expected help overlay in center area");
-        });
-    }
-
-    #[test]
-    fn test_help_overlay_tiny_terminal_noop() {
-        with_frame!(15, 4, |frame| {
-            let registry = build_registry();
-            render_help_overlay(
-                &mut frame,
-                Rect::new(0, 0, 15, 4),
-                &registry,
-                &Screen::Dashboard,
-                gray(),
-                white(),
-                gray(),
-                0,
-            );
-        });
-    }
-}

crates/lore-tui/src/view/common/loading.rs

@@ -1,179 +0,0 @@
-//! Loading spinner indicators (full-screen and corner).
-
-use ftui::core::geometry::Rect;
-use ftui::render::cell::{Cell, PackedRgba};
-use ftui::render::drawing::Draw;
-use ftui::render::frame::Frame;
-
-use crate::state::LoadState;
-
-/// Braille spinner frames for loading animation.
-const SPINNER_FRAMES: &[char] = &['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏'];
-
-/// Select spinner frame from tick count.
-#[must_use]
-pub(crate) fn spinner_char(tick: u64) -> char {
-    SPINNER_FRAMES[(tick as usize) % SPINNER_FRAMES.len()]
-}
-
-/// Render a loading indicator.
-///
-/// - `LoadingInitial`: centered full-screen spinner with "Loading..."
-/// - `Refreshing`: subtle spinner in top-right corner
-/// - Other states: no-op
-pub fn render_loading(
-    frame: &mut Frame<'_>,
-    area: Rect,
-    load_state: &LoadState,
-    text_color: PackedRgba,
-    muted_color: PackedRgba,
-    tick: u64,
-) {
-    match load_state {
-        LoadState::LoadingInitial => {
-            render_centered_spinner(frame, area, "Loading...", text_color, tick);
-        }
-        LoadState::Refreshing => {
-            render_corner_spinner(frame, area, muted_color, tick);
-        }
-        _ => {}
-    }
-}
-
-/// Render a centered spinner with message.
-fn render_centered_spinner(
-    frame: &mut Frame<'_>,
-    area: Rect,
-    message: &str,
-    color: PackedRgba,
-    tick: u64,
-) {
-    if area.height == 0 || area.width < 5 {
-        return;
-    }
-
-    let spinner = spinner_char(tick);
-    let text = format!("{spinner} {message}");
-    let text_len = text.len() as u16;
-
-    // Center horizontally and vertically.
-    let x = area
-        .x
-        .saturating_add(area.width.saturating_sub(text_len) / 2);
-    let y = area.y.saturating_add(area.height / 2);
-
-    let cell = Cell {
-        fg: color,
-        ..Cell::default()
-    };
-    frame.print_text_clipped(x, y, &text, cell, area.right());
-}
-
-/// Render a subtle spinner in the top-right corner.
-fn render_corner_spinner(frame: &mut Frame<'_>, area: Rect, color: PackedRgba, tick: u64) {
-    if area.width < 2 || area.height == 0 {
-        return;
-    }
-
-    let spinner = spinner_char(tick);
-    let x = area.right().saturating_sub(2);
-    let y = area.y;
-
-    let cell = Cell {
-        fg: color,
-        ..Cell::default()
-    };
-    frame.print_text_clipped(x, y, &spinner.to_string(), cell, area.right());
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use ftui::render::grapheme_pool::GraphemePool;
-
-    macro_rules! with_frame {
-        ($width:expr, $height:expr, |$frame:ident| $body:block) => {{
-            let mut pool = GraphemePool::new();
-            let mut $frame = Frame::new($width, $height, &mut pool);
-            $body
-        }};
-    }
-
-    fn white() -> PackedRgba {
-        PackedRgba::rgb(0xFF, 0xFF, 0xFF)
-    }
-
-    fn gray() -> PackedRgba {
-        PackedRgba::rgb(0x80, 0x80, 0x80)
-    }
-
-    #[test]
-    fn test_loading_initial_renders_spinner() {
-        with_frame!(80, 24, |frame| {
-            render_loading(
-                &mut frame,
-                Rect::new(0, 0, 80, 24),
-                &LoadState::LoadingInitial,
-                white(),
-                gray(),
-                0,
-            );
-
-            let center_y = 12u16;
-            let has_content = (0..80u16).any(|x| {
-                let cell = frame.buffer.get(x, center_y).unwrap();
-                !cell.is_empty()
-            });
-            assert!(has_content, "Expected loading spinner at center row");
-        });
-    }
-
-    #[test]
-    fn test_loading_refreshing_renders_corner() {
-        with_frame!(80, 24, |frame| {
-            render_loading(
-                &mut frame,
-                Rect::new(0, 0, 80, 24),
-                &LoadState::Refreshing,
-                white(),
-                gray(),
-                0,
-            );
-
-            let cell = frame.buffer.get(78, 0).unwrap();
-            assert!(!cell.is_empty(), "Expected corner spinner");
-        });
-    }
-
-    #[test]
-    fn test_loading_idle_noop() {
-        with_frame!(80, 24, |frame| {
-            render_loading(
-                &mut frame,
-                Rect::new(0, 0, 80, 24),
-                &LoadState::Idle,
-                white(),
-                gray(),
-                0,
-            );
-
-            let has_content = (0..80u16).any(|x| {
-                (0..24u16).any(|y| {
-                    let cell = frame.buffer.get(x, y).unwrap();
-                    !cell.is_empty()
-                })
-            });
-            assert!(!has_content, "Idle state should render nothing");
-        });
-    }
-
-    #[test]
-    fn test_spinner_animation_cycles() {
-        let frame0 = spinner_char(0);
-        let frame1 = spinner_char(1);
-        let frame_wrap = spinner_char(SPINNER_FRAMES.len() as u64);
-
-        assert_ne!(frame0, frame1, "Adjacent frames should differ");
-        assert_eq!(frame0, frame_wrap, "Should wrap around");
-    }
-}

crates/lore-tui/src/view/common/mod.rs

@@ -1,17 +0,0 @@
-//! Common widgets shared across all TUI screens.
-//!
-//! Each widget is a pure rendering function — writes directly into the
-//! [`Frame`] buffer using ftui's `Draw` trait. No state mutation,
-//! no side effects.
-
-mod breadcrumb;
-mod error_toast;
-mod help_overlay;
-mod loading;
-mod status_bar;
-
-pub use breadcrumb::render_breadcrumb;
-pub use error_toast::render_error_toast;
-pub use help_overlay::render_help_overlay;
-pub use loading::render_loading;
-pub use status_bar::render_status_bar;

crates/lore-tui/src/view/common/status_bar.rs

@@ -1,173 +0,0 @@
-//! Bottom status bar with key hints and mode indicator.
-
-use ftui::core::geometry::Rect;
-use ftui::render::cell::{Cell, PackedRgba};
-use ftui::render::drawing::Draw;
-use ftui::render::frame::Frame;
-
-use crate::commands::CommandRegistry;
-use crate::message::{InputMode, Screen};
-
-/// Render the bottom status bar with key hints and mode indicator.
-///
-/// Layout: `[mode] ─── [key hints]`
-///
-/// Key hints are sourced from the [`CommandRegistry`] filtered to the
-/// current screen, showing only the most important bindings.
-#[allow(clippy::too_many_arguments)]
-pub fn render_status_bar(
-    frame: &mut Frame<'_>,
-    area: Rect,
-    registry: &CommandRegistry,
-    screen: &Screen,
-    mode: &InputMode,
-    bar_bg: PackedRgba,
-    text_color: PackedRgba,
-    accent_color: PackedRgba,
-) {
-    if area.height == 0 || area.width < 5 {
-        return;
-    }
-
-    // Fill the bar background.
-    let bg_cell = Cell {
-        bg: bar_bg,
-        ..Cell::default()
-    };
-    frame.draw_rect_filled(area, bg_cell);
-
-    let mode_label = match mode {
-        InputMode::Normal => "NORMAL",
-        InputMode::Text => "INPUT",
-        InputMode::Palette => "PALETTE",
-        InputMode::GoPrefix { .. } => "g...",
-    };
-
-    // Left side: mode indicator.
-    let mode_cell = Cell {
-        fg: accent_color,
-        bg: bar_bg,
-        ..Cell::default()
-    };
-    let mut x = frame.print_text_clipped(
-        area.x.saturating_add(1),
-        area.y,
-        mode_label,
-        mode_cell,
-        area.right(),
-    );
-
-    // Spacer.
-    x = x.saturating_add(2);
-
-    // Right side: key hints from registry (formatted as "key:action").
-    let hints = registry.status_hints(screen);
-    let hint_cell = Cell {
-        fg: text_color,
-        bg: bar_bg,
-        ..Cell::default()
-    };
-    let key_cell = Cell {
-        fg: accent_color,
-        bg: bar_bg,
-        ..Cell::default()
-    };
-
-    for hint in &hints {
-        if x >= area.right().saturating_sub(1) {
-            break;
-        }
-        // Split "q:quit" into key part and description part.
-        if let Some((key_part, desc_part)) = hint.split_once(':') {
-            x = frame.print_text_clipped(x, area.y, key_part, key_cell, area.right());
-            x = frame.print_text_clipped(x, area.y, ":", hint_cell, area.right());
-            x = frame.print_text_clipped(x, area.y, desc_part, hint_cell, area.right());
-        } else {
-            x = frame.print_text_clipped(x, area.y, hint, hint_cell, area.right());
-        }
-        x = x.saturating_add(2);
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::commands::build_registry;
-    use crate::message::Screen;
-    use ftui::render::grapheme_pool::GraphemePool;
-
-    macro_rules! with_frame {
-        ($width:expr, $height:expr, |$frame:ident| $body:block) => {{
-            let mut pool = GraphemePool::new();
-            let mut $frame = Frame::new($width, $height, &mut pool);
-            $body
-        }};
-    }
-
-    fn white() -> PackedRgba {
-        PackedRgba::rgb(0xFF, 0xFF, 0xFF)
-    }
-
-    fn gray() -> PackedRgba {
-        PackedRgba::rgb(0x80, 0x80, 0x80)
-    }
-
-    #[test]
-    fn test_status_bar_renders_mode() {
-        with_frame!(80, 1, |frame| {
-            let registry = build_registry();
-            render_status_bar(
-                &mut frame,
-                Rect::new(0, 0, 80, 1),
-                &registry,
-                &Screen::Dashboard,
-                &InputMode::Normal,
-                gray(),
-                white(),
-                white(),
-            );
-
-            let n_cell = frame.buffer.get(1, 0).unwrap();
-            assert_eq!(n_cell.content.as_char(), Some('N'));
-        });
-    }
-
-    #[test]
-    fn test_status_bar_text_mode() {
-        with_frame!(80, 1, |frame| {
-            let registry = build_registry();
-            render_status_bar(
-                &mut frame,
-                Rect::new(0, 0, 80, 1),
-                &registry,
-                &Screen::Search,
-                &InputMode::Text,
-                gray(),
-                white(),
-                white(),
-            );
-
-            let i_cell = frame.buffer.get(1, 0).unwrap();
-            assert_eq!(i_cell.content.as_char(), Some('I'));
-        });
-    }
-
-    #[test]
-    fn test_status_bar_narrow_terminal() {
-        with_frame!(4, 1, |frame| {
-            let registry = build_registry();
-            render_status_bar(
-                &mut frame,
-                Rect::new(0, 0, 4, 1),
-                &registry,
-                &Screen::Dashboard,
-                &InputMode::Normal,
-                gray(),
-                white(),
-                white(),
-            );
-            let cell = frame.buffer.get(0, 0).unwrap();
-            assert!(cell.is_empty());
-        });
-    }
-}

crates/lore-tui/src/view/mod.rs

@@ -1,185 +0,0 @@
-#![allow(dead_code)] // Phase 1: screen content renders added in Phase 2+
-
-//! Top-level view dispatch for the lore TUI.
-//!
-//! [`render_screen`] is the entry point called from `LoreApp::view()`.
-//! It composes the layout: breadcrumb bar, screen content area, status
-//! bar, and optional overlays (help, error toast).
-
-pub mod common;
-
-use ftui::layout::{Constraint, Flex};
-use ftui::render::cell::PackedRgba;
-use ftui::render::frame::Frame;
-
-use crate::app::LoreApp;
-
-use common::{
-    render_breadcrumb, render_error_toast, render_help_overlay, render_loading, render_status_bar,
-};
-
-// ---------------------------------------------------------------------------
-// Colors (hardcoded Flexoki palette — will use Theme in Phase 2)
-// ---------------------------------------------------------------------------
-
-const TEXT: PackedRgba = PackedRgba::rgb(0xCE, 0xCD, 0xC3); // tx
-const TEXT_MUTED: PackedRgba = PackedRgba::rgb(0x87, 0x87, 0x80); // tx-2
-const BG_SURFACE: PackedRgba = PackedRgba::rgb(0x28, 0x28, 0x24); // bg-2
-const ACCENT: PackedRgba = PackedRgba::rgb(0xDA, 0x70, 0x2C); // orange
-const ERROR_BG: PackedRgba = PackedRgba::rgb(0xAF, 0x3A, 0x29); // red
-const ERROR_FG: PackedRgba = PackedRgba::rgb(0xCE, 0xCD, 0xC3); // tx
-const BORDER: PackedRgba = PackedRgba::rgb(0x87, 0x87, 0x80); // tx-2
-
-// ---------------------------------------------------------------------------
-// render_screen
-// ---------------------------------------------------------------------------
-
-/// Top-level view dispatch: composes breadcrumb + content + status bar + overlays.
-///
-/// Called from `LoreApp::view()`. The layout is:
-/// ```text
-/// +-----------------------------------+
-/// | Breadcrumb (1 row)                |
-/// +-----------------------------------+
-/// |                                   |
-/// | Screen content (fill)             |
-/// |                                   |
-/// +-----------------------------------+
-/// | Status bar (1 row)                |
-/// +-----------------------------------+
-/// ```
-///
-/// Overlays (help, error toast) render on top of existing content.
-pub fn render_screen(frame: &mut Frame<'_>, app: &LoreApp) {
-    let bounds = frame.bounds();
-    if bounds.width < 3 || bounds.height < 3 {
-        return; // Terminal too small to render anything useful.
-    }
-
-    // Split vertically: breadcrumb (1) | content (fill) | status bar (1).
-    let regions = Flex::vertical()
-        .constraints([
-            Constraint::Fixed(1), // breadcrumb
-            Constraint::Fill,     // content
-            Constraint::Fixed(1), // status bar
-        ])
-        .split(bounds);
-
-    let breadcrumb_area = regions[0];
-    let content_area = regions[1];
-    let status_area = regions[2];
-
-    let screen = app.navigation.current();
-
-    // --- Breadcrumb ---
-    render_breadcrumb(frame, breadcrumb_area, &app.navigation, TEXT, TEXT_MUTED);
-
-    // --- Screen content ---
-    let load_state = app.state.load_state.get(screen);
-    // tick=0 placeholder — animation wired up when Msg::Tick increments a counter.
-    render_loading(frame, content_area, load_state, TEXT, TEXT_MUTED, 0);
-
-    // Per-screen content dispatch (Phase 2+).
-    // match screen {
-    //     Screen::Dashboard => ...,
-    //     Screen::IssueList => ...,
-    //     ...
-    // }
-
-    // --- Status bar ---
-    render_status_bar(
-        frame,
-        status_area,
-        &app.command_registry,
-        screen,
-        &app.input_mode,
-        BG_SURFACE,
-        TEXT,
-        ACCENT,
-    );
-
-    // --- Overlays (render last, on top of everything) ---
-
-    // Error toast.
-    if let Some(ref error_msg) = app.state.error_toast {
-        render_error_toast(frame, bounds, error_msg, ERROR_BG, ERROR_FG);
-    }
-
-    // Help overlay.
-    if app.state.show_help {
-        render_help_overlay(
-            frame,
-            bounds,
-            &app.command_registry,
-            screen,
-            BORDER,
-            TEXT,
-            TEXT_MUTED,
-            0, // scroll_offset — tracked in future phase
-        );
-    }
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::app::LoreApp;
-    use ftui::render::grapheme_pool::GraphemePool;
-
-    macro_rules! with_frame {
-        ($width:expr, $height:expr, |$frame:ident| $body:block) => {{
-            let mut pool = GraphemePool::new();
-            let mut $frame = Frame::new($width, $height, &mut pool);
-            $body
-        }};
-    }
-
-    #[test]
-    fn test_render_screen_does_not_panic() {
-        with_frame!(80, 24, |frame| {
-            let app = LoreApp::new();
-            render_screen(&mut frame, &app);
-        });
-    }
-
-    #[test]
-    fn test_render_screen_tiny_terminal_noop() {
-        with_frame!(2, 2, |frame| {
-            let app = LoreApp::new();
-            render_screen(&mut frame, &app);
-            // Should not panic — early return for tiny terminals.
-        });
-    }
-
-    #[test]
-    fn test_render_screen_with_error_toast() {
-        with_frame!(80, 24, |frame| {
-            let mut app = LoreApp::new();
-            app.state.set_error("test error".into());
-            render_screen(&mut frame, &app);
-            // Should render without panicking.
-        });
-    }
-
-    #[test]
-    fn test_render_screen_with_help_overlay() {
-        with_frame!(80, 24, |frame| {
-            let mut app = LoreApp::new();
-            app.state.show_help = true;
-            render_screen(&mut frame, &app);
-            // Should render without panicking.
-        });
-    }
-
-    #[test]
-    fn test_render_screen_narrow_terminal() {
-        with_frame!(20, 5, |frame| {
-            let app = LoreApp::new();
-            render_screen(&mut frame, &app);
-        });
-    }
-}

docs/command-surface-analysis/00-overview.md

@@ -0,0 +1,92 @@
+# Lore Command Surface Analysis — Overview
+
+**Date:** 2026-02-26
+**Version:** v0.9.1 (439c20e)
+
+---
+
+## Purpose
+
+Deep analysis of the full `lore` CLI command surface: what each command does, how commands overlap, how they connect in agent workflows, and where consolidation and robot-mode optimization can reduce round trips and token waste.
+
+## Document Map
+
+| File | Contents | When to Read |
+|---|---|---|
+| **00-overview.md** | This file. Summary, inventory, priorities. | Always read first. |
+| [01-entity-commands.md](01-entity-commands.md) | `issues`, `mrs`, `notes`, `search`, `count` — flags, DB tables, robot schemas | Need command reference for entity queries |
+| [02-intelligence-commands.md](02-intelligence-commands.md) | `who`, `timeline`, `me`, `file-history`, `trace`, `related`, `drift` | Need command reference for intelligence/analysis |
+| [03-pipeline-and-infra.md](03-pipeline-and-infra.md) | `sync`, `ingest`, `generate-docs`, `embed`, diagnostics, setup | Need command reference for data management |
+| [04-data-flow.md](04-data-flow.md) | Shared data source map, command network graph, clusters | Understanding how commands interconnect |
+| [05-overlap-analysis.md](05-overlap-analysis.md) | Quantified overlap percentages for every command pair | Evaluating what to consolidate |
+| [06-agent-workflows.md](06-agent-workflows.md) | Common agent flows, round-trip costs, token profiles | Understanding inefficiency pain points |
+| [07-consolidation-proposals.md](07-consolidation-proposals.md) | 5 proposals to reduce 34 commands to 29 | Planning command surface changes |
+| [08-robot-optimization-proposals.md](08-robot-optimization-proposals.md) | 6 proposals for `--include`, `--batch`, `--depth`, etc. | Planning robot-mode improvements |
+| [09-appendices.md](09-appendices.md) | Robot output envelope, field presets, exit codes | Reference material |
+
+---
+
+## Command Inventory (34 commands)
+
+| Category | Commands | Count |
+|---|---|---|
+| Entity Query | `issues`, `mrs`, `notes`, `search`, `count` | 5 |
+| Intelligence | `who` (5 modes), `timeline`, `related`, `drift`, `me`, `file-history`, `trace` | 7 (11 with who sub-modes) |
+| Data Pipeline | `sync`, `ingest`, `generate-docs`, `embed` | 4 |
+| Diagnostics | `health`, `auth`, `doctor`, `status`, `stats` | 5 |
+| Setup | `init`, `token`, `cron`, `migrate` | 4 |
+| Meta | `version`, `completions`, `robot-docs` | 3 |
+
+---
+
+## Key Findings
+
+### High-Overlap Pairs
+
+| Pair | Overlap | Recommendation |
+|---|---|---|
+| `who workload` vs `me` | ~85% | Workload is a strict subset of me |
+| `health` vs `doctor` | ~90% | Health is a strict subset of doctor |
+| `file-history` vs `trace` | ~75% | Trace is a superset minus `--merged` |
+| `related` query-mode vs `search --mode semantic` | ~80% | Related query-mode is search without filters |
+| `auth` vs `doctor` | ~100% of auth | Auth is fully contained within doctor |
+
+### Agent Workflow Pain Points
+
+| Workflow | Current Round Trips | With Optimizations |
+|---|---|---|
+| "Understand this issue" | 4 calls | 1 call (`--include`) |
+| "Why was code changed?" | 3 calls | 1 call (`--include`) |
+| "What should I work on?" | 4 calls | 2 calls |
+| "Find and understand" | 4 calls | 2 calls |
+| "Is system healthy?" | 2-4 calls | 1 call |
+
+---
+
+## Priority Ranking
+
+| Pri | Proposal | Category | Effort | Impact |
+|---|---|---|---|---|
+| **P0** | `--include` flag on detail commands | Robot optimization | High | Eliminates 2-3 round trips per workflow |
+| **P0** | `--depth` on `me` command | Robot optimization | Low | 60-80% token reduction on most-used command |
+| **P1** | `--batch` for detail views | Robot optimization | Medium | Eliminates N+1 after search/timeline |
+| **P1** | Absorb `file-history` into `trace` | Consolidation | Low | Cleaner surface, shared code |
+| **P1** | Merge `who overlap` into `who expert` | Consolidation | Low | -1 round trip in review flows |
+| **P2** | `context` composite command | Robot optimization | Medium | Single entry point for entity understanding |
+| **P2** | Merge `count`+`status` into `stats` | Consolidation | Medium | -2 commands, progressive disclosure |
+| **P2** | Absorb `auth` into `doctor` | Consolidation | Low | -1 command |
+| **P2** | Remove `related` query-mode | Consolidation | Low | -1 confusing choice |
+| **P3** | `--max-tokens` budget | Robot optimization | High | Flexible but complex to implement |
+| **P3** | `--format tsv` | Robot optimization | Medium | High savings, limited applicability |
+
+### Consolidation Summary
+
+| Before | After | Removed |
+|---|---|---|
+| `file-history` + `trace` | `trace` (+ `--shallow`) | -1 |
+| `auth` + `doctor` | `doctor` (+ `--auth`) | -1 |
+| `related` query-mode | `search --mode semantic` | -1 mode |
+| `who overlap` + `who expert` | `who expert` (+ touch_count) | -1 sub-mode |
+| `count` + `status` + `stats` | `stats` (+ `--entities`, `--sync`) | -2 |
+
+**Total: 34 commands -> 29 commands**

docs/command-surface-analysis/01-entity-commands.md

@@ -0,0 +1,308 @@
+# Entity Query Commands
+
+Reference for: `issues`, `mrs`, `notes`, `search`, `count`
+
+---
+
+## `issues` (alias: `issue`)
+
+List or show issues from local database.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `[IID]` | positional | — | Omit to list, provide to show detail |
+| `-n, --limit` | int | 50 | Max results |
+| `--fields` | string | — | Select output columns (preset: `minimal`) |
+| `-s, --state` | enum | — | `opened\|closed\|all` |
+| `-p, --project` | string | — | Filter by project (fuzzy) |
+| `-a, --author` | string | — | Filter by author username |
+| `-A, --assignee` | string | — | Filter by assignee username |
+| `-l, --label` | string[] | — | Filter by labels (AND logic, repeatable) |
+| `-m, --milestone` | string | — | Filter by milestone title |
+| `--status` | string[] | — | Filter by work-item status (COLLATE NOCASE, OR logic) |
+| `--since` | duration/date | — | Filter by created date (`7d`, `2w`, `YYYY-MM-DD`) |
+| `--due-before` | date | — | Filter by due date |
+| `--has-due` | flag | — | Show only issues with due dates |
+| `--sort` | enum | `updated` | `updated\|created\|iid` |
+| `--asc` | flag | — | Sort ascending |
+| `-o, --open` | flag | — | Open first match in browser |
+
+**DB tables:** `issues`, `projects`, `issue_assignees`, `issue_labels`, `labels`
+**Detail mode adds:** `discussions`, `notes`, `entity_references` (closing MRs)
+
+### Robot Output (list mode)
+
+```json
+{
+  "ok": true,
+  "data": {
+    "issues": [
+      {
+        "iid": 42, "title": "Fix auth", "state": "opened",
+        "author_username": "jdoe", "labels": ["backend"],
+        "assignees": ["jdoe"], "discussion_count": 3,
+        "unresolved_count": 1, "created_at_iso": "...",
+        "updated_at_iso": "...", "web_url": "...",
+        "project_path": "group/repo",
+        "status_name": "In progress"
+      }
+    ],
+    "total_count": 150, "showing": 50
+  },
+  "meta": { "elapsed_ms": 40, "available_statuses": ["Open", "In progress", "Closed"] }
+}
+```
+
+### Robot Output (detail mode — `issues <IID>`)
+
+```json
+{
+  "ok": true,
+  "data": {
+    "id": 12345, "iid": 42, "title": "Fix auth",
+    "description": "Full markdown body...",
+    "state": "opened", "author_username": "jdoe",
+    "created_at": "...", "updated_at": "...", "closed_at": null,
+    "confidential": false, "web_url": "...", "project_path": "group/repo",
+    "references_full": "group/repo#42",
+    "labels": ["backend"], "assignees": ["jdoe"],
+    "due_date": null, "milestone": null,
+    "user_notes_count": 5, "merge_requests_count": 1,
+    "closing_merge_requests": [
+      { "iid": 99, "title": "Refactor auth", "state": "merged", "web_url": "..." }
+    ],
+    "discussions": [
+      {
+        "notes": [
+          { "author_username": "jdoe", "body": "...", "created_at": "...", "is_system": false }
+        ],
+        "individual_note": false
+      }
+    ],
+    "status_name": "In progress", "status_color": "#1068bf"
+  }
+}
+```
+
+**Minimal preset:** `iid`, `title`, `state`, `updated_at_iso`
+
+---
+
+## `mrs` (aliases: `mr`, `merge-request`, `merge-requests`)
+
+List or show merge requests.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `[IID]` | positional | — | Omit to list, provide to show detail |
+| `-n, --limit` | int | 50 | Max results |
+| `--fields` | string | — | Select output columns (preset: `minimal`) |
+| `-s, --state` | enum | — | `opened\|merged\|closed\|locked\|all` |
+| `-p, --project` | string | — | Filter by project |
+| `-a, --author` | string | — | Filter by author |
+| `-A, --assignee` | string | — | Filter by assignee |
+| `-r, --reviewer` | string | — | Filter by reviewer |
+| `-l, --label` | string[] | — | Filter by labels (AND) |
+| `--since` | duration/date | — | Filter by created date |
+| `-d, --draft` | flag | — | Draft MRs only |
+| `-D, --no-draft` | flag | — | Exclude drafts |
+| `--target` | string | — | Filter by target branch |
+| `--source` | string | — | Filter by source branch |
+| `--sort` | enum | `updated` | `updated\|created\|iid` |
+| `--asc` | flag | — | Sort ascending |
+| `-o, --open` | flag | — | Open in browser |
+
+**DB tables:** `merge_requests`, `projects`, `mr_reviewers`, `mr_labels`, `labels`, `mr_assignees`
+**Detail mode adds:** `discussions`, `notes`, `mr_diffs`
+
+### Robot Output (list mode)
+
+```json
+{
+  "ok": true,
+  "data": {
+    "mrs": [
+      {
+        "iid": 99, "title": "Refactor auth", "state": "merged",
+        "draft": false, "author_username": "jdoe",
+        "source_branch": "feat/auth", "target_branch": "main",
+        "labels": ["backend"], "assignees": ["jdoe"], "reviewers": ["reviewer"],
+        "discussion_count": 5, "unresolved_count": 0,
+        "created_at_iso": "...", "updated_at_iso": "...",
+        "web_url": "...", "project_path": "group/repo"
+      }
+    ],
+    "total_count": 500, "showing": 50
+  }
+}
+```
+
+### Robot Output (detail mode — `mrs <IID>`)
+
+```json
+{
+  "ok": true,
+  "data": {
+    "id": 67890, "iid": 99, "title": "Refactor auth",
+    "description": "Full markdown body...",
+    "state": "merged", "draft": false, "author_username": "jdoe",
+    "source_branch": "feat/auth", "target_branch": "main",
+    "created_at": "...", "updated_at": "...",
+    "merged_at": "...", "closed_at": null,
+    "web_url": "...", "project_path": "group/repo",
+    "labels": ["backend"], "assignees": ["jdoe"], "reviewers": ["reviewer"],
+    "discussions": [
+      {
+        "notes": [
+          {
+            "author_username": "reviewer", "body": "...",
+            "created_at": "...", "is_system": false,
+            "position": { "new_path": "src/auth.rs", "new_line": 42 }
+          }
+        ],
+        "individual_note": false
+      }
+    ]
+  }
+}
+```
+
+**Minimal preset:** `iid`, `title`, `state`, `updated_at_iso`
+
+---
+
+## `notes` (alias: `note`)
+
+List discussion notes/comments with fine-grained filters.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `-n, --limit` | int | 50 | Max results |
+| `--fields` | string | — | Preset: `minimal` |
+| `-a, --author` | string | — | Filter by author |
+| `--note-type` | enum | — | `DiffNote\|DiscussionNote` |
+| `--contains` | string | — | Body text substring filter |
+| `--note-id` | int | — | Internal note ID |
+| `--gitlab-note-id` | int | — | GitLab note ID |
+| `--discussion-id` | string | — | Discussion ID filter |
+| `--include-system` | flag | — | Include system notes |
+| `--for-issue` | int | — | Notes on specific issue (requires `-p`) |
+| `--for-mr` | int | — | Notes on specific MR (requires `-p`) |
+| `-p, --project` | string | — | Scope to project |
+| `--since` | duration/date | — | Created after |
+| `--until` | date | — | Created before (inclusive) |
+| `--path` | string | — | File path filter (exact or prefix with `/`) |
+| `--resolution` | enum | — | `any\|unresolved\|resolved` |
+| `--sort` | enum | `created` | `created\|updated` |
+| `--asc` | flag | — | Sort ascending |
+| `--open` | flag | — | Open in browser |
+
+**DB tables:** `notes`, `discussions`, `projects`, `issues`, `merge_requests`
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "notes": [
+      {
+        "id": 1234, "gitlab_id": 56789,
+        "author_username": "reviewer", "body": "...",
+        "note_type": "DiffNote", "is_system": false,
+        "created_at_iso": "...", "updated_at_iso": "...",
+        "position_new_path": "src/auth.rs", "position_new_line": 42,
+        "resolvable": true, "resolved": false,
+        "noteable_type": "MergeRequest", "parent_iid": 99,
+        "parent_title": "Refactor auth", "project_path": "group/repo"
+      }
+    ],
+    "total_count": 1000, "showing": 50
+  }
+}
+```
+
+**Minimal preset:** `id`, `author_username`, `body`, `created_at_iso`
+
+---
+
+## `search` (aliases: `find`, `query`)
+
+Semantic + full-text search across indexed documents.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `<QUERY>` | positional | required | Search query string |
+| `--mode` | enum | `hybrid` | `lexical\|hybrid\|semantic` |
+| `--type` | enum | — | `issue\|mr\|discussion\|note` |
+| `--author` | string | — | Filter by author |
+| `-p, --project` | string | — | Scope to project |
+| `--label` | string[] | — | Filter by labels (AND) |
+| `--path` | string | — | File path filter |
+| `--since` | duration/date | — | Created after |
+| `--updated-since` | duration/date | — | Updated after |
+| `-n, --limit` | int | 20 | Max results (max: 100) |
+| `--fields` | string | — | Preset: `minimal` |
+| `--explain` | flag | — | Show ranking breakdown |
+| `--fts-mode` | enum | `safe` | `safe\|raw` |
+
+**DB tables:** `documents`, `documents_fts` (FTS5), `embeddings` (vec0), `document_labels`, `document_paths`, `projects`
+
+**Search modes:**
+- **lexical** — FTS5 with BM25 ranking (fastest, no Ollama needed)
+- **hybrid** — RRF combination of lexical + semantic (default)
+- **semantic** — Vector similarity only (requires Ollama)
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "query": "authentication bug",
+    "mode": "hybrid",
+    "total_results": 15,
+    "results": [
+      {
+        "document_id": 1234, "source_type": "issue",
+        "title": "Fix SSO auth", "url": "...",
+        "author": "jdoe", "project_path": "group/repo",
+        "labels": ["auth"], "paths": ["src/auth/"],
+        "snippet": "...matching text...",
+        "score": 0.85,
+        "explain": { "vector_rank": 2, "fts_rank": 1, "rrf_score": 0.85 }
+      }
+    ],
+    "warnings": []
+  }
+}
+```
+
+**Minimal preset:** `document_id`, `title`, `source_type`, `score`
+
+---
+
+## `count`
+
+Count entities in local database.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `<ENTITY>` | positional | required | `issues\|mrs\|discussions\|notes\|events\|references` |
+| `-f, --for` | enum | — | Parent type: `issue\|mr` |
+
+**DB tables:** Conditional aggregation on entity tables
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "entity": "merge_requests",
+    "count": 1234,
+    "system_excluded": 5000,
+    "breakdown": { "opened": 100, "closed": 50, "merged": 1084 }
+  }
+}
+```

docs/command-surface-analysis/02-intelligence-commands.md

@@ -0,0 +1,452 @@
+# Intelligence Commands
+
+Reference for: `who`, `timeline`, `me`, `file-history`, `trace`, `related`, `drift`
+
+---
+
+## `who` (People Intelligence)
+
+Five sub-modes, dispatched by argument shape.
+
+| Mode | Trigger | Purpose |
+|---|---|---|
+| **expert** | `who <path>` or `who --path <path>` | Who knows about a code area? |
+| **workload** | `who @username` | What is this person working on? |
+| **reviews** | `who @username --reviews` | Review pattern analysis |
+| **active** | `who --active` | Unresolved discussions needing attention |
+| **overlap** | `who --overlap <path>` | Who else touches these files? |
+
+### Shared Flags
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `-p, --project` | string | — | Scope to project |
+| `-n, --limit` | int | varies | Max results (1-500) |
+| `--fields` | string | — | Preset: `minimal` |
+| `--since` | duration/date | — | Time window |
+| `--include-bots` | flag | — | Include bot users |
+| `--include-closed` | flag | — | Include closed issues/MRs |
+| `--all-history` | flag | — | Query all history |
+
+### Expert-Only Flags
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `--detail` | flag | — | Per-MR breakdown |
+| `--as-of` | date/duration | — | Score at point in time |
+| `--explain-score` | flag | — | Score breakdown |
+
+### DB Tables by Mode
+
+| Mode | Primary Tables |
+|---|---|
+| expert | `notes` (INDEXED BY idx_notes_diffnote_path_created), `merge_requests`, `mr_reviewers` |
+| workload | `issues`, `merge_requests`, `mr_reviewers` |
+| reviews | `merge_requests`, `discussions`, `notes` |
+| active | `discussions`, `notes`, `issues`, `merge_requests` |
+| overlap | `notes`, `mr_file_changes`, `merge_requests` |
+
+### Robot Output (expert)
+
+```json
+{
+  "ok": true,
+  "data": {
+    "mode": "expert",
+    "input": { "target": "src/auth/", "path": "src/auth/" },
+    "resolved_input": { "mode": "expert", "project_id": 1, "project_path": "group/repo" },
+    "result": {
+      "experts": [
+        {
+          "username": "jdoe", "score": 42.5,
+          "detail": { "mr_ids_author": [99, 101], "mr_ids_reviewer": [88] }
+        }
+      ]
+    }
+  }
+}
+```
+
+### Robot Output (workload)
+
+```json
+{
+  "data": {
+    "mode": "workload",
+    "result": {
+      "assigned_issues": [{ "iid": 42, "title": "Fix auth", "state": "opened" }],
+      "authored_mrs": [{ "iid": 99, "title": "Refactor auth", "state": "merged" }],
+      "review_mrs": [{ "iid": 88, "title": "Add SSO", "state": "opened" }]
+    }
+  }
+}
+```
+
+### Robot Output (reviews)
+
+```json
+{
+  "data": {
+    "mode": "reviews",
+    "result": {
+      "categories": [
+        {
+          "category": "approval_rate",
+          "reviewers": [{ "name": "jdoe", "count": 15, "percentage": 85.0 }]
+        }
+      ]
+    }
+  }
+}
+```
+
+### Robot Output (active)
+
+```json
+{
+  "data": {
+    "mode": "active",
+    "result": {
+      "discussions": [
+        { "entity_type": "mr", "iid": 99, "title": "Refactor auth", "participants": ["jdoe", "reviewer"] }
+      ]
+    }
+  }
+}
+```
+
+### Robot Output (overlap)
+
+```json
+{
+  "data": {
+    "mode": "overlap",
+    "result": {
+      "users": [{ "username": "jdoe", "touch_count": 15 }]
+    }
+  }
+}
+```
+
+### Minimal Presets
+
+| Mode | Fields |
+|---|---|
+| expert | `username`, `score` |
+| workload | `iid`, `title`, `state` |
+| reviews | `name`, `count`, `percentage` |
+| active | `entity_type`, `iid`, `title`, `participants` |
+| overlap | `username`, `touch_count` |
+
+---
+
+## `timeline`
+
+Reconstruct chronological event history for a topic/entity with cross-reference expansion.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `<QUERY>` | positional | required | Search text or entity ref (`issue:42`, `mr:99`) |
+| `-p, --project` | string | — | Scope to project |
+| `--since` | duration/date | — | Filter events after |
+| `--depth` | int | 1 | Cross-ref expansion depth (0=none) |
+| `--no-mentions` | flag | — | Skip "mentioned" edges, keep "closes"/"related" |
+| `-n, --limit` | int | 100 | Max events |
+| `--fields` | string | — | Preset: `minimal` |
+| `--max-seeds` | int | 10 | Max seed entities from search |
+| `--max-entities` | int | 50 | Max expanded entities |
+| `--max-evidence` | int | 10 | Max evidence notes |
+
+**Pipeline:** SEED -> HYDRATE -> EXPAND -> COLLECT -> RENDER
+
+**DB tables:** `issues`, `merge_requests`, `discussions`, `notes`, `entity_references`, `resource_state_events`, `resource_label_events`, `resource_milestone_events`, `documents` (for search seeding)
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "query": "authentication", "event_count": 25,
+    "seed_entities": [{ "type": "issue", "iid": 42, "project": "group/repo" }],
+    "expanded_entities": [
+      {
+        "type": "mr", "iid": 99, "project": "group/repo", "depth": 1,
+        "via": {
+          "from": { "type": "issue", "iid": 42 },
+          "reference_type": "closes"
+        }
+      }
+    ],
+    "unresolved_references": [
+      {
+        "source": { "type": "issue", "iid": 42, "project": "group/repo" },
+        "target_type": "mr", "target_iid": 200, "reference_type": "mentioned"
+      }
+    ],
+    "events": [
+      {
+        "timestamp": "2026-01-15T10:30:00Z",
+        "entity_type": "issue", "entity_iid": 42, "project": "group/repo",
+        "event_type": "state_changed", "summary": "Reopened",
+        "actor": "jdoe", "is_seed": true,
+        "evidence_notes": [{ "author": "jdoe", "snippet": "..." }]
+      }
+    ]
+  },
+  "meta": {
+    "elapsed_ms": 150, "search_mode": "fts",
+    "expansion_depth": 1, "include_mentions": true,
+    "total_entities": 5, "total_events": 25,
+    "evidence_notes_included": 8, "discussion_threads_included": 3,
+    "unresolved_references": 1, "showing": 25
+  }
+}
+```
+
+**Minimal preset:** `timestamp`, `type`, `entity_iid`, `detail`
+
+---
+
+## `me` (Personal Dashboard)
+
+Personal work dashboard with issues, MRs, activity, and since-last-check inbox.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `--issues` | flag | — | Open issues section only |
+| `--mrs` | flag | — | MRs section only |
+| `--activity` | flag | — | Activity feed only |
+| `--since` | duration/date | `30d` | Activity window |
+| `-p, --project` | string | — | Scope to one project |
+| `--all` | flag | — | All synced projects |
+| `--user` | string | — | Override configured username |
+| `--fields` | string | — | Preset: `minimal` |
+| `--reset-cursor` | flag | — | Clear since-last-check cursor |
+
+**Sections (no flags = all):** Issues, MRs authored, MRs reviewing, Activity, Inbox
+
+**DB tables:** `issues`, `merge_requests`, `resource_state_events`, `projects`, `issue_labels`, `mr_labels`
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "username": "jdoe",
+    "summary": {
+      "project_count": 3, "open_issue_count": 5,
+      "authored_mr_count": 2, "reviewing_mr_count": 1,
+      "needs_attention_count": 3
+    },
+    "since_last_check": {
+      "cursor_iso": "2026-02-25T18:00:00Z",
+      "total_event_count": 8,
+      "groups": [
+        {
+          "entity_type": "issue", "entity_iid": 42,
+          "entity_title": "Fix auth", "project": "group/repo",
+          "events": [
+            { "timestamp_iso": "...", "event_type": "comment",
+              "actor": "reviewer", "summary": "New comment" }
+          ]
+        }
+      ]
+    },
+    "open_issues": [
+      {
+        "project": "group/repo", "iid": 42, "title": "Fix auth",
+        "state": "opened", "attention_state": "needs_attention",
+        "status_name": "In progress", "labels": ["auth"],
+        "updated_at_iso": "..."
+      }
+    ],
+    "open_mrs_authored": [
+      {
+        "project": "group/repo", "iid": 99, "title": "Refactor auth",
+        "state": "opened", "attention_state": "needs_attention",
+        "draft": false, "labels": ["backend"], "updated_at_iso": "..."
+      }
+    ],
+    "reviewing_mrs": [],
+    "activity": [
+      {
+        "timestamp_iso": "...", "event_type": "state_changed",
+        "entity_type": "issue", "entity_iid": 42, "project": "group/repo",
+        "actor": "jdoe", "is_own": true, "summary": "Closed"
+      }
+    ]
+  }
+}
+```
+
+**Minimal presets:** Items: `iid, title, attention_state, updated_at_iso` | Activity: `timestamp_iso, event_type, entity_iid, actor`
+
+---
+
+## `file-history`
+
+Show which MRs touched a file, with linked discussions.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `<PATH>` | positional | required | File path to trace |
+| `-p, --project` | string | — | Scope to project |
+| `--discussions` | flag | — | Include DiffNote snippets |
+| `--no-follow-renames` | flag | — | Skip rename chain resolution |
+| `--merged` | flag | — | Only merged MRs |
+| `-n, --limit` | int | 50 | Max MRs |
+
+**DB tables:** `mr_file_changes`, `merge_requests`, `notes` (DiffNotes), `projects`
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "path": "src/auth/middleware.rs",
+    "rename_chain": [
+      { "previous_path": "src/auth.rs", "mr_iid": 55, "merged_at": "..." }
+    ],
+    "merge_requests": [
+      {
+        "iid": 99, "title": "Refactor auth", "state": "merged",
+        "author": "jdoe", "merged_at": "...", "change_type": "modified"
+      }
+    ],
+    "discussions": [
+      {
+        "discussion_id": 123, "mr_iid": 99, "author": "reviewer",
+        "body_snippet": "...", "path": "src/auth/middleware.rs"
+      }
+    ]
+  },
+  "meta": { "elapsed_ms": 30, "total_mrs": 5, "renames_followed": true }
+}
+```
+
+---
+
+## `trace`
+
+File -> MR -> issue -> discussion chain to understand why code was introduced.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `<PATH>` | positional | required | File path (future: `:line` suffix) |
+| `-p, --project` | string | — | Scope to project |
+| `--discussions` | flag | — | Include DiffNote snippets |
+| `--no-follow-renames` | flag | — | Skip rename chain |
+| `-n, --limit` | int | 20 | Max chains |
+
+**DB tables:** `mr_file_changes`, `merge_requests`, `issues`, `discussions`, `notes`, `entity_references`
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "path": "src/auth/middleware.rs",
+    "resolved_paths": ["src/auth/middleware.rs", "src/auth.rs"],
+    "trace_chains": [
+      {
+        "mr_iid": 99, "mr_title": "Refactor auth", "mr_state": "merged",
+        "mr_author": "jdoe", "change_type": "modified",
+        "merged_at_iso": "...", "web_url": "...",
+        "issues": [42],
+        "discussions": [
+          {
+            "discussion_id": 123, "author_username": "reviewer",
+            "body_snippet": "...", "path": "src/auth/middleware.rs"
+          }
+        ]
+      }
+    ]
+  },
+  "meta": { "tier": "api_only", "total_chains": 3, "renames_followed": 1 }
+}
+```
+
+---
+
+## `related`
+
+Find semantically related entities via vector search.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `<QUERY_OR_TYPE>` | positional | required | Entity type (`issues`, `mrs`) or free text |
+| `[IID]` | positional | — | Entity IID (required with entity type) |
+| `-n, --limit` | int | 10 | Max results |
+| `-p, --project` | string | — | Scope to project |
+
+**Two modes:**
+- **Entity mode:** `related issues 42` — find entities similar to issue #42
+- **Query mode:** `related "auth flow"` — find entities matching free text
+
+**DB tables:** `documents`, `embeddings` (vec0), `projects`
+
+**Requires:** Ollama running (for query mode embedding)
+
+### Robot Output (entity mode)
+
+```json
+{
+  "ok": true,
+  "data": {
+    "query_entity_type": "issue",
+    "query_entity_iid": 42,
+    "query_entity_title": "Fix SSO authentication",
+    "similar_entities": [
+      {
+        "entity_type": "mr", "entity_iid": 99,
+        "entity_title": "Refactor auth module",
+        "project_path": "group/repo", "state": "merged",
+        "similarity_score": 0.87,
+        "shared_labels": ["auth"], "shared_authors": ["jdoe"]
+      }
+    ]
+  }
+}
+```
+
+---
+
+## `drift`
+
+Detect discussion divergence from original intent.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `<ENTITY_TYPE>` | positional | required | Currently only `issues` |
+| `<IID>` | positional | required | Entity IID |
+| `--threshold` | f32 | 0.4 | Similarity threshold (0.0-1.0) |
+| `-p, --project` | string | — | Scope to project |
+
+**DB tables:** `issues`, `discussions`, `notes`, `embeddings`
+
+**Requires:** Ollama running
+
+### Robot Output
+
+```json
+{
+  "ok": true,
+  "data": {
+    "entity_type": "issue", "entity_iid": 42,
+    "total_notes": 15,
+    "detected_drift": true,
+    "drift_point": {
+      "note_index": 8, "similarity": 0.32,
+      "author": "someone", "created_at": "..."
+    },
+    "similarity_curve": [
+      { "note_index": 0, "similarity": 0.95, "author": "jdoe", "created_at": "..." },
+      { "note_index": 1, "similarity": 0.88, "author": "reviewer", "created_at": "..." }
+    ]
+  }
+}
+```

docs/command-surface-analysis/03-pipeline-and-infra.md

@@ -0,0 +1,210 @@
+# Pipeline & Infrastructure Commands
+
+Reference for: `sync`, `ingest`, `generate-docs`, `embed`, `health`, `auth`, `doctor`, `status`, `stats`, `init`, `token`, `cron`, `migrate`, `version`, `completions`, `robot-docs`
+
+---
+
+## Data Pipeline
+
+### `sync` (Full Pipeline)
+
+Complete sync: ingest -> generate-docs -> embed.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `--full` | flag | — | Full re-sync (reset cursors) |
+| `-f, --force` | flag | — | Override stale lock |
+| `--no-embed` | flag | — | Skip embedding |
+| `--no-docs` | flag | — | Skip doc generation |
+| `--no-events` | flag | — | Skip resource events |
+| `--no-file-changes` | flag | — | Skip MR file changes |
+| `--no-status` | flag | — | Skip work-item status enrichment |
+| `--dry-run` | flag | — | Preview without changes |
+| `-t, --timings` | flag | — | Show timing breakdown |
+| `--lock` | flag | — | Acquire file lock |
+| `--issue` | int[] | — | Surgically sync specific issues (repeatable) |
+| `--mr` | int[] | — | Surgically sync specific MRs (repeatable) |
+| `-p, --project` | string | — | Required with `--issue`/`--mr` |
+| `--preflight-only` | flag | — | Validate without DB writes |
+
+**Stages:** GitLab REST ingest -> GraphQL status enrichment -> Document generation -> Ollama embedding
+
+**Surgical sync:** `lore sync --issue 42 --mr 99 -p group/repo` fetches only specific entities.
+
+### `ingest`
+
+Fetch data from GitLab API only (no docs, no embeddings).
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `[ENTITY]` | positional | — | `issues` or `mrs` (omit for all) |
+| `-p, --project` | string | — | Single project |
+| `-f, --force` | flag | — | Override stale lock |
+| `--full` | flag | — | Full re-sync |
+| `--dry-run` | flag | — | Preview |
+
+**Fetches from GitLab:**
+- Issues + discussions + notes
+- MRs + discussions + notes
+- Resource events (state, label, milestone)
+- MR file changes (for DiffNote tracking)
+- Work-item statuses (via GraphQL)
+
+### `generate-docs`
+
+Create searchable documents from ingested data.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `--full` | flag | — | Full rebuild |
+| `-p, --project` | string | — | Single project rebuild |
+
+**Writes:** `documents`, `document_labels`, `document_paths`
+
+### `embed`
+
+Generate vector embeddings via Ollama.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `--full` | flag | — | Re-embed all |
+| `--retry-failed` | flag | — | Retry failed embeddings |
+
+**Requires:** Ollama running with `nomic-embed-text`
+**Writes:** `embeddings`, `embedding_metadata`
+
+---
+
+## Diagnostics
+
+### `health`
+
+Quick pre-flight check (~50ms). Exit 0 = healthy, exit 19 = unhealthy.
+
+**Checks:** config found, DB found, schema version current.
+
+```json
+{
+  "ok": true,
+  "data": {
+    "healthy": true,
+    "config_found": true, "db_found": true,
+    "schema_current": true, "schema_version": 28
+  }
+}
+```
+
+### `auth`
+
+Verify GitLab authentication.
+
+**Checks:** token set, GitLab reachable, user identity.
+
+### `doctor`
+
+Comprehensive environment check.
+
+**Checks:** config validity, token, GitLab connectivity, DB health, migration status, Ollama availability + model status.
+
+```json
+{
+  "ok": true,
+  "data": {
+    "config": { "valid": true, "path": "~/.config/lore/config.json" },
+    "token": { "set": true, "gitlab": { "reachable": true, "user": "jdoe" } },
+    "database": { "exists": true, "version": 28, "tables": 25 },
+    "ollama": { "available": true, "model_ready": true }
+  }
+}
+```
+
+### `status` (alias: `st`)
+
+Show sync state per project.
+
+```json
+{
+  "ok": true,
+  "data": {
+    "projects": [
+      {
+        "project_path": "group/repo",
+        "last_synced_at": "2026-02-26T10:00:00Z",
+        "document_count": 5000, "discussion_count": 2000, "notes_count": 15000
+      }
+    ]
+  }
+}
+```
+
+### `stats` (alias: `stat`)
+
+Document and index statistics with optional integrity checks.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `--check` | flag | — | Run integrity checks |
+| `--repair` | flag | — | Fix issues (implies `--check`) |
+| `--dry-run` | flag | — | Preview repairs |
+
+```json
+{
+  "ok": true,
+  "data": {
+    "documents": { "total": 61652, "issues": 5000, "mrs": 2000, "notes": 50000 },
+    "embeddings": { "total": 80000, "synced": 79500, "pending": 500, "failed": 0 },
+    "fts": { "total_docs": 61652 },
+    "queues": { "pending": 0, "in_progress": 0, "failed": 0, "max_attempts": 0 },
+    "integrity": {
+      "ok": true, "fts_doc_mismatch": 0, "orphan_embeddings": 0,
+      "stale_metadata": 0, "orphan_state_events": 0
+    }
+  }
+}
+```
+
+---
+
+## Setup
+
+### `init`
+
+Initialize configuration and database.
+
+| Flag | Type | Default | Purpose |
+|---|---|---|---|
+| `-f, --force` | flag | — | Skip overwrite confirmation |
+| `--non-interactive` | flag | — | Fail if prompts needed |
+| `--gitlab-url` | string | — | GitLab base URL (required in robot mode) |
+| `--token-env-var` | string | — | Env var holding token (required in robot mode) |
+| `--projects` | string | — | Comma-separated project paths (required in robot mode) |
+| `--default-project` | string | — | Default project path |
+
+### `token`
+
+| Subcommand | Flags | Purpose |
+|---|---|---|
+| `token set` | `--token <TOKEN>` | Store token (reads stdin if omitted) |
+| `token show` | `--unmask` | Display token (masked by default) |
+
+### `cron`
+
+| Subcommand | Flags | Purpose |
+|---|---|---|
+| `cron install` | `--interval <MINUTES>` (default: 8) | Schedule auto-sync |
+| `cron uninstall` | — | Remove cron job |
+| `cron status` | — | Check installation |
+
+### `migrate`
+
+Run pending database migrations. No flags.
+
+---
+
+## Meta
+
+| Command | Purpose |
+|---|---|
+| `version` | Show version string |
+| `completions <shell>` | Generate shell completions (bash/zsh/fish/powershell) |
+| `robot-docs` | Machine-readable command manifest (`--brief` for ~60% smaller) |

docs/command-surface-analysis/04-data-flow.md

@@ -0,0 +1,179 @@
+# Data Flow & Command Network
+
+How commands interconnect through shared data sources and output-to-input dependencies.
+
+---
+
+## 1. Command Network Graph
+
+Arrows mean "output of A feeds as input to B":
+
+```
+                    ┌─────────┐
+                    │ search  │─────────────────────────────┐
+                    └────┬────┘                             │
+                         │ iid                              │ topic
+                    ┌────▼────┐                        ┌────▼─────┐
+              ┌─────│ issues  │◄───────────────────────│ timeline │
+              │     │ mrs     │ (detail)               └──────────┘
+              │     └────┬────┘                             ▲
+              │          │ iid                              │ entity ref
+              │     ┌────▼────┐     ┌──────────────┐       │
+              │     │ related │     │ file-history  │───────┘
+              │     │ drift   │     └──────┬───────┘
+              │     └─────────┘            │ MR iids
+              │                       ┌────▼────┐
+              │                       │  trace  │──── issues (linked)
+              │                       └────┬────┘
+              │                            │ paths
+              │                       ┌────▼────┐
+              │                       │   who   │
+              │                       │ (expert)│
+              │                       └─────────┘
+              │
+         file paths                   ┌─────────┐
+              │                       │   me    │──── issues, mrs (dashboard)
+              ▼                       └─────────┘
+        ┌──────────┐                       ▲
+        │  notes   │                       │ (~same data)
+        └──────────┘                  ┌────┴──────┐
+                                      │who workload│
+                                      └───────────┘
+```
+
+### Feed Chains (output of A -> input of B)
+
+| From | To | What Flows |
+|---|---|---|
+| `search` | `issues`, `mrs` | IIDs from search results -> detail lookup |
+| `search` | `timeline` | Topic/query -> chronological history |
+| `search` | `related` | Entity IID -> semantic similarity |
+| `me` | `issues`, `mrs` | IIDs from dashboard -> detail lookup |
+| `trace` | `issues` | Linked issue IIDs -> detail lookup |
+| `trace` | `who` | File paths -> expert lookup |
+| `file-history` | `mrs` | MR IIDs -> detail lookup |
+| `file-history` | `timeline` | Entity refs -> chronological events |
+| `timeline` | `issues`, `mrs` | Referenced IIDs -> detail lookup |
+| `who expert` | `who reviews` | Username -> review patterns |
+| `who expert` | `mrs` | MR IIDs from expert detail -> MR detail |
+
+---
+
+## 2. Shared Data Source Map
+
+Which DB tables power which commands. Higher overlap = stronger consolidation signal.
+
+### Primary Entity Tables
+
+| Table | Read By |
+|---|---|
+| `issues` | issues, me, who-workload, search, timeline, trace, count, stats |
+| `merge_requests` | mrs, me, who-workload, search, timeline, trace, file-history, count, stats |
+| `notes` | notes, issues-detail, mrs-detail, who-expert, who-active, search, timeline, trace, file-history |
+| `discussions` | notes, issues-detail, mrs-detail, who-active, who-reviews, timeline, trace |
+
+### Relationship Tables
+
+| Table | Read By |
+|---|---|
+| `entity_references` | trace, timeline |
+| `mr_file_changes` | trace, file-history, who-overlap |
+| `issue_labels` | issues, me |
+| `mr_labels` | mrs, me |
+| `issue_assignees` | issues, me |
+| `mr_reviewers` | mrs, who-expert, who-workload |
+
+### Event Tables
+
+| Table | Read By |
+|---|---|
+| `resource_state_events` | timeline, me-activity |
+| `resource_label_events` | timeline |
+| `resource_milestone_events` | timeline |
+
+### Document/Search Tables
+
+| Table | Read By |
+|---|---|
+| `documents` + `documents_fts` | search, stats |
+| `embeddings` | search, related, drift |
+| `document_labels` | search |
+| `document_paths` | search |
+
+### Infrastructure Tables
+
+| Table | Read By |
+|---|---|
+| `sync_cursors` | status |
+| `dirty_sources` | stats |
+| `embedding_metadata` | stats, embed |
+
+---
+
+## 3. Shared-Data Clusters
+
+Commands that read from the same primary tables form natural clusters:
+
+### Cluster A: Issue/MR Entities
+
+`issues`, `mrs`, `me`, `who workload`, `count`
+
+All read `issues` + `merge_requests` with similar filter patterns (state, author, labels, project). These commands share the same underlying WHERE-clause builder logic.
+
+### Cluster B: Notes/Discussions
+
+`notes`, `issues detail`, `mrs detail`, `who expert`, `who active`, `timeline`
+
+All traverse the `discussions` -> `notes` join path. The `notes` command does it with independent filters; the others embed notes within parent context.
+
+### Cluster C: File Genealogy
+
+`trace`, `file-history`, `who overlap`
+
+All use `mr_file_changes` with rename chain BFS (forward: old_path -> new_path, backward: new_path -> old_path). Shared `resolve_rename_chain()` function.
+
+### Cluster D: Semantic/Vector
+
+`search`, `related`, `drift`
+
+All use `documents` + `embeddings` via Ollama. `search` adds FTS component; `related` is pure vector; `drift` uses vector for divergence scoring.
+
+### Cluster E: Diagnostics
+
+`health`, `auth`, `doctor`, `status`, `stats`
+
+All check system state. `health` < `doctor` (strict subset). `status` checks sync cursors. `stats` checks document/index health. `auth` checks token/connectivity.
+
+---
+
+## 4. Query Pattern Sharing
+
+### Dynamic Filter Builder (used by issues, mrs, notes)
+
+All three list commands use the same pattern: build a WHERE clause dynamically from filter flags with parameterized tokens. Labels use EXISTS subquery against junction table.
+
+### Rename Chain BFS (used by trace, file-history, who overlap)
+
+Forward query:
+```sql
+SELECT DISTINCT new_path FROM mr_file_changes
+WHERE project_id = ?1 AND old_path = ?2 AND change_type = 'renamed'
+```
+
+Backward query:
+```sql
+SELECT DISTINCT old_path FROM mr_file_changes
+WHERE project_id = ?1 AND new_path = ?2 AND change_type = 'renamed'
+```
+
+Cycle detection via `HashSet` of visited paths, `MAX_RENAME_HOPS = 10`.
+
+### Hybrid Search (used by search, timeline seeding)
+
+RRF ranking: `score = (60 / fts_rank) + (60 / vector_rank)`
+
+FTS5 queries go through `to_fts_query()` which sanitizes input and builds MATCH expressions. Vector search calls Ollama to embed the query, then does cosine similarity against `embeddings` vec0 table.
+
+### Project Resolution (used by most commands)
+
+`resolve_project(conn, project_filter)` does fuzzy matching on `path_with_namespace` — suffix and substring matching. Returns `(project_id, path_with_namespace)`.

docs/command-surface-analysis/05-overlap-analysis.md

@@ -0,0 +1,170 @@
+# Overlap Analysis
+
+Quantified functional duplication between commands.
+
+---
+
+## 1. High Overlap (>70%)
+
+### `who workload` vs `me` — 85% overlap
+
+| Dimension | `who @user` (workload) | `me --user @user` |
+|---|---|---|
+| Assigned issues | Yes | Yes |
+| Authored MRs | Yes | Yes |
+| Reviewing MRs | Yes | Yes |
+| Attention state | No | **Yes** |
+| Activity feed | No | **Yes** |
+| Since-last-check inbox | No | **Yes** |
+| Cross-project | Yes | **Yes** |
+
+**Verdict:** `who workload` is a strict subset of `me`. The only reason to use `who workload` is if you DON'T want attention_state/activity/inbox — but `me --issues --mrs --fields minimal` achieves the same thing.
+
+### `health` vs `doctor` — 90% overlap
+
+| Check | `health` | `doctor` |
+|---|---|---|
+| Config found | Yes | Yes |
+| DB exists | Yes | Yes |
+| Schema current | Yes | Yes |
+| Token valid | No | **Yes** |
+| GitLab reachable | No | **Yes** |
+| Ollama available | No | **Yes** |
+
+**Verdict:** `health` is a strict subset of `doctor`. However, `health` has unique value as a ~50ms pre-flight with clean exit 0/19 semantics for scripting.
+
+### `file-history` vs `trace` — 75% overlap
+
+| Feature | `file-history` | `trace` |
+|---|---|---|
+| Find MRs for file | Yes | Yes |
+| Rename chain BFS | Yes | Yes |
+| DiffNote discussions | `--discussions` | `--discussions` |
+| Follow to linked issues | No | **Yes** |
+| `--merged` filter | **Yes** | No |
+
+**Verdict:** `trace` is a superset of `file-history` minus the `--merged` filter. Both use the same `resolve_rename_chain()` function and query `mr_file_changes`.
+
+### `related` query-mode vs `search --mode semantic` — 80% overlap
+
+| Feature | `related "text"` | `search "text" --mode semantic` |
+|---|---|---|
+| Vector similarity | Yes | Yes |
+| FTS component | No | No (semantic mode skips FTS) |
+| Filters (labels, author, since) | No | **Yes** |
+| Explain ranking | No | **Yes** |
+| Field selection | No | **Yes** |
+| Requires Ollama | Yes | Yes |
+
+**Verdict:** `related "text"` is `search --mode semantic` without any filter capabilities. The entity-seeded mode (`related issues 42`) is NOT duplicated — it seeds from an existing entity's embedding.
+
+---
+
+## 2. Medium Overlap (40-70%)
+
+### `who expert` vs `who overlap` — 50%
+
+Both answer "who works on this file" but with different scoring:
+
+| Aspect | `who expert` | `who overlap` |
+|---|---|---|
+| Scoring | Half-life decay, signal types (diffnote_author, reviewer, etc.) | Raw touch count |
+| Output | Ranked experts with scores | Users with touch counts |
+| Use case | "Who should review this?" | "Who else touches this?" |
+
+**Verdict:** Overlap is a simplified version of expert. Expert could include touch_count as a field.
+
+### `timeline` vs `trace` — 45%
+
+Both follow `entity_references` to discover connected entities, but from different entry points:
+
+| Aspect | `timeline` | `trace` |
+|---|---|---|
+| Entry point | Entity (issue/MR) or search query | File path |
+| Direction | Entity -> cross-refs -> events | File -> MRs -> issues -> discussions |
+| Output | Chronological events | Causal chains (why code changed) |
+| Expansion | Depth-controlled cross-ref following | MR -> issue via entity_references |
+
+**Verdict:** Complementary, not duplicative. Different questions, shared plumbing.
+
+### `auth` vs `doctor` — 100% of auth
+
+`auth` checks: token set + GitLab reachable + user identity.
+`doctor` checks: all of the above + DB + schema + Ollama.
+
+**Verdict:** `auth` is completely contained within `doctor`.
+
+### `count` vs `stats` — 40%
+
+Both answer "how much data?":
+
+| Aspect | `count` | `stats` |
+|---|---|---|
+| Layer | Entity (issues, MRs, notes) | Document index |
+| State breakdown | Yes (opened/closed/merged) | No |
+| Integrity checks | No | Yes |
+| Queue status | No | Yes |
+
+**Verdict:** Different layers. Could be unified under `stats --entities`.
+
+### `notes` vs `issues/mrs detail` — 50%
+
+Both return note content:
+
+| Aspect | `notes` command | Detail view discussions |
+|---|---|---|
+| Independent filtering | **Yes** (author, path, resolution, contains, type) | No |
+| Parent context | Minimal (parent_iid, parent_title) | **Full** (complete entity + all discussions) |
+| Cross-entity queries | **Yes** (all notes matching criteria) | No (one entity only) |
+
+**Verdict:** `notes` is for filtered queries across entities. Detail views are for complete context on one entity. Different use cases.
+
+---
+
+## 3. No Significant Overlap
+
+| Command | Why It's Unique |
+|---|---|
+| `drift` | Only command doing semantic divergence detection |
+| `timeline` | Only command doing multi-entity chronological reconstruction with expansion |
+| `search` (hybrid) | Only command combining FTS + vector with RRF ranking |
+| `me` (inbox) | Only command with cursor-based since-last-check tracking |
+| `who expert` | Only command with half-life decay scoring by signal type |
+| `who reviews` | Only command analyzing review patterns (approval rate, latency) |
+| `who active` | Only command surfacing unresolved discussions needing attention |
+
+---
+
+## 4. Overlap Adjacency Matrix
+
+Rows/columns are commands. Values are estimated functional overlap percentage.
+
+```
+              issues  mrs  notes  search  who-e  who-w  who-r  who-a  who-o  timeline  me  fh  trace  related  drift  count  status  stats  health  doctor
+issues          -     30    50      20      5      40      0      5      0       15    40    0     10      10      0     20       0      10      0       0
+mrs            30      -    50      20      5      40      0      5      0       15    40    5     10      10      0     20       0      10      0       0
+notes          50     50     -      15     15       0      5     10      0       10     0    5      5       0      0      0       0       0      0       0
+search         20     20    15       -      0       0      0      0      0       15     0    0      0      80      0      0       0       5      0       0
+who-expert      5      5    15       0      -       0     10      0     50        0     0   10     10       0      0      0       0       0      0       0
+who-workload   40     40     0       0      0       -      0      0      0        0    85    0      0       0      0      0       0       0      0       0
+who-reviews     0      0     5       0     10       0      -      0      0        0     0    0      0       0      0      0       0       0      0       0
+who-active      5      5    10       0      0       0      0      -      0        5     0    0      0       0      0      0       0       0      0       0
+who-overlap     0      0     0       0     50       0      0      0      -        0     0   10      5       0      0      0       0       0      0       0
+timeline       15     15    10      15      0       0      0      5      0        -     5    5     45       0      0      0       0       0      0       0
+me             40     40     0       0      0      85      0      0      0        5     -    0      0       0      0      0       5       0      5       5
+file-history    0      5     5       0     10       0      0      0     10        5     0    -     75       0      0      0       0       0      0       0
+trace          10     10     5       0     10       0      0      0      5       45     0   75      -       0      0      0       0       0      0       0
+related        10     10     0      80      0       0      0      0      0        0     0    0      0       -      0      0       0       0      0       0
+drift           0      0     0       0      0       0      0      0      0        0     0    0      0       0      -      0       0       0      0       0
+count          20     20     0       0      0       0      0      0      0        0     0    0      0       0      0      -       0      40      0       0
+status          0      0     0       0      0       0      0      0      0        0     5    0      0       0      0      0       -      20     30      40
+stats          10     10     0       5      0       0      0      0      0        0     0    0      0       0      0     40      20       -      0      15
+health          0      0     0       0      0       0      0      0      0        0     5    0      0       0      0      0      30       0      -      90
+doctor          0      0     0       0      0       0      0      0      0        0     5    0      0       0      0      0      40      15     90       -
+```
+
+**Highest overlap pairs (>= 75%):**
+1. `health` / `doctor` — 90%
+2. `who workload` / `me` — 85%
+3. `related` query-mode / `search semantic` — 80%
+4. `file-history` / `trace` — 75%

docs/command-surface-analysis/06-agent-workflows.md

@@ -0,0 +1,216 @@
+# Agent Workflow Analysis
+
+Common agent workflows, round-trip costs, and token profiles.
+
+---
+
+## 1. Common Workflows
+
+### Flow 1: "What should I work on?" — 4 round trips
+
+```
+me                            → dashboard overview (which items need attention?)
+issues <iid> -p proj         → detail on picked issue (full context + discussions)
+trace src/relevant/file.rs    → understand code context (why was it written?)
+who src/relevant/file.rs      → find domain experts (who can help?)
+```
+
+**Total tokens (minimal):** ~800 + ~2000 + ~1000 + ~400 = ~4200
+**Total tokens (full):** ~3000 + ~6000 + ~1500 + ~800 = ~11300
+**Latency:** 4 serial round trips
+
+### Flow 2: "What happened with this feature?" — 3 round trips
+
+```
+search "feature name"         → find relevant entities
+timeline "feature name"       → reconstruct chronological history
+related issues 42             → discover connected work
+```
+
+**Total tokens (minimal):** ~600 + ~1500 + ~400 = ~2500
+**Total tokens (full):** ~2000 + ~5000 + ~1000 = ~8000
+**Latency:** 3 serial round trips
+
+### Flow 3: "Why was this code changed?" — 3 round trips
+
+```
+trace src/file.rs             → file -> MR -> issue chain
+issues <iid> -p proj         → full issue detail
+timeline "issue:42"           → full history with cross-refs
+```
+
+**Total tokens (minimal):** ~800 + ~2000 + ~1500 = ~4300
+**Total tokens (full):** ~1500 + ~6000 + ~5000 = ~12500
+**Latency:** 3 serial round trips
+
+### Flow 4: "Is the system healthy?" — 2-4 round trips
+
+```
+health                        → quick pre-flight (pass/fail)
+doctor                        → detailed diagnostics (if health fails)
+status                        → sync state per project
+stats                         → document/index health
+```
+
+**Total tokens:** ~100 + ~300 + ~200 + ~400 = ~1000
+**Latency:** 2-4 serial round trips (often 1 if health passes)
+
+### Flow 5: "Who can review this?" — 2-3 round trips
+
+```
+who src/auth/                 → find file experts
+who @jdoe --reviews           → check reviewer's patterns
+```
+
+**Total tokens (minimal):** ~300 + ~300 = ~600
+**Latency:** 2 serial round trips
+
+### Flow 6: "Find and understand an issue" — 4 round trips
+
+```
+search "query"                → discover entities (get IIDs)
+issues <iid>                  → full detail with discussions
+timeline "issue:42"           → chronological context
+related issues 42             → connected entities
+```
+
+**Total tokens (minimal):** ~600 + ~2000 + ~1500 + ~400 = ~4500
+**Total tokens (full):** ~2000 + ~6000 + ~5000 + ~1000 = ~14000
+**Latency:** 4 serial round trips
+
+---
+
+## 2. Token Cost Profiles
+
+Measured typical response sizes in robot mode with default settings:
+
+| Command | Typical Tokens (full) | With `--fields minimal` | Dominant Cost Driver |
+|---|---|---|---|
+| `me` (all sections) | 2000-5000 | 500-1500 | Open items count |
+| `issues` (list, n=50) | 1500-3000 | 400-800 | Labels arrays |
+| `issues <iid>` (detail) | 1000-8000 | N/A (no minimal for detail) | Discussion depth |
+| `mrs <iid>` (detail) | 1000-8000 | N/A | Discussion depth, DiffNote positions |
+| `timeline` (limit=100) | 2000-6000 | 800-1500 | Event count + evidence |
+| `search` (n=20) | 1000-3000 | 300-600 | Snippet length |
+| `who expert` | 300-800 | 150-300 | Expert count |
+| `who workload` | 500-1500 | 200-500 | Open items count |
+| `trace` | 500-2000 | 300-800 | Chain depth |
+| `file-history` | 300-1500 | 200-500 | MR count |
+| `related` | 300-1000 | 200-400 | Result count |
+| `drift` | 200-800 | N/A | Similarity curve length |
+| `notes` (n=50) | 1500-5000 | 500-1000 | Body length |
+| `count` | ~100 | N/A | Fixed structure |
+| `stats` | ~500 | N/A | Fixed structure |
+| `health` | ~100 | N/A | Fixed structure |
+| `doctor` | ~300 | N/A | Fixed structure |
+| `status` | ~200 | N/A | Project count |
+
+### Key Observations
+
+1. **Detail commands are expensive.** `issues <iid>` and `mrs <iid>` can hit 8000 tokens due to discussions. This is the content agents actually need, but most of it is discussion body text.
+
+2. **`me` is the most-called command** and ranges 2000-5000 tokens. Agents often just need "do I have work?" which is ~100 tokens (summary counts only).
+
+3. **Lists with labels are wasteful.** Every issue/MR in a list carries its full label array. With 50 items x 5 labels each, that's 250 strings of overhead.
+
+4. **`--fields minimal` helps a lot** — 50-70% reduction on list commands. But it's not available on detail views.
+
+5. **Timeline scales linearly** with event count and evidence notes. The `--max-evidence` flag helps cap the expensive part.
+
+---
+
+## 3. Round-Trip Inefficiency Patterns
+
+### Pattern A: Discovery -> Detail (N+1)
+
+Agent searches, gets 5 results, then needs detail on each:
+
+```
+search "auth bug"              → 5 results
+issues 42 -p proj             → detail
+issues 55 -p proj             → detail
+issues 71 -p proj             → detail
+issues 88 -p proj             → detail
+issues 95 -p proj             → detail
+```
+
+**6 round trips** for what should be 2 (search + batch detail).
+
+### Pattern B: Detail -> Context Gathering
+
+Agent gets issue detail, then needs timeline + related + trace:
+
+```
+issues 42 -p proj             → detail
+timeline "issue:42" -p proj   → events
+related issues 42 -p proj     → similar
+trace src/file.rs -p proj     → code provenance
+```
+
+**4 round trips** for what should be 1 (detail with embedded context).
+
+### Pattern C: Health Check Cascade
+
+Agent checks health, discovers issue, drills down:
+
+```
+health                         → unhealthy (exit 19)
+doctor                         → token OK, Ollama missing
+stats --check                  → 5 orphan embeddings
+stats --repair                 → fixed
+```
+
+**4 round trips** but only 2 are actually needed (doctor covers health).
+
+### Pattern D: Dashboard -> Action
+
+Agent checks dashboard, picks item, needs full context:
+
+```
+me                             → 5 open issues, 2 MRs
+issues 42 -p proj             → picked issue detail
+who src/auth/ -p proj         → expert for help
+timeline "issue:42" -p proj   → history
+```
+
+**4 round trips.** With `--include`, could be 2 (me with inline detail + who).
+
+---
+
+## 4. Optimized Workflow Vision
+
+What the same workflows look like with proposed optimizations:
+
+### Flow 1 Optimized: "What should I work on?" — 2 round trips
+
+```
+me --depth titles              → 400 tokens: counts + item titles with attention_state
+issues 42 --include timeline,trace  → 1 call: detail + events + code provenance
+```
+
+### Flow 2 Optimized: "What happened with this feature?" — 1-2 round trips
+
+```
+search "feature" -n 5          → find entities
+issues 42 --include timeline,related → everything in one call
+```
+
+### Flow 3 Optimized: "Why was this code changed?" — 1 round trip
+
+```
+trace src/file.rs --include experts,timeline → full chain + experts + events
+```
+
+### Flow 4 Optimized: "Is the system healthy?" — 1 round trip
+
+```
+doctor                         → covers health + auth + connectivity
+# status + stats only if doctor reveals issues
+```
+
+### Flow 6 Optimized: "Find and understand" — 2 round trips
+
+```
+search "query" -n 5            → discover entities
+issues --batch 42,55,71 --include timeline → batch detail with events
+```

docs/command-surface-analysis/07-consolidation-proposals.md

@@ -0,0 +1,198 @@
+# Consolidation Proposals
+
+5 proposals to reduce 34 commands to 29 by merging high-overlap commands.
+
+---
+
+## A. Absorb `file-history` into `trace --shallow`
+
+**Overlap:** 75%. Both do rename chain BFS on `mr_file_changes`, both optionally include DiffNote discussions. `trace` follows `entity_references` to linked issues; `file-history` stops at MRs.
+
+**Current state:**
+```bash
+# These do nearly the same thing:
+lore file-history src/auth/ -p proj --discussions
+lore trace src/auth/ -p proj --discussions
+# trace just adds: issues linked via entity_references
+```
+
+**Proposed change:**
+- `trace <path>` — full chain: file -> MR -> issue -> discussions (existing behavior)
+- `trace <path> --shallow` — MR-only, no issue following (replaces `file-history`)
+- Move `--merged` flag from `file-history` to `trace`
+- Deprecate `file-history` as an alias that maps to `trace --shallow`
+
+**Migration path:**
+1. Add `--shallow` and `--merged` flags to `trace`
+2. Make `file-history` an alias with deprecation warning
+3. Update robot-docs to point to `trace`
+4. Remove alias after 2 releases
+
+**Breaking changes:** Robot output shape differs slightly (`trace_chains` vs `merge_requests` key name). The `--shallow` variant should match `file-history`'s output shape for compatibility.
+
+**Effort:** Low. Most code is already shared via `resolve_rename_chain()`.
+
+---
+
+## B. Absorb `auth` into `doctor`
+
+**Overlap:** 100% of `auth` is contained within `doctor`.
+
+**Current state:**
+```bash
+lore auth     # checks: token set, GitLab reachable, user identity
+lore doctor   # checks: all of above + DB + schema + Ollama
+```
+
+**Proposed change:**
+- `doctor` — full check (existing behavior)
+- `doctor --auth` — token + GitLab only (replaces `auth`)
+- Keep `health` separate (fast pre-flight, different exit code contract: 0/19)
+- Deprecate `auth` as alias for `doctor --auth`
+
+**Migration path:**
+1. Add `--auth` flag to `doctor`
+2. Make `auth` an alias with deprecation warning
+3. Remove alias after 2 releases
+
+**Breaking changes:** None for robot mode (same JSON shape). Exit code mapping needs verification.
+
+**Effort:** Low. Doctor already has the auth check logic.
+
+---
+
+## C. Remove `related` query-mode
+
+**Overlap:** 80% with `search --mode semantic`.
+
+**Current state:**
+```bash
+# These are functionally equivalent:
+lore related "authentication flow"
+lore search "authentication flow" --mode semantic
+
+# This is UNIQUE (no overlap):
+lore related issues 42
+```
+
+**Proposed change:**
+- Keep entity-seeded mode: `related issues 42` (seeds from existing entity embedding)
+- Remove free-text mode: `related "text"` -> error with suggestion: "Use `search --mode semantic`"
+- Alternatively: keep as sugar but document it as equivalent to search
+
+**Migration path:**
+1. Add deprecation warning when query-mode is used
+2. After 2 releases, remove query-mode parsing
+3. Entity-mode stays unchanged
+
+**Breaking changes:** Agents using `related "text"` must switch to `search --mode semantic`. This is a strict improvement since search has filters.
+
+**Effort:** Low. Just argument validation change.
+
+---
+
+## D. Merge `who overlap` into `who expert`
+
+**Overlap:** 50% functional, but overlap is a strict simplification of expert.
+
+**Current state:**
+```bash
+lore who src/auth/               # expert mode: scored rankings
+lore who --overlap src/auth/     # overlap mode: raw touch counts
+```
+
+**Proposed change:**
+- `who <path>` (expert) adds `touch_count` and `last_touch_at` fields to each expert row
+- `who --overlap <path>` becomes an alias for `who <path> --fields username,touch_count`
+- Eventually remove `--overlap` flag
+
+**New expert output:**
+```json
+{
+  "experts": [
+    {
+      "username": "jdoe", "score": 42.5,
+      "touch_count": 15, "last_touch_at": "2026-02-20",
+      "detail": { "mr_ids_author": [99, 101] }
+    }
+  ]
+}
+```
+
+**Migration path:**
+1. Add `touch_count` and `last_touch_at` to expert output
+2. Make `--overlap` an alias with deprecation warning
+3. Remove `--overlap` after 2 releases
+
+**Breaking changes:** Expert output gains new fields (non-breaking for JSON consumers). Overlap output shape changes if agents were parsing `{ "users": [...] }` vs `{ "experts": [...] }`.
+
+**Effort:** Low. Expert query already touches the same tables; just need to add a COUNT aggregation.
+
+---
+
+## E. Merge `count` and `status` into `stats`
+
+**Overlap:** `count` and `stats` both answer "how much data?"; `status` and `stats` both report system state.
+
+**Current state:**
+```bash
+lore count issues           # entity count + state breakdown
+lore count mrs              # entity count + state breakdown
+lore status                 # sync cursors per project
+lore stats                  # document/index counts + integrity
+```
+
+**Proposed change:**
+- `stats` — document/index health (existing behavior, default)
+- `stats --entities` — adds entity counts (replaces `count`)
+- `stats --sync` — adds sync cursor positions (replaces `status`)
+- `stats --all` — everything: entities + sync + documents + integrity
+- `stats --check` / `--repair` — unchanged
+
+**New `--all` output:**
+```json
+{
+  "data": {
+    "entities": {
+      "issues": { "total": 5000, "opened": 200, "closed": 4800 },
+      "merge_requests": { "total": 1234, "opened": 100, "closed": 50, "merged": 1084 },
+      "discussions": { "total": 8000 },
+      "notes": { "total": 282000, "system_excluded": 50000 }
+    },
+    "sync": {
+      "projects": [
+        { "project_path": "group/repo", "last_synced_at": "...", "document_count": 5000 }
+      ]
+    },
+    "documents": { "total": 61652, "issues": 5000, "mrs": 2000, "notes": 50000 },
+    "embeddings": { "total": 80000, "synced": 79500, "pending": 500 },
+    "fts": { "total_docs": 61652 },
+    "queues": { "pending": 0, "in_progress": 0, "failed": 0 },
+    "integrity": { "ok": true }
+  }
+}
+```
+
+**Migration path:**
+1. Add `--entities`, `--sync`, `--all` flags to `stats`
+2. Make `count` an alias for `stats --entities` with deprecation warning
+3. Make `status` an alias for `stats --sync` with deprecation warning
+4. Remove aliases after 2 releases
+
+**Breaking changes:** `count` output currently has `{ "entity": "issues", "count": N, "breakdown": {...} }`. Under `stats --entities`, this becomes nested under `data.entities`. Alias can preserve old shape during deprecation period.
+
+**Effort:** Medium. Need to compose three query paths into one response builder.
+
+---
+
+## Summary
+
+| Consolidation | Removes | Effort | Breaking? |
+|---|---|---|---|
+| `file-history` -> `trace --shallow` | -1 command | Low | Alias redirect, output shape compat |
+| `auth` -> `doctor --auth` | -1 command | Low | Alias redirect |
+| `related` query-mode removal | -1 mode | Low | Must switch to `search --mode semantic` |
+| `who overlap` -> `who expert` | -1 sub-mode | Low | Output gains fields |
+| `count` + `status` -> `stats` | -2 commands | Medium | Output nesting changes |
+
+**Total: 34 commands -> 29 commands.** All changes use deprecation-with-alias pattern for gradual migration.

docs/command-surface-analysis/08-robot-optimization-proposals.md

@@ -0,0 +1,347 @@
+# Robot-Mode Optimization Proposals
+
+6 proposals to reduce round trips and token waste for agent consumers.
+
+---
+
+## A. `--include` flag for embedded sub-queries (P0)
+
+**Problem:** The #1 agent inefficiency. Every "understand this entity" workflow requires 3-4 serial round trips: detail + timeline + related + trace.
+
+**Proposal:** Add `--include` flag to detail commands that embeds sub-query results in the response.
+
+```bash
+# Before: 4 round trips, ~12000 tokens
+lore -J issues 42 -p proj
+lore -J timeline "issue:42" -p proj --limit 20
+lore -J related issues 42 -p proj -n 5
+lore -J trace src/auth/ -p proj
+
+# After: 1 round trip, ~5000 tokens (sub-queries use reduced limits)
+lore -J issues 42 -p proj --include timeline,related
+```
+
+### Include Matrix
+
+| Base Command | Valid Includes | Default Limits |
+|---|---|---|
+| `issues <iid>` | `timeline`, `related`, `trace` | 20 events, 5 related, 5 chains |
+| `mrs <iid>` | `timeline`, `related`, `file-changes` | 20 events, 5 related |
+| `trace <path>` | `experts`, `timeline` | 5 experts, 20 events |
+| `me` | `detail` (inline top-N item details) | 3 items detailed |
+| `search` | `detail` (inline top-N result details) | 3 results detailed |
+
+### Response Shape
+
+Included data uses `_` prefix to distinguish from base fields:
+
+```json
+{
+  "ok": true,
+  "data": {
+    "iid": 42, "title": "Fix auth", "state": "opened",
+    "discussions": [...],
+    "_timeline": {
+      "event_count": 15,
+      "events": [...]
+    },
+    "_related": {
+      "similar_entities": [...]
+    }
+  },
+  "meta": {
+    "elapsed_ms": 200,
+    "_timeline_ms": 45,
+    "_related_ms": 120
+  }
+}
+```
+
+### Error Handling
+
+Sub-query errors are non-fatal. If Ollama is down, `_related` returns an error instead of failing the whole request:
+
+```json
+{
+  "_related_error": "Ollama unavailable — related results skipped"
+}
+```
+
+### Limit Control
+
+```bash
+# Custom limits for included data
+lore -J issues 42 --include timeline:50,related:10
+```
+
+### Round-Trip Savings
+
+| Workflow | Before | After | Savings |
+|---|---|---|---|
+| Understand an issue | 4 calls | 1 call | **75%** |
+| Why was code changed | 3 calls | 1 call | **67%** |
+| Find and understand | 4 calls | 2 calls | **50%** |
+
+**Effort:** High. Each include needs its own sub-query executor, error isolation, and limit enforcement. But the payoff is massive — this single feature halves agent round trips.
+
+---
+
+## B. `--depth` control on `me` (P0)
+
+**Problem:** `me` returns 2000-5000 tokens. Agents checking "do I have work?" only need ~100 tokens.
+
+**Proposal:** Add `--depth` flag with three levels.
+
+```bash
+# Counts only (~100 tokens) — "do I have work?"
+lore -J me --depth counts
+
+# Titles (~400 tokens) — "what work do I have?"
+lore -J me --depth titles
+
+# Full (current behavior, 2000+ tokens) — "give me everything"
+lore -J me --depth full
+lore -J me  # same as --depth full
+```
+
+### Depth Levels
+
+| Level | Includes | Typical Tokens |
+|---|---|---|
+| `counts` | `summary` block only (counts, no items) | ~100 |
+| `titles` | summary + item lists with minimal fields (iid, title, attention_state) | ~400 |
+| `full` | Everything: items, activity, inbox, discussions | ~2000-5000 |
+
+### Response at `--depth counts`
+
+```json
+{
+  "ok": true,
+  "data": {
+    "username": "jdoe",
+    "summary": {
+      "project_count": 3,
+      "open_issue_count": 5,
+      "authored_mr_count": 2,
+      "reviewing_mr_count": 1,
+      "needs_attention_count": 3
+    }
+  }
+}
+```
+
+### Response at `--depth titles`
+
+```json
+{
+  "ok": true,
+  "data": {
+    "username": "jdoe",
+    "summary": { ... },
+    "open_issues": [
+      { "iid": 42, "title": "Fix auth", "attention_state": "needs_attention" }
+    ],
+    "open_mrs_authored": [
+      { "iid": 99, "title": "Refactor auth", "attention_state": "needs_attention" }
+    ],
+    "reviewing_mrs": []
+  }
+}
+```
+
+**Effort:** Low. The data is already available; just need to gate serialization by depth level.
+
+---
+
+## C. `--batch` flag for multi-entity detail (P1)
+
+**Problem:** After search/timeline, agents discover N entity IIDs and need detail on each. Currently N round trips.
+
+**Proposal:** Add `--batch` flag to `issues` and `mrs` detail mode.
+
+```bash
+# Before: 3 round trips
+lore -J issues 42 -p proj
+lore -J issues 55 -p proj
+lore -J issues 71 -p proj
+
+# After: 1 round trip
+lore -J issues --batch 42,55,71 -p proj
+```
+
+### Response
+
+```json
+{
+  "ok": true,
+  "data": {
+    "results": [
+      { "iid": 42, "title": "Fix auth", "state": "opened", ... },
+      { "iid": 55, "title": "Add SSO", "state": "opened", ... },
+      { "iid": 71, "title": "Token refresh", "state": "closed", ... }
+    ],
+    "errors": [
+      { "iid": 99, "error": "Not found" }
+    ]
+  }
+}
+```
+
+### Constraints
+
+- Max 20 IIDs per batch
+- Individual errors don't fail the batch (partial results returned)
+- Works with `--include` for maximum efficiency: `--batch 42,55 --include timeline`
+- Works with `--fields minimal` for token control
+
+**Effort:** Medium. Need to loop the existing detail handler and compose results.
+
+---
+
+## D. Composite `context` command (P2)
+
+**Problem:** Agents need full context on an entity but must learn `--include` syntax. A purpose-built command is more discoverable.
+
+**Proposal:** Add `context` command that returns detail + timeline + related in one call.
+
+```bash
+lore -J context issues 42 -p proj
+lore -J context mrs 99 -p proj
+```
+
+### Equivalent To
+
+```bash
+lore -J issues 42 -p proj --include timeline,related
+```
+
+But with optimized defaults:
+- Timeline: 20 most recent events, max 3 evidence notes
+- Related: top 5 entities
+- Discussions: truncated after 5 threads
+- Non-fatal: Ollama-dependent parts gracefully degrade
+
+### Response Shape
+
+Same as `issues <iid> --include timeline,related` but with the reduced defaults applied.
+
+### Relationship to `--include`
+
+`context` is sugar for the most common `--include` pattern. Both mechanisms can coexist:
+- `context` for the 80% case (agents wanting full entity understanding)
+- `--include` for custom combinations
+
+**Effort:** Medium. Thin wrapper around detail + include pipeline.
+
+---
+
+## E. `--max-tokens` response budget (P3)
+
+**Problem:** Response sizes vary wildly (100 to 8000 tokens). Agents can't predict cost in advance.
+
+**Proposal:** Let agents cap response size. Server truncates to fit.
+
+```bash
+lore -J me --max-tokens 500
+lore -J timeline "feature" --max-tokens 1000
+lore -J context issues 42 --max-tokens 2000
+```
+
+### Truncation Strategy (priority order)
+
+1. Apply `--fields minimal` if not already set
+2. Reduce array lengths (newest/highest-score items survive)
+3. Truncate string fields (descriptions, snippets) to 200 chars
+4. Omit null/empty fields
+5. Drop included sub-queries (if using `--include`)
+
+### Meta Notice
+
+```json
+{
+  "meta": {
+    "elapsed_ms": 50,
+    "truncated": true,
+    "original_tokens": 3500,
+    "budget_tokens": 1000,
+    "dropped": ["_related", "discussions[5:]", "activity[10:]"]
+  }
+}
+```
+
+### Implementation Notes
+
+Token estimation: rough heuristic based on JSON character count / 4. Doesn't need to be exact — the goal is "roughly this size" not "exactly N tokens."
+
+**Effort:** High. Requires token estimation, progressive truncation logic, and tracking what was dropped.
+
+---
+
+## F. `--format tsv` for list commands (P3)
+
+**Problem:** JSON is verbose for tabular data. List commands return arrays of objects with repeated key names.
+
+**Proposal:** Add `--format tsv` for list commands.
+
+```bash
+lore -J issues --format tsv --fields iid,title,state -n 10
+```
+
+### Output
+
+```
+iid	title	state
+42	Fix auth	opened
+55	Add SSO	opened
+71	Token refresh	closed
+```
+
+### Token Savings
+
+| Command | JSON tokens | TSV tokens | Savings |
+|---|---|---|---|
+| `issues -n 50 --fields minimal` | ~800 | ~250 | **69%** |
+| `mrs -n 50 --fields minimal` | ~800 | ~250 | **69%** |
+| `who expert -n 10` | ~300 | ~100 | **67%** |
+| `notes -n 50 --fields minimal` | ~1000 | ~350 | **65%** |
+
+### Applicable Commands
+
+TSV works well for flat, tabular data:
+- `issues` (list), `mrs` (list), `notes` (list)
+- `who expert`, `who overlap`, `who reviews`
+- `count`
+
+TSV does NOT work for nested/complex data:
+- Detail views (discussions are nested)
+- Timeline (events have nested evidence)
+- Search (nested explain, labels arrays)
+- `me` (multiple sections)
+
+### Agent Parsing
+
+Most LLMs parse TSV naturally. Agents that need structured data can still use JSON.
+
+**Effort:** Medium. Tab-separated serialization for flat structs is straightforward. Need to handle escaping for body text containing tabs/newlines.
+
+---
+
+## Impact Summary
+
+| Optimization | Priority | Effort | Round-Trip Savings | Token Savings |
+|---|---|---|---|---|
+| `--include` | P0 | High | **50-75%** | Moderate |
+| `--depth` on `me` | P0 | Low | None | **60-80%** |
+| `--batch` | P1 | Medium | **N-1 per batch** | Moderate |
+| `context` command | P2 | Medium | **67-75%** | Moderate |
+| `--max-tokens` | P3 | High | None | **Variable** |
+| `--format tsv` | P3 | Medium | None | **65-69% on lists** |
+
+### Implementation Order
+
+1. **`--depth` on `me`** — lowest effort, high value, no risk
+2. **`--include` on `issues`/`mrs` detail** — highest impact, start with `timeline` include only
+3. **`--batch`** — eliminates N+1 pattern
+4. **`context` command** — sugar on top of `--include`
+5. **`--format tsv`** — nice-to-have, easy to add incrementally
+6. **`--max-tokens`** — complex, defer until demand is clear

docs/command-surface-analysis/09-appendices.md

@@ -0,0 +1,181 @@
+# Appendices
+
+---
+
+## A. Robot Output Envelope
+
+All robot-mode responses follow this structure:
+
+```json
+{
+  "ok": true,
+  "data": { /* command-specific */ },
+  "meta": { "elapsed_ms": 42 }
+}
+```
+
+Errors (to stderr):
+
+```json
+{
+  "error": {
+    "code": "CONFIG_NOT_FOUND",
+    "message": "Configuration file not found",
+    "suggestion": "Run 'lore init'",
+    "actions": ["lore init"]
+  }
+}
+```
+
+The `actions` array contains copy-paste shell commands for automated recovery. Omitted when empty.
+
+---
+
+## B. Exit Codes
+
+| Code | Meaning | Retryable |
+|---|---|---|
+| 0 | Success | N/A |
+| 1 | Internal error / not implemented | Maybe |
+| 2 | Usage error (invalid flags or arguments) | No (fix syntax) |
+| 3 | Config invalid | No (fix config) |
+| 4 | Token not set | No (set token) |
+| 5 | GitLab auth failed | Maybe (token expired?) |
+| 6 | Resource not found (HTTP 404) | No |
+| 7 | Rate limited | Yes (wait) |
+| 8 | Network error | Yes (retry) |
+| 9 | Database locked | Yes (wait) |
+| 10 | Database error | Maybe |
+| 11 | Migration failed | No (investigate) |
+| 12 | I/O error | Maybe |
+| 13 | Transform error | No (bug) |
+| 14 | Ollama unavailable | Yes (start Ollama) |
+| 15 | Ollama model not found | No (pull model) |
+| 16 | Embedding failed | Yes (retry) |
+| 17 | Not found (entity does not exist) | No |
+| 18 | Ambiguous match (use `-p` to specify project) | No (be specific) |
+| 19 | Health check failed | Yes (fix issues first) |
+| 20 | Config not found | No (run init) |
+
+---
+
+## C. Field Selection Presets
+
+The `--fields` flag supports both presets and custom field lists:
+
+```bash
+lore -J issues --fields minimal              # Preset
+lore -J mrs --fields iid,title,state,draft   # Custom comma-separated
+```
+
+| Command | Minimal Preset Fields |
+|---|---|
+| `issues` (list) | `iid`, `title`, `state`, `updated_at_iso` |
+| `mrs` (list) | `iid`, `title`, `state`, `updated_at_iso` |
+| `notes` (list) | `id`, `author_username`, `body`, `created_at_iso` |
+| `search` | `document_id`, `title`, `source_type`, `score` |
+| `timeline` | `timestamp`, `type`, `entity_iid`, `detail` |
+| `who expert` | `username`, `score` |
+| `who workload` | `iid`, `title`, `state` |
+| `who reviews` | `name`, `count`, `percentage` |
+| `who active` | `entity_type`, `iid`, `title`, `participants` |
+| `who overlap` | `username`, `touch_count` |
+| `me` (items) | `iid`, `title`, `attention_state`, `updated_at_iso` |
+| `me` (activity) | `timestamp_iso`, `event_type`, `entity_iid`, `actor` |
+
+---
+
+## D. Configuration Precedence
+
+1. CLI flags (highest priority)
+2. Environment variables (`LORE_ROBOT`, `GITLAB_TOKEN`, `LORE_CONFIG_PATH`)
+3. Config file (`~/.config/lore/config.json`)
+4. Built-in defaults (lowest priority)
+
+---
+
+## E. Time Parsing
+
+All commands accepting `--since`, `--until`, `--as-of` support:
+
+| Format | Example | Meaning |
+|---|---|---|
+| Relative days | `7d` | 7 days ago |
+| Relative weeks | `2w` | 2 weeks ago |
+| Relative months | `1m`, `6m` | 1/6 months ago |
+| Absolute date | `2026-01-15` | Specific date |
+
+Internally converted to Unix milliseconds for DB queries.
+
+---
+
+## F. Database Schema (28 migrations)
+
+### Primary Entity Tables
+
+| Table | Key Columns | Notes |
+|---|---|---|
+| `projects` | `gitlab_project_id`, `path_with_namespace`, `web_url` | No `name` or `last_seen_at` |
+| `issues` | `iid`, `title`, `state`, `author_username`, 5 status columns | Status columns nullable (migration 021) |
+| `merge_requests` | `iid`, `title`, `state`, `draft`, `source_branch`, `target_branch` | `last_seen_at INTEGER NOT NULL` |
+| `discussions` | `gitlab_discussion_id` (text), `issue_id`/`merge_request_id` | One FK must be set |
+| `notes` | `gitlab_id`, `author_username`, `body`, DiffNote position columns | `type` column for DiffNote/DiscussionNote |
+
+### Relationship Tables
+
+| Table | Purpose |
+|---|---|
+| `issue_labels`, `mr_labels` | Label junction (DELETE+INSERT for stale removal) |
+| `issue_assignees`, `mr_assignees` | Assignee junction |
+| `mr_reviewers` | Reviewer junction |
+| `entity_references` | Cross-refs: closes, mentioned, related (with `source_method`) |
+| `mr_file_changes` | File diffs: old_path, new_path, change_type |
+
+### Event Tables
+
+| Table | Constraint |
+|---|---|
+| `resource_state_events` | CHECK: exactly one of issue_id/merge_request_id NOT NULL |
+| `resource_label_events` | Same CHECK constraint; `label_name` nullable (migration 012) |
+| `resource_milestone_events` | Same CHECK constraint; `milestone_title` nullable |
+
+### Document/Search Pipeline
+
+| Table | Purpose |
+|---|---|
+| `documents` | Unified searchable content (source_type: issue/merge_request/discussion) |
+| `documents_fts` | FTS5 virtual table for text search |
+| `documents_fts_docsize` | FTS5 shadow B-tree (19x faster for COUNT) |
+| `document_labels` | Fast label filtering (indexed exact-match) |
+| `document_paths` | File path association for DiffNote filtering |
+| `embeddings` | vec0 virtual table; rowid = document_id * 1000 + chunk_index |
+| `embedding_metadata` | Chunk provenance + staleness tracking (document_hash) |
+| `dirty_sources` | Documents needing regeneration (with backoff via next_attempt_at) |
+
+### Infrastructure
+
+| Table | Purpose |
+|---|---|
+| `sync_runs` | Sync history with metrics |
+| `sync_cursors` | Per-resource sync position (updated_at cursor + tie_breaker_id) |
+| `app_locks` | Crash-safe single-flight lock |
+| `raw_payloads` | Raw JSON storage for debugging |
+| `pending_discussion_fetches` | Dependent discussion fetch queue |
+| `pending_dependent_fetches` | Job queue for resource_events, mr_closes, mr_diffs |
+| `schema_version` | Migration tracking |
+
+---
+
+## G. Glossary
+
+| Term | Definition |
+|---|---|
+| **IID** | Issue/MR number within a project (not globally unique) |
+| **FTS5** | SQLite full-text search extension (BM25 ranking) |
+| **vec0** | SQLite extension for vector similarity search |
+| **RRF** | Reciprocal Rank Fusion — combines FTS and vector rankings |
+| **DiffNote** | Comment attached to a specific line in a merge request diff |
+| **Entity reference** | Cross-reference between issues/MRs (closes, mentioned, related) |
+| **Rename chain** | BFS traversal of mr_file_changes to follow file renames |
+| **Attention state** | Computed field on `me` items: needs_attention, not_started, stale, etc. |
+| **Surgical sync** | Fetching specific entities by IID instead of full incremental sync |

docs/lore-me-spec.md

@@ -0,0 +1,290 @@
+# `lore me` — Personal Work Dashboard
+
+## Overview
+
+A personal dashboard command that shows everything relevant to the configured user: open issues, authored MRs, MRs under review, and recent activity. Attention state is computed from GitLab interaction data (comments) with no local state tracking.
+
+## Command Interface
+
+```
+lore me                              # Full dashboard (default project or all)
+lore me --issues                     # Issues section only
+lore me --mrs                        # MRs section only (authored + reviewing)
+lore me --activity                   # Activity feed only
+lore me --issues --mrs               # Multiple sections (combinable)
+lore me --all                        # All synced projects (overrides default_project)
+lore me --since 2d                   # Activity window (default: 30d)
+lore me --project group/repo         # Scope to one project
+lore me --user jdoe                  # Override configured username
+```
+
+Standard global flags: `--robot`/`-J`, `--fields`, `--color`, `--icons`.
+
+---
+
+## Acceptance Criteria
+
+### AC-1: Configuration
+
+- **AC-1.1**: New optional field `gitlab.username` (string) in config.json
+- **AC-1.2**: Resolution order: `--user` CLI flag > `config.gitlab.username` > exit code 2 with actionable error message suggesting how to set it
+- **AC-1.3**: Username is case-sensitive (matches GitLab usernames exactly)
+
+### AC-2: Command Interface
+
+- **AC-2.1**: New command `lore me` — single command with flags (matches `who` pattern)
+- **AC-2.2**: Section filter flags: `--issues`, `--mrs`, `--activity` — combinable. Passing multiple shows those sections. No flags = full dashboard (all sections).
+- **AC-2.3**: `--since <duration>` controls activity feed window, default 30 days. Only affects the activity section; work item sections always show all open items regardless of `--since`.
+- **AC-2.4**: `--project <path>` scopes to a single project
+- **AC-2.5**: `--user <username>` overrides configured username
+- **AC-2.6**: `--all` flag shows all synced projects (overrides default_project)
+- **AC-2.7**: `--project` and `--all` are mutually exclusive — passing both is exit code 2
+- **AC-2.8**: Standard global flags: `--robot`/`-J`, `--fields`, `--color`, `--icons`
+
+### AC-3: "My Items" Definition
+
+- **AC-3.1**: Issues assigned to me (`issue_assignees.username`). Authorship alone does NOT qualify an issue.
+- **AC-3.2**: MRs authored by me (`merge_requests.author_username`)
+- **AC-3.3**: MRs where I'm a reviewer (`mr_reviewers.username`)
+- **AC-3.4**: Scope is **Assigned (issues) + Authored/Reviewing (MRs)** — no participation/mention expansion
+- **AC-3.5**: MR assignees (`mr_assignees`) are NOT used — in Pattern 1 workflows (author = assignee), this is redundant with authorship
+- **AC-3.6**: Activity feed uses CURRENT association only — if you've been unassigned from an issue, activity on it no longer appears. This keeps the query simple and the feed relevant.
+
+### AC-4: Attention State Model
+
+- **AC-4.1**: Computed per-item from synced GitLab data, no local state tracking
+- **AC-4.2**: Interaction signal: notes authored by the user (`notes.author_username = me` where `is_system = 0`)
+- **AC-4.3**: Future: award emoji will extend interaction signals (separate bead)
+- **AC-4.4**: States (evaluated in this order — first match wins):
+  1. `not_ready`: MR only — `draft=1` AND zero entries in `mr_reviewers`
+  2. `needs_attention`: Others' latest non-system note > user's latest non-system note
+  3. `stale`: Entity has at least one non-system note from someone, but the most recent note from anyone is older than 30 days. Items with ZERO notes are NOT stale — they're `not_started`.
+  4. `not_started`: User has zero non-system notes on this entity (regardless of whether others have commented)
+  5. `awaiting_response`: User's latest non-system note timestamp >= all others' latest non-system note timestamps (including when user is the only commenter)
+- **AC-4.5**: Applied to all item types (issues, authored MRs, reviewing MRs)
+
+### AC-5: Dashboard Sections
+
+**AC-5.1: Open Issues**
+- Source: `issue_assignees.username = me`, state = opened
+- Fields: project path, iid, title, status_name (work item status), attention state, relative time since updated
+- Sort: attention-first (needs_attention > not_started > awaiting_response > stale), then most recently updated within same state
+- No limit, no truncation — show all
+
+**AC-5.2: Open MRs — Authored**
+- Source: `merge_requests.author_username = me`, state = opened
+- Fields: project path, iid, title, draft indicator, detailed_merge_status, attention state, relative time
+- Sort: same as issues
+
+**AC-5.3: Open MRs — Reviewing**
+- Source: `mr_reviewers.username = me`, state = opened
+- Fields: project path, iid, title, MR author username, draft indicator, attention state, relative time
+- Sort: same as issues
+
+**AC-5.4: Activity Feed**
+- Sources (all within `--since` window, default 30d):
+  - Human comments (`notes.is_system = 0`) on my items
+  - State events (`resource_state_events`) on my items
+  - Label events (`resource_label_events`) on my items
+  - Milestone events (`resource_milestone_events`) on my items
+  - Assignment/reviewer system notes (see AC-12 for patterns) on my items
+- "My items" for the activity feed = items I'm CURRENTLY associated with per AC-3 (current assignment state, not historical)
+- Includes activity on items regardless of open/closed state
+- Own actions included but flagged (`is_own: true` in robot, `(you)` suffix + dimmed in human)
+- Sort: newest first (chronological descending)
+- No limit, no truncation — show all events
+
+**AC-5.5: Summary Header**
+- Counts: projects, open issues, authored MRs, reviewing MRs, needs_attention count
+- Attention legend (human mode): icon + label for each state
+
+### AC-6: Human Output — Visual Design
+
+**AC-6.1: Layout**
+- Section card style with `section_divider` headers
+- Legend at top explains attention icons
+- Two-line per item: main data on line 1, project path on line 2 (indented)
+- When scoped to single project (`--project`), suppress project path line (redundant)
+
+**AC-6.2: Attention Icons (three tiers)**
+
+| State | Nerd Font | Unicode | ASCII | Color |
+|-------|-----------|---------|-------|-------|
+| needs_attention | `\uf0f3` bell | `◆` | `[!]` | amber (warning) |
+| not_started | `\uf005` star | `★` | `[*]` | cyan (info) |
+| awaiting_response | `\uf017` clock | `◷` | `[~]` | dim (muted) |
+| stale | `\uf54c` skull | `☠` | `[x]` | dim (muted) |
+
+**AC-6.3: Color Vocabulary** (matches existing lore palette)
+- Issue refs (#N): cyan
+- MR refs (!N): purple
+- Usernames (@name): cyan
+- Opened state: green
+- Merged state: purple
+- Closed state: dim
+- Draft indicator: gray
+- Own actions: dimmed + `(you)` suffix
+- Timestamps: dim (relative time)
+
+**AC-6.4: Activity Event Badges**
+
+| Event | Nerd/Unicode (colored bg) | ASCII fallback |
+|-------|--------------------------|----------------|
+| note | cyan bg, dark text | `[note]` cyan text |
+| status | amber bg, dark text | `[status]` amber text |
+| label | purple bg, white text | `[label]` purple text |
+| assign | green bg, dark text | `[assign]` green text |
+| milestone | magenta bg, white text | `[milestone]` magenta text |
+
+Fallback: when background colors aren't available (ASCII mode), use colored text with brackets instead of background pills.
+
+**AC-6.5: Labels**
+- Human mode: not shown
+- Robot mode: included in JSON
+
+### AC-7: Robot Output
+
+- **AC-7.1**: Standard `{ok, data, meta}` envelope
+- **AC-7.2**: `data` contains: `username`, `since_iso`, `summary` (counts + `needs_attention_count`), `open_issues[]`, `open_mrs_authored[]`, `reviewing_mrs[]`, `activity[]`
+- **AC-7.3**: Each item includes: project, iid, title, state, attention_state (programmatic: `needs_attention`, `not_started`, `awaiting_response`, `stale`, `not_ready`), labels, updated_at_iso, web_url
+- **AC-7.4**: Issues include `status_name` (work item status)
+- **AC-7.5**: MRs include `draft`, `detailed_merge_status`, `author_username` (reviewing section)
+- **AC-7.6**: Activity items include: `timestamp_iso`, `event_type`, `entity_type`, `entity_iid`, `project`, `actor`, `is_own`, `summary`, `body_preview` (for notes, truncated to 200 chars)
+- **AC-7.7**: `--fields minimal` preset: `iid`, `title`, `attention_state`, `updated_at_iso` (work items); `timestamp_iso`, `event_type`, `entity_iid`, `actor` (activity)
+- **AC-7.8**: Metadata-only depth — agents drill into specific items with `timeline`, `issues`, `mrs` for full context
+- **AC-7.9**: No limits, no truncation on any array
+
+### AC-8: Cross-Project Behavior
+
+- **AC-8.1**: If `config.default_project` is set, scope to that project by default. If no default project, show all synced projects.
+- **AC-8.2**: `--all` flag overrides default project and shows all synced projects
+- **AC-8.3**: `--project` flag narrows to a specific project (supports fuzzy match like other commands)
+- **AC-8.4**: `--project` and `--all` are mutually exclusive (exit 2 if both passed)
+- **AC-8.5**: Project path shown per-item in both human and robot output (suppressed in human when single-project scoped per AC-6.1)
+
+### AC-9: Sort Order
+
+- **AC-9.1**: Work item sections: attention-first, then most recently updated
+- **AC-9.2**: Attention priority: `needs_attention` > `not_started` > `awaiting_response` > `stale` > `not_ready`
+- **AC-9.3**: Activity feed: chronological descending (newest first)
+
+### AC-10: Error Handling
+
+- **AC-10.1**: No username configured and no `--user` flag → exit 2 with suggestion
+- **AC-10.2**: No synced data → exit 17 with suggestion to run `lore sync`
+- **AC-10.3**: Username found but no matching items → empty sections with summary showing zeros
+- **AC-10.4**: `--project` and `--all` both passed → exit 2 with message
+
+### AC-11: Relationship to Existing Commands
+
+- **AC-11.1**: `who @username` remains for looking at anyone's workload
+- **AC-11.2**: `lore me` is the self-view with attention intelligence
+- **AC-11.3**: No deprecation of `who` — they serve different purposes
+
+### AC-12: New Assignments Detection
+
+- **AC-12.1**: Detect from system notes (`notes.is_system = 1`) matching these body patterns:
+  - `"assigned to @username"` — issue/MR assignment
+  - `"unassigned @username"` — removal (shown as `unassign` event type)
+  - `"requested review from @username"` — reviewer assignment (shown as `review_request` event type)
+- **AC-12.2**: These appear in the activity feed with appropriate event types
+- **AC-12.3**: Shows who performed the action (note author from the associated non-system context, or "system" if unavailable) and when (note created_at)
+- **AC-12.4**: Pattern matching is case-insensitive and matches username at word boundary
+
+---
+
+## Out of Scope (Follow-Up Work)
+
+- **Award emoji sync**: Extends attention signal with reaction timestamps. Requires new table + GitLab REST API integration. Note-level emoji sync has N+1 concern requiring smart batching.
+- **Participation/mention expansion**: Broadening "my items" beyond assigned+authored.
+- **Label filtering**: `--label` flag to scope dashboard by label.
+
+---
+
+## Design Notes
+
+### Why No High-Water Mark
+
+GitLab itself is the source of truth for "what I've engaged with." The attention state is computed by comparing the user's latest comment timestamp against others' latest comment timestamps on each item. No local cursor or mark is needed.
+
+### Why Comments-Only (For Now)
+
+Award emoji (reactions) are a valid "I've engaged" signal but aren't currently synced. The attention model is designed to incorporate emoji timestamps when available — adding them later requires no model changes.
+
+### Why MR Assignees Are Excluded
+
+GitLab MR workflows have three role fields: Author, Assignee, and Reviewer. In Pattern 1 workflows (the most common post-2020), the author assigns themselves — making assignee redundant with authorship. The Reviewing section uses `mr_reviewers` as the review signal.
+
+### Attention State Evaluation Order
+
+States are evaluated in priority order (first match wins):
+
+```
+1. not_ready    — MR-only: draft=1 AND no reviewers
+2. needs_attention — others commented after me
+3. stale        — had activity, but nothing in 30d (NOT for zero-comment items)
+4. not_started  — I have zero comments (may or may not have others' comments)
+5. awaiting_response — I commented last (or I'm the only commenter)
+```
+
+Edge cases:
+- Zero comments from anyone → `not_started` (NOT stale)
+- Only my comments, none from others → `awaiting_response`
+- Only others' comments, none from me → `not_started` (I haven't engaged)
+  - Wait: this conflicts with `needs_attention` (step 2). If others have commented and I haven't, then others' latest > my latest (NULL). This should be `needs_attention`, not `not_started`.
+
+Corrected logic:
+- `needs_attention` takes priority over `not_started` when others HAVE commented but I haven't. The distinction: `not_started` only applies when NOBODY has commented.
+
+```
+1. not_ready         — MR-only: draft=1 AND no reviewers
+2. needs_attention   — others have non-system notes AND (I have none OR others' latest > my latest)
+3. stale             — latest note from anyone is older than 30 days
+4. awaiting_response — my latest >= others' latest (I'm caught up)
+5. not_started       — zero non-system notes from anyone
+```
+
+### Attention State Computation (SQL Sketch)
+
+```sql
+WITH my_latest AS (
+    SELECT d.issue_id, d.merge_request_id, MAX(n.created_at) AS ts
+    FROM notes n
+    JOIN discussions d ON n.discussion_id = d.id
+    WHERE n.author_username = ?me AND n.is_system = 0
+    GROUP BY d.issue_id, d.merge_request_id
+),
+others_latest AS (
+    SELECT d.issue_id, d.merge_request_id, MAX(n.created_at) AS ts
+    FROM notes n
+    JOIN discussions d ON n.discussion_id = d.id
+    WHERE n.author_username != ?me AND n.is_system = 0
+    GROUP BY d.issue_id, d.merge_request_id
+),
+any_latest AS (
+    SELECT d.issue_id, d.merge_request_id, MAX(n.created_at) AS ts
+    FROM notes n
+    JOIN discussions d ON n.discussion_id = d.id
+    WHERE n.is_system = 0
+    GROUP BY d.issue_id, d.merge_request_id
+)
+SELECT
+    CASE
+        -- MR-only: draft with no reviewers
+        WHEN entity_type = 'mr' AND draft = 1
+             AND NOT EXISTS (SELECT 1 FROM mr_reviewers WHERE merge_request_id = entity_id)
+            THEN 'not_ready'
+        -- Others commented and I haven't caught up (or never engaged)
+        WHEN others.ts IS NOT NULL AND (my.ts IS NULL OR others.ts > my.ts)
+            THEN 'needs_attention'
+        -- Had activity but gone quiet for 30d
+        WHEN any.ts IS NOT NULL AND any.ts < ?now_minus_30d
+            THEN 'stale'
+        -- I've responded and I'm caught up
+        WHEN my.ts IS NOT NULL AND my.ts >= COALESCE(others.ts, 0)
+            THEN 'awaiting_response'
+        -- Nobody has commented at all
+        ELSE 'not_started'
+    END AS attention_state
+FROM ...
+```

docs/plan-expose-discussion-ids.feedback-1.md

@@ -0,0 +1,202 @@
+No `## Rejected Recommendations` section appears in the plan you pasted, so the revisions below are all net-new.
+
+1. **Add an explicit “Bridge Contract” and fix scope inconsistency**
+Analysis: The plan says “Three changes” but defines four. More importantly, identifier requirements are scattered. A single contract section prevents drift and makes every new read surface prove it can drive a write call.
+
+```diff
+@@
+-**Scope**: Three changes, delivered in order:
++**Scope**: Four workstreams, delivered in order:
+ 1. Add `gitlab_discussion_id` to notes output
+ 2. Add `gitlab_discussion_id` to show command discussion groups
+ 3. Add a standalone `discussions` list command
+ 4. Fix robot-docs to list actual field names instead of opaque type references
++
++## Bridge Contract (Cross-Cutting)
++Every read payload that surfaces notes/discussions MUST include:
++- `project_path`
++- `noteable_type`
++- `parent_iid`
++- `gitlab_discussion_id`
++- `gitlab_note_id` (when note-level data is returned)
++This contract is required so agents can deterministically construct `glab api` write calls.
+```
+
+2. **Normalize identifier naming now (break ambiguous names)**
+Analysis: Current `id`/`gitlab_id` naming is ambiguous in mixed payloads. Rename to explicit `note_id` and `gitlab_note_id` now (you explicitly don’t care about backward compatibility). This reduces automation mistakes.
+
+```diff
+@@ 1b. Add field to `NoteListRow`
+-pub struct NoteListRow {
+-    pub id: i64,
+-    pub gitlab_id: i64,
++pub struct NoteListRow {
++    pub note_id: i64,           // local DB id
++    pub gitlab_note_id: i64,    // GitLab note id
+@@
+@@ 1c. Add field to `NoteListRowJson`
+-pub struct NoteListRowJson {
+-    pub id: i64,
+-    pub gitlab_id: i64,
++pub struct NoteListRowJson {
++    pub note_id: i64,
++    pub gitlab_note_id: i64,
+@@
+-#### 2f. Add `gitlab_note_id` to note detail structs in show
+-While we're here, add `gitlab_id` to `NoteDetail`, `MrNoteDetail`, and their JSON
++#### 2f. Add `gitlab_note_id` to note detail structs in show
++While we're here, add `gitlab_note_id` to `NoteDetail`, `MrNoteDetail`, and their JSON
+ counterparts.
+```
+
+3. **Stop positional column indexing for these changes**
+Analysis: In `list.rs`, row extraction is positional (`row.get(18)`, etc.). Adding fields is fragile and easy to break silently. Use named aliases and named lookup for robustness.
+
+```diff
+@@ 1a/1b SQL + query_map
+-    p.path_with_namespace AS project_path
++    p.path_with_namespace AS project_path,
++    d.gitlab_discussion_id AS gitlab_discussion_id
+@@
+-    project_path: row.get(18)?,
+-    gitlab_discussion_id: row.get(19)?,
++    project_path: row.get("project_path")?,
++    gitlab_discussion_id: row.get("gitlab_discussion_id")?,
+```
+
+4. **Redesign `discussions` query to avoid correlated subquery fanout**
+Analysis: Proposed query uses many correlated subqueries per row. That’s acceptable for tiny MR-scoped sets, but degrades for project-wide scans. Use a base CTE + one rollup pass over notes.
+
+```diff
+@@ 3c. SQL Query
+-SELECT
+-    d.id,
+-    ...
+-    (SELECT COUNT(*) FROM notes n2 WHERE n2.discussion_id = d.id AND n2.is_system = 0) AS note_count,
+-    (SELECT n3.author_username FROM notes n3 WHERE n3.discussion_id = d.id ORDER BY n3.position LIMIT 1) AS first_author,
+-    ...
+-FROM discussions d
++WITH base AS (
++  SELECT d.id, d.gitlab_discussion_id, d.noteable_type, d.project_id, d.issue_id, d.merge_request_id,
++         d.individual_note, d.first_note_at, d.last_note_at, d.resolvable, d.resolved
++  FROM discussions d
++  {where_sql}
++),
++note_rollup AS (
++  SELECT n.discussion_id,
++         COUNT(*) FILTER (WHERE n.is_system = 0) AS user_note_count,
++         COUNT(*) AS total_note_count,
++         MIN(CASE WHEN n.is_system = 0 THEN n.position END) AS first_user_pos
++  FROM notes n
++  JOIN base b ON b.id = n.discussion_id
++  GROUP BY n.discussion_id
++)
++SELECT ...
++FROM base b
++LEFT JOIN note_rollup r ON r.discussion_id = b.id
+```
+
+5. **Add explicit index work for new access patterns**
+Analysis: Existing indexes are good but not ideal for new list patterns (`project + last_note`, note position ordering inside discussion). Add migration entries to keep latency stable.
+
+```diff
+@@ ## 3. Add Standalone `discussions` List Command
++#### 3h. Add migration for discussion-list performance
++**File**: `migrations/027_discussions_list_indexes.sql`
++```sql
++CREATE INDEX IF NOT EXISTS idx_discussions_project_last_note
++  ON discussions(project_id, last_note_at DESC, id DESC);
++CREATE INDEX IF NOT EXISTS idx_discussions_project_first_note
++  ON discussions(project_id, first_note_at DESC, id DESC);
++CREATE INDEX IF NOT EXISTS idx_notes_discussion_position
++  ON notes(discussion_id, position);
++```
+```
+
+6. **Add keyset pagination (critical for agent workflows)**
+Analysis: `--limit` alone is not enough for automation over large datasets. Add cursor-based pagination with deterministic sort keys and `next_cursor` in JSON.
+
+```diff
+@@ 3a. CLI Args
++    /// Keyset cursor from previous response
++    #[arg(long, help_heading = "Output")]
++    pub cursor: Option<String>,
+@@
+@@ Response Schema
+-    "total_count": 15,
+-    "showing": 15
++    "total_count": 15,
++    "showing": 15,
++    "next_cursor": "eyJsYXN0X25vdGVfYXQiOjE3MDAwMDAwMDAwMDAsImlkIjoxMjN9"
+@@
+@@ Validation Criteria
++7. `lore -J discussions ... --cursor <token>` returns the next stable page without duplicates/skips
+```
+
+7. **Fix semantic ambiguities in discussion summary fields**
+Analysis: `note_count` is ambiguous, and `first_author` can accidentally be a system note author. Make fields explicit and consistent with non-system default behavior.
+
+```diff
+@@ Response Schema
+-        "note_count": 3,
+-        "first_author": "elovegrove",
++        "user_note_count": 3,
++        "total_note_count": 4,
++        "first_user_author": "elovegrove",
+@@
+@@ 3d. Filters struct / path behavior
+-- `path` → `EXISTS (SELECT 1 FROM notes n WHERE n.discussion_id = d.id AND n.position_new_path LIKE ?)`
++- `path` → match on BOTH `position_new_path` and `position_old_path` (exact/prefix)
+```
+
+8. **Enrich show outputs with actionable thread metadata**
+Analysis: Adding only discussion id helps, but agents still need thread state and note ids to pick targets correctly. Add `resolvable`, `resolved`, `last_note_at_iso`, and `gitlab_note_id` in show discussion payloads.
+
+```diff
+@@ 2a/2b show discussion structs
+ pub struct DiscussionDetailJson {
+     pub gitlab_discussion_id: String,
++    pub resolvable: bool,
++    pub resolved: bool,
++    pub last_note_at_iso: String,
+     pub notes: Vec<NoteDetailJson>,
+@@
+ pub struct NoteDetailJson {
++    pub gitlab_note_id: i64,
+     pub author_username: String,
+```
+
+9. **Harden robot-docs against schema drift with tests**
+Analysis: Static JSON in `main.rs` will drift again. Add a lightweight contract test that asserts docs include required fields for `notes`, `discussions`, and show payloads.
+
+```diff
+@@ 4. Fix Robot-Docs Response Schemas
++#### 4f. Add robot-docs contract tests
++**File**: `src/main.rs` (or dedicated test module)
++- Assert `robot-docs` contains `gitlab_discussion_id` and `gitlab_note_id` in:
++  - `notes.response_schema`
++  - `issues.response_schema.show`
++  - `mrs.response_schema.show`
++  - `discussions.response_schema`
+```
+
+10. **Adjust delivery order to reduce rework and include missing CSV path**
+Analysis: In your sample `handle_discussions`, `csv` is declared in args but not handled. Also, robot-docs should land after all payload changes. Sequence should minimize churn.
+
+```diff
+@@ Delivery Order
+-3. **Change 4** (robot-docs) — depends on 1 and 2 being done so schemas are accurate.
+-4. **Change 3** (discussions command) — largest change, depends on 1 for design consistency.
++3. **Change 3** (discussions command + indexes + pagination) — largest change.
++4. **Change 4** (robot-docs + contract tests) — last, after payloads are final.
+@@ 3e. Handler wiring
+-    match format {
++    match format {
+         "json" => ...
+         "jsonl" => ...
++        "csv" => print_list_discussions_csv(&result),
+         _ => ...
+     }
+```
+
+If you want, I can produce a single consolidated revised plan markdown with these edits applied so you can drop it in directly.

docs/plan-expose-discussion-ids.feedback-2.md

@@ -0,0 +1,162 @@
+Best non-rejected upgrades I’d make to this plan are below. They focus on reducing schema drift, making robot output safer to consume, and improving performance behavior at scale.
+
+1. Add a shared contract model and field constants first (before workstreams 1-4)  
+Rationale: Right now each command has its own structs and ad-hoc mapping. That is exactly how drift happens. A single contract definition reused by `notes`, `show`, `discussions`, and robot-docs gives compile-time coupling between output payloads and docs. It also makes future fields cheaper and safer to add.
+
+```diff
+@@ Scope: Four workstreams, delivered in order:
+-1. Add `gitlab_discussion_id` to notes output
+-2. Add `gitlab_discussion_id` to show command discussion groups
+-3. Add a standalone `discussions` list command
+-4. Fix robot-docs to list actual field names instead of opaque type references
++0. Introduce shared Bridge Contract model/constants used by notes/show/discussions/robot-docs
++1. Add `gitlab_discussion_id` to notes output
++2. Add `gitlab_discussion_id` to show command discussion groups
++3. Add a standalone `discussions` list command
++4. Fix robot-docs to list actual field names instead of opaque type references
+
++## 0. Shared Contract Model (Cross-Cutting)
++Define canonical required-field constants and shared mapping helpers, then consume them in:
++- `src/cli/commands/list.rs`
++- `src/cli/commands/show.rs`
++- `src/cli/robot.rs`
++- `src/main.rs` robot-docs builder
++This removes duplicated field-name strings and prevents docs/output mismatch.
+```
+
+2. Make bridge fields “non-droppable” in robot mode  
+Rationale: The current plan adds fields, but `--fields` can still remove them. That breaks the core read/write bridge contract in exactly the workflows this change is trying to fix. In robot mode, contract fields should always be force-included.
+
+```diff
+@@ ## Bridge Contract (Cross-Cutting)
+ Every read payload that surfaces notes or discussions **MUST** include:
+ - `project_path`
+ - `noteable_type`
+ - `parent_iid`
+ - `gitlab_discussion_id`
+ - `gitlab_note_id` (when note-level data is returned — i.e., in notes list and show detail)
+
++### Field Filtering Guardrail
++In robot mode, `filter_fields` must force-include Bridge Contract fields even when users pass a narrower `--fields` list.
++Human/table mode keeps existing behavior.
+```
+
+3. Replace correlated subqueries in `discussions` rollup with a single-pass window/aggregate pattern  
+Rationale: Your CTE is better than naive fanout, but it still uses multiple correlated sub-selects per discussion for first author/body/path. At 200K+ discussions this can regress badly depending on cache/index state. A window-ranked `notes` CTE with grouped aggregates is usually faster and more predictable in SQLite.
+
+```diff
+@@ #### 3c. SQL Query
+-Core query uses a CTE + rollup to avoid correlated subquery fanout on larger result sets:
++Core query uses a CTE + ranked-notes rollup (window function) to avoid per-row correlated subqueries:
+
+-WITH filtered_discussions AS (...),
+-note_rollup AS (
+-    SELECT
+-        n.discussion_id,
+-        SUM(...) AS note_count,
+-        (SELECT ... LIMIT 1) AS first_author,
+-        (SELECT ... LIMIT 1) AS first_note_body,
+-        (SELECT ... LIMIT 1) AS position_new_path,
+-        (SELECT ... LIMIT 1) AS position_new_line
+-    FROM notes n
+-    ...
+-)
++WITH filtered_discussions AS (...),
++ranked_notes AS (
++    SELECT
++        n.*,
++        ROW_NUMBER() OVER (PARTITION BY n.discussion_id ORDER BY n.position, n.id) AS rn
++    FROM notes n
++    WHERE n.discussion_id IN (SELECT id FROM filtered_discussions)
++),
++note_rollup AS (
++    SELECT
++        discussion_id,
++        SUM(CASE WHEN is_system = 0 THEN 1 ELSE 0 END) AS note_count,
++        MAX(CASE WHEN rn = 1 AND is_system = 0 THEN author_username END) AS first_author,
++        MAX(CASE WHEN rn = 1 AND is_system = 0 THEN body END) AS first_note_body,
++        MAX(CASE WHEN position_new_path IS NOT NULL THEN position_new_path END) AS position_new_path,
++        MAX(CASE WHEN position_new_line IS NOT NULL THEN position_new_line END) AS position_new_line
++    FROM ranked_notes
++    GROUP BY discussion_id
++)
+```
+
+4. Add direct GitLab ID filters for deterministic bridging  
+Rationale: Bridge workflows often start from one known ID. You already have `gitlab_note_id` in notes filters, but discussion filtering still looks internal-ID-centric. Add explicit GitLab-ID filters so agents do not need extra translation calls.
+
+```diff
+@@ #### 3a. CLI Args
+ pub struct DiscussionsArgs {
++    /// Filter by GitLab discussion ID
++    #[arg(long, help_heading = "Filters")]
++    pub gitlab_discussion_id: Option<String>,
+@@
+
+@@ #### 3d. Filters struct
+ pub struct DiscussionListFilters {
++    pub gitlab_discussion_id: Option<String>,
+@@
+ }
+```
+
+```diff
+@@ ## 1. Add `gitlab_discussion_id` to Notes Output
++#### 1g. Add `--gitlab-discussion-id` filter to notes
++Allow filtering notes directly by GitLab thread ID (not only internal discussion ID).
++This enables one-hop note retrieval from external references.
+```
+
+5. Add optional note expansion to `discussions` for fewer round-trips  
+Rationale: Today the agent flow is often `discussions -> show`. Optional embedded notes (`--include-notes N`) gives a fast path for “list unresolved threads with latest context” without forcing full show payloads.
+
+```diff
+@@ ### Design
+ lore -J discussions --for-mr 99 --resolution unresolved
++lore -J discussions --for-mr 99 --resolution unresolved --include-notes 2
+
+@@ #### 3a. CLI Args
++    /// Include up to N latest notes per discussion (0 = none)
++    #[arg(long, default_value = "0", help_heading = "Output")]
++    pub include_notes: usize,
+```
+
+6. Upgrade robot-docs from string blobs to structured schema + explicit contract block  
+Rationale: `contains("gitlab_discussion_id")` tests on schema strings are brittle. A structured schema object gives machine-checked docs and reliable test assertions. Add a contract section for agent consumers.
+
+```diff
+@@ ## 4. Fix Robot-Docs Response Schemas
+-#### 4a. Notes response_schema
+-Replace stringly-typed schema snippets...
++#### 4a. Notes response_schema (structured)
++Represent response fields as JSON objects (field -> type/nullable), not freeform strings.
+
++#### 4g. Add `bridge_contract` section in robot-docs
++Publish canonical required fields per entity:
++- notes
++- discussions
++- show.discussions
++- show.notes
+```
+
+7. Strengthen validation: add CLI-level contract tests and perf guardrails  
+Rationale: Most current tests are unit-level struct/query checks. Add end-to-end JSON contract tests via command handlers, plus a benchmark-style regression test (ignored by default) so performance work stays intentional.
+
+```diff
+@@ ## Validation Criteria
+ 8. Bridge Contract fields (...) are present in every applicable read payload
++9. Contract fields remain present even with `--fields` in robot mode
++10. `discussions` query meets performance guardrail on representative fixture (documented threshold)
+
+@@ ### Tests
++#### Test: robot-mode fields cannot drop bridge contract keys
++Run notes/discussions JSON output through `filter_fields` path and assert required keys remain.
++
++#### Test: CLI contract integration
++Invoke command handlers for `notes`, `discussions`, `mrs <iid>`, parse JSON, assert required keys and types.
++
++#### Test (ignored): large-fixture performance regression
++Generate representative fixture and assert `query_discussions` stays under target elapsed time.
+```
+
+If you want, I can now produce a full “v2 plan” document that applies these diffs end-to-end (including revised delivery order and complete updated sections).

docs/plan-expose-discussion-ids.feedback-3.md

@@ -0,0 +1,147 @@
+1. **Make `gitlab_note_id` explicit in all note-level payloads without breaking existing consumers**
+Rationale: Your Bridge Contract already requires `gitlab_note_id`, but current plan keeps `gitlab_id` only in `notes` list while adding `gitlab_note_id` only in detail views. That forces agents to special-case commands. Add `gitlab_note_id` as an alias field everywhere note-level data appears, while keeping `gitlab_id` for compatibility.
+
+```diff
+@@ Bridge Contract (Cross-Cutting)
+-Every read payload that surfaces notes or discussions MUST include:
++Every read payload that surfaces notes or discussions MUST include:
+   - project_path
+   - noteable_type
+   - parent_iid
+   - gitlab_discussion_id
+   - gitlab_note_id (when note-level data is returned — i.e., in notes list and show detail)
++  - Back-compat rule: note payloads may continue exposing `gitlab_id`, but MUST also expose `gitlab_note_id` with the same value.
+
+@@ 1. Add `gitlab_discussion_id` to Notes Output
+-#### 1c. Add field to `NoteListRowJson`
++#### 1c. Add fields to `NoteListRowJson`
++Add `gitlab_note_id` alias in addition to existing `gitlab_id` (no rename, no breakage).
+
+@@ 1f. Update `--fields minimal` preset
+-"notes" => ["id", "author_username", "body", "created_at_iso", "gitlab_discussion_id"]
++"notes" => ["id", "gitlab_note_id", "author_username", "body", "created_at_iso", "gitlab_discussion_id"]
+```
+
+2. **Avoid duplicate flag semantics for discussion filtering**
+Rationale: `notes` already has `--discussion-id` and it already maps to `d.gitlab_discussion_id`. Adding a second independent flag/field (`--gitlab-discussion-id`) increases complexity and precedence bugs. Keep one backing filter field and make the new flag an alias.
+
+```diff
+@@ 1g. Add `--gitlab-discussion-id` filter to notes
+-Allow filtering notes directly by GitLab discussion thread ID...
++Normalize discussion ID flags:
++- Keep one backing filter field (`discussion_id`)
++- Support both `--discussion-id` (existing) and `--gitlab-discussion-id` (alias)
++- If both are provided, clap should reject as duplicate/alias conflict
+```
+
+3. **Add ambiguity guardrails for cross-project discussion IDs**
+Rationale: `gitlab_discussion_id` is unique per project, not globally. Filtering by discussion ID without project can return multiple rows across repos, which breaks deterministic write bridging. Fail fast with an `Ambiguous` error and actionable fix (`--project`).
+
+```diff
+@@ Bridge Contract (Cross-Cutting)
++### Ambiguity Guardrail
++When filtering by `gitlab_discussion_id` without `--project`, if multiple projects match:
++- return `Ambiguous` error
++- include matching project paths in message
++- suggest retry with `--project <path>`
+```
+
+4. **Replace `--include-notes` N+1 retrieval with one batched top-N query**
+Rationale: The current plan’s per-discussion follow-up query scales poorly and creates latency spikes. Use a single window-function query over selected discussion IDs and group rows in Rust. This is both faster and more predictable.
+
+```diff
+@@ 3c-ii. Note expansion query (--include-notes)
+-When `include_notes > 0`, after the main discussion query, run a follow-up query per discussion...
++When `include_notes > 0`, run one batched query:
++WITH ranked_notes AS (
++  SELECT
++    n.*,
++    d.gitlab_discussion_id,
++    ROW_NUMBER() OVER (
++      PARTITION BY n.discussion_id
++      ORDER BY n.created_at DESC, n.id DESC
++    ) AS rn
++  FROM notes n
++  JOIN discussions d ON d.id = n.discussion_id
++  WHERE n.discussion_id IN ( ...selected discussion ids... )
++)
++SELECT ... FROM ranked_notes WHERE rn <= ?
++ORDER BY discussion_id, rn;
++
++Group by `discussion_id` in Rust and attach notes arrays without per-thread round-trips.
+```
+
+5. **Add hard output guardrails and explicit truncation metadata**
+Rationale: `--limit` and `--include-notes` are unbounded today. For robot workflows this can accidentally generate huge payloads. Cap values and surface effective limits plus truncation state in `meta`.
+
+```diff
+@@ 3a. CLI Args
+-    pub limit: usize,
++    pub limit: usize, // clamp to max (e.g., 500)
+
+-    pub include_notes: usize,
++    pub include_notes: usize, // clamp to max (e.g., 20)
+
+@@ Response Schema
+-  "meta": { "elapsed_ms": 12 }
++  "meta": {
++    "elapsed_ms": 12,
++    "effective_limit": 50,
++    "effective_include_notes": 2,
++    "has_more": true
++  }
+```
+
+6. **Strengthen deterministic ordering and null handling**
+Rationale: `first_note_at`, `last_note_at`, and note `position` can be null/incomplete during partial sync states. Add null-safe ordering to avoid unstable output and flaky automation.
+
+```diff
+@@ 2c. Update queries to SELECT new fields
+-... ORDER BY first_note_at
++... ORDER BY COALESCE(first_note_at, last_note_at, 0), id
+
+@@ show note query
+-ORDER BY position
++ORDER BY COALESCE(position, 9223372036854775807), created_at, id
+
+@@ 3c. SQL Query
+-ORDER BY {sort_column} {order}
++ORDER BY COALESCE({sort_column}, 0) {order}, fd.id {order}
+```
+
+7. **Make write-bridging more useful with optional command hints**
+Rationale: Exposing IDs is necessary but not sufficient; agents still need to assemble endpoints repeatedly. Add optional `--with-write-hints` that injects compact endpoint templates (`reply`, `resolve`) derived from row context. This improves usability without bloating default output.
+
+```diff
+@@ 3a. CLI Args
++    /// Include machine-actionable glab write hints per row
++    #[arg(long, help_heading = "Output")]
++    pub with_write_hints: bool,
+
+@@ Response Schema (notes/discussions/show)
++    "write_hints?": {
++      "reply_endpoint": "string",
++      "resolve_endpoint?": "string"
++    }
+```
+
+8. **Upgrade robot-docs/contract validation from string-contains to parity checks**
+Rationale: `contains("gitlab_discussion_id")` catches very little and allows schema drift. Build field-set parity tests that compare actual serialized JSON keys to robot-docs declared fields for `notes`, `discussions`, and `show` discussion nodes.
+
+```diff
+@@ 4f. Add robot-docs contract tests
+-assert!(notes_schema.contains("gitlab_discussion_id"));
++let declared = parse_schema_field_list(notes_schema);
++let sample = sample_notes_row_json_keys();
++assert_required_subset(&declared, &["project_path","noteable_type","parent_iid","gitlab_discussion_id","gitlab_note_id"]);
++assert_schema_matches_payload(&declared, &sample);
+
+@@ 4g. Add CLI-level contract integration tests
++Add parity tests for:
++- notes list JSON
++- discussions list JSON
++- issues show discussions[*]
++- mrs show discussions[*]
+```
+
+If you want, I can produce a full revised v3 plan text with these edits merged end-to-end so it’s ready to execute directly.

docs/plan-expose-discussion-ids.feedback-4.md

@@ -0,0 +1,207 @@
+Below are the highest-impact revisions I’d make to this plan. I excluded everything listed in your `## Rejected Recommendations` section.
+
+**1. Fix a correctness bug in the ambiguity guardrail (must run before `LIMIT`)**
+
+The current post-query ambiguity check can silently fail when `--limit` truncates results to one project even though multiple projects match the same `gitlab_discussion_id`. That creates non-deterministic write targeting risk.
+
+```diff
+@@ ## Ambiguity Guardrail
+-**Implementation**: After the main query, if `gitlab_discussion_id` is set and no `--project`
+-was provided, check if the result set spans multiple `project_path` values.
++**Implementation**: Run a preflight distinct-project check when `gitlab_discussion_id` is set
++and `--project` was not provided, before the main list query applies `LIMIT`.
++Use:
++```sql
++SELECT DISTINCT p.path_with_namespace
++FROM discussions d
++JOIN projects p ON p.id = d.project_id
++WHERE d.gitlab_discussion_id = ?
++LIMIT 3
++```
++If more than one project is found, return `LoreError::Ambiguous` (exit code 18) with project
++paths and suggestion to retry with `--project <path>`.
+```
+
+---
+
+**2. Add `gitlab_project_id` to the Bridge Contract**
+
+`project_path` is human-friendly but mutable (renames/transfers). `gitlab_project_id` gives a stable write target and avoids path re-resolution failures.
+
+```diff
+@@ ## Bridge Contract (Cross-Cutting)
+ Every read payload that surfaces notes or discussions **MUST** include:
+ - `project_path`
++- `gitlab_project_id`
+ - `noteable_type`
+ - `parent_iid`
+ - `gitlab_discussion_id`
+ - `gitlab_note_id`
+@@
+ const BRIDGE_FIELDS_NOTES: &[&str] = &[
+-    "project_path", "noteable_type", "parent_iid",
++    "project_path", "gitlab_project_id", "noteable_type", "parent_iid",
+     "gitlab_discussion_id", "gitlab_note_id",
+ ];
+ const BRIDGE_FIELDS_DISCUSSIONS: &[&str] = &[
+-    "project_path", "noteable_type", "parent_iid",
++    "project_path", "gitlab_project_id", "noteable_type", "parent_iid",
+     "gitlab_discussion_id",
+ ];
+```
+
+---
+
+**3. Replace stringly-typed filter/sort fields with enums end-to-end**
+
+Right now `sort`, `order`, `resolution`, `noteable_type` are mostly `String`. This is fragile and risks unsafe SQL interpolation drift over time. Typed enums make invalid states unrepresentable.
+
+```diff
+@@ ## 3a. CLI Args
+-    pub resolution: Option<String>,
++    pub resolution: Option<ResolutionFilter>,
+@@
+-    pub noteable_type: Option<String>,
++    pub noteable_type: Option<NoteableTypeFilter>,
+@@
+-    pub sort: String,
++    pub sort: DiscussionSortField,
+@@
+-    pub asc: bool,
++    pub order: SortDirection,
+@@ ## 3d. Filters struct
+-    pub resolution: Option<String>,
+-    pub noteable_type: Option<String>,
+-    pub sort: String,
+-    pub order: String,
++    pub resolution: Option<ResolutionFilter>,
++    pub noteable_type: Option<NoteableTypeFilter>,
++    pub sort: DiscussionSortField,
++    pub order: SortDirection,
+@@
++Map enum -> SQL fragment via `match` in query builder; never interpolate raw strings.
+```
+
+---
+
+**4. Enforce snapshot consistency for multi-query commands**
+
+`discussions` with `--include-notes` does multiple reads. Without a single read transaction, concurrent ingest can produce mismatched `total_count`, row set, and expanded notes.
+
+```diff
+@@ ## 3c. SQL Query
+-pub fn query_discussions(...)
++pub fn query_discussions(...)
+ {
++    // Run count query + page query + note expansion under one deferred read transaction
++    // so output is a single consistent snapshot.
++    let tx = conn.transaction_with_behavior(rusqlite::TransactionBehavior::Deferred)?;
+     ...
++    tx.commit()?;
+ }
+@@ ## 1. Add `gitlab_discussion_id` to Notes Output
++Apply the same snapshot rule to `query_notes` when returning `total_count` + paged rows.
+```
+
+---
+
+**5. Correct first-note rollup semantics (current CTE can return null/incorrect `first_author`)**
+
+In the proposed SQL, `rn=1` is computed over all notes but then filtered with `is_system=0`, so threads with a leading system note may incorrectly lose `first_author`/snippet. Also path rollup uses non-deterministic `MAX(...)`.
+
+```diff
+@@ ## 3c. SQL Query
+-ranked_notes AS (
++ranked_notes AS (
+     SELECT
+         n.discussion_id,
+         n.author_username,
+         n.body,
+         n.is_system,
+         n.position_new_path,
+         n.position_new_line,
+-        ROW_NUMBER() OVER (
+-            PARTITION BY n.discussion_id
+-            ORDER BY n.position, n.id
+-        ) AS rn
++        ROW_NUMBER() OVER (
++            PARTITION BY n.discussion_id
++            ORDER BY CASE WHEN n.is_system = 0 THEN 0 ELSE 1 END, n.created_at, n.id
++        ) AS rn_first_note,
++        ROW_NUMBER() OVER (
++            PARTITION BY n.discussion_id
++            ORDER BY CASE WHEN n.position_new_path IS NULL THEN 1 ELSE 0 END, n.created_at, n.id
++        ) AS rn_first_position
+@@
+-        MAX(CASE WHEN rn = 1 AND is_system = 0 THEN author_username END) AS first_author,
+-        MAX(CASE WHEN rn = 1 AND is_system = 0 THEN body END) AS first_note_body,
+-        MAX(CASE WHEN position_new_path IS NOT NULL THEN position_new_path END) AS position_new_path,
+-        MAX(CASE WHEN position_new_line IS NOT NULL THEN position_new_line END) AS position_new_line
++        MAX(CASE WHEN rn_first_note = 1 AND is_system = 0 THEN author_username END) AS first_author,
++        MAX(CASE WHEN rn_first_note = 1 AND is_system = 0 THEN body END) AS first_note_body,
++        MAX(CASE WHEN rn_first_position = 1 THEN position_new_path END) AS position_new_path,
++        MAX(CASE WHEN rn_first_position = 1 THEN position_new_line END) AS position_new_line
+```
+
+---
+
+**6. Add per-discussion truncation signals for `--include-notes`**
+
+Top-level `has_more` is useful, but agents also need to know if an individual thread’s notes were truncated. Otherwise they can’t tell if a thread is complete.
+
+```diff
+@@ ## Response Schema
+       {
+         "gitlab_discussion_id": "...",
+         ...
+-        "notes": []
++        "included_note_count": 0,
++        "has_more_notes": false,
++        "notes": []
+       }
+@@ ## 3b. Domain Structs
+ pub struct DiscussionListRowJson {
+@@
++    pub included_note_count: usize,
++    pub has_more_notes: bool,
+     #[serde(skip_serializing_if = "Vec::is_empty")]
+     pub notes: Vec<NoteListRowJson>,
+ }
+@@ ## 3c-ii. Note expansion query (--include-notes)
+-Group by `discussion_id` in Rust and attach notes arrays...
++Group by `discussion_id` in Rust, attach notes arrays, and set:
++`included_note_count = notes.len()`,
++`has_more_notes = note_count > included_note_count`.
+```
+
+---
+
+**7. Add explicit query-plan gate and targeted index workstream (measured, not speculative)**
+
+This plan introduces heavy discussion-centric reads. You should bake in deterministic performance validation with `EXPLAIN QUERY PLAN` and only then add indexes if missing.
+
+```diff
+@@ ## Scope: Four workstreams, delivered in order:
+-4. Fix robot-docs to list actual field names instead of opaque type references
++4. Add query-plan validation + targeted index updates for new discussion queries
++5. Fix robot-docs to list actual field names instead of opaque type references
+@@
++## 4. Query-Plan Validation and Targeted Indexes
++
++Before and after implementing `query_discussions`, capture `EXPLAIN QUERY PLAN` for:
++- `--for-mr <iid> --resolution unresolved`
++- `--project <path> --since 7d --sort last_note`
++- `--gitlab-discussion-id <id>`
++
++If plans show table scans on `notes`/`discussions`, add indexes in `MIGRATIONS` array:
++- `discussions(project_id, gitlab_discussion_id)`
++- `discussions(merge_request_id, last_note_at, id)`
++- `notes(discussion_id, created_at DESC, id DESC)`
++- `notes(discussion_id, position, id)`
++
++Tests: assert the new query paths return expected rows under indexed schema and no regressions.
+```
+
+---
+
+If you want, I can produce a single consolidated “iteration 4” version of the plan text with all seven revisions merged in place.

docs/plan-expose-discussion-ids.feedback-4.md.bak

@@ -0,0 +1,160 @@
+I reviewed the plan end-to-end and focused only on new improvements (none of the items in `## Rejected Recommendations` are re-proposed).
+
+1. Add direct `--discussion-id` retrieval paths
+Rationale: This removes a full discovery hop for the exact workflow that failed (replying to a known thread). It also reduces ambiguity and query cost when an agent already has the thread ID.
+
+```diff
+@@ Core Changes
+ | 7 | Fix robot-docs to list actual field names | Docs | Small |
++| 8 | Add direct `--discussion-id` filter to notes/discussions/show | Core | Small |
+
+@@ Change 3: Add Standalone `discussions` List Command
+ lore -J discussions --for-mr 99 --cursor <token>       # keyset pagination
++lore -J discussions --discussion-id 6a9c1750b37d...    # direct lookup
+
+@@ 3a. CLI Args
++    #[arg(long, conflicts_with_all = ["for_issue", "for_mr"], help_heading = "Filters")]
++    pub discussion_id: Option<String>,
+
+@@ Change 1: Add `gitlab_discussion_id` to Notes Output
++Add `--discussion-id <hex>` filter to `notes` for direct note retrieval within one thread.
+```
+
+2. Add a shared filter compiler to eliminate count/query drift
+Rationale: The plan currently repeats filters across data query, `total_count`, and `incomplete_rows` count queries. That is a classic reliability bug source. A single compiled filter object makes count semantics provably consistent.
+
+```diff
+@@ Count Semantics (Cross-Cutting Convention)
++## Filter Compiler (NEW, Cross-Cutting Convention)
++All list commands must build predicates via a shared `CompiledFilters` object that emits:
++- SQL predicate fragment
++- bind parameters
++- canonical filter string (for cursor hash)
++The same compiled object is reused by:
++- page data query
++- `total_count` query
++- `incomplete_rows` query
+```
+
+3. Harden keyset pagination semantics for `DESC`, limits, and client ergonomics
+Rationale: `(sort_value, id) > (?, ?)` is only correct for ascending order. Descending sort needs `<`. Also add explicit `has_more` so clients don’t infer from cursor nullability.
+
+```diff
+@@ Keyset Pagination (Cross-Cutting, Change B)
+-```sql
+-WHERE (sort_value, id) > (?, ?)
+-```
++Use comparator by order:
++- ASC: `(sort_value, id) > (?, ?)`
++- DESC: `(sort_value, id) < (?, ?)`
+
+@@ 3a. CLI Args
++    #[arg(short = 'n', long = "limit", default_value = "50", value_parser = clap::value_parser!(usize).range(1..=500), help_heading = "Output")]
++    pub limit: usize,
+
+@@ Response Schema
+-    "next_cursor": "aW...xyz=="
++    "next_cursor": "aW...xyz==",
++    "has_more": true
+```
+
+4. Add DB-level entity integrity invariants (not just response invariants)
+Rationale: Response-side filtering is good, but DB correctness should also be guarded. This prevents silent corruption and bad joins from ingestion or future migrations.
+
+```diff
+@@ Contract Invariants (NEW)
++### Entity Integrity Invariants (DB + Ingest)
++1. `discussions` must belong to exactly one parent (`issue_id XOR merge_request_id`).
++2. `discussions.noteable_type` must match the populated parent column.
++3. Natural-key uniqueness is enforced where valid:
++   - `(project_id, gitlab_discussion_id)` unique for discussions.
++4. Ingestion must reject/quarantine rows violating invariants and report counts.
+
+@@ Supporting Indexes (Cross-Cutting, Change D)
++CREATE UNIQUE INDEX IF NOT EXISTS idx_discussions_project_gitlab_discussion_id
++    ON discussions(project_id, gitlab_discussion_id);
+```
+
+5. Switch bulk note loading to streaming grouping (avoid large intermediate vecs)
+Rationale: Current bulk strategy still materializes all notes before grouping. Streaming into the map cuts peak memory and improves large-MR stability.
+
+```diff
+@@ Change 2e. Constructor — use bulk notes map
+-let all_note_rows: Vec<MrNoteDetail> = ...  // From bulk query above
+-let notes_by_discussion: HashMap<i64, Vec<MrNoteDetail>> = 
+-    all_note_rows.into_iter().fold(HashMap::new(), |mut map, note| {
+-        map.entry(note.discussion_id).or_insert_with(Vec::new).push(note);
+-        map
+-    });
++let mut notes_by_discussion: HashMap<i64, Vec<MrNoteDetail>> = HashMap::new();
++for row in bulk_note_stmt.query_map(params, map_note_row)? {
++    let note = row?;
++    notes_by_discussion.entry(note.discussion_id).or_default().push(note);
++}
+```
+
+6. Make freshness tri-state (`fresh|stale|unknown`) and fail closed on unknown with `--require-fresh`
+Rationale: `stale: bool` alone cannot represent “never synced / unknown project freshness.” For write safety, unknown freshness should be explicit and reject under freshness constraints.
+
+```diff
+@@ Freshness Metadata & Staleness Guards
+ pub struct ResponseMeta {
+     pub elapsed_ms: i64,
+     pub data_as_of_iso: String,
+     pub sync_lag_seconds: i64,
+     pub stale: bool,
++    pub freshness_state: String, // "fresh" | "stale" | "unknown"
++    #[serde(skip_serializing_if = "Option::is_none")]
++    pub freshness_reason: Option<String>,
+     pub incomplete_rows: i64,
+@@
+-if sync_lag_seconds > max_age_secs {
++if freshness_state == "unknown" || sync_lag_seconds > max_age_secs {
+```
+
+7. Tune indexes to match actual ORDER BY paths in window queries
+Rationale: `idx_notes_discussion_position` is likely insufficient for the two window orderings. A covering-style index aligned with partition/order keys reduces random table lookups.
+
+```diff
+@@ Supporting Indexes (Cross-Cutting, Change D)
+--- Notes: window function ORDER BY (discussion_id, position) for ROW_NUMBER()
+-CREATE INDEX IF NOT EXISTS idx_notes_discussion_position
+-    ON notes(discussion_id, position);
++-- Notes: support dual ROW_NUMBER() orderings and reduce table lookups
++CREATE INDEX IF NOT EXISTS idx_notes_discussion_window
++    ON notes(discussion_id, is_system, position, created_at, gitlab_id);
+```
+
+8. Add a phased rollout gate before strict exclusion becomes default
+Rationale: Enforcing `gitlab_* IS NOT NULL` immediately can hide data if existing rows are incomplete. A short observation gate prevents sudden regressions while preserving the end-state contract.
+
+```diff
+@@ Delivery Order
++Batch 0: Observability gate (NEW)
++- Ship `incomplete_rows` and freshness meta first
++- Measure incomplete rate across real datasets
++- If incomplete ratio <= threshold, enable strict exclusion defaults
++- If above threshold, block rollout and fix ingestion quality first
++
+ Change 1 (notes output)       ──┐
+```
+
+9. Add property-based invariants for pagination/count correctness
+Rationale: Your current tests are scenario-based and good, but randomized property tests are much better at catching edge-case cursor/count bugs.
+
+```diff
+@@ Tests (Change 3 / Change B)
++**Test 12**: Property-based pagination invariants (`proptest`)
++```rust
++#[test]
++fn prop_discussion_cursor_no_overlap_no_gap_under_random_data() { /* ... */ }
++```
++
++**Test 13**: Property-based count invariants
++```rust
++#[test]
++fn prop_total_count_and_incomplete_rows_match_filter_partition() { /* ... */ }
++```
+```
+
+If you want, I can now produce a fully consolidated “Plan v4” that applies these diffs cleanly into your original document so it reads as a single coherent spec.

docs/plan-expose-discussion-ids.feedback-5.md

@@ -0,0 +1,140 @@
+Your iteration 4 plan is already strong. The highest-impact revisions are around query shape, transaction boundaries, and contract stability for agents.
+
+1. **Switch discussions query to a two-phase page-first architecture**
+Analysis: Current `ranked_notes` runs over every filtered discussion before `LIMIT`, which can explode on project-wide queries. A page-first plan keeps complexity proportional to `limit`, improves tail latency, and reduces memory churn.
+```diff
+@@ ## 3c. SQL Query
+-Core query uses a CTE + ranked-notes rollup (window function) to avoid per-row correlated
+-subqueries.
++Core query is split into two phases for scalability:
++1) `paged_discussions` applies filters/sort/LIMIT and returns only page IDs.
++2) Note rollups and optional `--include-notes` expansion run only for those page IDs.
++This bounds note scanning to visible results and stabilizes latency on large projects.
+ 
+-WITH filtered_discussions AS (
++WITH filtered_discussions AS (
+   ...
+ ),
+-ranked_notes AS (
++paged_discussions AS (
++    SELECT id
++    FROM filtered_discussions
++    ORDER BY COALESCE({sort_column}, 0) {order}, id {order}
++    LIMIT ?
++),
++ranked_notes AS (
+   ...
+-    WHERE n.discussion_id IN (SELECT id FROM filtered_discussions)
++    WHERE n.discussion_id IN (SELECT id FROM paged_discussions)
+ )
+```
+
+2. **Move snapshot transaction ownership to handlers (not query helpers)**
+Analysis: This avoids nested transaction edge cases, keeps function signatures clean, and guarantees one snapshot across count + page + include-notes + serialization metadata.
+```diff
+@@ ## Cross-cutting: snapshot consistency
+-Wrap `query_notes` and `query_discussions` in a deferred read transaction.
++Open one deferred read transaction in each handler (`handle_notes`, `handle_discussions`)
++and pass `&Transaction` into query helpers. Query helpers do not open/commit transactions.
++This guarantees a single snapshot across all subqueries and avoids nested tx pitfalls.
+ 
+-pub fn query_discussions(conn: &Connection, ...)
++pub fn query_discussions(tx: &rusqlite::Transaction<'_>, ...)
+```
+
+3. **Add immutable input filter `--project-id` across notes/discussions/show**
+Analysis: You already expose `gitlab_project_id` because paths are mutable; input should support the same immutable selector. This removes failure modes after project renames/transfers.
+```diff
+@@ ## 3a. CLI Args
++    /// Filter by immutable GitLab project ID
++    #[arg(long, help_heading = "Filters", conflicts_with = "project")]
++    pub project_id: Option<i64>,
+@@ ## Bridge Contract
++Input symmetry rule: commands that accept `--project` should also accept `--project-id`.
++If both are present, return usage error (exit code 2).
+```
+
+4. **Enforce bridge fields for nested notes in `discussions --include-notes`**
+Analysis: Current guardrail is entity-level; nested notes can still lose required IDs under aggressive filtering. This is a contract hole for write-bridging.
+```diff
+@@ ### Field Filtering Guardrail
+-In robot mode, `filter_fields` MUST force-include Bridge Contract fields...
++In robot mode, `filter_fields` MUST force-include Bridge Contract fields at all returned levels:
++- discussion row fields
++- nested note fields when `discussions --include-notes` is used
+ 
++const BRIDGE_FIELDS_DISCUSSION_NOTES: &[&str] = &[
++    "project_path", "gitlab_project_id", "noteable_type", "parent_iid",
++    "gitlab_discussion_id", "gitlab_note_id",
++];
+```
+
+5. **Make ambiguity preflight scope-aware and machine-actionable**
+Analysis: Current preflight checks only `gitlab_discussion_id`, which can produce false ambiguity when additional filters already narrow to one project. Also, agents need structured candidates, not only free-text.
+```diff
+@@ ### Ambiguity Guardrail
+-SELECT DISTINCT p.path_with_namespace
++SELECT DISTINCT p.path_with_namespace, p.gitlab_project_id
+ FROM discussions d
+ JOIN projects p ON p.id = d.project_id
+-WHERE d.gitlab_discussion_id = ?
++WHERE d.gitlab_discussion_id = ?
++  /* plus active scope filters: noteable_type, for_issue/for_mr, since/path when present */
+ LIMIT 3
+ 
+-Return LoreError::Ambiguous with message
++Return LoreError::Ambiguous with structured details:
++`{ code, message, candidates:[{project_path, gitlab_project_id}], suggestion }`
+```
+
+6. **Add `--contains` filter to `discussions`**
+Analysis: This is a high-utility agent workflow gap. Agents frequently need “find thread by text then reply”; forcing a separate `notes` search round-trip is unnecessary.
+```diff
+@@ ## 3a. CLI Args
++    /// Filter discussions whose notes contain text
++    #[arg(long, help_heading = "Filters")]
++    pub contains: Option<String>,
+@@ ## 3d. Filters struct
++    pub contains: Option<String>,
+@@ ## 3d. Where-clause construction
++- `path` -> EXISTS (...)
++- `path` -> EXISTS (...)
++- `contains` -> EXISTS (
++    SELECT 1 FROM notes n
++    WHERE n.discussion_id = d.id
++      AND n.body LIKE ?
++  )
+```
+
+7. **Promote two baseline indexes from “candidate” to “required”**
+Analysis: These are directly hit by new primary paths; waiting for post-merge profiling risks immediate perf cliffs in real usage.
+```diff
+@@ ## 3h. Query-plan validation
+-Candidate indexes (add only if EXPLAIN QUERY PLAN shows they're needed):
+-- discussions(project_id, gitlab_discussion_id)
+-- notes(discussion_id, created_at DESC, id DESC)
++Required baseline indexes for this feature:
++- discussions(project_id, gitlab_discussion_id)
++- notes(discussion_id, created_at DESC, id DESC)
++Keep other indexes conditional on EXPLAIN QUERY PLAN.
+```
+
+8. **Add schema versioning and remove contradictory rejected items**
+Analysis: `robot-docs` contract drift is a long-term agent risk; explicit schema versions let clients fail safely. Also, rejected items currently contradict active sections, which creates implementation ambiguity.
+```diff
+@@ ## 4. Fix Robot-Docs Response Schemas
+ "meta": {"elapsed_ms": "int", ...}
++"meta": {"elapsed_ms":"int", ..., "schema_version":"string"}
++
++Schema version policy:
++- bump minor on additive fields
++- bump major on removals/renames
++- expose per-command versions in `robot-docs`
+@@ ## Rejected Recommendations
+-- Add `gitlab_note_id` to show-command note detail structs ... rejected ...
+-- Add `gitlab_discussion_id` to show-command discussion detail structs ... rejected ...
+-- Add `gitlab_project_id` to show-command discussion detail structs ... rejected ...
++Remove stale rejected entries that conflict with accepted workstreams in this plan iteration.
+```
+
+If you want, I can produce a fully rewritten iteration 5 plan document that applies all of the above edits cleanly end-to-end.

docs/plan-expose-discussion-ids.feedback-5.md.bak

@@ -0,0 +1,158 @@
+I reviewed the whole plan and only proposed changes that are not in your `## Rejected Recommendations`.
+
+1. **Fix plan-internal inconsistencies first**
+Analysis: The plan currently has a few self-contradictions (`8` vs `9` cross-cutting improvements, `stale` still referenced after moving to tri-state freshness). Cleaning this prevents implementation drift and bad AC validation.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@
+-**Scope**: 8 core changes + 8 cross-cutting architectural improvements across 3 tiers:
++**Scope**: 8 core changes + 9 cross-cutting architectural improvements across 3 tiers:
+@@ AC-7: Freshness Metadata Present & Staleness Guards Work
+-lore -J notes -n 1 | jq '.meta | {data_as_of_iso, sync_lag_seconds, stale}'
+-# All fields present, stale=false if recently synced
++lore -J notes -n 1 | jq '.meta | {data_as_of_iso, sync_lag_seconds, freshness_state}'
++# All fields present, freshness_state is one of fresh|stale|unknown
+@@ Change 6 Response Schema example
+-    "stale": false,
++    "freshness_state": "fresh",
+```
+
+2. **Require snapshot-consistent list responses (page + counts)**
+Analysis: `total_count`, `incomplete_rows`, and page rows can drift if sync writes between queries. Enforcing a single read snapshot for all list commands makes pagination and counts deterministic.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ Count Semantics (Cross-Cutting Convention)
+ All list commands use consistent count fields:
++All three queries (`page`, `total_count`, `incomplete_rows`) MUST execute inside one read transaction/snapshot.
++This guarantees count/page consistency under concurrent sync writes.
+```
+
+3. **Use RAII transactions instead of manual `BEGIN/COMMIT`**
+Analysis: Manual `execute_batch("BEGIN...")` is fragile on early returns. `rusqlite::Transaction` guarantees rollback on error and removes transaction-leak risk.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ Change 2: Consistency guarantee
+-conn.execute_batch("BEGIN DEFERRED")?;
+-// ... discussion query ...
+-// ... bulk note query ...
+-conn.execute_batch("COMMIT")?;
++let tx = conn.transaction_with_behavior(rusqlite::TransactionBehavior::Deferred)?;
++// ... discussion query ...
++// ... bulk note query ...
++tx.commit()?;
+```
+
+4. **Allow small focused new modules for query infrastructure**
+Analysis: Keeping everything in `list.rs`/`show.rs` will become a maintenance hotspot as filters/cursors/freshness expand. A small module split reduces coupling and regression risk.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ Change 3: File Architecture
+-**No new files.** Follow existing patterns:
++Allow focused infra modules for shared logic:
++- `src/cli/query/filters.rs` (CompiledFilters + builders)
++- `src/cli/query/cursor.rs` (encode/decode/validate v2 cursors)
++- `src/cli/query/freshness.rs` (freshness computation + guards)
++Command handlers remain in existing files.
+```
+
+5. **Add ingest-time `discussion_rollups` to avoid repeated heavy window scans**
+Analysis: Window functions are good, but doing them on every read over large note volumes is still expensive. Precomputing rollups during ingest gives lower and more predictable p95 latency while keeping read paths simpler.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ Architectural Improvements (Cross-Cutting)
++| J | Ingest-time discussion rollups (`discussion_rollups`) | Performance | Medium |
+@@ Change 3 SQL strategy
+-Use `ROW_NUMBER()` window function instead of correlated subqueries...
++Primary path: join precomputed `discussion_rollups` for `note_count`, `first_author`,
++`first_note_body`, `position_new_path`, `position_new_line`.
++Fallback path: window-function recompute if rollup row is missing (defensive correctness).
+```
+
+6. **Add deterministic numeric project selector `--project-id`**
+Analysis: `-p group/repo` is human-friendly, but numeric project IDs are safer for robots and avoid fuzzy/project-path ambiguity. This reduces false ambiguity failures and lookup overhead.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ DiscussionsArgs
+     #[arg(short = 'p', long, help_heading = "Filters")]
+     pub project: Option<String>,
++    #[arg(long, conflicts_with = "project", help_heading = "Filters")]
++    pub project_id: Option<i64>,
+@@ Ambiguity handling
++If `--project-id` is provided, IID resolution is scoped directly to that project.
++`--project-id` takes precedence over path-based project matching.
+```
+
+7. **Make path filtering rename-aware (`old` + `new`)**
+Analysis: Current `--path` strategy only using `position_new_path` misses deleted/renamed-file discussions. Supporting side selection makes the feature materially more useful for review workflows.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ DiscussionsArgs
+     #[arg(long, help_heading = "Filters")]
+     pub path: Option<String>,
++    #[arg(long, value_parser = ["either", "new", "old"], default_value = "either", help_heading = "Filters")]
++    pub path_side: String,
+@@ Change 3 filtering
+-Path filter matches `position_new_path`.
++Path filter semantics:
++- `either` (default): match `position_new_path` OR `position_old_path`
++- `new`: match only `position_new_path`
++- `old`: match only `position_old_path`
+```
+
+8. **Add explicit freshness behavior for empty-result queries + bootstrap backfill**
+Analysis: Freshness based only on “participating rows” is undefined when results are empty. Define deterministic behavior and backfill `project_sync_state` on migration so `unknown` doesn’t spike unexpectedly after deploy.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ Freshness state logic
++Empty-result rules:
++- If query is project-scoped (`-p` or `--project-id`), freshness is computed from that project even when no rows match.
++- If query is unscoped and returns zero rows, freshness is computed from all tracked projects.
+@@ A1. Track per-project sync timestamp
++Migration step: seed `project_sync_state` from latest known sync metadata where available
++to avoid mass `unknown` freshness immediately after rollout.
+```
+
+9. **Upgrade `--discussion-id` from filter-only to first-class thread retrieval**
+Analysis: Filtering list output by discussion ID still returns list-shaped data and partial note context. A direct thread retrieval mode is faster for agent workflows and avoids extra commands.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ Core Changes
+-| 8 | Add direct `--discussion-id` filter to notes/discussions/show | Core | Small |
++| 8 | Add direct `--discussion-id` filter + single-thread retrieval mode | Core | Medium |
+@@ Change 8
++lore -J discussions --discussion-id <id> --full-thread
++# Returns one discussion with full notes payload (same note schema as show command).
+```
+
+10. **Replace ad-hoc AC performance timing with repeatable perf harness**
+Analysis: `time lore ...` is noisy and machine-dependent. A reproducible seeded benchmark test gives stable guardrails and catches regressions earlier.
+
+```diff
+--- a/plan.md
++++ b/plan.md
+@@ AC-10: Performance Budget
+-time lore -J discussions --for-mr <iid> -n 100
+-# real  0m0.100s (p95 < 150ms)
++cargo test --test perf_discussions -- --ignored --nocapture
++# Uses seeded fixture DB and N repeated runs; asserts p95 < 150ms for target query shape.
+```
+
+If you want, I can also produce a fully merged “iteration 5” rewritten plan document with these edits applied end-to-end so it’s directly executable by an implementation agent.

docs/plan-expose-discussion-ids.feedback-6.md.bak

@@ -0,0 +1,143 @@
+Strong plan overall. The biggest gaps I’d fix are around sync-health correctness, idempotency/integrity under repeated ingests, deleted-entity lifecycle, and reducing schema drift risk without heavy reflection machinery.
+
+I avoided everything in your `## Rejected Recommendations` section.
+
+**1. Add Sync Health Semantics (not just age)**
+Time freshness alone can mislead after partial/failed syncs. Agents need to know whether data is both recent and complete.
+
+```diff
+@@ ## Freshness Metadata & Staleness Guards (Cross-Cutting, Change A/F/G)
+-    pub freshness_state: String,      // "fresh" | "stale" | "unknown"
++    pub freshness_state: String,      // "fresh" | "stale" | "unknown"
++    pub sync_status: String,          // "ok" | "partial" | "failed" | "never"
++    pub last_successful_sync_run_id: Option<i64>,
++    pub last_attempted_sync_run_id: Option<i64>,
+@@
+-#[arg(long, help_heading = "Freshness")]
+-pub require_fresh: Option<String>,
++#[arg(long, help_heading = "Freshness")]
++pub require_fresh: Option<String>,
++#[arg(long, help_heading = "Freshness")]
++pub require_sync_ok: bool,
+```
+
+Rationale: this prevents false confidence when one project is fresh-by-time but latest sync actually failed or was partial.
+
+---
+
+**2. Add `--require-complete` Guard for Missing Required IDs**
+You already expose `meta.incomplete_rows`; add a hard gate for automation.
+
+```diff
+@@ ## Count Semantics (Cross-Cutting Convention)
+ `incomplete_rows` is computed via a dedicated COUNT query...
++Add CLI guard:
++`--require-complete` fails with exit code 19 when `meta.incomplete_rows > 0`.
++Suggested action: `lore sync --full`.
+```
+
+Rationale: agents can fail fast instead of silently acting on partial datasets.
+
+---
+
+**3. Strengthen Ingestion Idempotency + Referential Integrity for Notes**
+You added natural-key uniqueness for discussions; do the same for notes and enforce parent integrity at DB level.
+
+```diff
+@@ ## Supporting Indexes (Cross-Cutting, Change D)
+ CREATE UNIQUE INDEX IF NOT EXISTS idx_discussions_project_gitlab_discussion_id
+     ON discussions(project_id, gitlab_discussion_id);
++CREATE UNIQUE INDEX IF NOT EXISTS idx_notes_project_gitlab_id
++    ON notes(project_id, gitlab_id);
++
++-- Referential integrity
++-- notes.discussion_id REFERENCES discussions(id)
++-- notes.project_id REFERENCES projects(id)
+```
+
+Rationale: repeated syncs and retries won’t duplicate notes, and orphaned rows can’t accumulate.
+
+---
+
+**4. Add Deleted/Tombstoned Entity Lifecycle**
+Current plan excludes null IDs but doesn’t define behavior when GitLab entities are deleted after sync.
+
+```diff
+@@ ## Contract Invariants (NEW)
++### Deletion Lifecycle Invariant
++1. Notes/discussions deleted upstream are tombstoned locally (`deleted_at`), not hard-deleted.
++2. All list/show commands exclude tombstoned rows by default.
++3. Optional flag `--include-deleted` exposes tombstoned rows for audit/debug.
+```
+
+Rationale: preserves auditability, prevents ghost actions on deleted objects, and avoids destructive resync behavior.
+
+---
+
+**5. Expand Discussions Payload for Rename Accuracy + Better Triage**
+`--path-side old` is great, but output currently only returns `position_new_*`.
+
+```diff
+@@ ## Change 3: Add Standalone `discussions` List Command
+     pub position_new_path: Option<String>,
+     pub position_new_line: Option<i64>,
++    pub position_old_path: Option<String>,
++    pub position_old_line: Option<i64>,
++    pub last_author: Option<String>,
++    pub participant_usernames: Vec<String>,
+```
+
+Rationale: for renamed/deleted files, agents need old and new coordinates to act confidently; participants/last_author improve thread routing and prioritization.
+
+---
+
+**6. Add SQLite Busy Handling + Retry Policy**
+Read transactions + concurrent sync writes can still produce `SQLITE_BUSY` under load.
+
+```diff
+@@ ## Count Semantics (Cross-Cutting Convention)
+ **Snapshot consistency**: All three queries ... inside a single read transaction ...
++**Busy handling**: set `PRAGMA busy_timeout` (e.g. 5000ms) and retry transient
++`SQLITE_BUSY` errors up to 3 times with jittered backoff for read commands.
+```
+
+Rationale: improves reliability in real multi-agent usage without changing semantics.
+
+---
+
+**7. Make Field Definitions Single-Source (Lightweight Drift Prevention)**
+You rejected full schema generation from code; a lower-cost middle ground is shared field manifests used by both docs and `--fields` validation.
+
+```diff
+@@ ## Change 7: Fix Robot-Docs Response Schemas
++#### 7h. Single-source field manifests (no reflection)
++Define per-command field constants (e.g. `NOTES_FIELDS`, `DISCUSSIONS_FIELDS`)
++used by:
++1) `--fields` validation/filtering
++2) `--fields minimal` expansion
++3) `robot-docs` schema rendering
+```
+
+Rationale: cuts drift risk materially while staying much simpler than reflection/snapshot infra.
+
+---
+
+**8. De-duplicate and Upgrade Test Strategy Around Concurrency**
+There are duplicated tests across Change 2 and Change 3; add explicit race tests where sync writes happen between list subqueries to prove tx consistency.
+
+```diff
+@@ ## Tests
+-**Test 6**: `--project-id` scopes IID resolution directly
+-**Test 7**: `--path-side old` matches renamed file discussions
+-**Test 8**: `--path-side either` matches both old and new paths
++Move shared discussion-filter tests to a single section under Change 3.
++Add concurrency tests:
++1) count/page/incomplete consistency under concurrent sync writes
++2) show discussion+notes snapshot consistency under concurrent writes
+```
+
+Rationale: less maintenance noise, better coverage of your highest-risk correctness path.
+
+---
+
+If you want, I can also produce a single consolidated patch block that rewrites your plan text end-to-end with these edits applied in-place.

docs/plan-surgical-sync.feedback-3.md

@@ -0,0 +1,169 @@
+Below are the strongest **new** revisions I’d make (excluding everything in your rejected list), with rationale and plan-level diffs.
+
+### 1. Add a durable run ledger (`sync_runs`) with phase state
+This makes surgical sync crash-resumable, auditable, and safer under Ctrl+C. Right now `run_id` is mostly ephemeral; persisting phase state removes ambiguity about what completed.
+
+```diff
+@@ Design Constraints
++9. **Durable run state**: Surgical sync MUST persist a `sync_runs` row keyed by `run_id`
++   with phase transitions (`preflight`, `ingest`, `dependents`, `docs`, `embed`, `done`, `failed`).
++   This is required for crash recovery, observability, and deterministic retries.
+
+@@ Step 9: Create `run_sync_surgical`
++Before Stage 0, insert `sync_runs(run_id, project_id, mode='surgical', requested_counts, started_at)`.
++After each stage, update `sync_runs.phase`, counters, and `last_error` if present.
++On success/failure, set terminal state (`done`/`failed`) and `finished_at`.
+```
+
+### 2. Add `--preflight-only` (network validation without writes)
+`--dry-run` is intentionally zero-network, so it cannot validate IIDs. `--preflight-only` is high-value for agents: verifies existence/permissions quickly with no DB mutation.
+
+```diff
+@@ CLI Interface
+ lore sync --dry-run --issue 123 -p myproject
++lore sync --preflight-only --issue 123 -p myproject
+
+@@ Step 2: Add `--issue`, `--mr`, `-p` to `SyncArgs`
++    /// Validate remote entities and auth without any DB writes
++    #[arg(long, default_value_t = false)]
++    pub preflight_only: bool,
+
+@@ Step 10: Add branch in `run_sync`
++if options.preflight_only && options.is_surgical() {
++    return run_sync_surgical_preflight_only(config, &options, run_id, signal).await;
++}
+```
+
+### 3. Preflight should aggregate all missing/failed IIDs, not fail-fast
+Fail-fast causes repeated reruns. Aggregating errors gives one-shot correction and better robot automation.
+
+```diff
+@@ Step 7: Create `src/ingestion/surgical.rs`
+-/// Returns the fetched payloads. If ANY fetch fails, the entire operation should abort.
++/// Returns fetched payloads plus per-IID failures; caller aborts writes if failures exist.
+ pub async fn preflight_fetch(...) -> Result<PreflightResult> {
+
+@@
+ #[derive(Debug, Default)]
+ pub struct PreflightResult {
+     pub issues: Vec<GitLabIssue>,
+     pub merge_requests: Vec<GitLabMergeRequest>,
++    pub failures: Vec<EntityFailure>, // stage="fetch"
+ }
+
+@@ Step 9: Create `run_sync_surgical`
+-let preflight = preflight_fetch(...).await?;
++let preflight = preflight_fetch(...).await?;
++if !preflight.failures.is_empty() {
++    result.entity_failures = preflight.failures;
++    return Err(LoreError::Other("Surgical preflight failed for one or more IIDs".into()).into());
++}
+```
+
+### 4. Stop filtering scoped queue drains with raw `json_extract` scans
+`json_extract(payload_json, '$.scope_run_id')` in hot drain queries will degrade as queue grows. Use indexed scope metadata.
+
+```diff
+@@ Step 9b: Implement scoped drain helpers
+-// claim query adds:
+-// AND json_extract(payload_json, '$.scope_run_id') = ?
++// Add migration:
++// 1) Add `scope_run_id` generated/stored column derived from payload_json (or explicit column)
++// 2) Create index on (project_id, job_type, scope_run_id, status, id)
++// Scoped drains filter by indexed `scope_run_id`, not full-table JSON extraction.
+```
+
+### 5. Replace `dirty_source_ids` collection-by-query with explicit run scoping
+Current approach can accidentally include prior dirty rows for same source and can duplicate work. Tag dirty rows with `origin_run_id` and consume by run.
+
+```diff
+@@ Design Constraints
+-2. **Dirty queue scoping**: ... MUST call ... `run_generate_docs_for_dirty_ids`
++2. **Dirty queue scoping**: Surgical sync MUST scope docs by `origin_run_id` on `dirty_sources`
++   (or equivalent exact run marker) and MUST NOT drain unrelated dirty rows.
+
+@@ Step 7: `SurgicalIngestResult`
+-    pub dirty_source_ids: Vec<i64>,
++    pub origin_run_id: String,
+
+@@ Step 9a: Implement `run_generate_docs_for_dirty_ids`
+-pub fn run_generate_docs_for_dirty_ids(config: &Config, dirty_source_ids: &[i64]) -> Result<...>
++pub fn run_generate_docs_for_run_id(config: &Config, run_id: &str) -> Result<...>
+```
+
+### 6. Enforce transaction safety at the type boundary
+`unchecked_transaction()` + `&Connection` signatures is fragile. Accept `&Transaction` for ingest internals and use `TransactionBehavior::Immediate` for deterministic lock behavior.
+
+```diff
+@@ Step 7: Create `src/ingestion/surgical.rs`
+-pub fn ingest_issue_by_iid_from_payload(conn: &Connection, ...)
++pub fn ingest_issue_by_iid_from_payload(tx: &rusqlite::Transaction<'_>, ...)
+
+-pub fn ingest_mr_by_iid_from_payload(conn: &Connection, ...)
++pub fn ingest_mr_by_iid_from_payload(tx: &rusqlite::Transaction<'_>, ...)
+
+-let tx = conn.unchecked_transaction()?;
++let tx = conn.transaction_with_behavior(rusqlite::TransactionBehavior::Immediate)?;
+```
+
+### 7. Acquire sync lock only for mutation phases, not remote preflight
+This materially reduces lock contention and keeps normal sync throughput higher, while still guaranteeing mutation serialization.
+
+```diff
+@@ Design Constraints
++10. **Lock window minimization**: Preflight fetch runs without sync lock; lock is acquired immediately
++    before first DB mutation and held through all mutation stages.
+
+@@ Step 9: Create `run_sync_surgical`
+-// ── Acquire sync lock ──
+-...
+-// ── Stage 0: Preflight fetch ──
++// ── Stage 0: Preflight fetch (no lock, no writes) ──
+ ...
++// ── Acquire sync lock just before Stage 1 mutation ──
+```
+
+### 8. Add explicit transient retry policy beyond 429
+Client already handles rate limits; surgical reliability improves a lot if 5xx/timeouts are retried with bounded backoff.
+
+```diff
+@@ Design Constraints
++11. **Transient retry policy**: Preflight and dependent remote fetches MUST retry boundedly on
++    timeout/5xx with jittered backoff; permanent errors (404/401/403) fail immediately.
+
+@@ Step 5: Add `get_issue_by_iid` / `get_mr_by_iid`
++Document retry behavior for transient transport/server failures.
+```
+
+### 9. Tighten automated tests around scoping invariants
+You already list manual checks; these should be enforced in unit/integration tests to prevent regressions.
+
+```diff
+@@ Step 1: TDD — Write Failing Tests First
++### 1d. New invariants tests
++- `surgical_docs_scope_ignores_preexisting_dirty_rows`
++- `scoped_queue_drain_ignores_orphaned_jobs`
++- `preflight_aggregates_multiple_missing_iids`
++- `preflight_only_performs_zero_writes`
++- `dry_run_performs_zero_network_calls`
++- `lock_window_does_not_block_during_preflight`
+
+@@ Acceptance Criteria
++32. Scoped queue/docs invariants are covered by automated tests (not manual-only verification).
+```
+
+### 10. Make robot-mode surgical output first-class
+For agent workflows, include full stage telemetry and actionable recovery commands.
+
+```diff
+@@ Step 15: Update `SyncResult` for robot mode structured output
++    /// Per-stage elapsed ms for deterministic performance tracking
++    pub stage_timings_ms: std::collections::BTreeMap<String, u64>,
++    /// Suggested recovery commands (robot ergonomics)
++    pub recovery_actions: Vec<String>,
+
+@@ Step 14: Update `robot-docs` manifest
++Document surgical-specific error codes and `actions` schema for automated recovery.
+```
+
+If you want, I can now produce a fully rewritten **iteration 3** plan that merges these into your current structure end-to-end.

docs/plan-surgical-sync.feedback-4.md

@@ -0,0 +1,212 @@
+1. **Resolve the current contract contradictions (`preflight-only`, `dry-run`, `sync_runs`)**
+
+Why this improves the plan:
+- Right now constraints conflict: “zero DB writes before commit” vs inserting `sync_runs` during preflight.
+- This ambiguity will cause implementation drift and flaky acceptance tests.
+- Splitting control-plane writes from content-plane writes keeps safety guarantees strict while preserving observability.
+
+```diff
+@@ ## Design Constraints
+-6. **Preflight-then-commit**: All remote fetches happen BEFORE any DB writes. If any IID fetch fails (404, network error), the entire operation aborts with zero DB mutations.
++6. **Preflight-then-commit (content-plane)**: All remote fetches happen BEFORE any writes to content tables (`issues`, `merge_requests`, `discussions`, `resource_events`, `documents`, `embeddings`).
++7. **Control-plane exception**: `sync_runs` / `sync_run_entities` writes are allowed during preflight for observability and crash diagnostics.
+@@
+-11. **Preflight-only mode**: `--preflight-only` validates remote entity existence and permissions with zero DB writes.
++11. **Preflight-only mode**: `--preflight-only` performs zero content writes; control-plane run-ledger writes are allowed.
+@@ ### For me to evaluate (functional):
+-24. **Preflight-only mode** ... no DB mutations beyond the sync_runs ledger entry
++24. **Preflight-only mode** ... no content DB mutations; only run-ledger rows may be written
+```
+
+---
+
+2. **Add stale-write protection to avoid TOCTOU regressions during unlocked preflight**
+
+Why this improves the plan:
+- You intentionally preflight without lock; that’s good for throughput but introduces race risk.
+- Without a guard, a slower surgical run can overwrite newer data ingested by a concurrent normal sync.
+- This is a correctness bug under contention, not a nice-to-have.
+
+```diff
+@@ ## Design Constraints
++12. **Stale-write protection**: Surgical ingest MUST NOT overwrite fresher local rows. If local `updated_at` is newer than the preflight payload’s `updated_at`, skip that entity and record `skipped_stale`.
+@@ ## Step 7: Create `src/ingestion/surgical.rs`
+-    let labels_created = process_single_issue(conn, config, project_id, issue)?;
++    // Skip stale payloads to avoid TOCTOU overwrite after unlocked preflight.
++    if is_local_newer_issue(conn, project_id, issue.iid, issue.updated_at)? {
++        result.skipped_stale += 1;
++        return Ok(result);
++    }
++    let labels_created = process_single_issue(conn, config, project_id, issue)?;
+@@
++// same guard for MR path
+@@ ## Step 15: Update `SyncResult`
++    /// Entities skipped because local row was newer than preflight payload
++    pub skipped_stale: usize,
+@@ ### Edge cases to verify:
++38. **TOCTOU safety**: if a normal sync updates entity after preflight but before ingest, surgical run skips stale payload (no overwrite)
+```
+
+---
+
+3. **Make dirty-source scoping exact (do not capture pre-existing rows for same entity)**
+
+Why this improves the plan:
+- Current “query dirty rows by `source_id` after ingest” can accidentally include older dirty rows for the same entity.
+- That silently violates strict run scoping and can delete unrelated backlog rows.
+- You can fix this without adding `origin_run_id` to `dirty_sources` (which you already rejected).
+
+```diff
+@@ ## Step 7: Create `src/ingestion/surgical.rs`
+-    // Collect dirty_source rows for this entity
+-    let mut stmt = conn.prepare(
+-        "SELECT id FROM dirty_sources WHERE source_type = 'issue' AND source_id = ?1"
+-    )?;
++    // Capture only rows inserted by THIS call using high-water mark.
++    let before_dirty_id: i64 = conn.query_row(
++        "SELECT COALESCE(MAX(id), 0) FROM dirty_sources",
++        [], |r| r.get(0),
++    )?;
++    // ... call process_single_issue ...
++    let mut stmt = conn.prepare(
++        "SELECT id FROM dirty_sources
++         WHERE id > ?1 AND source_type = 'issue' AND source_id = ?2"
++    )?;
+@@
++    // same pattern for MR
+@@ ### 1d. Scoping invariant tests
++#[test]
++fn surgical_docs_scope_ignores_preexisting_dirty_rows_for_same_entity() {
++    // pre-insert dirty row for iid=7, then surgical ingest iid=7
++    // assert result.dirty_source_ids only contains newly inserted rows
++}
+```
+
+---
+
+4. **Fix embed-stage leakage when `--no-docs` is used in surgical mode**
+
+Why this improves the plan:
+- Current design can run global embed even when docs stage is skipped, which may embed unrelated backlog docs.
+- That breaks the surgical “scope only this run” promise.
+- This is both correctness and operator-trust critical.
+
+```diff
+@@ ## Step 9: Create `run_sync_surgical`
+-        if !options.no_embed {
++        // Surgical embed only runs when surgical docs actually regenerated docs in this run.
++        if !options.no_embed && !options.no_docs && result.documents_regenerated > 0 {
+@@ ## Step 4: Wire new fields in `handle_sync_cmd`
++        if options.is_surgical() && options.no_docs && !options.no_embed {
++            return Err(Box::new(LoreError::Other(
++                "In surgical mode, --no-docs requires --no-embed (to preserve scoping guarantees)".to_string()
++            )));
++        }
+@@ ### For me to evaluate
++39. **No embed leakage**: `sync --issue X --no-docs` never embeds unrelated unembedded docs
+```
+
+---
+
+5. **Add queue-failure hygiene so scoped jobs do not leak forever**
+
+Why this improves the plan:
+- Scoped drains prevent accidental processing, but failed runs can strand pending jobs permanently.
+- You need explicit terminalization (`aborted`) and optional replay mechanics.
+- Otherwise queue bloat and confusing diagnostics accumulate.
+
+```diff
+@@ ## Step 8a: Add `sync_runs` table migration
++ALTER TABLE dependent_queue ADD COLUMN aborted_reason TEXT;
++-- status domain now includes: pending, claimed, done, failed, aborted
+@@ ## Step 9: run_sync_surgical failure paths
++// On run failure/cancel:
++conn.execute(
++  "UPDATE dependent_queue
++   SET status='aborted', aborted_reason=?1
++   WHERE project_id=?2 AND scope_run_id=?3 AND status='pending'",
++  rusqlite::params![failure_summary, project_id, run_id],
++)?;
+@@ ## Acceptance Criteria
++40. **No stranded scoped jobs**: failed surgical runs leave no `pending` rows for their `scope_run_id`
+```
+
+---
+
+6. **Persist per-entity lifecycle (`sync_run_entities`) for real observability and deterministic retry**
+
+Why this improves the plan:
+- `sync_runs` alone gives aggregate counters but not which IID failed at which stage.
+- Per-entity records make retries deterministic and robot output far more useful.
+- This is the missing piece for your stated “deterministic retry decisions.”
+
+```diff
+@@ ## Step 8a: Add `sync_runs` table migration
++CREATE TABLE IF NOT EXISTS sync_run_entities (
++  id INTEGER PRIMARY KEY,
++  run_id TEXT NOT NULL REFERENCES sync_runs(run_id),
++  entity_type TEXT NOT NULL CHECK(entity_type IN ('issue','merge_request')),
++  iid INTEGER NOT NULL,
++  stage TEXT NOT NULL,
++  status TEXT NOT NULL CHECK(status IN ('ok','failed','skipped_stale')),
++  error_code TEXT,
++  error_message TEXT,
++  updated_at INTEGER NOT NULL
++);
++CREATE INDEX IF NOT EXISTS idx_sync_run_entities_run ON sync_run_entities(run_id, entity_type, iid);
+@@ ## Step 15: Update `SyncResult`
++    pub failed_iids: Vec<(String, u64)>,
++    pub skipped_stale_iids: Vec<(String, u64)>,
+@@ ## CLI Interface
++lore --robot sync-runs --run-id <id>
++lore --robot sync-runs --run-id <id> --retry-failed
+```
+
+---
+
+7. **Use explicit error type for surgical preflight failures (not `LoreError::Other`)**
+
+Why this improves the plan:
+- `Other(String)` loses machine semantics, weakens robot mode, and leads to bad exit-code behavior.
+- A typed error preserves structured failures and enables actionable recovery commands.
+
+```diff
+@@ ## Step 9: run_sync_surgical
+-            return Err(LoreError::Other(
+-                format!("Surgical preflight failed for {} of {} IIDs: {}", ...)
+-            ).into());
++            return Err(LoreError::SurgicalPreflightFailed {
++                run_id: run_id.to_string(),
++                total: total_items,
++                failures: preflight.failures.clone(),
++            }.into());
+@@ ## Step 15: Update `SyncResult`
++    /// Machine-actionable error summary for robot mode
++    pub error_code: Option<String>,
+@@ ## Acceptance Criteria
++41. **Typed failure**: preflight failures serialize structured errors (not generic `Other`) with machine-usable codes/actions
+```
+
+---
+
+8. **Strengthen tests for rollback, contention, and stale-skip guarantees**
+
+Why this improves the plan:
+- Current tests cover many happy-paths and scoping invariants, but key race/rollback behaviors are still under-tested.
+- These are exactly where regressions will appear first in production.
+
+```diff
+@@ ## Step 1: TDD — Write Failing Tests First
++### 1f. Transactional rollback + TOCTOU tests
++1. `preflight_success_then_ingest_failure_rolls_back_all_content_writes`
++2. `stale_payload_is_skipped_when_local_updated_at_is_newer`
++3. `failed_run_aborts_pending_scoped_jobs`
++4. `surgical_no_docs_requires_no_embed`
+@@ ### Automated scoping invariants
+-38. **Scoped queue/docs invariants are enforced by automated tests**
++42. **Rollback and race invariants are enforced by automated tests** (no partial writes on ingest failure, no stale overwrite)
+```
+
+---
+
+These eight revisions keep your core approach intact, avoid your explicitly rejected ideas, and close the biggest correctness/operability gaps before implementation.

docs/plan-surgical-sync.feedback-5.md

@@ -0,0 +1,130 @@
+**Critical Gaps In Current Plan**
+1. `dirty_sources` scoping is based on `id`, but `dirty_sources` has no `id` column and uses `(source_type, source_id)` UPSERT semantics.
+2. Plan assumes a new `dependent_queue` with `status`, but current code uses `pending_dependent_fetches` (delete-on-complete), so queue-scoping design conflicts with existing invariants.
+3. Constraint 6 says all remote fetches happen before any content writes, but the proposed surgical flow fetches discussions/events/diffs after ingest writes.
+4. `sync_runs` is already an existing table and already used by `SyncRunRecorder`; the plan currently treats it like a new table.
+
+**Best Revisions**
+
+1. **Fix dirty-source scoping to match real schema (queued-at watermark, not `id` high-water).**  
+Why this is better: This removes a correctness bug and makes same-entity re-ingest deterministic under UPSERT behavior.
+
+```diff
+@@ Design Constraints
+-2. Dirty queue scoping: ... capture MAX(id) FROM dirty_sources ... run_generate_docs_for_dirty_ids ...
++2. Dirty queue scoping: `dirty_sources` is keyed by `(source_type, source_id)` and updated via UPSERT.
++   Surgical scoping MUST use:
++   1) a run-level `run_dirty_floor_ms` captured before surgical ingest, and
++   2) explicit touched source keys from ingest (`(source_type, source_id)`).
++   Surgical docs MUST call a scoped API (e.g. `run_generate_docs_for_sources`) and MUST NOT drain global dirty queue.
+@@ Step 9a
+-pub fn run_generate_docs_for_dirty_ids(config: &Config, dirty_source_ids: &[i64]) -> Result<GenerateDocsResult>
++pub fn run_generate_docs_for_sources(config: &Config, sources: &[(SourceType, i64)]) -> Result<GenerateDocsResult>
+```
+
+2. **Bypass shared dependent queue in surgical mode; run dependents inline per target.**  
+Why this is better: Avoids queue migration churn, avoids run-scope conflicts with existing unique constraints, and removes orphan-job hygiene complexity entirely.
+
+```diff
+@@ Design Constraints
+-4. Dependent queue scoping: ... scope_run_id indexed column on dependent_queue ...
++4. Surgical dependent execution: surgical mode MUST bypass `pending_dependent_fetches`.
++   Dependents (resource_events, mr_closes_issues, mr_diffs) run inline for targeted entities only.
++   Global queue remains for normal sync only.
+@@ Design Constraints
+-14. Queue failure hygiene: ... pending scoped jobs ... terminalized to aborted ...
++14. Surgical failure hygiene: surgical mode MUST leave no queue artifacts because it does not enqueue dependent jobs.
+@@ Step 9b / 9c / Step 13
+-Implement scoped drain helpers and enqueue_job scope_run_id plumbing
++Replace with direct per-entity helpers in ingestion layer:
++  - sync_issue_resource_events_direct(...)
++  - sync_mr_resource_events_direct(...)
++  - sync_mr_closes_issues_direct(...)
++  - sync_mr_diffs_direct(...)
+```
+
+3. **Clarify atomicity contract to “primary-entity atomicity” (remove contradiction).**  
+Why this is better: Keeps strong zero-write guarantees for missing IIDs while matching practical staged pipeline behavior.
+
+```diff
+@@ Design Constraints
+-6. Preflight-then-commit (content-plane): All remote fetches happen BEFORE any writes to content tables ...
++6. Primary-entity atomicity: all requested issue/MR payload fetches complete before first content write.
++   If any primary IID fetch fails, primary ingest does zero content writes.
++   Dependent stages (discussions/events/diffs/closes) are post-ingest and best-effort, with structured per-stage failure reporting.
+```
+
+4. **Extend existing `sync_runs` schema instead of redefining it.**  
+Why this is better: Preserves compatibility with current `SyncRunRecorder`, `sync_status`, and existing historical data.
+
+```diff
+@@ Step 8a
+-Add `sync_runs` table migration (CREATE TABLE sync_runs ...)
++Add migration 027 to extend existing `sync_runs` table:
++  - ADD COLUMN mode TEXT NULL            -- 'standard' | 'surgical'
++  - ADD COLUMN phase TEXT NULL           -- preflight|ingest|dependents|docs|embed|done|failed
++  - ADD COLUMN surgical_summary_json TEXT NULL
++Reuse `SyncRunRecorder` row lifecycle; do not introduce a parallel run-ledger model.
+```
+
+5. **Strengthen TOCTOU stale protection for equal timestamps.**  
+Why this is better: Prevents regressions when `updated_at` is equal but a fresher local fetch already happened.
+
+```diff
+@@ Design Constraints
+-13. ... If local `updated_at` is newer than preflight payload `updated_at`, skip ...
++13. ... Skip stale when:
++    a) local.updated_at > payload.updated_at, OR
++    b) local.updated_at == payload.updated_at AND local.last_seen_at > preflight_started_at_ms.
++    This prevents equal-timestamp regressions under concurrent sync.
+@@ Step 1f tests
++Add test: `equal_updated_at_but_newer_last_seen_is_skipped`.
+```
+
+6. **Shrink lock window further: release `sync` lock before embed; use dedicated embed lock.**  
+Why this is better: Prevents long embedding from blocking unrelated syncs and avoids concurrent embed writers.
+
+```diff
+@@ Design Constraints
+-11. Lock ... held through all mutation stages.
++11. Lock ... held through ingest/dependents/docs only.
++    Release `AppLock("sync")` before embed.
++    Embed stage uses `AppLock("embed")` for single-flight embedding writes.
+@@ Step 9
+-Embed runs inside the same sync lock window
++Embed runs after sync lock release, under dedicated embed lock
+```
+
+7. **Add the missing `sync-runs` robot read path (the plan references it but doesn’t define it).**  
+Why this is better: Makes durable run-state actually useful for recovery automation and observability.
+
+```diff
+@@ Step 14 (new)
++## Step 14a: Add `sync-runs` read command
++
++CLI:
++  lore --robot sync-runs --limit 20
++  lore --robot sync-runs --run-id <id>
++  lore --robot sync-runs --state failed
++
++Robot response fields:
++  run_id, mode, phase, status, started_at, finished_at, counters, failures, suggested_retry_command
+```
+
+8. **Add URL-native surgical targets (`--issue-url`, `--mr-url`) with project inference.**  
+Why this is better: Much more agent-friendly and reduces project-resolution errors from copy/paste workflows.
+
+```diff
+@@ CLI Interface
+ lore sync --issue 123 --issue 456 -p myproject
++lore sync --issue-url https://gitlab.example.com/group/proj/-/issues/123
++lore sync --mr-url https://gitlab.example.com/group/proj/-/merge_requests/789
+@@ Step 2
++Add repeatable flags:
++  --issue-url <url>
++  --mr-url <url>
++Parse URL into (project_path, iid). If all targets are URL-derived and same project, `-p` is optional.
++If mixed projects are provided in one command, reject with clear error.
+```
+
+If you want, I can produce a single consolidated patched version of your plan (iteration 5 draft) with these revisions already merged.

docs/plan-surgical-sync.feedback-6.md

@@ -0,0 +1,152 @@
+Highest-impact revisions after reviewing your v5 plan:
+
+1. **Fix a real scoping hole: embed can still process unrelated docs**
+Rationale: Current plan assumes scoped docs implies scoped embed, but that only holds while no other run creates unembedded docs. You explicitly release sync lock before embed, so another sync can enqueue/regenerate docs in between, and `run_embed` may embed unrelated backlog. This breaks surgical isolation and can hide backlog debt.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Design Constraints
+-3. Embed scoping: Embedding runs only for documents regenerated by this surgical run. Because `run_embed` processes only unembedded docs, scoping is automatic IF docs are scoped correctly...
++3. Embed scoping: Embedding MUST be explicitly scoped to documents regenerated by this surgical run.
++   `run_generate_docs_for_sources` returns regenerated `document_ids`; surgical mode calls
++   `run_embed_for_document_ids(document_ids)` and never global `run_embed`.
++   This remains true even after lock release and under concurrent normal sync activity.
+@@ Step 9a: Implement `run_generate_docs_for_sources`
+-pub fn run_generate_docs_for_sources(...) -> Result<GenerateDocsResult> {
++pub fn run_generate_docs_for_sources(...) -> Result<GenerateDocsResult> {
++    // Return regenerated document IDs for scoped embedding.
++    // GenerateDocsResult { regenerated, errored, regenerated_document_ids: Vec<i64> }
+@@ Step 9: Embed stage
+- match run_embed(config, false, false, None, signal).await {
++ match run_embed_for_document_ids(config, &result.regenerated_document_ids, signal).await {
+```
+
+2. **Make run-ledger lifecycle actually durable (and consistent with your own constraint 10)**
+Rationale: Plan text says “reuse `SyncRunRecorder`”, but Step 9 writes raw SQL directly. That creates lifecycle drift, missing heartbeats, and inconsistent failure handling as code evolves.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Design Constraints
+-10. Durable run state: ... Reuses `SyncRunRecorder` row lifecycle ...
++10. Durable run state: surgical sync MUST use `SyncRunRecorder` end-to-end (no ad-hoc SQL updates).
++    Add recorder APIs for `set_mode`, `set_phase`, `set_counters`, `finish_succeeded`,
++    `finish_failed`, `finish_cancelled`, and periodic `heartbeat`.
+@@ Step 9: Create `run_sync_surgical`
+- conn.execute("INSERT INTO sync_runs ...")
+- conn.execute("UPDATE sync_runs SET phase = ...")
++ let mut recorder = SyncRunRecorder::start_surgical(...)?;
++ recorder.set_phase("preflight")?;
++ recorder.heartbeat_if_due()?;
++ recorder.set_phase("ingest")?;
++ ...
++ recorder.finish_succeeded_with_warnings(...)?;
+```
+
+3. **Add explicit `cancelled` terminal state**
+Rationale: Current early cancellation branches return `Ok(result)` without guaranteed run-row finalization. That leaves misleading `running` rows and weak crash diagnostics.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Design Constraints
++15. Cancellation semantics: If shutdown is observed after run start, phase is set to `cancelled`,
++    status is `cancelled`, `finished_at` is written, and lock is released before return.
+@@ Step 8a migration
++ALTER TABLE sync_runs ADD COLUMN warnings_count INTEGER NOT NULL DEFAULT 0;
++ALTER TABLE sync_runs ADD COLUMN cancelled_at INTEGER;
+@@ Acceptance Criteria
++47. Cancellation durability: Ctrl+C during surgical sync records `status='cancelled'`,
++    `phase='cancelled'`, and `finished_at` in `sync_runs`.
+```
+
+4. **Reduce lock contention further by separating dependent fetch and dependent write**
+Rationale: You currently hold lock through network-heavy dependent stages. That maximizes contention and increases lock timeout risk. Better: fetch dependents unlocked, write in short locked transactions with per-entity freshness guards.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Design Constraints
+-11. Lock window minimization: ... held through ingest, dependents, and docs stages.
++11. Lock window minimization: lock is held only for DB mutation windows.
++    Dependents run in two phases:
++    (a) fetch from GitLab without lock,
++    (b) write results under lock in short transactions.
++    Apply per-entity freshness checks before dependent writes.
+@@ Step 9: Dependent stages
+- // All dependents run INLINE per-entity ... while lock is held
++ // Dependents fetch outside lock, then write under lock with CAS-style watermark guards.
+```
+
+5. **Introduce stage timeout budgets to prevent hung surgical runs**
+Rationale: A single slow GitLab endpoint can stall the whole run and hold resources too long. Timeout budgets plus per-entity failure recording keep the run bounded and predictable.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Design Constraints
++16. Stage timeout budgets: each dependent fetch has a per-entity timeout and a global stage budget.
++    Timed-out entities are recorded in `entity_failures` with code `TIMEOUT` and run continues best-effort.
+@@ Step 9 notes
++ - Wrap dependent network calls with `tokio::time::timeout`.
++ - Add config knobs:
++   `sync.surgical_entity_timeout_seconds` (default 20),
++   `sync.surgical_dependents_budget_seconds` (default 120).
+```
+
+6. **Add payload integrity checks (project mismatch hard-fail)**
+Rationale: Surgical mode is precision tooling. If API/proxy misconfiguration returns payloads from wrong project, you should fail preflight loudly, not trust downstream assumptions.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Step 7: preflight_fetch
++ // Integrity check: payload.project_id must equal requested gitlab_project_id.
++ // On mismatch, record EntityFailure { code: "PROJECT_MISMATCH", stage: "fetch" }.
+@@ Step 9d: error codes
++PROJECT_MISMATCH -> usage/config data integrity failure (typed, machine-readable)
+@@ Acceptance Criteria
++48. Project integrity: payloads with unexpected `project_id` are rejected in preflight
++    and produce zero content writes.
+```
+
+7. **Upgrade robot output from aggregate-only to per-entity lifecycle**
+Rationale: `entity_failures` alone is not enough for robust automation. Agents need a complete entity outcome map (fetched, ingested, stale-skipped, dependent failures) to retry deterministically.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Step 15: Update `SyncResult`
++pub struct EntityOutcome {
++    pub entity_type: String,
++    pub iid: u64,
++    pub fetched: bool,
++    pub ingested: bool,
++    pub stale_skipped: bool,
++    pub dependent_failures: Vec<EntityFailure>,
++}
+@@
++pub entity_outcomes: Vec<EntityOutcome>,
++pub completion_status: String, // succeeded | succeeded_with_warnings | failed | cancelled
+@@ Robot mode
+- enables agents to detect partial failures via `entity_failures`
++ enables deterministic, per-IID retry and richer UI messaging.
+```
+
+8. **Index `sync_runs` for real observability at scale**
+Rationale: You’re adding mode/phase/counters and then querying recent surgical runs. Without indexes, this degrades as run history grows.
+```diff
+diff --git a/plan.md b/plan.md
+@@ Step 8a migration
++CREATE INDEX IF NOT EXISTS idx_sync_runs_mode_started
++    ON sync_runs(mode, started_at DESC);
++CREATE INDEX IF NOT EXISTS idx_sync_runs_status_phase_started
++    ON sync_runs(status, phase, started_at DESC);
+```
+
+9. **Add tests specifically for the new failure-prone paths**
+Rationale: Current tests are strong on ingest and scoping, but still miss new high-risk runtime behavior (cancel state, timeout handling, scoped embed under concurrency).
+```diff
+diff --git a/plan.md b/plan.md
+@@ Step 1f tests
++#[tokio::test]
++async fn cancellation_marks_sync_run_cancelled() { ... }
++
++#[tokio::test]
++async fn dependent_timeout_records_entity_failure_and_continues() { ... }
++
++#[tokio::test]
++async fn scoped_embed_does_not_embed_unrelated_docs_created_after_docs_stage() { ... }
+@@ Acceptance Criteria
++49. Scoped embed isolation under concurrency is verified by automated test.
++50. Timeout path is verified (TIMEOUT code + continued processing).
+```
+
+These revisions keep your core direction intact, avoid every rejected recommendation, and materially improve correctness under concurrency, operational observability, and agent automation quality.

docs/prd-per-note-search.feedback-1.md

@@ -1,174 +0,0 @@
-Highest-impact gaps I see in the current plan:
-
-1. `for-issue` / `for-mr` filtering is ambiguous across projects and can return incorrect rows.
-2. `lore notes` has no pagination contract, so large exports and deterministic resumption are weak.
-3. Migration `022` is high-risk (table rebuild + FTS + junction tables) without explicit integrity gates.
-4. Note-doc freshness is incomplete for upstream note deletions and parent metadata changes (labels/title).
-
-Below are my best revisions, each with rationale and a git-diff-style plan edit.
-
----
-
-1. **Add gated rollout + rollback controls**
-Rationale: You can still “ship together” while reducing blast radius. This makes recovery fast if note-doc generation causes DB/embedding pressure.
-
-```diff
-@@ ## Design
--Two phases, shipped together as one feature:
-+Two phases, shipped together as one feature, but with runtime gates:
-+
-+- `feature.notes_cli` (Phase 1 surface)
-+- `feature.note_documents` (Phase 2 indexing/extraction path)
-+
-+Rollout order:
-+1) Enable `notes_cli`
-+2) Run note-doc backfill in bounded batches
-+3) Enable `note_documents` for continuous updates
-+
-+Rollback:
-+- Disabling `feature.note_documents` stops new note-doc generation without affecting issue/MR/discussion docs.
-```
-
-2. **Add keyset pagination + deterministic ordering**
-Rationale: Needed for year-long reviewer analysis and reliable “continue where I left off” behavior under concurrent updates.
-
-```diff
-@@ pub struct NoteListFilters<'a> {
-     pub limit: usize,
-+    pub cursor: Option<&'a str>,        // keyset token "<sort_ms>:<id>"
-+    pub include_total_count: bool,      // avoid COUNT(*) in hot paths
-@@
--    pub sort: &'a str,                  // "created" (default) | "updated"
-+    pub sort: &'a str,                  // "created" | "updated"
-@@ query_notes SQL
--ORDER BY {sort_column} {order}
-+ORDER BY {sort_column} {order}, n.id {order}
- LIMIT ?
-```
-
-3. **Make `for-issue` / `for-mr` project-scoped**
-Rationale: IIDs are not globally unique. Requiring project avoids false positives and hard-to-debug cross-project leakage.
-
-```diff
-@@ pub struct NotesArgs {
--    #[arg(long = "for-issue", help_heading = "Filters", conflicts_with = "for_mr")]
-+    #[arg(long = "for-issue", help_heading = "Filters", conflicts_with = "for_mr", requires = "project")]
-     pub for_issue: Option<i64>,
-@@
--    #[arg(long = "for-mr", help_heading = "Filters", conflicts_with = "for_issue")]
-+    #[arg(long = "for-mr", help_heading = "Filters", conflicts_with = "for_issue", requires = "project")]
-     pub for_mr: Option<i64>,
-```
-
-4. **Upgrade path filtering semantics**
-Rationale: Review comments often reference renames/moves. Restricting to `position_new_path` misses relevant notes.
-
-```diff
-@@ pub struct NotesArgs {
--    /// Filter by file path (trailing / for prefix match)
-+    /// Filter by file path
-     #[arg(long, help_heading = "Filters")]
-     pub path: Option<String>,
-+    /// Path mode: exact|prefix|glob
-+    #[arg(long = "path-mode", value_parser = ["exact","prefix","glob"], default_value = "exact", help_heading = "Filters")]
-+    pub path_mode: String,
-+    /// Match against old path as well as new path
-+    #[arg(long = "match-old-path", help_heading = "Filters")]
-+    pub match_old_path: bool,
-@@ query_notes filter mappings
--- `path` ... n.position_new_path ...
-+- `path` applies to `n.position_new_path` and optionally `n.position_old_path`.
-+- `glob` mode translates `*`/`?` to SQL LIKE with escaping.
-```
-
-5. **Add explicit performance indexes (new migration)**
-Rationale: `notes` becomes a first-class query surface; without indexes, filters degrade quickly at 10k+ note scale.
-
-```diff
-@@ ## Phase 1: `lore notes` Command
-+### Work Chunk 1E: Query Performance Indexes
-+**Files:** `migrations/023_notes_query_indexes.sql`, `src/core/db.rs`
-+
-+Add indexes:
-+- `notes(project_id, created_at DESC, id DESC)`
-+- `notes(author_username, created_at DESC, id DESC) WHERE is_system = 0`
-+- `notes(discussion_id)`
-+- `notes(position_new_path)`
-+- `notes(position_old_path)`
-+- `discussions(issue_id)`
-+- `discussions(merge_request_id)`
-```
-
-6. **Harden migration 022 with transactional integrity checks**
-Rationale: This is the riskiest part of the plan. Add hard fail-fast checks so corruption cannot silently pass.
-
-```diff
-@@ ### Work Chunk 2A: Schema Migration (022)
-+Migration safety requirements:
-+- Execute in a single `BEGIN IMMEDIATE ... COMMIT` transaction.
-+- Capture and compare pre/post row counts for `documents`, `document_labels`, `document_paths`, `dirty_sources`.
-+- Run `PRAGMA foreign_key_check` and abort on any violation.
-+- Run `PRAGMA integrity_check` and abort on non-`ok`.
-+- Rebuild FTS and assert `documents_fts` rowcount equals `documents` rowcount.
-```
-
-7. **Add note deletion + parent-change propagation**
-Rationale: Current plan handles create/update ingestion but not all staleness paths. Without this, note documents drift.
-
-```diff
-@@ ## Phase 2: Per-Note Documents
-+### Work Chunk 2G: Freshness Propagation
-+**Files:** `src/ingestion/discussions.rs`, `src/ingestion/mr_discussions.rs`, `src/documents/regenerator.rs`
-+
-+Rules:
-+- If a previously stored note is missing from upstream payload, delete local note row and enqueue `(note, id)` for document deletion.
-+- When parent issue/MR title or labels change, enqueue descendant note docs dirty (notes inherit parent metadata).
-+- Keep idempotent behavior for repeated syncs.
-```
-
-8. **Separate FTS coverage from embedding coverage**
-Rationale: Biggest cost/perf risk is embeddings. Index all notes in FTS, but embed selectively with policy knobs.
-
-```diff
-@@ ## Estimated Document Volume Impact
--FTS5 handles this comfortably. Embedding generation time scales linearly (~4x increase).
-+FTS5 handles this comfortably. Embedding generation is policy-controlled:
-+- FTS: index all non-system note docs
-+- Embeddings default: only notes with body length >= 40 chars (configurable)
-+- Add config: `documents.note_embeddings.min_chars`, `documents.note_embeddings.enabled`
-+- Prioritize unresolved DiffNotes before other notes during embedding backfill
-```
-
-9. **Bring structured reviewer profiling into scope (not narrative reporting)**
-Rationale: This directly serves the stated use case and makes the feature compelling immediately.
-
-```diff
-@@ ## Non-Goals
--- Adding a "reviewer profile" report command (that's a downstream use case built on this infrastructure)
-+- Generating free-form narrative reviewer reports.
-+  A structured profiling command is in scope.
-+
-+## Phase 3: Structured Reviewer Profiling
-+Add `lore notes profile --author <user> --since <window>` returning:
-+- top commented paths
-+- top parent labels
-+- unresolved-comment ratio
-+- note-type distribution
-+- median comment length
-```
-
-10. **Add operational SLOs + robot-mode status for note pipeline**
-Rationale: Reliability improves when regressions are observable, not inferred from failures.
-
-```diff
-@@ ## Verification Checklist
-+Operational checks:
-+- `lore -J stats` includes per-`source_type` document counts (including `note`)
-+- Add queue lag metrics: oldest dirty note age, retry backlog size
-+- Add extraction error breakdown by `source_type`
-+- Add smoke assertion: disabling `feature.note_documents` leaves other source regeneration unaffected
-```
-
----
-
-If you want, I can produce a single consolidated revised PRD draft (fully merged text, not just diffs) as the next step.

docs/prd-per-note-search.feedback-2.md

@@ -1,200 +0,0 @@
-Below are the strongest revisions I’d make, excluding everything in your `## Rejected Recommendations` list.
-
-1. **Add a Phase 0 for stable note identity before any note-doc generation**
-Rationale: your current plan still allows note document churn because Issue discussion ingestion is delete/reinsert-based. That makes local `notes.id` unstable, causing unnecessary dirtying/regeneration and potential stale-doc edge cases. Stabilizing identity first (upsert-by-GitLab-ID + sweep stale) improves correctness and cuts repeated work.
-
-```diff
-@@ ## Design
--Two phases, shipped together as one feature:
-+Three phases, shipped together as one feature:
-+- **Phase 0 (Foundation):** Stable note identity in local DB (upsert + sweep, no delete/reinsert churn)
- - **Phase 1 (Option A):** `lore notes` command — direct SQL query over the `notes` table with rich filtering
- - **Phase 2 (Option B):** Per-note documents — each non-system note becomes its own searchable document in the FTS/embedding pipeline
-@@
-+## Phase 0: Stable Note Identity
-+
-+### Work Chunk 0A: Upsert/Sweep for Issue Discussion Notes
-+**Files:** `src/ingestion/discussions.rs`, `migrations/022_notes_identity_index.sql`, `src/core/db.rs`
-+**Implementation:**
-+- Add unique index: `UNIQUE(project_id, gitlab_id)` on `notes`
-+- Replace delete/reinsert issue-note flow with upsert + `last_seen_at` sweep (same durability model as MR note sweep)
-+- Ensure `insert_note/upsert_note` returns the stable local row id for both insert and update paths
-```
-
-2. **Replace `source_type` CHECK constraints with a registry table + FK in migration**
-Rationale: table CHECKs force full table rebuild for every new source type forever. A `source_types` table with FK keeps DB-level integrity and future extensibility without rebuilding `documents`/`dirty_sources` every time. This is a major architecture hardening win.
-
-```diff
-@@ ### Work Chunk 2A: Schema Migration (023)
--Current migration ... CHECK constraints limiting `source_type` ...
-+Current migration ... CHECK constraints limiting `source_type` ...
-+Revision: migrate to `source_types` registry table + FK constraints.
-@@
--1. `dirty_sources` — add `'note'` to source_type CHECK
--2. `documents` — add `'note'` to source_type CHECK
-+1. Create `source_types(name TEXT PRIMARY KEY)` and seed: `issue, merge_request, discussion, note`
-+2. Rebuild `dirty_sources` and `documents` to replace CHECK with `REFERENCES source_types(name)`
-+3. Future source-type additions become `INSERT INTO source_types(name) VALUES (?)` (no table rebuild)
-@@
-+#### Additional integrity tests
-+#[test]
-+fn test_source_types_registry_contains_note() { ... }
-+#[test]
-+fn test_documents_source_type_fk_enforced() { ... }
-+#[test]
-+fn test_dirty_sources_source_type_fk_enforced() { ... }
-```
-
-3. **Mark note documents dirty only when note semantics actually changed**
-Rationale: current loops mark every non-system note dirty every sync. With 8k+ notes this creates avoidable queue pressure and regeneration time. Change-aware dirtying (inserted/changed only) gives major performance and stability improvements.
-
-```diff
-@@ ### Work Chunk 2D: Regenerator & Dirty Tracking Integration
--for note in notes {
--    let local_note_id = insert_note(&tx, local_discussion_id, &note, None)?;
--    if !note.is_system {
--        dirty_tracker::mark_dirty_tx(&tx, SourceType::Note, local_note_id)?;
--    }
--}
-+for note in notes {
-+    let outcome = upsert_note(&tx, local_discussion_id, &note, None)?;
-+    if !note.is_system && outcome.changed_semantics {
-+        dirty_tracker::mark_dirty_tx(&tx, SourceType::Note, outcome.local_note_id)?;
-+    }
-+}
-@@
-+// changed_semantics should include: body, note_type, path/line positions, resolvable/resolved/resolved_by, updated_at
-```
-
-4. **Expand filters to support real analysis windows and resolution state**
-Rationale: reviewer profiling usually needs bounded windows and both resolved/unresolved views. Current `unresolved: bool` is too narrow and one-sided. Add `--until` and tri-state resolution filtering for better analytical power.
-
-```diff
-@@ pub struct NoteListFilters<'a> {
--    pub since: Option<&'a str>,
-+    pub since: Option<&'a str>,
-+    pub until: Option<&'a str>,
-@@
--    pub unresolved: bool,
-+    pub resolution: &'a str, // "any" (default) | "unresolved" | "resolved"
-@@
--    pub author: Option<&'a str>,
-+    pub author: Option<&'a str>, // case-insensitive match
-@@
--    // Filter by time (7d, 2w, 1m, or YYYY-MM-DD)
-+    // Filter by start time (7d, 2w, 1m, or YYYY-MM-DD)
-     pub since: Option<String>,
-+    /// Filter by end time (7d, 2w, 1m, or YYYY-MM-DD)
-+    #[arg(long, help_heading = "Filters")]
-+    pub until: Option<String>,
-@@
--    /// Only show unresolved review comments
--    pub unresolved: bool,
-+    /// Resolution filter: any, unresolved, resolved
-+    #[arg(long, value_parser = ["any", "unresolved", "resolved"], default_value = "any", help_heading = "Filters")]
-+    pub resolution: String,
-```
-
-5. **Broaden index strategy to match actual query shapes, not just author queries**
-Rationale: `idx_notes_user_created` helps one path, but common usage also includes project+time scans and unresolved filters. Add two more partial composites for high-selectivity paths.
-
-```diff
-@@ ### Work Chunk 1E: Composite Query Index
- CREATE INDEX IF NOT EXISTS idx_notes_user_created
- ON notes(project_id, author_username, created_at DESC, id DESC)
- WHERE is_system = 0;
-+
-+CREATE INDEX IF NOT EXISTS idx_notes_project_created
-+ON notes(project_id, created_at DESC, id DESC)
-+WHERE is_system = 0;
-+
-+CREATE INDEX IF NOT EXISTS idx_notes_unresolved_project_created
-+ON notes(project_id, created_at DESC, id DESC)
-+WHERE is_system = 0 AND resolvable = 1 AND resolved = 0;
-@@
-+#[test]
-+fn test_notes_query_plan_uses_project_created_index_for_default_listing() { ... }
-+#[test]
-+fn test_notes_query_plan_uses_unresolved_index_when_resolution_unresolved() { ... }
-```
-
-6. **Improve per-note document payload with structured metadata header + minimal thread context**
-Rationale: isolated single-note docs can lose meaning. A small structured header plus lightweight context (parent + one preceding note excerpt) improves semantic retrieval quality substantially without re-bundling full threads.
-
-```diff
-@@ ### Work Chunk 2C: Note Document Extractor
--// 6. Format content:
--//    [[Note]] {note_type or "Comment"} on {parent_type_prefix}: {parent_title}
--//    Project: {path_with_namespace}
--//    URL: {url}
--//    Author: @{author}
--//    Date: {format_date(created_at)}
--//    Labels: {labels_json}
--//    File: {position_new_path}:{position_new_line}  (if DiffNote)
--//
--//    --- Body ---
--//
--//    {body}
-+// 6. Format content with machine-readable header:
-+//    [[Note]]
-+//    source_type: note
-+//    note_gitlab_id: {gitlab_id}
-+//    project: {path_with_namespace}
-+//    parent_type: {Issue|MergeRequest}
-+//    parent_iid: {iid}
-+//    note_type: {DiffNote|DiscussionNote|Comment}
-+//    author: @{author}
-+//    created_at: {iso8601}
-+//    resolved: {true|false}
-+//    path: {position_new_path}:{position_new_line}
-+//    url: {url}
-+//
-+//    --- Context ---
-+//    parent_title: {title}
-+//    previous_note_excerpt: {optional, max 200 chars}
-+//
-+//    --- Body ---
-+//    {body}
-```
-
-7. **Add first-class export modes for downstream profiling pipelines**
-Rationale: this makes the feature much more useful immediately (LLM prompts, notebook analysis, external scripts) without adding a profiling command. It stays within your non-goals and increases adoption.
-
-```diff
-@@ pub struct NotesArgs {
-+    /// Output format
-+    #[arg(long, value_parser = ["table", "json", "jsonl", "csv"], default_value = "table", help_heading = "Output")]
-+    pub format: String,
-@@
--    if robot_mode {
-+    if robot_mode || args.format == "json" || args.format == "jsonl" || args.format == "csv" {
-         print_list_notes_json(...)
-     } else {
-         print_list_notes(&result);
-     }
-@@ ### Work Chunk 1C: Human & Robot Output Formatting
-+Add `print_list_notes_csv()` and `print_list_notes_jsonl()`:
-+- CSV columns mirror `NoteListRowJson` field names
-+- JSONL emits one note object per line for streaming pipelines
-```
-
-8. **Strengthen verification with idempotence + migration data-preservation checks**
-Rationale: this feature touches ingestion, migrations, indexing, and regeneration. Add explicit idempotence/perf checks so regressions surface early.
-
-```diff
-@@ ## Verification Checklist
- cargo test
- cargo clippy --all-targets -- -D warnings
- cargo fmt --check
-+cargo test test_note_ingestion_idempotent_across_two_syncs
-+cargo test test_note_document_count_stable_after_second_generate_docs_full
-@@
-+lore sync
-+lore generate-docs --full
-+lore -J stats > /tmp/stats1.json
-+lore generate-docs --full
-+lore -J stats > /tmp/stats2.json
-+# assert note doc count unchanged and dirty queue drains to zero
-```
-
-If you want, I can turn this into a fully rewritten PRD v2 draft with these changes merged in-place and renumbered work chunks end-to-end.

docs/prd-per-note-search.feedback-3.md

@@ -1,162 +0,0 @@
-These are the highest-impact revisions I’d make. They avoid everything in your `## Rejected Recommendations` list.
-
-1. Add immediate note-document deletion propagation (don’t wait for `generate-docs --full`)
-Why: right now, deleted notes can leave stale `source_type='note'` documents until a full rebuild. That creates incorrect search/reporting results and weakens trust in the dataset.
-```diff
-@@ Phase 0: Stable Note Identity
-+### Work Chunk 0B: Immediate Deletion Propagation
-+
-+When sweep deletes stale notes, propagate deletion to documents in the same transaction.
-+Do not rely on eventual cleanup via `generate-docs --full`.
-+
-+#### Tests to Write First
-+#[test]
-+fn test_issue_note_sweep_deletes_note_documents_immediately() { ... }
-+#[test]
-+fn test_mr_note_sweep_deletes_note_documents_immediately() { ... }
-+
-+#### Implementation
-+Use `DELETE ... RETURNING id, is_system` in note sweep functions.
-+For returned non-system note ids:
-+1) `DELETE FROM documents WHERE source_type='note' AND source_id=?`
-+2) `DELETE FROM dirty_sources WHERE source_type='note' AND source_id=?`
-```
-
-2. Add one-time upgrade backfill for existing notes (migration 024)
-Why: existing DBs will otherwise only get note-documents for changed/new notes. Historical notes remain invisible unless users manually run full rebuild.
-```diff
-@@ Phase 2: Per-Note Documents
-+### Work Chunk 2H: Backfill Existing Notes After Upgrade (Migration 024)
-+
-+Create migration `024_note_dirty_backfill.sql`:
-+INSERT INTO dirty_sources (source_type, source_id, queued_at)
-+SELECT 'note', n.id, unixepoch('now') * 1000
-+FROM notes n
-+LEFT JOIN documents d
-+  ON d.source_type='note' AND d.source_id=n.id
-+WHERE n.is_system=0 AND d.id IS NULL
-+ON CONFLICT(source_type, source_id) DO NOTHING;
-+
-+Add migration test asserting idempotence and expected queue size.
-```
-
-3. Fix `--since/--until` semantics and validation
-Why: reusing `parse_since` for `until` creates ambiguous windows and off-by-boundary behavior; your own example `--since 90d --until 180d` is chronologically reversed.
-```diff
-@@ Work Chunk 1A: Data Types & Query Layer
-- since: parse_since(since_str) then n.created_at >= ?
-- until: parse_since(until_str) then n.created_at <= ?
-+ since: parse_since_start_bound(since_str) then n.created_at >= ?
-+ until: parse_until_end_bound(until_str) then n.created_at <= ?
-+ Validate since <= until; otherwise return a clear user error.
-+
-+#### Tests to Write First
-+#[test] fn test_query_notes_invalid_time_window_rejected() { ... }
-+#[test] fn test_query_notes_until_date_is_end_of_day_inclusive() { ... }
-```
-
-4. Separate semantic-change detection from housekeeping updates
-Why: current proposed `WHERE` includes `updated_at`, which will cause unnecessary dirty churn. You want `last_seen_at` to always refresh, but regeneration only when searchable semantics changed.
-```diff
-@@ Work Chunk 0A: Upsert/Sweep for Issue Discussion Notes
-- OR notes.updated_at IS NOT excluded.updated_at
-+ -- updated_at-only changes should not mark semantic dirty
-+
-+Perform two-step logic:
-+1) Upsert always updates persistence/housekeeping fields (`updated_at`, `last_seen_at`).
-+2) `changed_semantics` is computed only from fields used by note documents/search filters
-+   (body, note_type, resolved flags, paths, author, parent linkage).
-+
-+#### Tests to Write First
-+#[test]
-+fn test_issue_note_upsert_updated_at_only_does_not_mark_semantic_change() { ... }
-```
-
-5. Make indexes align with actual query collation and join strategy
-Why: `author` uses `COLLATE NOCASE`; without collation-aware index, SQLite can skip index use. Also, IID filters via scalar subqueries are harder for planner than direct join predicates.
-```diff
-@@ Work Chunk 1E: Composite Query Index
--CREATE INDEX ... ON notes(project_id, author_username, created_at DESC, id DESC) WHERE is_system = 0;
-+CREATE INDEX ... ON notes(project_id, author_username COLLATE NOCASE, created_at DESC, id DESC) WHERE is_system = 0;
-+
-+CREATE INDEX IF NOT EXISTS idx_discussions_issue_id ON discussions(issue_id);
-+CREATE INDEX IF NOT EXISTS idx_discussions_mr_id ON discussions(merge_request_id);
-```
-
-```diff
-@@ Work Chunk 1A: query_notes()
-- d.issue_id = (SELECT id FROM issues WHERE iid = ? AND project_id = ?)
-+ i.iid = ? AND i.project_id = ?
-- d.merge_request_id = (SELECT id FROM merge_requests WHERE iid = ? AND project_id = ?)
-+ m.iid = ? AND m.project_id = ?
-```
-
-6. Replace manual CSV escaping with `csv` crate
-Why: manual RFC4180 escaping is fragile (quotes/newlines/multi-byte edge cases). This is exactly where a mature library reduces long-term bug risk.
-```diff
-@@ Work Chunk 1C: Human & Robot Output Formatting
-- Uses a minimal CSV writer (no external dependency — the format is simple enough for manual escaping).
-+ Uses `csv::Writer` for RFC4180-compliant escaping and stable output across edge cases.
-+
-+#### Tests to Write First
-+#[test] fn test_csv_output_multiline_and_quotes_roundtrip() { ... }
-```
-
-7. Add `--contains` lexical body filter to `lore notes`
-Why: useful middle ground between metadata filtering and semantic search; great for reviewer-pattern mining without requiring FTS query syntax.
-```diff
-@@ Work Chunk 1B: CLI Arguments & Command Wiring
-+/// Filter by case-insensitive substring in note body
-+#[arg(long, help_heading = "Filters")]
-+pub contains: Option<String>;
-```
-
-```diff
-@@ Work Chunk 1A: NoteListFilters
-+ pub contains: Option<&'a str>,
-@@ query_notes dynamic filters
-+ if contains.is_some() {
-+   where_clauses.push("n.body LIKE ? COLLATE NOCASE");
-+   params.push(format!("%{}%", escape_like(contains.unwrap())));
-+ }
-```
-
-8. Reduce note-document embedding noise by slimming metadata header
-Why: current verbose key-value header repeats low-signal tokens and consumes embedding budget. Keep context, but bias tokens toward actual review text.
-```diff
-@@ Work Chunk 2C: Note Document Extractor
-- Build content with structured metadata header:
-- [[Note]]
-- source_type: note
-- note_gitlab_id: ...
-- project: ...
-- ...
-- --- Body ---
-- {body}
-+ Build content with compact, high-signal layout:
-+ [[Note]]
-+ @{author} on {Issue#|MR!}{iid} in {project_path}
-+ path: {path:line}            (only when available)
-+ state: {resolved|unresolved} (only when resolvable)
-+
-+ {body}
-+
-+Keep detailed metadata in structured document columns/labels/paths/url,
-+not repeated in verbose text.
-```
-
-9. Add explicit performance regression checks for the new hot paths
-Why: this feature increases document volume ~4x; you should pin acceptable query behavior now so future changes don’t silently degrade.
-```diff
-@@ Verification Checklist
-+Performance/plan checks:
-+1) `EXPLAIN QUERY PLAN` for:
-+   - author+since query
-+   - project+date query
-+   - for-mr / for-issue query
-+2) Seed 50k-note synthetic fixture and assert:
-+   - `lore notes --author ... --limit 100` stays under agreed local threshold
-+   - `lore search --type note ...` remains deterministic and completes successfully
-```
-
-If you want, I can also provide a fully merged “iteration 3” PRD text with these edits applied end-to-end so you can drop it in directly.

docs/prd-per-note-search.feedback-4.md

@@ -1,187 +0,0 @@
-1. **Canonical note identity for documents: use `notes.gitlab_id` as `source_id`**
-Why this is better: the current plan still couples document identity to local row IDs. Even with upsert+sweep, local IDs are a storage artifact and can be reused in edge cases. Using GitLab note IDs as canonical document IDs makes regeneration, backfill, and deletion propagation more stable and portable.
-
-```diff
---- a/PRD.md
-+++ b/PRD.md
-@@ Phase 0: Stable Note Identity
--Phase 2 depends on `notes.id` as the `source_id` for note documents.
-+Phase 2 uses `notes.gitlab_id` as the `source_id` for note documents.
-+`notes.id` remains an internal relational key only.
-
-@@ Work Chunk 0A
- pub struct NoteUpsertOutcome {
-     pub local_note_id: i64,
-+    pub document_source_id: i64, // notes.gitlab_id
-     pub changed_semantics: bool,
- }
-
-@@ Work Chunk 2D
--if !note.is_system && outcome.changed_semantics {
--    dirty_tracker::mark_dirty_tx(&tx, SourceType::Note, outcome.local_note_id)?;
-+if !note.is_system && outcome.changed_semantics {
-+    dirty_tracker::mark_dirty_tx(&tx, SourceType::Note, outcome.document_source_id)?;
- }
-
-@@ Work Chunk 2E
--SELECT 'note', n.id, ?1
-+SELECT 'note', n.gitlab_id, ?1
-
-@@ Work Chunk 2H
--ON d.source_type = 'note' AND d.source_id = n.id
-+ON d.source_type = 'note' AND d.source_id = n.gitlab_id
-```
-
-2. **Prevent false deletions on partial/incomplete syncs**
-Why this is better: sweep-based deletion is correct only when a discussion’s notes were fully fetched. If a page fails mid-fetch, current logic can incorrectly delete valid notes. Add an explicit “fetch complete” guard before sweep.
-
-```diff
---- a/PRD.md
-+++ b/PRD.md
-@@ Phase 0
-+### Work Chunk 0C: Sweep Safety Guard (Partial Fetch Protection)
-+
-+Only run stale-note sweep when note pagination completed successfully for that discussion.
-+If fetch is partial/interrupted, skip sweep and keep prior notes intact.
-
-+#### Tests to Write First
-+#[test]
-+fn test_partial_fetch_does_not_sweep_notes() { /* ... */ }
-+
-+#[test]
-+fn test_complete_fetch_runs_sweep_notes() { /* ... */ }
-
-+#### Implementation
-+if discussion_fetch_complete {
-+    sweep_stale_issue_notes(...)?;
-+} else {
-+    tracing::warn!("Skipping stale sweep for discussion {} due to partial fetch", discussion_gitlab_id);
-+}
-```
-
-3. **Make deletion propagation set-based (not per-note loop)**
-Why this is better: the current per-note DELETE loop is O(N) statements and gets slow on large threads. A temp-table/CTE set-based delete is faster, simpler to reason about, and remains atomic.
-
-```diff
---- a/PRD.md
-+++ b/PRD.md
-@@ Work Chunk 0B Implementation
--    for note_id in stale_note_ids {
--        conn.execute("DELETE FROM documents WHERE source_type = 'note' AND source_id = ?", [note_id])?;
--        conn.execute("DELETE FROM dirty_sources WHERE source_type = 'note' AND source_id = ?", [note_id])?;
--    }
-+    CREATE TEMP TABLE _stale_note_source_ids(source_id INTEGER PRIMARY KEY) WITHOUT ROWID;
-+    INSERT INTO _stale_note_source_ids
-+    SELECT gitlab_id
-+    FROM notes
-+    WHERE discussion_id = ? AND last_seen_at < ? AND is_system = 0;
-+
-+    DELETE FROM notes
-+    WHERE discussion_id = ? AND last_seen_at < ?;
-+
-+    DELETE FROM documents
-+    WHERE source_type = 'note'
-+      AND source_id IN (SELECT source_id FROM _stale_note_source_ids);
-+
-+    DELETE FROM dirty_sources
-+    WHERE source_type = 'note'
-+      AND source_id IN (SELECT source_id FROM _stale_note_source_ids);
-+
-+    DROP TABLE _stale_note_source_ids;
-```
-
-4. **Fix project-scoping and time-window semantics in `lore notes`**
-Why this is better: the plan currently has a contradiction: clap `requires = "project"` blocks use of `defaultProject`, while query layer says default fallback is allowed. Also, `since/until` parsing should use one shared “now” to avoid subtle drift and inverted windows.
-
-```diff
---- a/PRD.md
-+++ b/PRD.md
-@@ Work Chunk 1B NotesArgs
--#[arg(long = "for-issue", ..., requires = "project")]
-+#[arg(long = "for-issue", ...)]
- pub for_issue: Option<i64>;
-
--#[arg(long = "for-mr", ..., requires = "project")]
-+#[arg(long = "for-mr", ...)]
- pub for_mr: Option<i64>;
-
-@@ Work Chunk 1A Query Notes
--- `since`: `parse_since(since_str)` then `n.created_at >= ?`
--- `until`: `parse_since(until_str)` then `n.created_at <= ?`
-+- Parse `since` and `until` with a single anchored `now_ms` captured once per command.
-+- If user supplies `YYYY-MM-DD` for `--until`, interpret as end-of-day (23:59:59.999 UTC).
-+- Validate `since <= until` after both parse with same anchor.
-```
-
-5. **Add an analytics mode (not a profile command): `lore notes --aggregate`**
-Why this is better: this directly supports the stated use case (review patterns) without introducing the rejected “profile report” command. It keeps scope narrow and reuses existing filters.
-
-```diff
---- a/PRD.md
-+++ b/PRD.md
-@@ Phase 1
-+### Work Chunk 1F: Aggregation Mode for Notes Listing
-+
-+Add optional aggregation on top of `lore notes`:
-+- `--aggregate author|note_type|path|resolution`
-+- `--top N` (default 20)
-+
-+Behavior:
-+- Reuses all existing filters (`--since`, `--project`, `--for-mr`, etc.)
-+- Returns grouped counts (+ percentage of filtered corpus)
-+- Works in table/json/jsonl/csv
-+
-+Non-goal alignment:
-+- This is not a narrative “reviewer profile” command.
-+- It is a query primitive for downstream analysis.
-```
-
-6. **Prevent note backfill from starving other document regeneration**
-Why this is better: after migration/backfill, note dirty entries can dominate the queue and delay issue/MR/discussion updates. Add source-type fairness in regenerator scheduling.
-
-```diff
---- a/PRD.md
-+++ b/PRD.md
-@@ Work Chunk 2D
-+#### Scheduling Revision
-+Process dirty sources with weighted fairness instead of strict FIFO:
-+- issue: 3
-+- merge_request: 3
-+- discussion: 2
-+- note: 1
-+
-+Implementation sketch:
-+- fetch next batch by source_type buckets
-+- interleave according to weights
-+- preserve retry semantics per source
-
-+#### Tests to Write First
-+#[test]
-+fn test_note_backfill_does_not_starve_issue_and_mr_regeneration() { /* ... */ }
-```
-
-7. **Harden migration 023: remove invalid SQL assertions and move integrity checks to tests**
-Why this is better: `RAISE(ABORT, ...)` in standalone `SELECT` is not valid SQLite usage outside triggers/check expressions. Keep migration SQL minimal/portable and enforce invariants in migration tests.
-
-```diff
---- a/PRD.md
-+++ b/PRD.md
-@@ Work Chunk 2A Migration SQL
---- Step 10: Integrity verification
--SELECT CASE
--    WHEN ... THEN RAISE(ABORT, '...')
--END;
-+-- Step 10 removed from SQL migration.
-+-- Integrity verification is enforced in migration tests:
-+-- 1) pre/post row-count equality
-+-- 2) `PRAGMA foreign_key_check` is empty
-+-- 3) documents_fts row count matches documents row count after rebuild
-
-@@ Work Chunk 2A Tests
-+#[test]
-+fn test_migration_023_integrity_checks_pass() {
-+    // pre/post counts, foreign_key_check empty, fts parity
-+}
-```
-
-These 7 revisions improve correctness under failure, reduce churn risk, improve large-sync performance, and make the feature materially more useful for reviewer-analysis workflows without reintroducing any rejected recommendations.

docs/prd-per-note-search.feedback-5.md

@@ -1,190 +0,0 @@
-Here are the highest-impact revisions I’d make. None of these repeat anything in your `## Rejected Recommendations`.
-
-1. **Add immutable reviewer identity (`author_id`) as a first-class key**
-Why this improves the plan: the PRD’s core use case is year-scale reviewer profiling. Usernames are mutable in GitLab, so username-only filtering will fragment one reviewer into multiple identities over time. Adding `author_id` closes that correctness hole and makes historical analysis reliable.
-
-```diff
-@@ Problem Statement
--1. **Query individual notes by author** — the `--author` filter on `lore search` only matches the first note's author per discussion thread
-+1. **Query individual notes by reviewer identity** — support both mutable username and immutable GitLab `author_id` for stable longitudinal analysis
-
-@@ Phase 0: Stable Note Identity
-+### Work Chunk 0D: Immutable Author Identity Capture
-+**Files:** `migrations/025_notes_author_id.sql`, `src/ingestion/discussions.rs`, `src/ingestion/mr_discussions.rs`, `src/cli/commands/list.rs`
-+
-+#### Implementation
-+- Add nullable `notes.author_id INTEGER` and backfill from future syncs.
-+- Populate `author_id` from GitLab note payload (`note.author.id`) on both issue and MR note ingestion paths.
-+- Add `--author-id <int>` filter to `lore notes`.
-+- Keep `--author` for ergonomics; when both provided, require both to match.
-+
-+#### Indexing
-+- Add `idx_notes_author_id_created ON notes(project_id, author_id, created_at DESC, id DESC) WHERE is_system = 0;`
-+
-+#### Tests
-+- `test_query_notes_filter_author_id_survives_username_change`
-+- `test_query_notes_author_and_author_id_intersection`
-```
-
-2. **Strengthen partial-fetch safety from a boolean to an explicit fetch state contract**
-Why this improves the plan: `fetch_complete: bool` is easy to misuse and fragile under retries/crashes. A run-scoped state model makes sweep correctness auditable and prevents accidental deletions when ingestion aborts midway.
-
-```diff
-@@ Phase 0: Stable Note Identity
--### Work Chunk 0C: Sweep Safety Guard (Partial Fetch Protection)
-+### Work Chunk 0C: Sweep Safety Guard with Run-Scoped Fetch State
-
-@@ Implementation
--Add a `fetch_complete` parameter to the discussion ingestion functions. Only run the stale-note sweep when the fetch completed successfully:
-+Add a run-scoped fetch state:
-+- `FetchState::Complete`
-+- `FetchState::Partial`
-+- `FetchState::Failed`
-+
-+Only run sweep on `FetchState::Complete`.
-+Persist `run_seen_at` once per sync run and pass unchanged through all discussion/note upserts.
-+Require `run_seen_at` monotonicity per discussion before sweep (skip and warn otherwise).
-
-@@ Tests to Write First
-+#[test]
-+fn test_failed_fetch_never_sweeps_even_after_partial_upserts() { ... }
-+#[test]
-+fn test_non_monotonic_run_seen_at_skips_sweep() { ... }
-+#[test]
-+fn test_retry_after_failed_fetch_then_complete_sweeps_correctly() { ... }
-```
-
-3. **Add DB-level cleanup triggers for note-document referential integrity**
-Why this improves the plan: Work Chunk 0B handles the sweep path, but not every possible delete path. DB triggers give defense-in-depth so stale note docs cannot survive even if a future code path deletes notes differently.
-
-```diff
-@@ Work Chunk 0B: Immediate Deletion Propagation
--Update both sweep functions to propagate deletion to documents and dirty_sources using set-based SQL
-+Keep set-based SQL in sweep functions, and add DB-level cleanup triggers as a safety net.
-
-@@ Work Chunk 2A: Schema Migration (023)
-+-- Cleanup trigger: deleting a non-system note must delete note document + dirty queue row
-+CREATE TRIGGER notes_ad_cleanup AFTER DELETE ON notes
-+WHEN old.is_system = 0
-+BEGIN
-+  DELETE FROM documents
-+   WHERE source_type = 'note' AND source_id = old.id;
-+  DELETE FROM dirty_sources
-+   WHERE source_type = 'note' AND source_id = old.id;
-+END;
-+
-+-- Cleanup trigger: if note flips to system, remove its document artifacts
-+CREATE TRIGGER notes_au_system_cleanup AFTER UPDATE OF is_system ON notes
-+WHEN old.is_system = 0 AND new.is_system = 1
-+BEGIN
-+  DELETE FROM documents
-+   WHERE source_type = 'note' AND source_id = new.id;
-+  DELETE FROM dirty_sources
-+   WHERE source_type = 'note' AND source_id = new.id;
-+END;
-```
-
-4. **Eliminate N+1 extraction cost with parent metadata caching in regeneration**
-Why this improves the plan: backfilling ~8k notes with per-note parent/label lookups creates avoidable query amplification. Batch caching turns repeated joins into one-time lookups per parent entity and materially reduces rebuild time.
-
-```diff
-@@ Phase 2: Per-Note Documents
-+### Work Chunk 2I: Batch Parent Metadata Cache for Note Regeneration
-+**Files:** `src/documents/regenerator.rs`, `src/documents/extractor.rs`
-+
-+#### Implementation
-+- Add `NoteExtractionContext` cache keyed by `(noteable_type, parent_id)` containing:
-+  - parent iid/title/url
-+  - parent labels
-+  - project path
-+- In batch regeneration, prefetch parent metadata for note IDs in the current chunk.
-+- Use cached metadata in `extract_note_document()` to avoid repeated parent/label queries.
-+
-+#### Tests
-+- `test_note_regeneration_uses_parent_cache_consistently`
-+- `test_note_regeneration_cache_hit_preserves_hash_determinism`
-```
-
-5. **Add embedding dedup cache keyed by semantic text hash**
-Why this improves the plan: note docs will contain repeated short comments (“LGTM”, “nit: …”). Current doc-level hashing includes metadata, so identical semantic comments still re-embed many times. A semantic embedding hash cache cuts cost and speeds full rebuild/backfill without changing search behavior.
-
-```diff
-@@ Phase 2: Per-Note Documents
-+### Work Chunk 2J: Semantic Embedding Dedup for Notes
-+**Files:** `migrations/026_embedding_cache.sql`, embedding pipeline module(s), `src/documents/extractor.rs`
-+
-+#### Implementation
-+- Compute `embedding_text` for notes as: normalized note body + compact stable context (`parent_type`, `path`, `resolution`), excluding volatile fields.
-+- Compute `embedding_hash = sha256(embedding_text)`.
-+- Before embedding generation, lookup existing vector by `(model, embedding_hash)`.
-+- Reuse cached vector when present; only call embedding model on misses.
-+
-+#### Tests
-+- `test_identical_note_bodies_reuse_embedding_vector`
-+- `test_embedding_hash_changes_when_semantic_context_changes`
-```
-
-6. **Add deterministic review-signal tags as derived labels**
-Why this improves the plan: this makes output immediately more useful for reviewer-pattern analysis without adding a profile command (which is explicitly out of scope). It increases practical value of both `lore notes` and `lore search --type note` with low complexity.
-
-```diff
-@@ Non-Goals
--- Adding a "reviewer profile" report command (that's a downstream use case built on this infrastructure)
-+- Adding a "reviewer profile" report command (downstream), while allowing low-level derived signal tags as indexing primitives
-
-@@ Phase 2: Per-Note Documents
-+### Work Chunk 2K: Derived Review Signal Labels
-+**Files:** `src/documents/extractor.rs`
-+
-+#### Implementation
-+- Derive deterministic labels from note text + metadata:
-+  - `signal:nit`
-+  - `signal:blocking`
-+  - `signal:security`
-+  - `signal:performance`
-+  - `signal:testing`
-+- Attach via existing `document_labels` flow for note documents.
-+- No new CLI mode required; existing label filters can consume these labels.
-+
-+#### Tests
-+- `test_note_document_derives_signal_labels_nit`
-+- `test_note_document_derives_signal_labels_security`
-+- `test_signal_label_derivation_is_deterministic`
-```
-
-7. **Add high-precision note targeting filters (`--note-id`, `--gitlab-note-id`, `--discussion-id`)**
-Why this improves the plan: debugging, incident response, and reproducibility all benefit from exact addressing. This is especially useful when validating sync correctness and cross-checking a specific note/document lifecycle.
-
-```diff
-@@ Work Chunk 1B: CLI Arguments & Command Wiring
- pub struct NotesArgs {
-+    /// Filter by local note row id
-+    #[arg(long = "note-id", help_heading = "Filters")]
-+    pub note_id: Option<i64>,
-+
-+    /// Filter by GitLab note id
-+    #[arg(long = "gitlab-note-id", help_heading = "Filters")]
-+    pub gitlab_note_id: Option<i64>,
-+
-+    /// Filter by local discussion id
-+    #[arg(long = "discussion-id", help_heading = "Filters")]
-+    pub discussion_id: Option<i64>,
- }
-
-@@ Work Chunk 1A: Filter struct
- pub struct NoteListFilters<'a> {
-+    pub note_id: Option<i64>,
-+    pub gitlab_note_id: Option<i64>,
-+    pub discussion_id: Option<i64>,
- }
-
-@@ Tests to Write First
-+#[test]
-+fn test_query_notes_filter_note_id_exact() { ... }
-+#[test]
-+fn test_query_notes_filter_gitlab_note_id_exact() { ... }
-+#[test]
-+fn test_query_notes_filter_discussion_id_exact() { ... }
-```
-
-If you want, I can produce a single consolidated “iteration 5” PRD diff that merges these into your exact section ordering and updates the dependency graph/migration numbering end-to-end.

docs/who-command-design.feedback-1.md

@@ -1,434 +0,0 @@
-Below are the highest-leverage revisions I’d make to this plan. I’m focusing on correctness pitfalls, SQLite gotchas, query performance on 280K notes, and reducing “dynamic SQL + param juggling” complexity—without turning this into a new ingestion project.
-
-Change 1 — Fix a hard SQLite bug in --active (GROUP_CONCAT DISTINCT + separator)
-Why
-
-SQLite does not allow GROUP_CONCAT(DISTINCT x, sep). With DISTINCT, SQLite only permits a single argument (GROUP_CONCAT(DISTINCT x)). Your current query will error at runtime in many SQLite versions.
-
-Revision
-
-Use a subquery that selects distinct participants, then GROUP_CONCAT with your separator.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ fn query_active(...)
--            (SELECT GROUP_CONCAT(DISTINCT n.author_username, X'1F')
--             FROM notes n
--             WHERE n.discussion_id = d.id
--               AND n.is_system = 0
--               AND n.author_username IS NOT NULL) AS participants
-+            (SELECT GROUP_CONCAT(username, X'1F') FROM (
-+               SELECT DISTINCT n.author_username AS username
-+               FROM notes n
-+               WHERE n.discussion_id = d.id
-+                 AND n.is_system = 0
-+                 AND n.author_username IS NOT NULL
-+               ORDER BY username
-+            )) AS participants
-
-Change 2 — Replace “contains('.') => exact file match” with segment-aware path classification
-Why
-
-path.contains('.') misclassifies directories like:
-
-.github/workflows/
-
-src/v1.2/auth/
-
-It also fails the “root file” case (README.md) because your mode discriminator only treats paths as paths if they contain /.
-
-Revision
-
-Add explicit --path to force Expert mode (covers root files cleanly).
-
-Classify file-vs-dir by checking last path segment for a dot, and whether the input ends with /.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ pub struct WhoArgs {
--    /// Username or file path (path if contains /)
--    pub target: Option<String>,
-+    /// Username or file path shorthand (ambiguous for root files like README.md)
-+    pub target: Option<String>,
-+
-+    /// Force expert mode for a file/directory path (supports root files like README.md)
-+    #[arg(long, help_heading = "Mode", conflicts_with_all = ["active", "overlap", "reviews"])]
-+    pub path: Option<String>,
-@@ fn resolve_mode<'a>(args: &'a WhoArgs) -> Result<WhoMode<'a>> {
--    if let Some(target) = &args.target {
-+    if let Some(p) = &args.path {
-+        return Ok(WhoMode::Expert { path: p });
-+    }
-+    if let Some(target) = &args.target {
-         let clean = target.strip_prefix('@').unwrap_or(target);
-         if args.reviews {
-             return Ok(WhoMode::Reviews { username: clean });
-         }
--        // Disambiguation: if target contains '/', it's a file path.
--        // GitLab usernames never contain '/'.
--        if target.contains('/') {
-+        // Disambiguation:
-+        // - treat as path if it contains '/'
-+        // - otherwise treat as username (root files require --path)
-+        if target.contains('/') {
-             return Ok(WhoMode::Expert { path: target });
-         }
-         return Ok(WhoMode::Workload { username: clean });
-     }
-
-
-And update the path pattern logic used by Expert/Overlap:
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ fn query_expert(...)
--    // Normalize path for LIKE matching: add trailing % if no extension
--    let path_pattern = if path.contains('.') {
--        path.to_string() // Exact file match
--    } else {
--        let trimmed = path.trim_end_matches('/');
--        format!("{trimmed}/%")
--    };
-+    // Normalize:
-+    // - if ends_with('/') => directory prefix
-+    // - else if last segment contains '.' => file exact match
-+    // - else => directory prefix
-+    let trimmed = path.trim_end_matches('/');
-+    let last = trimmed.rsplit('/').next().unwrap_or(trimmed);
-+    let is_file = !path.ends_with('/') && last.contains('.');
-+    let path_pattern = if is_file { trimmed.to_string() } else { format!("{trimmed}/%") };
-
-Change 3 — Stop building dynamic SQL strings for optional filters; always bind params
-Why
-
-Right now you’re mixing:
-
-dynamic project_clause string fragments
-
-ad-hoc param vectors
-
-placeholder renumbering by branch
-
-That’s brittle and easy to regress (especially when you add more conditions later). SQLite/rusqlite can bind Option<T> to NULL, which enables a simple pattern:
-
-sql
-Copy code
-AND (?3 IS NULL OR n.project_id = ?3)
-
-Revision (representative; apply to all queries)
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ fn query_expert(...)
--    let project_clause = if project_id.is_some() {
--        "AND n.project_id = ?3"
--    } else {
--        ""
--    };
--
--    let sql = format!(
-+    let sql = format!(
-         "SELECT username, role, activity_count, last_active_at FROM (
-@@
-             FROM notes n
-             WHERE n.position_new_path LIKE ?1
-               AND n.is_system = 0
-               AND n.author_username IS NOT NULL
-               AND n.created_at >= ?2
--              {project_clause}
-+              AND (?3 IS NULL OR n.project_id = ?3)
-@@
-             WHERE n.position_new_path LIKE ?1
-               AND m.author_username IS NOT NULL
-               AND m.updated_at >= ?2
--              {project_clause}
-+              AND (?3 IS NULL OR n.project_id = ?3)
-             GROUP BY m.author_username
--        )"
-+        ) t"
-     );
--
--    let mut params: Vec<Box<dyn rusqlite::ToSql>> = Vec::new();
--    params.push(Box::new(path_pattern.clone()));
--    params.push(Box::new(since_ms));
--    if let Some(pid) = project_id {
--        params.push(Box::new(pid));
--    }
--    let param_refs: Vec<&dyn rusqlite::ToSql> = params.iter().map(|p| p.as_ref()).collect();
-+    let param_refs = rusqlite::params![path_pattern, since_ms, project_id];
-
-
-Notes:
-
-Adds required derived-table alias t (some SQLite configurations are stricter).
-
-Eliminates the dynamic param vector and placeholder gymnastics.
-
-Change 4 — Filter “path touch” queries to DiffNotes and escape LIKE properly
-Why
-
-Only DiffNotes reliably have position_new_path; including other note types can skew counts and harm performance.
-
-LIKE treats % and _ as wildcards—rare in file paths, but not impossible (generated files, templates). Escaping is a low-cost robustness win.
-
-Revision
-
-Add note_type='DiffNote' and LIKE ... ESCAPE '\' plus a tiny escape helper.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ fn query_expert(...)
--            FROM notes n
--            WHERE n.position_new_path LIKE ?1
-+            FROM notes n
-+            WHERE n.note_type = 'DiffNote'
-+              AND n.position_new_path LIKE ?1 ESCAPE '\'
-               AND n.is_system = 0
-@@
-diff --git a/Plan.md b/Plan.md
-@@ Helper Functions
-+fn escape_like(input: &str) -> String {
-+    input.replace('\\', "\\\\").replace('%', "\\%").replace('_', "\\_")
-+}
-
-
-And when building patterns:
-
-diff
-Copy code
--    let path_pattern = if is_file { trimmed.to_string() } else { format!("{trimmed}/%") };
-+    let base = escape_like(trimmed);
-+    let path_pattern = if is_file { base } else { format!("{base}/%") };
-
-
-Apply the same changes to query_overlap and any other position_new_path LIKE ....
-
-Change 5 — Use note timestamps for “touch since” semantics (Expert/Overlap author branch)
-Why
-
-In Expert/Overlap “author” branches you filter by m.updated_at >= since. That answers “MR updated recently” rather than “MR touched at this path recently”, which can surface stale ownership.
-
-Revision
-
-Filter by the note creation time (and use it for “last touch” where relevant). You can still compute author activity, but anchor it to note activity.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ fn query_overlap(...)
--            WHERE n.position_new_path LIKE ?1
-+            WHERE n.note_type = 'DiffNote'
-+              AND n.position_new_path LIKE ?1 ESCAPE '\'
-               AND m.state IN ('opened', 'merged')
-               AND m.author_username IS NOT NULL
--              AND m.updated_at >= ?2
-+              AND n.created_at >= ?2
-               AND (?3 IS NULL OR m.project_id = ?3)
-
-
-Same idea in Expert mode’s “MR authors” branch.
-
-Change 6 — Workload mode: apply --since consistently to unresolved discussions
-Why
-
-Workload’s unresolved discussions ignore since_ms. That makes --since partially misleading and can dump very old threads.
-
-Revision
-
-Filter on d.last_note_at when since_ms is set.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ fn query_workload(...)
--    let disc_sql = format!(
-+    let disc_since = if since_ms.is_some() {
-+        "AND d.last_note_at >= ?2"
-+    } else { "" };
-+    let disc_sql = format!(
-         "SELECT d.noteable_type,
-@@
-          WHERE d.resolvable = 1 AND d.resolved = 0
-            AND EXISTS (
-@@
-            )
-            {disc_project_filter}
-+           {disc_since}
-          ORDER BY d.last_note_at DESC
-          LIMIT {limit}"
-     );
-@@
--    // Rebuild params for discussion query (only username + optional project_id)
--    let mut disc_params: Vec<Box<dyn rusqlite::ToSql>> = Vec::new();
--    disc_params.push(Box::new(username.to_string()));
--    if let Some(pid) = project_id {
--        disc_params.push(Box::new(pid));
--    }
-+    // Params: username, since_ms, project_id (NULLs ok)
-+    let disc_param_refs = rusqlite::params![username, since_ms, project_id];
-
-
-(If you adopt Change 3 fully, this becomes very clean.)
-
-Change 7 — Make Overlap results represent “both roles” instead of collapsing to one
-Why
-
-Collapsing to a single role loses valuable info (“they authored and reviewed”). Also your current “prefer author” rule is arbitrary for the “who else is touching this” question.
-
-Revision
-
-Track role counts separately and render as A, R, or A+R.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ pub struct OverlapUser {
-     pub username: String,
--    pub role: String,
--    pub touch_count: u32,
-+    pub author_touch_count: u32,
-+    pub review_touch_count: u32,
-+    pub touch_count: u32,
-     pub last_touch_at: i64,
-     pub mr_iids: Vec<i64>,
- }
-@@ fn query_overlap(...)
--        let entry = user_map.entry(username.clone()).or_insert_with(|| OverlapUser {
-+        let entry = user_map.entry(username.clone()).or_insert_with(|| OverlapUser {
-             username: username.clone(),
--            role: role.clone(),
-+            author_touch_count: 0,
-+            review_touch_count: 0,
-             touch_count: 0,
-             last_touch_at: 0,
-             mr_iids: Vec::new(),
-         });
-         entry.touch_count += count;
-+        if role == "author" { entry.author_touch_count += count; }
-+        if role == "reviewer" { entry.review_touch_count += count; }
-@@ human output
--        println!(
--            "  {:<16} {:<8} {:>7}  {:<12}  {}",
-+        println!(
-+            "  {:<16} {:<6} {:>7}  {:<12}  {}",
-             ...
-         );
-@@
--            user.role,
-+            format_roles(user.author_touch_count, user.review_touch_count),
-
-Change 8 — Add an “Index Audit + optional migration” step (big perf win, low blast radius)
-Why
-
-With 280K notes, the path/timestamp queries will degrade quickly without indexes. This isn’t “scope creep”; it’s making the feature usable.
-
-Revision (plan-level)
-
-Add a non-breaking migration that only creates indexes if missing.
-
-Optionally add a runtime check: if EXPLAIN QUERY PLAN indicates full table scan on notes, print a dim warning in human mode.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ Implementation Order
--| Step | What | Files |
-+| Step | What | Files |
- | 1 | CLI skeleton: `WhoArgs` + `Commands::Who` + dispatch + stub | `cli/mod.rs`, `commands/mod.rs`, `main.rs` |
-+| 1.5 | Index audit + add `CREATE INDEX IF NOT EXISTS` migration for who hot paths | `migrations/0xx_who_indexes.sql` |
-@@
-
-
-Suggested indexes (tune names to your conventions):
-
-notes(note_type, position_new_path, created_at)
-
-notes(discussion_id, is_system, author_username)
-
-discussions(resolvable, resolved, last_note_at, project_id)
-
-merge_requests(project_id, state, updated_at, author_username)
-
-issue_assignees(username, issue_id)
-
-Even if SQLite can’t perfectly index LIKE, these still help with join and timestamp filters.
-
-Change 9 — Make robot JSON reproducible by echoing the effective query inputs
-Why
-
-Agent workflows benefit from a stable “query record”: what mode ran, what path/user, resolved project, effective since, limit.
-
-Revision
-
-Include an input object in JSON output.
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ struct WhoJsonData {
-     mode: String,
-+    input: serde_json::Value,
-     #[serde(flatten)]
-     result: serde_json::Value,
- }
-@@ pub fn print_who_json(...)
--    let output = WhoJsonEnvelope {
-+    let input = serde_json::json!({
-+        "project": /* resolved or raw args.project */,
-+        "since": /* resolved since ISO */,
-+        "limit": /* args.limit */,
-+    });
-+    let output = WhoJsonEnvelope {
-         ok: true,
-         data: WhoJsonData {
-             mode: mode.to_string(),
-+            input,
-             result: data,
-         },
-         meta: RobotMeta { elapsed_ms },
-     };
-
-Change 10 — Tighten clap constraints so invalid combinations never reach resolve_mode
-Why
-
-Right now conflicts are enforced manually (or not at all). Clamp the invalid combos at the CLI layer:
-
---active should conflict with target, --overlap, --reviews, --path
-
---reviews should require a username (and should conflict with Expert path modes)
-
-diff
-Copy code
-diff --git a/Plan.md b/Plan.md
-@@ pub struct WhoArgs {
--    pub active: bool,
-+    #[arg(long, help_heading = "Mode", conflicts_with_all = ["target", "overlap", "reviews", "path"])]
-+    pub active: bool,
-@@
--    pub overlap: Option<String>,
-+    #[arg(long, help_heading = "Mode", conflicts_with_all = ["target", "active", "reviews", "path"])]
-+    pub overlap: Option<String>,
-@@
--    pub reviews: bool,
-+    #[arg(long, help_heading = "Mode", requires = "target", conflicts_with_all = ["active", "overlap", "path"])]
-+    pub reviews: bool,
-
-Summary of what I’d definitely change
-
-If you do nothing else, do these first:
-
-Fix GROUP_CONCAT(DISTINCT ..., sep) in Active mode (runtime error).
-
-Path classification: add --path, and stop using contains('.') globally.
-
-Remove dynamic SQL + param vectors: always bind project_id as nullable and use (? IS NULL OR ...).
-
-Filter to DiffNotes + LIKE escaping for correctness and fewer rows scanned.
-
-Optional index migration: otherwise this will feel slow/non-deterministically slow depending on local DB state.
-
-If you want, I can also provide a consolidated “v2 plan” as a single unified patch (one diff) rather than per-change snippets.

docs/who-command-design.feedback-2.md

@@ -1,303 +0,0 @@
-Below are the highest-leverage revisions I’d make to iteration 1 to tighten correctness, performance, and “agent usefulness” without blowing up scope. For each change: (1) rationale, (2) a focused unified diff against the plan you pasted.
-
-Change 1 — Make robot “input echo” actually resolved (project_id, project_path, since_ms/iso, mode)
-Why
-
-Your Design Principle #5 says the robot envelope should echo resolved inputs (“effective since, resolved project”), but the current input object echoes only raw CLI strings. Agents can’t reliably reproduce or compare runs (e.g., fuzzy project resolution may map differently over time).
-
-This is also a reliability improvement: “what ran” should be computed once and propagated, not recomputed in output.
-
-Plan diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@
--5. **Robot-first reproducibility.** Robot JSON output includes an `input` object echoing the resolved query parameters (effective since, resolved project, limit) so agents can trace exactly what ran.
-+5. **Robot-first reproducibility.** Robot JSON output includes a `resolved_input` object (mode, since_ms + since_iso, resolved project_id + project_path, limit, db_path) so agents can trace exactly what ran.
-
-@@
--/// Main entry point. Resolves mode from args and dispatches.
--pub fn run_who(config: &Config, args: &WhoArgs) -> Result<WhoResult> {
-+/// Main entry point. Resolves mode + resolved inputs once, then dispatches.
-+pub fn run_who(config: &Config, args: &WhoArgs) -> Result<WhoRun> {
-     let db_path = get_db_path(config.storage.db_path.as_deref());
-     let conn = create_connection(&db_path)?;
- 
--    let project_id = args
-+    let project_id = args
-         .project
-         .as_deref()
-         .map(|p| resolve_project(&conn, p))
-         .transpose()?;
-+    let project_path = project_id
-+        .map(|id| lookup_project_path(&conn, id))
-+        .transpose()?;
- 
-     let mode = resolve_mode(args)?;
- 
-     match mode {
-         WhoMode::Expert { path } => {
-             let since_ms = resolve_since(args.since.as_deref(), "6m")?;
-             let result = query_expert(&conn, path, project_id, since_ms, args.limit)?;
--            Ok(WhoResult::Expert(result))
-+            Ok(WhoRun::new("expert", &db_path, project_id, project_path, since_ms, args.limit, WhoResult::Expert(result)))
-         }
-@@
-     }
- }
-+
-+/// Wrapper that carries resolved inputs for reproducible output.
-+pub struct WhoRun {
-+    pub mode: String,
-+    pub resolved_input: WhoResolvedInput,
-+    pub result: WhoResult,
-+}
-+
-+pub struct WhoResolvedInput {
-+    pub db_path: String,
-+    pub project_id: Option<i64>,
-+    pub project_path: Option<String>,
-+    pub since_ms: i64,
-+    pub since_iso: String,
-+    pub limit: usize,
-+}
-@@
--pub fn print_who_json(result: &WhoResult, args: &WhoArgs, elapsed_ms: u64) {
--    let (mode, data) = match result {
-+pub fn print_who_json(run: &WhoRun, args: &WhoArgs, elapsed_ms: u64) {
-+    let (mode, data) = match &run.result {
-         WhoResult::Expert(r) => ("expert", expert_to_json(r)),
-@@
--    let input = serde_json::json!({
-+    let input = serde_json::json!({
-         "target": args.target,
-         "path": args.path,
-         "project": args.project,
-         "since": args.since,
-         "limit": args.limit,
-     });
-+
-+    let resolved_input = serde_json::json!({
-+        "mode": run.mode,
-+        "db_path": run.resolved_input.db_path,
-+        "project_id": run.resolved_input.project_id,
-+        "project_path": run.resolved_input.project_path,
-+        "since_ms": run.resolved_input.since_ms,
-+        "since_iso": run.resolved_input.since_iso,
-+        "limit": run.resolved_input.limit,
-+    });
-@@
--        data: WhoJsonData {
--            mode: mode.to_string(),
--            input,
--            result: data,
--        },
-+        data: WhoJsonData { mode: mode.to_string(), input, resolved_input, result: data },
-         meta: RobotMeta { elapsed_ms },
-     };
-@@
- struct WhoJsonData {
-     mode: String,
-     input: serde_json::Value,
-+    resolved_input: serde_json::Value,
-     #[serde(flatten)]
-     result: serde_json::Value,
- }
-
-Change 2 — Remove dynamic SQL format!(..LIMIT {limit}) and parameterize LIMIT everywhere
-Why
-
-You explicitly prefer static SQL ((?N IS NULL OR ...)) to avoid subtle bugs; but Workload/Active use format! for LIMIT. Even though limit is typed, it’s an inconsistency that complicates statement caching and encourages future string assembly creep.
-
-SQLite supports LIMIT ? with bound parameters; rusqlite can bind an i64.
-
-Plan diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@
--    let issues_sql = format!(
--        "SELECT ... 
--         ORDER BY i.updated_at DESC
--         LIMIT {limit}"
--    );
--    let mut stmt = conn.prepare(&issues_sql)?;
-+    let issues_sql =
-+        "SELECT ...
-+         ORDER BY i.updated_at DESC
-+         LIMIT ?4";
-+    let mut stmt = conn.prepare(issues_sql)?;
-     let assigned_issues: Vec<WorkloadIssue> = stmt
--        .query_map(rusqlite::params![username, project_id, since_ms], |row| {
-+        .query_map(rusqlite::params![username, project_id, since_ms, limit as i64], |row| {
-@@
--    let authored_sql = format!(
--        "SELECT ...
--         ORDER BY m.updated_at DESC
--         LIMIT {limit}"
--    );
--    let mut stmt = conn.prepare(&authored_sql)?;
-+    let authored_sql =
-+        "SELECT ...
-+         ORDER BY m.updated_at DESC
-+         LIMIT ?4";
-+    let mut stmt = conn.prepare(authored_sql)?;
-@@
--        .query_map(rusqlite::params![username, project_id, since_ms], |row| {
-+        .query_map(rusqlite::params![username, project_id, since_ms, limit as i64], |row| {
-@@
--    let reviewing_sql = format!(
--        "SELECT ...
--         ORDER BY m.updated_at DESC
--         LIMIT {limit}"
--    );
--    let mut stmt = conn.prepare(&reviewing_sql)?;
-+    let reviewing_sql =
-+        "SELECT ...
-+         ORDER BY m.updated_at DESC
-+         LIMIT ?4";
-+    let mut stmt = conn.prepare(reviewing_sql)?;
-@@
--        .query_map(rusqlite::params![username, project_id, since_ms], |row| {
-+        .query_map(rusqlite::params![username, project_id, since_ms, limit as i64], |row| {
-@@
--    let disc_sql = format!(
--        "SELECT ...
--         ORDER BY d.last_note_at DESC
--         LIMIT {limit}"
--    );
--    let mut stmt = conn.prepare(&disc_sql)?;
-+    let disc_sql =
-+        "SELECT ...
-+         ORDER BY d.last_note_at DESC
-+         LIMIT ?4";
-+    let mut stmt = conn.prepare(disc_sql)?;
-@@
--        .query_map(rusqlite::params![username, project_id, since_ms], |row| {
-+        .query_map(rusqlite::params![username, project_id, since_ms, limit as i64], |row| {
-@@
--    let sql = format!(
--        "SELECT ...
--         ORDER BY d.last_note_at DESC
--         LIMIT {limit}"
--    );
--    let mut stmt = conn.prepare(&sql)?;
-+    let sql =
-+        "SELECT ...
-+         ORDER BY d.last_note_at DESC
-+         LIMIT ?3";
-+    let mut stmt = conn.prepare(sql)?;
-@@
--        .query_map(rusqlite::params![since_ms, project_id], |row| {
-+        .query_map(rusqlite::params![since_ms, project_id, limit as i64], |row| {
-
-Change 3 — Fix path matching for dotless files (LICENSE/Makefile) via “exact OR prefix” (no new flags)
-Why
-
-Your improved “dot only in last segment” heuristic still fails on dotless files (LICENSE, Makefile, Dockerfile) which are common, especially at repo root. Right now they’ll be treated as directories (LICENSE/%) and silently return nothing.
-
-Best minimal UX: if user provides a path that’s ambiguous (no trailing slash), match either exact file OR directory prefix.
-
-Plan diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@
--/// Build a LIKE pattern from a user-supplied path, with proper LIKE escaping.
--///
--/// Rules:
--/// - If the path ends with `/`, it's a directory prefix → `escaped_path%`
--/// - If the last path segment contains `.`, it's a file → exact match
--/// - Otherwise, it's a directory prefix → `escaped_path/%`
-+/// Build an exact + prefix match from a user-supplied path, with proper LIKE escaping.
-+///
-+/// Rules:
-+/// - If the path ends with `/`, treat as directory-only (prefix match)
-+/// - Otherwise, treat as ambiguous: exact match OR directory prefix
-+///   (fixes dotless files like LICENSE/Makefile without requiring new flags)
-@@
--fn build_path_pattern(path: &str) -> String {
-+struct PathMatch {
-+    exact: String,
-+    prefix: String,
-+    dir_only: bool,
-+}
-+
-+fn build_path_match(path: &str) -> PathMatch {
-     let trimmed = path.trim_end_matches('/');
--    let last_segment = trimmed.rsplit('/').next().unwrap_or(trimmed);
--    let is_file = !path.ends_with('/') && last_segment.contains('.');
-     let escaped = escape_like(trimmed);
--
--    if is_file {
--        escaped
--    } else {
--        format!("{escaped}/%")
--    }
-+    PathMatch {
-+        exact: escaped.clone(),
-+        prefix: format!("{escaped}/%"),
-+        dir_only: path.ends_with('/'),
-+    }
- }
-@@
--    let path_pattern = build_path_pattern(path);
-+    let pm = build_path_match(path);
-@@
--              AND n.position_new_path LIKE ?1 ESCAPE '\\'
-+              AND (
-+                    (?4 = 1 AND n.position_new_path LIKE ?2 ESCAPE '\\')
-+                 OR (?4 = 0 AND (n.position_new_path = ?1 OR n.position_new_path LIKE ?2 ESCAPE '\\'))
-+              )
-@@
--    let rows: Vec<(String, String, u32, i64)> = stmt
--        .query_map(rusqlite::params![path_pattern, since_ms, project_id], |row| {
-+    let rows: Vec<(String, String, u32, i64)> = stmt
-+        .query_map(rusqlite::params![pm.exact, pm.prefix, since_ms, i32::from(pm.dir_only), project_id], |row| {
-             Ok((row.get(0)?, row.get(1)?, row.get(2)?, row.get(3)?))
-         })?
-
-
-(Apply the same pattern to Overlap mode.)
-
-Change 4 — Consistently exclude system notes in all DiffNote-based branches (Expert/Overlap author branches currently don’t)
-Why
-
-You filter n.is_system = 0 for reviewer branches, but not in the author branches of Expert/Overlap. That can skew “author touch” via system-generated diff notes or bot activity.
-
-Consistency here improves correctness and also enables more aggressive partial indexing.
-
-Plan diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@
--            WHERE n.note_type = 'DiffNote'
-+            WHERE n.note_type = 'DiffNote'
-               AND n.position_new_path LIKE ?1 ESCAPE '\\'
-+              AND n.is_system = 0
-               AND m.author_username IS NOT NULL
-               AND n.created_at >= ?2
-               AND (?3 IS NULL OR m.project_id = ?3)
-@@
--            WHERE n.note_type = 'DiffNote'
-+            WHERE n.note_type = 'DiffNote'
-               AND n.position_new_path LIKE ?1 ESCAPE '\\'
-+              AND n.is_system = 0
-               AND m.state IN ('opened', 'merged')
-               AND m.author_username IS NOT NULL
-               AND n.created_at >= ?2
-               AND (?3 IS NULL OR m.project_id = ?3)
-
-Change 5 — Rework Migration 017 indexes to match real predicates + add one critical notes index for discussion participation
-Why
-
-(a) idx_notes_diffnote_path_created currently leads with note_type even though it’s constant via partial index. You want the leading columns to match your most selective predicates: position_new_path prefix + created_at range, with optional project_id.
-
-(b) Active + Workload discussion participation repeatedly hits notes by (discussion_id, author_username); you only guarantee notes(discussion_id) is indexed. Adding a narrow partial composite index pays off immediately for both “participants” and “EXISTS user participated” checks.
-
-(c) The discussions index should focus on (project_id, last_note_at) with a partial predicate; resolvable/resolved a_

docs/who-command-design.feedback-3.md

@@ -1,471 +0,0 @@
-Below are the revisions I’d make to iteration 2 to improve correctness, determinism, query-plan quality, and multi-project usability without turning this into a bigger product.
-
-I’m treating your plan as the “source of truth” and showing git-diff style patches against the plan text/code blocks you included.
-
-Change 1 — Fix project scoping to hit the right index (DiffNote branches)
-Why
-
-Your hot-path index is:
-
-idx_notes_diffnote_path_created ON notes(position_new_path, created_at, project_id) WHERE note_type='DiffNote' AND is_system=0
-
-But in Expert/Overlap you sometimes scope by m.project_id = ?3 (MR table), not n.project_id = ?3 (notes table). That weakens the optimizer’s ability to use the composite notes index (and can force broader joins before filtering).
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ Query: Expert Mode @@
--              AND (?3 IS NULL OR m.project_id = ?3)
-+              -- IMPORTANT: scope on notes.project_id to maximize use of
-+              -- idx_notes_diffnote_path_created (notes is the selective table)
-+              AND (?3 IS NULL OR n.project_id = ?3)
-
-@@ Query: Overlap Mode @@
--              AND (?3 IS NULL OR m.project_id = ?3)
-+              AND (?3 IS NULL OR n.project_id = ?3)
-
-@@ Query: Overlap Mode (author branch) @@
--              AND (?3 IS NULL OR m.project_id = ?3)
-+              AND (?3 IS NULL OR n.project_id = ?3)
-
-Change 2 — Introduce a “prefix vs exact” path query to avoid LIKE when you don’t need it
-Why
-
-For exact file paths (e.g. src/auth/login.rs), you currently do:
-
-position_new_path LIKE ?1 ESCAPE '\' where ?1 has no wildcard
-
-That’s logically fine, but it’s a worse signal to the planner than = and can degrade performance depending on collation/case settings.
-
-This doesn’t violate “static SQL” — you can pick between two static query strings.
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ Helper: Path Pattern Construction @@
--fn build_path_pattern(path: &str) -> String {
-+struct PathQuery {
-+    /// The parameter value to bind.
-+    value: String,
-+    /// If true: use LIKE value || '%'. If false: use '='.
-+    is_prefix: bool,
-+}
-+
-+fn build_path_query(path: &str) -> PathQuery {
-     let trimmed = path.trim_end_matches('/');
-     let last_segment = trimmed.rsplit('/').next().unwrap_or(trimmed);
-     let is_file = !path.ends_with('/') && last_segment.contains('.');
-     let escaped = escape_like(trimmed);
- 
-     if is_file {
--        escaped
-+        PathQuery { value: escaped, is_prefix: false }
-     } else {
--        format!("{escaped}/%")
-+        PathQuery { value: format!("{escaped}/%"), is_prefix: true }
-     }
- }
-
-
-And then (example for DiffNote predicates):
-
-diff
-Copy code
-@@ Query: Expert Mode @@
--    let path_pattern = build_path_pattern(path);
-+    let pq = build_path_query(path);
-
--    let sql = " ... n.position_new_path LIKE ?1 ESCAPE '\\' ... ";
-+    let sql_prefix = " ... n.position_new_path LIKE ?1 ESCAPE '\\' ... ";
-+    let sql_exact  = " ... n.position_new_path = ?1 ... ";
-
--    let mut stmt = conn.prepare(sql)?;
-+    let mut stmt = if pq.is_prefix { conn.prepare_cached(sql_prefix)? }
-+                   else { conn.prepare_cached(sql_exact)? };
-     let rows = stmt.query_map(params![... pq.value ...], ...);
-
-Change 3 — Push Expert aggregation into SQL (less Rust, fewer rows, SQL-level LIMIT)
-Why
-
-Right now Expert does:
-
-UNION ALL
-
-return per-role rows
-
-HashMap merge
-
-score compute
-
-sort/truncate
-
-You can do all of that in SQL deterministically, then LIMIT ?N actually works.
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ Query: Expert Mode @@
--    let sql = "SELECT username, role, activity_count, last_active_at FROM (
--            ...
--        )";
-+    let sql = "
-+      WITH activity AS (
-+        SELECT
-+          n.author_username AS username,
-+          'reviewer' AS role,
-+          COUNT(*) AS cnt,
-+          MAX(n.created_at) AS last_active_at
-+        FROM notes n
-+        WHERE n.note_type = 'DiffNote'
-+          AND n.is_system = 0
-+          AND n.author_username IS NOT NULL
-+          AND n.created_at >= ?2
-+          AND (?3 IS NULL OR n.project_id = ?3)
-+          AND (
-+            (?4 = 1 AND n.position_new_path LIKE ?1 ESCAPE '\\') OR
-+            (?4 = 0 AND n.position_new_path = ?1)
-+          )
-+        GROUP BY n.author_username
-+
-+        UNION ALL
-+
-+        SELECT
-+          m.author_username AS username,
-+          'author' AS role,
-+          COUNT(DISTINCT m.id) AS cnt,
-+          MAX(n.created_at) AS last_active_at
-+        FROM merge_requests m
-+        JOIN discussions d ON d.merge_request_id = m.id
-+        JOIN notes n ON n.discussion_id = d.id
-+        WHERE n.note_type = 'DiffNote'
-+          AND n.is_system = 0
-+          AND m.author_username IS NOT NULL
-+          AND n.created_at >= ?2
-+          AND (?3 IS NULL OR n.project_id = ?3)
-+          AND (
-+            (?4 = 1 AND n.position_new_path LIKE ?1 ESCAPE '\\') OR
-+            (?4 = 0 AND n.position_new_path = ?1)
-+          )
-+        GROUP BY m.author_username
-+      )
-+      SELECT
-+        username,
-+        SUM(CASE WHEN role='reviewer' THEN cnt ELSE 0 END) AS review_count,
-+        SUM(CASE WHEN role='author' THEN cnt ELSE 0 END) AS author_count,
-+        MAX(last_active_at) AS last_active_at,
-+        (SUM(CASE WHEN role='reviewer' THEN cnt ELSE 0 END) * 3.0) +
-+        (SUM(CASE WHEN role='author' THEN cnt ELSE 0 END) * 2.0) AS score
-+      FROM activity
-+      GROUP BY username
-+      ORDER BY score DESC, last_active_at DESC, username ASC
-+      LIMIT ?5
-+    ";
-
--    // Aggregate by username: combine reviewer + author counts
--    let mut user_map: HashMap<...> = HashMap::new();
--    ...
--    experts.sort_by(...); experts.truncate(limit);
-+    // No Rust-side merge/sort needed; SQL already returns final rows.
-
-Change 4 — Overlap output is ambiguous across projects: include stable MR refs (project_path!iid)
-Why
-
-mr_iids: Vec<i64> is ambiguous in a multi-project DB. !123 only means something with a project.
-
-Also: your MR IID dedup is currently Vec.contains() inside a loop (O(n²)). Use a HashSet.
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ OverlapResult @@
- pub struct OverlapUser {
-     pub username: String,
-@@
--    pub mr_iids: Vec<i64>,
-+    /// Stable MR references like "group/project!123"
-+    pub mr_refs: Vec<String>,
- }
-
-@@ Query: Overlap Mode (SQL) @@
--                GROUP_CONCAT(DISTINCT m.iid) AS mr_iids
-+                GROUP_CONCAT(DISTINCT (p.path_with_namespace || '!' || m.iid)) AS mr_refs
-             FROM notes n
-             JOIN discussions d ON n.discussion_id = d.id
-             JOIN merge_requests m ON d.merge_request_id = m.id
-+            JOIN projects p ON m.project_id = p.id
-@@
--                GROUP_CONCAT(DISTINCT m.iid) AS mr_iids
-+                GROUP_CONCAT(DISTINCT (p.path_with_namespace || '!' || m.iid)) AS mr_refs
-             FROM merge_requests m
-             JOIN discussions d ON d.merge_request_id = m.id
-             JOIN notes n ON n.discussion_id = d.id
-+            JOIN projects p ON m.project_id = p.id
-
-@@ Query: Overlap Mode (Rust merge) @@
--    let mr_iids: Vec<i64> = mr_iids_csv ...
-+    let mr_refs: Vec<String> = mr_refs_csv
-+      .as_deref()
-+      .map(|csv| csv.split(',').map(|s| s.trim().to_string()).collect())
-+      .unwrap_or_default();
-@@
--        // Merge MR IIDs, deduplicate
--        for iid in &mr_iids {
--            if !entry.mr_iids.contains(iid) {
--                entry.mr_iids.push(*iid);
--            }
--        }
-+        // Merge MR refs, deduplicate
-+        use std::collections::HashSet;
-+        let mut set: HashSet<String> = entry.mr_refs.drain(..).collect();
-+        for r in mr_refs { set.insert(r); }
-+        entry.mr_refs = set.into_iter().collect();
-
-Change 5 — Active mode: avoid correlated subqueries by preselecting discussions, then aggregating notes once
-Why
-
-Your Active query does two correlated subqueries per discussion row:
-
-note_count
-
-participants
-
-With LIMIT 20 it’s not catastrophic, but it is still unnecessary work and creates “spiky” behavior if the planner chooses poorly.
-
-Pattern to use:
-
-CTE selects the limited set of discussions
-
-Join notes once, aggregate with GROUP BY
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ Query: Active Mode @@
--    let sql =
--        "SELECT
--            d.noteable_type,
--            ...
--            (SELECT COUNT(*) FROM notes n
--             WHERE n.discussion_id = d.id AND n.is_system = 0) AS note_count,
--            (SELECT GROUP_CONCAT(username, X'1F') FROM (
--               SELECT DISTINCT n.author_username AS username
--               FROM notes n
--               WHERE n.discussion_id = d.id
--                 AND n.is_system = 0
--                 AND n.author_username IS NOT NULL
--               ORDER BY username
--            )) AS participants
--         FROM discussions d
--         ...
--         LIMIT ?3";
-+    let sql = "
-+      WITH picked AS (
-+        SELECT d.id, d.noteable_type, d.issue_id, d.merge_request_id, d.project_id, d.last_note_at
-+        FROM discussions d
-+        WHERE d.resolvable = 1 AND d.resolved = 0
-+          AND d.last_note_at >= ?1
-+          AND (?2 IS NULL OR d.project_id = ?2)
-+        ORDER BY d.last_note_at DESC
-+        LIMIT ?3
-+      ),
-+      note_agg AS (
-+        SELECT
-+          n.discussion_id,
-+          COUNT(*) AS note_count,
-+          GROUP_CONCAT(n.author_username, X'1F') AS participants
-+        FROM (
-+          SELECT DISTINCT discussion_id, author_username
-+          FROM notes
-+          WHERE is_system = 0 AND author_username IS NOT NULL
-+        ) n
-+        JOIN picked p ON p.id = n.discussion_id
-+        GROUP BY n.discussion_id
-+      )
-+      SELECT
-+        p.noteable_type,
-+        COALESCE(i.iid, m.iid) AS entity_iid,
-+        COALESCE(i.title, m.title) AS entity_title,
-+        proj.path_with_namespace,
-+        p.last_note_at,
-+        COALESCE(na.note_count, 0) AS note_count,
-+        COALESCE(na.participants, '') AS participants
-+      FROM picked p
-+      JOIN projects proj ON p.project_id = proj.id
-+      LEFT JOIN issues i ON p.issue_id = i.id
-+      LEFT JOIN merge_requests m ON p.merge_request_id = m.id
-+      LEFT JOIN note_agg na ON na.discussion_id = p.id
-+      ORDER BY p.last_note_at DESC
-+    ";
-
-Change 6 — Use prepare_cached() everywhere (cheap perf win, no scope creep)
-Why
-
-You already worked hard to keep SQL static. Taking advantage of sqlite statement caching completes the loop.
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ Query functions @@
--    let mut stmt = conn.prepare(sql)?;
-+    let mut stmt = conn.prepare_cached(sql)?;
-
-
-Apply in all query fns (query_workload, query_reviews, query_active, query_expert, query_overlap, lookup_project_path).
-
-Change 7 — Human output: show project_path where ambiguity exists (Workload + Overlap)
-Why
-
-When not project-scoped, #42 and !100 aren’t unique. You already have project paths in the query results — you’re just not printing them.
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ print_workload_human @@
--            println!(
--                "    {} {}  {}",
-+            println!(
-+                "    {} {}  {}  {}",
-                 style(format!("#{:<5}", item.iid)).cyan(),
-                 truncate_str(&item.title, 45),
-                 style(format_relative_time(item.updated_at)).dim(),
-+                style(&item.project_path).dim(),
-             );
-
-@@ print_workload_human (MRs) @@
--            println!(
--                "    {} {}{}  {}",
-+            println!(
-+                "    {} {}{}  {}  {}",
-                 style(format!("!{:<5}", mr.iid)).cyan(),
-                 truncate_str(&mr.title, 40),
-                 style(draft).dim(),
-                 style(format_relative_time(mr.updated_at)).dim(),
-+                style(&mr.project_path).dim(),
-             );
-
-@@ print_overlap_human @@
--        let mr_str = user.mr_iids.iter().take(5).map(|iid| format!("!{iid}")).collect::<Vec<_>>().join(", ");
-+        let mr_str = user.mr_refs.iter().take(5).cloned().collect::<Vec<_>>().join(", ");
-
-Change 8 — Robot JSON: add stable IDs + “defaulted” flags for reproducibility
-Why
-
-You already added resolved_input — good. Two more reproducibility gaps remain:
-
-Agents can’t reliably “open” an entity without IDs (discussion_id, mr_id, issue_id).
-
-Agents can’t tell whether since was user-provided vs defaulted (important when replaying intent).
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ WhoResolvedInput @@
- pub struct WhoResolvedInput {
-@@
-     pub since_ms: Option<i64>,
-     pub since_iso: Option<String>,
-+    pub since_was_default: bool,
-     pub limit: usize,
- }
-
-@@ run_who @@
--            let since_ms = resolve_since(args.since.as_deref(), "6m")?;
-+            let since_was_default = args.since.is_none();
-+            let since_ms = resolve_since(args.since.as_deref(), "6m")?;
-             Ok(WhoRun {
-                 resolved_input: WhoResolvedInput {
-@@
-                     since_ms: Some(since_ms),
-                     since_iso: Some(ms_to_iso(since_ms)),
-+                    since_was_default,
-                     limit: args.limit,
-                 },
-
-@@ print_who_json resolved_input @@
-     let resolved_input = serde_json::json!({
-@@
-         "since_ms": run.resolved_input.since_ms,
-         "since_iso": run.resolved_input.since_iso,
-+        "since_was_default": run.resolved_input.since_was_default,
-         "limit": run.resolved_input.limit,
-     });
-
-
-And for Active/Workload discussion items, add IDs in SQL and JSON:
-
-diff
-Copy code
-@@ ActiveDiscussion @@
- pub struct ActiveDiscussion {
-+    pub discussion_id: i64,
-@@
- }
-
-@@ query_active SELECT @@
--      SELECT
--        p.noteable_type,
-+      SELECT
-+        p.id AS discussion_id,
-+        p.noteable_type,
-
-@@ active_to_json @@
--        "discussions": r.discussions.iter().map(|d| json!({
-+        "discussions": r.discussions.iter().map(|d| json!({
-+            "discussion_id": d.discussion_id,
-             ...
-         }))
-
-Change 9 — Make performance verification explicit: require EXPLAIN QUERY PLAN checks for each mode
-Why
-
-You’re adding indexes specifically for these queries. The only way to ensure the planner is doing what you think is to lock in a short perf checklist (especially after schema drift or SQLite version differences).
-
-Diff
-diff
-Copy code
---- a/who-command-design.md
-+++ b/who-command-design.md
-@@ Verification @@
- # Manual verification against real data
- cargo run --release -- who src/features/global-search/
-@@
- cargo run --release -- who src/features/global-search/ -p typescript  # project scoped
-+
-+# Perf verification (required before merge):
-+# Confirm idx_notes_diffnote_path_created is used for Expert/Overlap and
-+# idx_discussions_unresolved_recent is used for Active.
-+sqlite3 path/to/db.sqlite "
-+  EXPLAIN QUERY PLAN
-+  SELECT ... -- paste final Expert SQL with representative bindings
-+";
-
-
-(Keep it lightweight: one representative query per mode is enough.)
-
-Net effect
-
-Correctness: project scoping hits the notes index; IDs added for agent workflows.
-
-Performance: fewer rows/materialization in Expert; statement caching everywhere; Active avoids correlated subqueries.
-
-UX: human output no longer ambiguous across projects; Overlap MR references become actionable.
-
-Reproducibility: agents can distinguish defaults vs explicit inputs; can dereference entities reliably.
-
-If you want one “highest ROI” subset to implement first: Change 1 + Change 4 + Change 6 + Change 7. That’s where the real operational value lands.