test: add contract tests for CLI output parsing

Implement contract testing to catch CLI schema drift early:

Contract Test Suite (fixture_contract_tests.rs):
- parse_lore_me_empty_fixture: Validates LoreMeResponse on empty data
- parse_lore_me_with_activity_fixture: Real lore output with activity
- parse_br_list_empty_fixture: Empty beads list
- parse_br_list_with_beads_fixture: Real br output with beads

Fixtures (captured from real CLI output):
- fixtures/lore/me_empty.json: Synthetic empty response
- fixtures/lore/me_with_activity.json: Real 'lore --robot me' output
- fixtures/br/list_empty.json: Empty array []
- fixtures/br/list_with_beads.json: Real 'br list --json' output
- fixtures/br/bv_triage.json: Real 'bv --robot-triage' output

Fixture Regeneration:
- scripts/regenerate-fixtures.sh: Captures fresh CLI output
  - Run periodically to update fixtures
  - CI can diff against committed fixtures to detect drift

Why Contract Tests Matter:
MC depends on external CLIs (lore, br, bv) whose output format may
change. Contract tests fail fast when our Rust types diverge from
actual CLI output, preventing runtime deserialization errors.

The tests use include_str!() for compile-time fixture embedding,
ensuring tests fail to compile if fixtures are missing.
This commit is contained in:
teernisse
2026-02-25 17:01:51 -05:00
parent c8854e59e9
commit d9f9c6aae7
7 changed files with 1101 additions and 0 deletions

View File

@@ -0,0 +1,65 @@
//! Contract tests to verify our types can parse real CLI outputs
//!
//! These tests use fixtures captured from actual CLI commands to ensure
//! our Rust types stay in sync with the CLI output format.
use mission_control_lib::data::lore::LoreMeResponse;
use mission_control_lib::data::beads::Bead;
/// Test that we can deserialize empty lore response
#[test]
fn parse_lore_me_empty_fixture() {
let fixture = include_str!("fixtures/lore/me_empty.json");
let result: Result<LoreMeResponse, _> = serde_json::from_str(fixture);
assert!(result.is_ok(), "Failed to parse me_empty.json: {:?}", result.err());
let response = result.unwrap();
assert!(response.ok);
assert!(response.data.open_issues.is_empty());
assert!(response.data.open_mrs_authored.is_empty());
assert!(response.data.reviewing_mrs.is_empty());
}
/// Test that we can deserialize real lore response with activity
///
/// This test may fail if the fixture format changes. Run:
/// ./scripts/regenerate-fixtures.sh
/// to update the fixtures if the CLI output format changes.
#[test]
fn parse_lore_me_with_activity_fixture() {
let fixture = include_str!("fixtures/lore/me_with_activity.json");
let result: Result<LoreMeResponse, _> = serde_json::from_str(fixture);
// If this fails, run: ./scripts/regenerate-fixtures.sh
assert!(result.is_ok(), "Failed to parse me_with_activity.json: {:?}", result.err());
let response = result.unwrap();
assert!(response.ok);
}
/// Test that we can deserialize empty beads list
#[test]
fn parse_br_list_empty_fixture() {
let fixture = include_str!("fixtures/br/list_empty.json");
let result: Result<Vec<Bead>, _> = serde_json::from_str(fixture);
assert!(result.is_ok(), "Failed to parse list_empty.json: {:?}", result.err());
assert!(result.unwrap().is_empty());
}
/// Test that we can deserialize real beads list with entries
#[test]
fn parse_br_list_with_beads_fixture() {
let fixture = include_str!("fixtures/br/list_with_beads.json");
let result: Result<Vec<Bead>, _> = serde_json::from_str(fixture);
// If this fails, run: ./scripts/regenerate-fixtures.sh
assert!(result.is_ok(), "Failed to parse list_with_beads.json: {:?}", result.err());
let beads = result.unwrap();
assert!(!beads.is_empty());
// Verify first bead has expected fields
let first = &beads[0];
assert!(!first.id.is_empty());
assert!(!first.title.is_empty());
assert!(!first.status.is_empty());
}