feat(followup): implement PLAN-FOLLOWUP.md gap fixes
Complete implementation of 7 slices addressing E2E testing gaps: Slice 0+1: Wire Actions + ReasonPrompt - FocusView now uses useActions hook instead of direct act() calls - Added pendingAction state pattern for skip/defer/complete actions - ReasonPrompt integration with proper confirm/cancel flow - Tags support in DecisionEntry interface Slice 2: Drag Reorder UI - Installed @dnd-kit (core, sortable, utilities) - QueueView with DndContext, SortableContext, verticalListSortingStrategy - SortableQueueItem wrapper component using useSortable hook - pendingReorder state with ReasonPrompt for reorder reasons - Cmd+Up/Down keyboard shortcuts for accessibility - Fixed: Store item ID in PendingReorder to avoid stale queue reference Slice 3: System Tray Integration - tray.rs with TrayState, setup_tray, toggle_window_visibility - Menu with Show/Quit items - Left-click toggles window visibility - update_tray_badge command updates tooltip with item count - Frontend wiring in AppShell Slice 4: E2E Test Updates - Fixed test selectors for InboxView, Queue badge - Exposed inbox store for test seeding Slice 5: Staleness Visualization - Already implemented in computeStaleness() with tests Slice 6: Quick Wiring - onStartBatch callback wired to QueueView - SyncStatus rendered in nav area - SettingsView renders Settings component Slice 7: State Persistence - settings-store with hydrate/update methods - Tauri backend integration via read_settings/write_settings - AppShell hydrates settings on mount Bug fixes from code review: - close_bead now has error isolation (try/catch) so decision logging and queue advancement continue even if bead close fails - PendingReorder stores item ID to avoid stale queue reference E2E tests for all ACs (tests/e2e/followup-acs.spec.ts): - AC-F1: Drag reorder (4 tests) - AC-F2: ReasonPrompt integration (7 tests) - AC-F5: Staleness visualization (3 tests) - AC-F6: Batch mode (2 tests) - AC-F7: SyncStatus (2 tests) - ReasonPrompt behavior (3 tests) Tests: 388 frontend + 119 Rust + 32 E2E all passing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
27
CLAUDE.md
27
CLAUDE.md
@@ -50,14 +50,37 @@ All MC-specific state lives in `~/.local/share/mc/`:
|
||||
npm run dev
|
||||
|
||||
# Tauri dev (frontend + backend)
|
||||
npm run tauri dev
|
||||
npm run tauri:dev
|
||||
|
||||
# Build
|
||||
npm run tauri build
|
||||
npm run tauri:build
|
||||
|
||||
# Tests
|
||||
npm run test # Vitest unit tests
|
||||
npm run test:watch # Watch mode
|
||||
npm run test:coverage # With coverage
|
||||
npm run test:e2e # Playwright e2e
|
||||
cargo test # Rust tests
|
||||
|
||||
# Lint
|
||||
npm run lint
|
||||
cargo clippy -- -D warnings
|
||||
```
|
||||
|
||||
## Keyboard Shortcuts
|
||||
|
||||
| Shortcut | Action |
|
||||
|----------|--------|
|
||||
| `Cmd+1` | Focus view |
|
||||
| `Cmd+2` | Queue view |
|
||||
| `Cmd+3` | Inbox |
|
||||
| `Cmd+4` | Debug view |
|
||||
| `Cmd+,` | Settings |
|
||||
| `Ctrl+Shift+Space` | Quick capture |
|
||||
|
||||
## Code Quality
|
||||
|
||||
- Run `cargo clippy -- -D warnings` before committing Rust changes
|
||||
- Run `npm run lint` before committing frontend changes
|
||||
- Follow existing patterns in the codebase
|
||||
- Use trait-based mocking for CLI integrations
|
||||
|
||||
Reference in New Issue
Block a user