feat(followup): implement PLAN-FOLLOWUP.md gap fixes
Complete implementation of 7 slices addressing E2E testing gaps: Slice 0+1: Wire Actions + ReasonPrompt - FocusView now uses useActions hook instead of direct act() calls - Added pendingAction state pattern for skip/defer/complete actions - ReasonPrompt integration with proper confirm/cancel flow - Tags support in DecisionEntry interface Slice 2: Drag Reorder UI - Installed @dnd-kit (core, sortable, utilities) - QueueView with DndContext, SortableContext, verticalListSortingStrategy - SortableQueueItem wrapper component using useSortable hook - pendingReorder state with ReasonPrompt for reorder reasons - Cmd+Up/Down keyboard shortcuts for accessibility - Fixed: Store item ID in PendingReorder to avoid stale queue reference Slice 3: System Tray Integration - tray.rs with TrayState, setup_tray, toggle_window_visibility - Menu with Show/Quit items - Left-click toggles window visibility - update_tray_badge command updates tooltip with item count - Frontend wiring in AppShell Slice 4: E2E Test Updates - Fixed test selectors for InboxView, Queue badge - Exposed inbox store for test seeding Slice 5: Staleness Visualization - Already implemented in computeStaleness() with tests Slice 6: Quick Wiring - onStartBatch callback wired to QueueView - SyncStatus rendered in nav area - SettingsView renders Settings component Slice 7: State Persistence - settings-store with hydrate/update methods - Tauri backend integration via read_settings/write_settings - AppShell hydrates settings on mount Bug fixes from code review: - close_bead now has error isolation (try/catch) so decision logging and queue advancement continue even if bead close fails - PendingReorder stores item ID to avoid stale queue reference E2E tests for all ACs (tests/e2e/followup-acs.spec.ts): - AC-F1: Drag reorder (4 tests) - AC-F2: ReasonPrompt integration (7 tests) - AC-F5: Staleness visualization (3 tests) - AC-F6: Batch mode (2 tests) - AC-F7: SyncStatus (2 tests) - ReasonPrompt behavior (3 tests) Tests: 388 frontend + 119 Rust + 32 E2E all passing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
import { describe, it, expect, vi, beforeEach } from "vitest";
|
||||
import { render, screen, act } from "@testing-library/react";
|
||||
import { render, screen, act, waitFor } from "@testing-library/react";
|
||||
import userEvent from "@testing-library/user-event";
|
||||
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
||||
import { AppShell } from "@/components/AppShell";
|
||||
@@ -7,7 +7,7 @@ import { useNavStore } from "@/stores/nav-store";
|
||||
import { useFocusStore } from "@/stores/focus-store";
|
||||
import { useCaptureStore } from "@/stores/capture-store";
|
||||
import { useInboxStore } from "@/stores/inbox-store";
|
||||
import { simulateEvent, resetMocks } from "../mocks/tauri-api";
|
||||
import { simulateEvent, resetMocks, setMockResponse } from "../mocks/tauri-api";
|
||||
import { makeFocusItem } from "../helpers/fixtures";
|
||||
|
||||
function renderWithProviders(ui: React.ReactElement) {
|
||||
@@ -97,7 +97,8 @@ describe("AppShell", () => {
|
||||
renderWithProviders(<AppShell />);
|
||||
|
||||
act(() => {
|
||||
simulateEvent("global-shortcut-triggered", "quick-capture");
|
||||
// Typed event: GlobalShortcutTriggered has payload { shortcut: string }
|
||||
simulateEvent("global-shortcut-triggered", { shortcut: "quick-capture" });
|
||||
});
|
||||
|
||||
expect(useCaptureStore.getState().isOpen).toBe(true);
|
||||
@@ -130,4 +131,76 @@ describe("AppShell", () => {
|
||||
expect(useFocusStore.getState().current?.id).toBe("target");
|
||||
expect(useNavStore.getState().activeView).toBe("focus");
|
||||
});
|
||||
|
||||
it("populates focus store with lore items on mount", async () => {
|
||||
const mockLoreItemsResponse = {
|
||||
items: [
|
||||
{
|
||||
id: "mr_review:group::repo:200",
|
||||
title: "Review this MR",
|
||||
item_type: "mr_review",
|
||||
project: "group/repo",
|
||||
url: "https://gitlab.com/group/repo/-/merge_requests/200",
|
||||
iid: 200,
|
||||
updated_at: "2026-02-26T10:00:00Z",
|
||||
requested_by: "alice",
|
||||
},
|
||||
{
|
||||
id: "issue:group::repo:42",
|
||||
title: "Fix the bug",
|
||||
item_type: "issue",
|
||||
project: "group/repo",
|
||||
url: "https://gitlab.com/group/repo/-/issues/42",
|
||||
iid: 42,
|
||||
updated_at: "2026-02-26T09:00:00Z",
|
||||
requested_by: null,
|
||||
},
|
||||
],
|
||||
success: true,
|
||||
error: null,
|
||||
};
|
||||
|
||||
setMockResponse("get_lore_items", mockLoreItemsResponse);
|
||||
|
||||
renderWithProviders(<AppShell />);
|
||||
|
||||
// Wait for the focus store to be populated with lore items
|
||||
await waitFor(() => {
|
||||
const state = useFocusStore.getState();
|
||||
expect(state.current !== null || state.queue.length > 0).toBe(true);
|
||||
});
|
||||
|
||||
// Verify the items were transformed and stored
|
||||
const state = useFocusStore.getState();
|
||||
const allItems = state.current ? [state.current, ...state.queue] : state.queue;
|
||||
expect(allItems.length).toBe(2);
|
||||
expect(allItems[0].id).toBe("mr_review:group::repo:200");
|
||||
expect(allItems[0].type).toBe("mr_review");
|
||||
});
|
||||
|
||||
it("clears focus store when lore returns empty items", async () => {
|
||||
// Start with existing items in the store (simulating stale data)
|
||||
useFocusStore.setState({
|
||||
current: makeFocusItem({ id: "stale-item", title: "Stale Item" }),
|
||||
queue: [makeFocusItem({ id: "stale-queue", title: "Stale Queue Item" })],
|
||||
});
|
||||
|
||||
// Lore now returns empty (user cleared their GitLab queue)
|
||||
const mockEmptyResponse = {
|
||||
items: [],
|
||||
success: true,
|
||||
error: null,
|
||||
};
|
||||
|
||||
setMockResponse("get_lore_items", mockEmptyResponse);
|
||||
|
||||
renderWithProviders(<AppShell />);
|
||||
|
||||
// Wait for the store to be cleared
|
||||
await waitFor(() => {
|
||||
const state = useFocusStore.getState();
|
||||
expect(state.current).toBeNull();
|
||||
expect(state.queue.length).toBe(0);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user