feat(followup): implement PLAN-FOLLOWUP.md gap fixes
Complete implementation of 7 slices addressing E2E testing gaps: Slice 0+1: Wire Actions + ReasonPrompt - FocusView now uses useActions hook instead of direct act() calls - Added pendingAction state pattern for skip/defer/complete actions - ReasonPrompt integration with proper confirm/cancel flow - Tags support in DecisionEntry interface Slice 2: Drag Reorder UI - Installed @dnd-kit (core, sortable, utilities) - QueueView with DndContext, SortableContext, verticalListSortingStrategy - SortableQueueItem wrapper component using useSortable hook - pendingReorder state with ReasonPrompt for reorder reasons - Cmd+Up/Down keyboard shortcuts for accessibility - Fixed: Store item ID in PendingReorder to avoid stale queue reference Slice 3: System Tray Integration - tray.rs with TrayState, setup_tray, toggle_window_visibility - Menu with Show/Quit items - Left-click toggles window visibility - update_tray_badge command updates tooltip with item count - Frontend wiring in AppShell Slice 4: E2E Test Updates - Fixed test selectors for InboxView, Queue badge - Exposed inbox store for test seeding Slice 5: Staleness Visualization - Already implemented in computeStaleness() with tests Slice 6: Quick Wiring - onStartBatch callback wired to QueueView - SyncStatus rendered in nav area - SettingsView renders Settings component Slice 7: State Persistence - settings-store with hydrate/update methods - Tauri backend integration via read_settings/write_settings - AppShell hydrates settings on mount Bug fixes from code review: - close_bead now has error isolation (try/catch) so decision logging and queue advancement continue even if bead close fails - PendingReorder stores item ID to avoid stale queue reference E2E tests for all ACs (tests/e2e/followup-acs.spec.ts): - AC-F1: Drag reorder (4 tests) - AC-F2: ReasonPrompt integration (7 tests) - AC-F5: Staleness visualization (3 tests) - AC-F6: Batch mode (2 tests) - AC-F7: SyncStatus (2 tests) - ReasonPrompt behavior (3 tests) Tests: 388 frontend + 119 Rust + 32 E2E all passing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,112 +0,0 @@
|
||||
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
||||
import { renderHook, act } from "@testing-library/react";
|
||||
import { useTauriEvent, useTauriEvents } from "@/hooks/useTauriEvents";
|
||||
|
||||
// Mock the listen function
|
||||
const mockUnlisten = vi.fn();
|
||||
const mockListen = vi.fn().mockResolvedValue(mockUnlisten);
|
||||
|
||||
vi.mock("@tauri-apps/api/event", () => ({
|
||||
listen: (...args: unknown[]) => mockListen(...args),
|
||||
}));
|
||||
|
||||
describe("useTauriEvent", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
it("subscribes to the specified event on mount", async () => {
|
||||
const handler = vi.fn();
|
||||
renderHook(() => useTauriEvent("lore-data-changed", handler));
|
||||
|
||||
// Wait for the listen promise to resolve
|
||||
await vi.waitFor(() => {
|
||||
expect(mockListen).toHaveBeenCalledWith(
|
||||
"lore-data-changed",
|
||||
expect.any(Function)
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
it("calls the handler when event is received", async () => {
|
||||
const handler = vi.fn();
|
||||
renderHook(() => useTauriEvent("global-shortcut-triggered", handler));
|
||||
|
||||
// Get the callback that was passed to listen
|
||||
await vi.waitFor(() => {
|
||||
expect(mockListen).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
const eventCallback = mockListen.mock.calls[0][1];
|
||||
|
||||
// Simulate receiving an event
|
||||
act(() => {
|
||||
eventCallback({ payload: "quick-capture" });
|
||||
});
|
||||
|
||||
expect(handler).toHaveBeenCalledWith("quick-capture");
|
||||
});
|
||||
|
||||
it("calls unlisten on unmount", async () => {
|
||||
const handler = vi.fn();
|
||||
const { unmount } = renderHook(() =>
|
||||
useTauriEvent("lore-data-changed", handler)
|
||||
);
|
||||
|
||||
// Wait for subscription to be set up
|
||||
await vi.waitFor(() => {
|
||||
expect(mockListen).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
unmount();
|
||||
|
||||
expect(mockUnlisten).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
describe("useTauriEvents", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
it("subscribes to multiple events", async () => {
|
||||
const handlers = {
|
||||
"lore-data-changed": vi.fn(),
|
||||
"sync-status": vi.fn(),
|
||||
};
|
||||
|
||||
renderHook(() => useTauriEvents(handlers));
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(mockListen).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
|
||||
expect(mockListen).toHaveBeenCalledWith(
|
||||
"lore-data-changed",
|
||||
expect.any(Function)
|
||||
);
|
||||
expect(mockListen).toHaveBeenCalledWith("sync-status", expect.any(Function));
|
||||
});
|
||||
|
||||
it("cleans up all subscriptions on unmount", async () => {
|
||||
const handlers = {
|
||||
"lore-data-changed": vi.fn(),
|
||||
"sync-status": vi.fn(),
|
||||
};
|
||||
|
||||
const { unmount } = renderHook(() => useTauriEvents(handlers));
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(mockListen).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
|
||||
unmount();
|
||||
|
||||
// Should call unlisten for each subscription
|
||||
expect(mockUnlisten).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user