{"data":{"activity":[{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"Correct. Probably not too much of a problem, but I think fixing https://gitlab.visiostack.com/vs/typescript-code/-/merge_requests/3875#note_507216 will fix this anyway (see Elliot's comment I forgot t","timestamp_iso":"2026-02-25T21:10:40.978+00:00"},{"actor":"njindia","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"Yup this is with chrome. FWIW _technically_ we dont support FF right? So maybe it's a non-issue if it's tough to fix\n\n![image.png](/uploads/7befad3dab12903f47c94c0b84abccb3/image.png){width=\"396\" heig","timestamp_iso":"2026-02-25T21:05:17.725+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"@njindia  Does the score selector always appear to the left for you like that? It's supposed to be centered :grimacing:. For me this happens on Firefox but not Chrome. Is this the same for you?","timestamp_iso":"2026-02-25T21:02:33.885+00:00"},{"actor":"njindia","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"**nit:**\n\n![image.png](/uploads/7b9b1118683d3f58e64ccb4707a0c568/image.png){width=\"149\" height=\"81\"}\n\nI upload this as a major distance (mi/km), is there a particular reason we convert to feet? I can ","timestamp_iso":"2026-02-25T20:53:03.678+00:00"},{"actor":"njindia","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"**nit:** \n\n![image.png](/uploads/af1fe0b550fa9dcb77bfcf41adc3f300/image.png){width=375 height=325}\n\nI am not a huge fan of these colors for the vehicle signals, but I'll let @elovegrove have final say","timestamp_iso":"2026-02-25T20:53:03.554+00:00"},{"actor":"njindia","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"**nit:** \n\n![image.png](/uploads/ffed3ff870af9062b2e06cabec85cf5e/image.png){width=379 height=73}\n\nWe should show the worst scores first. Right it is the 10th worst first and the worst last. (I know I","timestamp_iso":"2026-02-25T20:53:03.476+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"@njindia Yes, nitpick away :apartyblob:","timestamp_iso":"2026-02-25T20:09:37.317+00:00"},{"actor":"jdefting","body_preview":null,"entity_iid":3981,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"Also if we're going to use this, we should pass something better than a boolean like `outFormat: 'mathJs' | '???'`. That way it actually describes itself instead of just seeing `useFormulaJsonToText(t","timestamp_iso":"2026-02-25T20:08:17.095+00:00"},{"actor":"jdefting","body_preview":null,"entity_iid":3981,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"**question**: Why wouldn't we just do `mathJsCompatible` all the time? Seems weird to only sometimes need it.","timestamp_iso":"2026-02-25T20:07:03.067+00:00"},{"actor":"njindia","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"@carambula is this feature-complete now? (i.e. is it ready for me to nitpick)","timestamp_iso":"2026-02-25T20:06:20.081+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"2b25653d Null coalescing is :gone:","timestamp_iso":"2026-02-25T19:35:46.075+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"27e3127e Changed `null` to `undefined` here.","timestamp_iso":"2026-02-25T19:35:45.869+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"35c07e2d Replaced usages of `map` with `forEach` here.","timestamp_iso":"2026-02-25T19:35:45.573+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"4dd3db8f Removed unneeded `async`","timestamp_iso":"2026-02-25T19:35:45.416+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"This wasn't intentional, but it should be fine here. The same logic should be used whether `score` is 0 or if `score` is `NaN` (no background color for both).","timestamp_iso":"2026-02-25T19:35:45.147+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"The spinner does not render if the inverse of this condition is true, it just renders if the condition and all other conditions before it are false (which is why it works). However, I do agree it's ov","timestamp_iso":"2026-02-25T19:35:44.940+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"670e25a8 Forgot about the vehicle scores :sweat_smile:. X values have been corrected.","timestamp_iso":"2026-02-25T19:35:44.566+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"dd915234 Sidebar's scrollbar has been restored","timestamp_iso":"2026-02-25T19:35:44.451+00:00"},{"actor":"carambula","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"1ac1ba0d fixes this to make sidebar closing and tab switching simultaneous. Needed to add some extra conditions/setters, wrote comments for changes.","timestamp_iso":"2026-02-25T19:35:44.380+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":4009,"entity_type":"mr","event_type":"assign","is_own":true,"project":"vs/typescript-code","summary":"assigned to @teernisse","timestamp_iso":"2026-02-25T19:13:24.029+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":4009,"entity_type":"mr","event_type":"label_change","is_own":true,"project":"vs/typescript-code","summary":"add priority::medium","timestamp_iso":"2026-02-25T19:13:23.990+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":4009,"entity_type":"mr","event_type":"label_change","is_own":true,"project":"vs/typescript-code","summary":"add refactor","timestamp_iso":"2026-02-25T19:13:23.990+00:00"},{"actor":"jdefting","body_preview":null,"entity_iid":3989,"entity_type":"issue","event_type":"label_change","is_own":false,"project":"vs/typescript-code","summary":"add priority::low","timestamp_iso":"2026-02-25T18:58:59.351+00:00"},{"actor":"jdefting","body_preview":null,"entity_iid":3989,"entity_type":"issue","event_type":"label_change","is_own":false,"project":"vs/typescript-code","summary":"add analytics-studio","timestamp_iso":"2026-02-25T18:58:52.583+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3931,"entity_type":"issue","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"How's this?\n\n<details>\n<summary>Click to expand</summary>\n\n![image](/uploads/cc125db6233840cabe60003139497569/image.png){width=434 height=517}\n\n</details>","timestamp_iso":"2026-02-25T18:25:58.575+00:00"},{"actor":"elovegrove","body_preview":null,"entity_iid":3931,"entity_type":"issue","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"Yes, we should at least try it and take that approach as far as we can! \n\nOn a related note, I think we should probably just show all of _this_ info (which isn't dynamic, like the info you highlighted","timestamp_iso":"2026-02-25T16:36:11.791+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3931,"entity_type":"issue","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"> the issue here is that we used to only show this info on the expanded version, where there was room, but now we're trying to combine expanded and non-expanded versions, right?\n\nExactly. Are you sayi","timestamp_iso":"2026-02-25T16:29:33.612+00:00"},{"actor":"elovegrove","body_preview":null,"entity_iid":3931,"entity_type":"issue","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"I'm leaning towards saying that this info should just go in a tooltip directly over the chart, like it does on the rest of our graphs, for consistency . . .","timestamp_iso":"2026-02-25T16:28:22.190+00:00"},{"actor":"elovegrove","body_preview":null,"entity_iid":3931,"entity_type":"issue","event_type":"note","is_own":false,"project":"vs/typescript-code","summary":"@teernisse the issue here is that we used to only show this info on the expanded version, where there was room, but now we're trying to combine expanded and non-expanded versions, right?","timestamp_iso":"2026-02-25T16:27:39.076+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3931,"entity_type":"issue","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"@elovegrove How do you want me to handle the additional info when hovering on chart bars?\n\nOn one hand it's nice to have this context, but it's currently covering the year tick mark.\n\n<details>\n<summa","timestamp_iso":"2026-02-25T16:03:46.997+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"nit: since `averageScoreSignalData` is declared as a const and never `undefined`, the null coalescing isn't needed","timestamp_iso":"2026-02-25T14:12:36.257+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"issue: the signature of this atom was changed to `number | undefined`, so the checks here and on line 58 need to be changed from `null` to `undefined`.","timestamp_iso":"2026-02-25T14:12:36.101+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"suggestion: use `forEach` instead of `map` since you aren't using the return values of the three `map` calls.","timestamp_iso":"2026-02-25T14:12:35.933+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"nit: this function no longer needs to be `async` since the `awaits` were removed.","timestamp_iso":"2026-02-25T14:12:35.753+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"issue: if `score` is 0, this ends up being `true` which I assume isn't what's desired here. If you're wanting to check for `NaN`, you can use `Number.isNaN()` instead.","timestamp_iso":"2026-02-25T14:12:35.619+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"question: since it isn't possible for queries to be successful AND pending at the same time, this value is _always_ true, right? What is this trying to do? This is pre-existing code, but if I'm readin","timestamp_iso":"2026-02-25T14:12:35.434+00:00"},{"actor":"teernisse","body_preview":null,"entity_iid":3875,"entity_type":"mr","event_type":"note","is_own":true,"project":"vs/typescript-code","summary":"issue: I think this line and line 79 also need to be inverted with `1 / x` like line 104","timestamp_iso":"2026-02-25T14:12:35.241+00:00"}],"open_issues":[{"attention_state":"needs_attention","iid":3864,"labels":["customer:BNSF","gate::approved-for-development","priority::medium"],"project":"vs/typescript-code","state":"opened","status_name":"In review","title":"Switch Health Card (Throw Times)","updated_at_iso":"2026-02-24T19:28:54.788+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/issues/3864"},{"attention_state":"awaiting_response","iid":3931,"labels":["priority::medium","refactor"],"project":"vs/typescript-code","state":"opened","status_name":"In review","title":"Port Weather Report cards to standard card components","updated_at_iso":"2026-02-25T21:30:12.470+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/issues/3931"},{"attention_state":"awaiting_response","iid":3537,"labels":["analytics-studio","priority::medium"],"project":"vs/typescript-code","state":"opened","status_name":"In review","title":"Analytics Studio: Support comparison operands","updated_at_iso":"2026-02-24T19:44:39.128+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/issues/3537"}],"open_mrs_authored":[{"attention_state":"needs_attention","author_username":null,"detailed_merge_status":"requested_changes","draft":false,"iid":3981,"labels":["analytics-studio","priority::medium"],"project":"vs/typescript-code","state":"opened","title":"Resolve \"Analytics Studio: Support comparison operands\"","updated_at_iso":"2026-02-25T20:08:17.129+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/merge_requests/3981"},{"attention_state":"not_started","author_username":null,"detailed_merge_status":"not_approved","draft":false,"iid":4009,"labels":["priority::medium","refactor"],"project":"vs/typescript-code","state":"opened","title":"Resolve \"Port Weather Report cards to standard card components\"","updated_at_iso":"2026-02-25T20:51:27.109+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/merge_requests/4009"},{"attention_state":"not_started","author_username":null,"detailed_merge_status":"not_approved","draft":false,"iid":3881,"labels":["priority::low"],"project":"vs/typescript-code","state":"opened","title":"fix: Prevent layout shift from copy icon on JSON view hover","updated_at_iso":"2026-01-27T22:30:09.542+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/merge_requests/3881"},{"attention_state":"awaiting_response","author_username":null,"detailed_merge_status":"not_approved","draft":false,"iid":3929,"labels":["customer:BNSF","gate::approved-for-development","priority::medium"],"project":"vs/typescript-code","state":"opened","title":"Resolve \"Switch Health Card (Throw Times)\"","updated_at_iso":"2026-02-25T19:12:27.932+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/merge_requests/3929"}],"reviewing_mrs":[{"attention_state":"needs_attention","author_username":"carambula","detailed_merge_status":"requested_changes","draft":false,"iid":3875,"labels":["feature-request","priority::medium"],"project":"vs/typescript-code","state":"opened","title":"Add Vehicle Quality Cross Comparison Chart Sidebar","updated_at_iso":"2026-02-25T21:10:41.005+00:00","web_url":"https://gitlab.visiostack.com/vs/typescript-code/-/merge_requests/3875"}],"since_iso":"2026-02-24T21:37:12.076+00:00","since_last_check":{"cursor_iso":"2026-02-25T21:10:40.978+00:00","groups":[],"total_event_count":0},"summary":{"authored_mr_count":4,"needs_attention_count":3,"open_issue_count":3,"project_count":1,"reviewing_mr_count":1},"username":"teernisse"},"meta":{"elapsed_ms":1351},"ok":true}