Files
mission-control/src/lib/invariant.ts
teernisse f5ce8a9091 feat(followup): implement PLAN-FOLLOWUP.md gap fixes
Complete implementation of 7 slices addressing E2E testing gaps:

Slice 0+1: Wire Actions + ReasonPrompt
- FocusView now uses useActions hook instead of direct act() calls
- Added pendingAction state pattern for skip/defer/complete actions
- ReasonPrompt integration with proper confirm/cancel flow
- Tags support in DecisionEntry interface

Slice 2: Drag Reorder UI
- Installed @dnd-kit (core, sortable, utilities)
- QueueView with DndContext, SortableContext, verticalListSortingStrategy
- SortableQueueItem wrapper component using useSortable hook
- pendingReorder state with ReasonPrompt for reorder reasons
- Cmd+Up/Down keyboard shortcuts for accessibility
- Fixed: Store item ID in PendingReorder to avoid stale queue reference

Slice 3: System Tray Integration
- tray.rs with TrayState, setup_tray, toggle_window_visibility
- Menu with Show/Quit items
- Left-click toggles window visibility
- update_tray_badge command updates tooltip with item count
- Frontend wiring in AppShell

Slice 4: E2E Test Updates
- Fixed test selectors for InboxView, Queue badge
- Exposed inbox store for test seeding

Slice 5: Staleness Visualization
- Already implemented in computeStaleness() with tests

Slice 6: Quick Wiring
- onStartBatch callback wired to QueueView
- SyncStatus rendered in nav area
- SettingsView renders Settings component

Slice 7: State Persistence
- settings-store with hydrate/update methods
- Tauri backend integration via read_settings/write_settings
- AppShell hydrates settings on mount

Bug fixes from code review:
- close_bead now has error isolation (try/catch) so decision logging
  and queue advancement continue even if bead close fails
- PendingReorder stores item ID to avoid stale queue reference

E2E tests for all ACs (tests/e2e/followup-acs.spec.ts):
- AC-F1: Drag reorder (4 tests)
- AC-F2: ReasonPrompt integration (7 tests)
- AC-F5: Staleness visualization (3 tests)
- AC-F6: Batch mode (2 tests)
- AC-F7: SyncStatus (2 tests)
- ReasonPrompt behavior (3 tests)

Tests: 388 frontend + 119 Rust + 32 E2E all passing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-26 17:28:28 -05:00

118 lines
3.3 KiB
TypeScript

/**
* Invariant assertion helpers for runtime validation.
*
* These utilities provide type-safe assertions that narrow types and
* throw descriptive errors when invariants are violated.
*/
/**
* Custom error class for invariant violations.
* Provides a distinct error type that can be caught and identified.
*/
export class InvariantError extends Error {
constructor(message: string) {
super(message);
this.name = "InvariantError";
// Maintains proper stack trace in V8 environments (Node, Chrome)
// captureStackTrace is V8-specific, not in standard ES
const ErrorWithCapture = Error as typeof Error & {
captureStackTrace?: (target: object, constructor: unknown) => void;
};
if (ErrorWithCapture.captureStackTrace) {
ErrorWithCapture.captureStackTrace(this, InvariantError);
}
}
}
/**
* Message can be a string or a function that returns a string.
* Using a function allows for lazy evaluation of expensive messages.
*/
export type InvariantMessage = string | (() => string);
/**
* Assert that a condition is truthy. Throws InvariantError if false.
*
* This function acts as a type guard - TypeScript will narrow the type
* after the assertion. Useful for null/undefined checks.
*
* @param condition - The condition to check (must be truthy)
* @param message - Error message or function returning message
* @throws InvariantError if condition is falsy
*
* @example
* ```ts
* const user: User | null = getUser();
* invariant(user !== null, "User must be logged in");
* // TypeScript now knows user is User, not null
* console.log(user.name);
* ```
*
* @example
* ```ts
* // Lazy message evaluation for performance
* invariant(isValid, () => `Invalid state: ${JSON.stringify(state)}`);
* ```
*/
export function invariant(
condition: unknown,
message: InvariantMessage
): asserts condition {
if (!condition) {
const errorMessage = typeof message === "function" ? message() : message;
throw new InvariantError(errorMessage);
}
}
/**
* Assert that a value should never be reached (exhaustive type checking).
*
* Use this in the default case of switch statements to ensure all
* union members are handled. TypeScript will error at compile time
* if a case is missing.
*
* @param value - The value that should be of type `never`
* @returns never - This function always throws
* @throws InvariantError with a description of the unexpected value
*
* @example
* ```ts
* type Status = "pending" | "complete" | "failed";
*
* function handleStatus(status: Status): string {
* switch (status) {
* case "pending": return "Waiting...";
* case "complete": return "Done!";
* case "failed": return "Error occurred";
* default:
* // If a new status is added, TypeScript will error here
* return assertNever(status);
* }
* }
* ```
*/
export function assertNever(value: never): never {
const description = formatValue(value);
throw new InvariantError(`Unexpected value: ${description}`);
}
/**
* Format a value for display in error messages.
* Handles objects, arrays, and primitives.
*/
function formatValue(value: unknown): string {
if (value === null) return "null";
if (value === undefined) return "undefined";
if (typeof value === "object") {
try {
return JSON.stringify(value);
} catch {
return String(value);
}
}
return String(value);
}