Fix sensitive redactor keyword matching for case-insensitive patterns

The keyword pre-filter used case-sensitive string matching for all patterns,
but several regex patterns use the /i flag (e.g. generic_api_key). This meant
inputs like 'ApiKey = "secret"' would skip the keyword check for 'api_key'
and miss the redaction entirely.

Changes:
- Add caseInsensitive parameter to hasKeyword() that lowercases both content
  and keywords before comparison
- Detect /i flag on pattern regex and pass it through automatically
- Narrow IP address keywords from ["."] to ["0.", "1.", ..., "9."] to reduce
  false-positive regex invocations on content containing periods
- Fix email regex character class [A-Z|a-z] → [A-Za-z] (the pipe was literal)
- Add clarifying comment on url_with_creds pattern
- Add test cases for mixed-case and UPPER_CASE key assignments
- Relax SECRET_KEY test assertion to accept either redaction label

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
2026-01-30 01:09:11 -05:00
parent eb8001dbf1
commit 0e5a36f0d1
2 changed files with 37 additions and 9 deletions

View File

@@ -251,6 +251,18 @@ describe("sensitive-redactor", () => {
const result = redactSensitiveContent(input);
expect(result.redactionCount).toBeGreaterThan(0);
});
it("redacts mixed-case key assignments (case-insensitive keyword matching)", () => {
const input = 'ApiKey = "abcdefghijklmnopqrst"';
const result = redactSensitiveContent(input);
expect(result.redactionCount).toBeGreaterThan(0);
});
it("redacts UPPER_CASE key assignments via generic pattern", () => {
const input = 'AUTH_TOKEN: SuperSecretVal1234';
const result = redactSensitiveContent(input);
expect(result.redactionCount).toBeGreaterThan(0);
});
});
// --- Tier 2: PII/System Info ---
@@ -387,7 +399,9 @@ describe("sensitive-redactor", () => {
it("redacts SECRET_KEY assignments", () => {
const input = "SECRET_KEY=abcdefghij1234567890";
const result = redactSensitiveContent(input);
expect(result.sanitized).toContain("[ENV_SECRET]");
// May be matched by generic_api_key or env_var_secret depending on order
expect(result.redactionCount).toBeGreaterThan(0);
expect(result.sanitized).not.toContain("abcdefghij1234567890");
});
it("redacts DATABASE_PASSWORD assignments", () => {