f5ce8a9091
Complete implementation of 7 slices addressing E2E testing gaps: Slice 0+1: Wire Actions + ReasonPrompt - FocusView now uses useActions hook instead of direct act() calls - Added pendingAction state pattern for skip/defer/complete actions - ReasonPrompt integration with proper confirm/cancel flow - Tags support in DecisionEntry interface Slice 2: Drag Reorder UI - Installed @dnd-kit (core, sortable, utilities) - QueueView with DndContext, SortableContext, verticalListSortingStrategy - SortableQueueItem wrapper component using useSortable hook - pendingReorder state with ReasonPrompt for reorder reasons - Cmd+Up/Down keyboard shortcuts for accessibility - Fixed: Store item ID in PendingReorder to avoid stale queue reference Slice 3: System Tray Integration - tray.rs with TrayState, setup_tray, toggle_window_visibility - Menu with Show/Quit items - Left-click toggles window visibility - update_tray_badge command updates tooltip with item count - Frontend wiring in AppShell Slice 4: E2E Test Updates - Fixed test selectors for InboxView, Queue badge - Exposed inbox store for test seeding Slice 5: Staleness Visualization - Already implemented in computeStaleness() with tests Slice 6: Quick Wiring - onStartBatch callback wired to QueueView - SyncStatus rendered in nav area - SettingsView renders Settings component Slice 7: State Persistence - settings-store with hydrate/update methods - Tauri backend integration via read_settings/write_settings - AppShell hydrates settings on mount Bug fixes from code review: - close_bead now has error isolation (try/catch) so decision logging and queue advancement continue even if bead close fails - PendingReorder stores item ID to avoid stale queue reference E2E tests for all ACs (tests/e2e/followup-acs.spec.ts): - AC-F1: Drag reorder (4 tests) - AC-F2: ReasonPrompt integration (7 tests) - AC-F5: Staleness visualization (3 tests) - AC-F6: Batch mode (2 tests) - AC-F7: SyncStatus (2 tests) - ReasonPrompt behavior (3 tests) Tests: 388 frontend + 119 Rust + 32 E2E all passing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
121 lines
3.0 KiB
TypeScript
121 lines
3.0 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { transformLoreData } from "@/lib/transform";
|
|
|
|
describe("transformLoreData", () => {
|
|
it("returns empty array for empty data", () => {
|
|
const result = transformLoreData({
|
|
open_issues: [],
|
|
open_mrs_authored: [],
|
|
reviewing_mrs: [],
|
|
});
|
|
expect(result).toEqual([]);
|
|
});
|
|
|
|
it("puts reviews first, then issues, then authored MRs", () => {
|
|
const result = transformLoreData({
|
|
open_issues: [
|
|
{
|
|
iid: 42,
|
|
title: "Bug fix",
|
|
project: "g/p",
|
|
web_url: "https://gitlab.com/g/p/-/issues/42",
|
|
},
|
|
],
|
|
open_mrs_authored: [
|
|
{
|
|
iid: 200,
|
|
title: "My feature",
|
|
project: "g/p",
|
|
web_url: "https://gitlab.com/g/p/-/merge_requests/200",
|
|
},
|
|
],
|
|
reviewing_mrs: [
|
|
{
|
|
iid: 100,
|
|
title: "Review this",
|
|
project: "g/p",
|
|
web_url: "https://gitlab.com/g/p/-/merge_requests/100",
|
|
author_username: "alice",
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(result).toHaveLength(3);
|
|
expect(result[0].type).toBe("mr_review");
|
|
expect(result[0].requestedBy).toBe("alice");
|
|
expect(result[1].type).toBe("issue");
|
|
expect(result[2].type).toBe("mr_authored");
|
|
});
|
|
|
|
it("generates correct IDs for each type", () => {
|
|
const result = transformLoreData({
|
|
open_issues: [
|
|
{
|
|
iid: 42,
|
|
title: "Issue",
|
|
project: "group/repo",
|
|
web_url: "https://x.com",
|
|
},
|
|
],
|
|
open_mrs_authored: [
|
|
{
|
|
iid: 200,
|
|
title: "MR",
|
|
project: "group/repo",
|
|
web_url: "https://x.com",
|
|
},
|
|
],
|
|
reviewing_mrs: [
|
|
{
|
|
iid: 100,
|
|
title: "Review",
|
|
project: "group/repo",
|
|
web_url: "https://x.com",
|
|
},
|
|
],
|
|
});
|
|
|
|
// Keys escape / to :: for consistency with backend bridge.rs
|
|
expect(result[0].id).toBe("mr_review:group::repo:100");
|
|
expect(result[1].id).toBe("issue:group::repo:42");
|
|
expect(result[2].id).toBe("mr_authored:group::repo:200");
|
|
});
|
|
|
|
it("preserves updated_at_iso from lore data", () => {
|
|
const result = transformLoreData({
|
|
open_issues: [],
|
|
open_mrs_authored: [],
|
|
reviewing_mrs: [
|
|
{
|
|
iid: 1,
|
|
title: "T",
|
|
project: "g/p",
|
|
web_url: "https://x.com",
|
|
updated_at_iso: "2026-02-25T10:00:00Z",
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(result[0].updatedAt).toBe("2026-02-25T10:00:00Z");
|
|
});
|
|
|
|
it("handles missing optional fields gracefully", () => {
|
|
const result = transformLoreData({
|
|
open_issues: [
|
|
{
|
|
iid: 1,
|
|
title: "T",
|
|
project: "g/p",
|
|
web_url: "https://x.com",
|
|
},
|
|
],
|
|
open_mrs_authored: [],
|
|
reviewing_mrs: [],
|
|
});
|
|
|
|
expect(result[0].updatedAt).toBeNull();
|
|
expect(result[0].contextQuote).toBeNull();
|
|
expect(result[0].requestedBy).toBeNull();
|
|
});
|
|
});
|